Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/libgroove-4.3.0/example/fingerprint.c Examining data/libgroove-4.3.0/example/metadata.c Examining data/libgroove-4.3.0/example/playlist.c Examining data/libgroove-4.3.0/example/replaygain.c Examining data/libgroove-4.3.0/example/transcode.c Examining data/libgroove-4.3.0/groove/buffer.c Examining data/libgroove-4.3.0/groove/buffer.h Examining data/libgroove-4.3.0/groove/encoder.h Examining data/libgroove-4.3.0/groove/file.h Examining data/libgroove-4.3.0/groove/global.c Examining data/libgroove-4.3.0/groove/groove.h Examining data/libgroove-4.3.0/groove/queue.c Examining data/libgroove-4.3.0/groove/queue.h Examining data/libgroove-4.3.0/groove/encoder.c Examining data/libgroove-4.3.0/groove/playlist.c Examining data/libgroove-4.3.0/groove/file.c Examining data/libgroove-4.3.0/groovefingerprinter/fingerprinter.c Examining data/libgroove-4.3.0/groovefingerprinter/fingerprinter.h Examining data/libgroove-4.3.0/grooveloudness/loudness.c Examining data/libgroove-4.3.0/grooveloudness/loudness.h Examining data/libgroove-4.3.0/grooveplayer/osx_time_shim.c Examining data/libgroove-4.3.0/grooveplayer/osx_time_shim.h Examining data/libgroove-4.3.0/grooveplayer/player.h Examining data/libgroove-4.3.0/grooveplayer/player.c FINAL RESULTS: data/libgroove-4.3.0/groove/playlist.c:344:5: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. snprintf(p->strbuf, sizeof(p->strbuf), data/libgroove-4.3.0/groove/playlist.c:418:13: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. snprintf(p->strbuf, sizeof(p->strbuf), data/libgroove-4.3.0/groove/global.c:46:5: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srand(time(NULL)); data/libgroove-4.3.0/example/transcode.c:35:30: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). bit_rate_k = atoi(argv[++i]); data/libgroove-4.3.0/example/transcode.c:80:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *f = fopen(output_file_name, "wb"); data/libgroove-4.3.0/groove/encoder.c:56:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char strbuf[512]; data/libgroove-4.3.0/groove/encoder.c:330:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(b->data, buf, buf_size); data/libgroove-4.3.0/groove/encoder.c:551:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[128]; data/libgroove-4.3.0/groove/file.c:186:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char prepend[11]; data/libgroove-4.3.0/groove/file.c:296:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(ocodec->extradata, icodec->extradata, icodec->extradata_size); data/libgroove-4.3.0/groove/playlist.c:53:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char strbuf[512]; data/libgroove-4.3.0/grooveplayer/player.c:314:21: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(stream, data/libgroove-4.3.0/grooveplayer/player.c:321:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(stream, data/libgroove-4.3.0/groove/file.c:183:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). size_t len = strlen(str); data/libgroove-4.3.0/groove/file.c:195:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(pos, prepend, 10); data/libgroove-4.3.0/groovefingerprinter/fingerprinter.c:397:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int encoded_size = strlen(encoded_fp); ANALYSIS SUMMARY: Hits = 16 Lines analyzed = 5939 in approximately 0.28 seconds (21089 lines/second) Physical Source Lines of Code (SLOC) = 4184 Hits@level = [0] 38 [1] 3 [2] 10 [3] 1 [4] 2 [5] 0 Hits@level+ = [0+] 54 [1+] 16 [2+] 13 [3+] 3 [4+] 2 [5+] 0 Hits/KSLOC@level+ = [0+] 12.9063 [1+] 3.82409 [2+] 3.10707 [3+] 0.717017 [4+] 0.478011 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.