Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/libiscsi-1.19.0/aros/aros_compat.c Examining data/libiscsi-1.19.0/aros/aros_compat.h Examining data/libiscsi-1.19.0/aros/iscsi-ls.c Examining data/libiscsi-1.19.0/examples/iscsi-dd.c Examining data/libiscsi-1.19.0/examples/iscsiclient.c Examining data/libiscsi-1.19.0/examples/ld_iscsi.c Examining data/libiscsi-1.19.0/include/iscsi-private.h Examining data/libiscsi-1.19.0/include/iscsi.h Examining data/libiscsi-1.19.0/include/md5.h Examining data/libiscsi-1.19.0/include/scsi-lowlevel.h Examining data/libiscsi-1.19.0/include/slist.h Examining data/libiscsi-1.19.0/include/iser-private.h Examining data/libiscsi-1.19.0/lib/connect.c Examining data/libiscsi-1.19.0/lib/crc32c.c Examining data/libiscsi-1.19.0/lib/discovery.c Examining data/libiscsi-1.19.0/lib/init.c Examining data/libiscsi-1.19.0/lib/iscsi-command.c Examining data/libiscsi-1.19.0/lib/iser.c Examining data/libiscsi-1.19.0/lib/logging.c Examining data/libiscsi-1.19.0/lib/login.c Examining data/libiscsi-1.19.0/lib/md5.c Examining data/libiscsi-1.19.0/lib/nop.c Examining data/libiscsi-1.19.0/lib/pdu.c Examining data/libiscsi-1.19.0/lib/scsi-lowlevel.c Examining data/libiscsi-1.19.0/lib/socket.c Examining data/libiscsi-1.19.0/lib/sync.c Examining data/libiscsi-1.19.0/lib/task_mgmt.c Examining data/libiscsi-1.19.0/test-tool/iscsi-multipath.c Examining data/libiscsi-1.19.0/test-tool/iscsi-multipath.h Examining data/libiscsi-1.19.0/test-tool/iscsi-support.c Examining data/libiscsi-1.19.0/test-tool/iscsi-support.h Examining data/libiscsi-1.19.0/test-tool/iscsi-test-cu.c Examining data/libiscsi-1.19.0/test-tool/iscsi-test-cu.h Examining data/libiscsi-1.19.0/test-tool/test_async_abort_simple.c Examining data/libiscsi-1.19.0/test-tool/test_async_lu_reset_simple.c Examining data/libiscsi-1.19.0/test-tool/test_async_read.c Examining data/libiscsi-1.19.0/test-tool/test_async_write.c Examining data/libiscsi-1.19.0/test-tool/test_compareandwrite_dpofua.c Examining data/libiscsi-1.19.0/test-tool/test_compareandwrite_invalid_dataout_size.c Examining data/libiscsi-1.19.0/test-tool/test_compareandwrite_simple.c Examining data/libiscsi-1.19.0/test-tool/test_compareandwrite_unwritten.c Examining data/libiscsi-1.19.0/test-tool/test_extendedcopy_descr_limits.c Examining data/libiscsi-1.19.0/test-tool/test_extendedcopy_descr_type.c Examining data/libiscsi-1.19.0/test-tool/test_extendedcopy_param.c Examining data/libiscsi-1.19.0/test-tool/test_extendedcopy_simple.c Examining data/libiscsi-1.19.0/test-tool/test_extendedcopy_validate_seg_descr.c Examining data/libiscsi-1.19.0/test-tool/test_extendedcopy_validate_tgt_descr.c Examining data/libiscsi-1.19.0/test-tool/test_get_lba_status_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_get_lba_status_simple.c Examining data/libiscsi-1.19.0/test-tool/test_get_lba_status_unmap_single.c Examining data/libiscsi-1.19.0/test-tool/test_inquiry_alloc_length.c Examining data/libiscsi-1.19.0/test-tool/test_inquiry_block_limits.c Examining data/libiscsi-1.19.0/test-tool/test_inquiry_evpd.c Examining data/libiscsi-1.19.0/test-tool/test_inquiry_mandatory_vpd_sbc.c Examining data/libiscsi-1.19.0/test-tool/test_inquiry_standard.c Examining data/libiscsi-1.19.0/test-tool/test_inquiry_supported_vpd.c Examining data/libiscsi-1.19.0/test-tool/test_inquiry_version_descriptors.c Examining data/libiscsi-1.19.0/test-tool/test_iscsi_cmdsn_toohigh.c Examining data/libiscsi-1.19.0/test-tool/test_iscsi_cmdsn_toolow.c Examining data/libiscsi-1.19.0/test-tool/test_iscsi_datasn_invalid.c Examining data/libiscsi-1.19.0/test-tool/test_mandatory_sbc.c Examining data/libiscsi-1.19.0/test-tool/test_modesense6_all_pages.c Examining data/libiscsi-1.19.0/test-tool/test_modesense6_control.c Examining data/libiscsi-1.19.0/test-tool/test_modesense6_control_d_sense.c Examining data/libiscsi-1.19.0/test-tool/test_modesense6_control_swp.c Examining data/libiscsi-1.19.0/test-tool/test_modesense6_residuals.c Examining data/libiscsi-1.19.0/test-tool/test_multipathio_async_caw.c Examining data/libiscsi-1.19.0/test-tool/test_multipathio_compareandwrite.c Examining data/libiscsi-1.19.0/test-tool/test_multipathio_reset.c Examining data/libiscsi-1.19.0/test-tool/test_multipathio_simple.c Examining data/libiscsi-1.19.0/test-tool/test_nomedia_sbc.c Examining data/libiscsi-1.19.0/test-tool/test_orwrite_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_orwrite_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_orwrite_dpofua.c Examining data/libiscsi-1.19.0/test-tool/test_orwrite_simple.c Examining data/libiscsi-1.19.0/test-tool/test_orwrite_verify.c Examining data/libiscsi-1.19.0/test-tool/test_orwrite_wrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_prefetch10_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_prefetch10_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_prefetch10_flags.c Examining data/libiscsi-1.19.0/test-tool/test_prefetch10_simple.c Examining data/libiscsi-1.19.0/test-tool/test_prefetch16_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_prefetch16_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_prefetch16_flags.c Examining data/libiscsi-1.19.0/test-tool/test_prefetch16_simple.c Examining data/libiscsi-1.19.0/test-tool/test_preventallow_2_itnexuses.c Examining data/libiscsi-1.19.0/test-tool/test_preventallow_cold_reset.c Examining data/libiscsi-1.19.0/test-tool/test_preventallow_eject.c Examining data/libiscsi-1.19.0/test-tool/test_preventallow_itnexus_loss.c Examining data/libiscsi-1.19.0/test-tool/test_preventallow_logout.c Examining data/libiscsi-1.19.0/test-tool/test_preventallow_lun_reset.c Examining data/libiscsi-1.19.0/test-tool/test_preventallow_simple.c Examining data/libiscsi-1.19.0/test-tool/test_preventallow_warm_reset.c Examining data/libiscsi-1.19.0/test-tool/test_prin_read_keys_simple.c Examining data/libiscsi-1.19.0/test-tool/test_prin_read_keys_truncate.c Examining data/libiscsi-1.19.0/test-tool/test_prin_report_caps.c Examining data/libiscsi-1.19.0/test-tool/test_prin_serviceaction_range.c Examining data/libiscsi-1.19.0/test-tool/test_prout_clear_simple.c Examining data/libiscsi-1.19.0/test-tool/test_prout_preempt.c Examining data/libiscsi-1.19.0/test-tool/test_prout_register_simple.c Examining data/libiscsi-1.19.0/test-tool/test_prout_reserve_access.c Examining data/libiscsi-1.19.0/test-tool/test_prout_reserve_ownership.c Examining data/libiscsi-1.19.0/test-tool/test_prout_reserve_simple.c Examining data/libiscsi-1.19.0/test-tool/test_read10_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_read10_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_read10_dpofua.c Examining data/libiscsi-1.19.0/test-tool/test_read10_invalid.c Examining data/libiscsi-1.19.0/test-tool/test_read10_rdprotect.c Examining data/libiscsi-1.19.0/test-tool/test_read10_residuals.c Examining data/libiscsi-1.19.0/test-tool/test_read10_simple.c Examining data/libiscsi-1.19.0/test-tool/test_read12_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_read12_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_read12_dpofua.c Examining data/libiscsi-1.19.0/test-tool/test_read12_rdprotect.c Examining data/libiscsi-1.19.0/test-tool/test_read12_residuals.c Examining data/libiscsi-1.19.0/test-tool/test_read12_simple.c Examining data/libiscsi-1.19.0/test-tool/test_read16_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_read16_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_read16_dpofua.c Examining data/libiscsi-1.19.0/test-tool/test_read16_rdprotect.c Examining data/libiscsi-1.19.0/test-tool/test_read16_residuals.c Examining data/libiscsi-1.19.0/test-tool/test_read16_simple.c Examining data/libiscsi-1.19.0/test-tool/test_read6_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_read6_simple.c Examining data/libiscsi-1.19.0/test-tool/test_readcapacity10_simple.c Examining data/libiscsi-1.19.0/test-tool/test_readcapacity16_alloclen.c Examining data/libiscsi-1.19.0/test-tool/test_readcapacity16_protection.c Examining data/libiscsi-1.19.0/test-tool/test_readcapacity16_simple.c Examining data/libiscsi-1.19.0/test-tool/test_readcapacity16_support.c Examining data/libiscsi-1.19.0/test-tool/test_readdefectdata10_simple.c Examining data/libiscsi-1.19.0/test-tool/test_readdefectdata12_simple.c Examining data/libiscsi-1.19.0/test-tool/test_readonly_sbc.c Examining data/libiscsi-1.19.0/test-tool/test_receive_copy_results_copy_status.c Examining data/libiscsi-1.19.0/test-tool/test_receive_copy_results_op_params.c Examining data/libiscsi-1.19.0/test-tool/test_report_supported_opcodes_one_command.c Examining data/libiscsi-1.19.0/test-tool/test_report_supported_opcodes_rctd.c Examining data/libiscsi-1.19.0/test-tool/test_report_supported_opcodes_servactv.c Examining data/libiscsi-1.19.0/test-tool/test_report_supported_opcodes_simple.c Examining data/libiscsi-1.19.0/test-tool/test_reserve6_2initiators.c Examining data/libiscsi-1.19.0/test-tool/test_reserve6_itnexus_loss.c Examining data/libiscsi-1.19.0/test-tool/test_reserve6_logout.c Examining data/libiscsi-1.19.0/test-tool/test_reserve6_lun_reset.c Examining data/libiscsi-1.19.0/test-tool/test_reserve6_simple.c Examining data/libiscsi-1.19.0/test-tool/test_reserve6_target_cold_reset.c Examining data/libiscsi-1.19.0/test-tool/test_reserve6_target_warm_reset.c Examining data/libiscsi-1.19.0/test-tool/test_sanitize_block_erase_reserved.c Examining data/libiscsi-1.19.0/test-tool/test_sanitize_crypto_erase.c Examining data/libiscsi-1.19.0/test-tool/test_sanitize_crypto_erase_reserved.c Examining data/libiscsi-1.19.0/test-tool/test_sanitize_exit_failure_mode.c Examining data/libiscsi-1.19.0/test-tool/test_sanitize_invalid_serviceaction.c Examining data/libiscsi-1.19.0/test-tool/test_sanitize_overwrite.c Examining data/libiscsi-1.19.0/test-tool/test_sanitize_overwrite_reserved.c Examining data/libiscsi-1.19.0/test-tool/test_sanitize_readonly.c Examining data/libiscsi-1.19.0/test-tool/test_sanitize_reservations.c Examining data/libiscsi-1.19.0/test-tool/test_startstopunit_noloej.c Examining data/libiscsi-1.19.0/test-tool/test_startstopunit_pwrcnd.c Examining data/libiscsi-1.19.0/test-tool/test_startstopunit_simple.c Examining data/libiscsi-1.19.0/test-tool/test_testunitready_simple.c Examining data/libiscsi-1.19.0/test-tool/test_unmap_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_unmap_simple.c Examining data/libiscsi-1.19.0/test-tool/test_unmap_vpd.c Examining data/libiscsi-1.19.0/test-tool/test_verify10_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_verify10_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_verify10_dpo.c Examining data/libiscsi-1.19.0/test-tool/test_verify10_flags.c Examining data/libiscsi-1.19.0/test-tool/test_verify10_mismatch.c Examining data/libiscsi-1.19.0/test-tool/test_verify10_mismatch_no_cmp.c Examining data/libiscsi-1.19.0/test-tool/test_verify10_simple.c Examining data/libiscsi-1.19.0/test-tool/test_verify10_vrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_verify12_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_verify12_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_verify12_dpo.c Examining data/libiscsi-1.19.0/test-tool/test_verify12_flags.c Examining data/libiscsi-1.19.0/test-tool/test_verify12_mismatch.c Examining data/libiscsi-1.19.0/test-tool/test_verify12_mismatch_no_cmp.c Examining data/libiscsi-1.19.0/test-tool/test_verify12_simple.c Examining data/libiscsi-1.19.0/test-tool/test_verify12_vrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_verify16_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_verify16_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_verify16_dpo.c Examining data/libiscsi-1.19.0/test-tool/test_verify16_flags.c Examining data/libiscsi-1.19.0/test-tool/test_verify16_mismatch.c Examining data/libiscsi-1.19.0/test-tool/test_verify16_mismatch_no_cmp.c Examining data/libiscsi-1.19.0/test-tool/test_verify16_simple.c Examining data/libiscsi-1.19.0/test-tool/test_verify16_vrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_write10_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_write10_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_write10_dpofua.c Examining data/libiscsi-1.19.0/test-tool/test_write10_flags.c Examining data/libiscsi-1.19.0/test-tool/test_write10_residuals.c Examining data/libiscsi-1.19.0/test-tool/test_write10_simple.c Examining data/libiscsi-1.19.0/test-tool/test_write10_wrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_write12_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_write12_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_write12_dpofua.c Examining data/libiscsi-1.19.0/test-tool/test_write12_flags.c Examining data/libiscsi-1.19.0/test-tool/test_write12_residuals.c Examining data/libiscsi-1.19.0/test-tool/test_write12_simple.c Examining data/libiscsi-1.19.0/test-tool/test_write12_wrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_write16_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_write16_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_write16_dpofua.c Examining data/libiscsi-1.19.0/test-tool/test_write16_flags.c Examining data/libiscsi-1.19.0/test-tool/test_write16_residuals.c Examining data/libiscsi-1.19.0/test-tool/test_write16_simple.c Examining data/libiscsi-1.19.0/test-tool/test_write16_wrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_writeatomic16_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_writeatomic16_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_writeatomic16_dpofua.c Examining data/libiscsi-1.19.0/test-tool/test_writeatomic16_simple.c Examining data/libiscsi-1.19.0/test-tool/test_writeatomic16_vpd.c Examining data/libiscsi-1.19.0/test-tool/test_writeatomic16_wrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_writesame10_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_writesame10_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_writesame10_check.c Examining data/libiscsi-1.19.0/test-tool/test_writesame10_invalid_dataout_size.c Examining data/libiscsi-1.19.0/test-tool/test_writesame10_simple.c Examining data/libiscsi-1.19.0/test-tool/test_writesame10_unmap.c Examining data/libiscsi-1.19.0/test-tool/test_writesame10_unmap_unaligned.c Examining data/libiscsi-1.19.0/test-tool/test_writesame10_unmap_until_end.c Examining data/libiscsi-1.19.0/test-tool/test_writesame10_unmap_vpd.c Examining data/libiscsi-1.19.0/test-tool/test_writesame10_wrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_writesame16_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_writesame16_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_writesame16_check.c Examining data/libiscsi-1.19.0/test-tool/test_writesame16_invalid_dataout_size.c Examining data/libiscsi-1.19.0/test-tool/test_writesame16_simple.c Examining data/libiscsi-1.19.0/test-tool/test_writesame16_unmap.c Examining data/libiscsi-1.19.0/test-tool/test_writesame16_unmap_unaligned.c Examining data/libiscsi-1.19.0/test-tool/test_writesame16_unmap_until_end.c Examining data/libiscsi-1.19.0/test-tool/test_writesame16_unmap_vpd.c Examining data/libiscsi-1.19.0/test-tool/test_writesame16_wrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify10_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify10_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify10_dpo.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify10_flags.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify10_residuals.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify10_simple.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify10_wrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify12_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify12_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify12_dpo.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify12_flags.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify12_residuals.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify12_simple.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify12_wrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify16_0blocks.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify16_beyond_eol.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify16_dpo.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify16_flags.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify16_residuals.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify16_simple.c Examining data/libiscsi-1.19.0/test-tool/test_writeverify16_wrprotect.c Examining data/libiscsi-1.19.0/test-tool/test_sanitize_reset.c Examining data/libiscsi-1.19.0/test-tool/test_compareandwrite_miscompare.c Examining data/libiscsi-1.19.0/test-tool/test_sanitize_block_erase.c Examining data/libiscsi-1.19.0/tests/prog_header_digest.c Examining data/libiscsi-1.19.0/tests/prog_noop_reply.c Examining data/libiscsi-1.19.0/tests/prog_read_all_pdus.c Examining data/libiscsi-1.19.0/tests/prog_readwrite_iov.c Examining data/libiscsi-1.19.0/tests/prog_reconnect.c Examining data/libiscsi-1.19.0/tests/prog_reconnect_timeout.c Examining data/libiscsi-1.19.0/tests/prog_timeout.c Examining data/libiscsi-1.19.0/utils/iscsi-inq.c Examining data/libiscsi-1.19.0/utils/iscsi-ls.c Examining data/libiscsi-1.19.0/utils/iscsi-readcapacity16.c Examining data/libiscsi-1.19.0/utils/iscsi-swp.c Examining data/libiscsi-1.19.0/utils/iscsi-perf.c Examining data/libiscsi-1.19.0/win32/win32_compat.c Examining data/libiscsi-1.19.0/win32/win32_compat.h FINAL RESULTS: data/libiscsi-1.19.0/aros/aros_compat.c:38:5: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. snprintf(host, hostlen, Inet_NtoA(sin->sin_addr.s_addr)); data/libiscsi-1.19.0/examples/ld_iscsi.c:43:102: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. #define LD_ISCSI_DPRINTF(level,fmt,args...) do { if ((debug) >= level) {fprintf(stderr,"ld_iscsi: ");fprintf(stderr, (fmt), ##args); fprintf(stderr,"\n");} } while (0); data/libiscsi-1.19.0/include/iscsi-private.h:333:35: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. ...) __attribute__((format(printf, 2, 3))); data/libiscsi-1.19.0/lib/init.c:442:6: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. if (vsnprintf(errstr, MAX_STRING_SIZE, error_string, ap) < 0) { data/libiscsi-1.19.0/lib/logging.c:67:8: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. ret = vsnprintf(message, 1024, format, ap); data/libiscsi-1.19.0/test-tool/iscsi-support.c:474:15: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. ret = vsnprintf(message, 1024, format, ap); data/libiscsi-1.19.0/test-tool/iscsi-test-cu.c:984:21: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (test && access(test, F_OK) == 0) { data/libiscsi-1.19.0/win32/win32_compat.h:76:9: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. #define snprintf(a, b, c, ...) _snprintf_s(a, b, b, c, ## __VA_ARGS__) data/libiscsi-1.19.0/aros/iscsi-ls.c:325:14: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt(argc, argv, "h?udi:s")) != -1) { data/libiscsi-1.19.0/examples/iscsi-dd.c:551:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "d:s:i:m:b:p6nx", long_options, data/libiscsi-1.19.0/examples/ld_iscsi.c:145:7: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("LD_ISCSI_GET_LBA_STATUS") != NULL) { data/libiscsi-1.19.0/examples/ld_iscsi.c:146:44: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. iscsi_fd_list[fd].get_lba_status = atoi(getenv("LD_ISCSI_GET_LBA_STATUS")); data/libiscsi-1.19.0/examples/ld_iscsi.c:595:6: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("LD_ISCSI_DEBUG") != NULL) { data/libiscsi-1.19.0/examples/ld_iscsi.c:596:16: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. debug = atoi(getenv("LD_ISCSI_DEBUG")); data/libiscsi-1.19.0/lib/init.c:188:2: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srand(seed); data/libiscsi-1.19.0/lib/init.c:193:2: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srand(getpid() ^ (uint32_t)((uintptr_t) iscsi)); data/libiscsi-1.19.0/lib/init.c:254:6: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("LIBISCSI_DEBUG") != NULL) { data/libiscsi-1.19.0/lib/init.c:255:35: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. iscsi_set_log_level(iscsi, atoi(getenv("LIBISCSI_DEBUG"))); data/libiscsi-1.19.0/lib/init.c:259:6: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("LIBISCSI_TCP_USER_TIMEOUT") != NULL) { data/libiscsi-1.19.0/lib/init.c:260:41: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. iscsi_set_tcp_user_timeout(iscsi,atoi(getenv("LIBISCSI_TCP_USER_TIMEOUT"))); data/libiscsi-1.19.0/lib/init.c:263:6: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("LIBISCSI_TCP_KEEPCNT") != NULL) { data/libiscsi-1.19.0/lib/init.c:264:36: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. iscsi_set_tcp_keepcnt(iscsi,atoi(getenv("LIBISCSI_TCP_KEEPCNT"))); data/libiscsi-1.19.0/lib/init.c:267:6: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("LIBISCSI_TCP_KEEPINTVL") != NULL) { data/libiscsi-1.19.0/lib/init.c:268:38: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. iscsi_set_tcp_keepintvl(iscsi,atoi(getenv("LIBISCSI_TCP_KEEPINTVL"))); data/libiscsi-1.19.0/lib/init.c:271:6: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("LIBISCSI_TCP_KEEPIDLE") != NULL) { data/libiscsi-1.19.0/lib/init.c:272:37: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. iscsi_set_tcp_keepidle(iscsi,atoi(getenv("LIBISCSI_TCP_KEEPIDLE"))); data/libiscsi-1.19.0/lib/init.c:275:6: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("LIBISCSI_TCP_SYNCNT") != NULL) { data/libiscsi-1.19.0/lib/init.c:276:35: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. iscsi_set_tcp_syncnt(iscsi,atoi(getenv("LIBISCSI_TCP_SYNCNT"))); data/libiscsi-1.19.0/lib/init.c:279:6: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("LIBISCSI_BIND_INTERFACES") != NULL) { data/libiscsi-1.19.0/lib/init.c:280:35: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. iscsi_set_bind_interfaces(iscsi,getenv("LIBISCSI_BIND_INTERFACES")); data/libiscsi-1.19.0/lib/init.c:294:7: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. ca = getenv("LIBISCSI_CACHE_ALLOCATIONS"); data/libiscsi-1.19.0/lib/init.c:583:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. user = getenv("LIBISCSI_CHAP_USERNAME"); data/libiscsi-1.19.0/lib/init.c:584:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. passwd = getenv("LIBISCSI_CHAP_PASSWORD"); data/libiscsi-1.19.0/lib/init.c:585:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. target_user = getenv("LIBISCSI_CHAP_TARGET_USERNAME"); data/libiscsi-1.19.0/lib/init.c:586:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. target_passwd = getenv("LIBISCSI_CHAP_TARGET_PASSWORD"); data/libiscsi-1.19.0/lib/nop.c:150:7: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("LIBISCSI_IGNORE_NOP_OUT_ON_STUCK_WAITPDU_QUEUE") == NULL) { data/libiscsi-1.19.0/lib/pdu.c:479:8: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("LIBISCSI_DROP_CONN_ON_ASYNC_EVENT1") != NULL) { data/libiscsi-1.19.0/test-tool/iscsi-support.h:802:17: [3] (random) srandom: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srandom(s); data/libiscsi-1.19.0/test-tool/iscsi-support.h:805:16: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. return random(); data/libiscsi-1.19.0/test-tool/iscsi-test-cu.c:1135:21: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "?hli:I:t:sdgfAsSnvxV", long_opts, data/libiscsi-1.19.0/test-tool/test_verify10_mismatch.c:37:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int offset = random() % (i * block_size); data/libiscsi-1.19.0/test-tool/test_verify10_mismatch.c:56:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int offset = random() % (i * block_size); data/libiscsi-1.19.0/test-tool/test_verify10_mismatch_no_cmp.c:37:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int offset = random() % (i * block_size); data/libiscsi-1.19.0/test-tool/test_verify10_mismatch_no_cmp.c:56:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int offset = random() % (i * block_size); data/libiscsi-1.19.0/test-tool/test_verify12_mismatch.c:37:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int offset = random() % (i * block_size); data/libiscsi-1.19.0/test-tool/test_verify12_mismatch.c:56:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int offset = random() % (i * block_size); data/libiscsi-1.19.0/test-tool/test_verify12_mismatch_no_cmp.c:37:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int offset = random() % (i * block_size); data/libiscsi-1.19.0/test-tool/test_verify12_mismatch_no_cmp.c:56:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int offset = random() % (i * block_size); data/libiscsi-1.19.0/test-tool/test_verify16_mismatch.c:37:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int offset = random() % (i * block_size); data/libiscsi-1.19.0/test-tool/test_verify16_mismatch.c:56:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int offset = random() % (i * block_size); data/libiscsi-1.19.0/test-tool/test_verify16_mismatch_no_cmp.c:37:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int offset = random() % (i * block_size); data/libiscsi-1.19.0/test-tool/test_verify16_mismatch_no_cmp.c:56:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int offset = random() % (i * block_size); data/libiscsi-1.19.0/tests/prog_header_digest.c:152:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "h?uUdi:s", long_options, data/libiscsi-1.19.0/tests/prog_noop_reply.c:152:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "h?uUdi:s", long_options, data/libiscsi-1.19.0/tests/prog_read_all_pdus.c:100:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "h?uUdi:s", long_options, data/libiscsi-1.19.0/tests/prog_readwrite_iov.c:96:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "h?uUdi:s", long_options, data/libiscsi-1.19.0/tests/prog_reconnect.c:212:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "h?uUdi:s", long_options, data/libiscsi-1.19.0/tests/prog_reconnect_timeout.c:235:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "h?uUdi:s", long_options, data/libiscsi-1.19.0/tests/prog_timeout.c:125:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "h?uUdi:s", long_options, data/libiscsi-1.19.0/utils/iscsi-inq.c:256:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "h?udi:e:c:", long_options, data/libiscsi-1.19.0/utils/iscsi-perf.c:54:6: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int random; data/libiscsi-1.19.0/utils/iscsi-perf.c:197:15: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. if (client->random) { data/libiscsi-1.19.0/utils/iscsi-perf.c:269:2: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srand(time(NULL)); data/libiscsi-1.19.0/utils/iscsi-perf.c:273:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "i:m:b:t:lnrRx:", long_options, data/libiscsi-1.19.0/utils/iscsi-perf.c:373:66: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. printf("performing %s READ with %d parallel requests\n", client.random ? "RANDOM" : "SEQUENTIAL", max_in_flight); data/libiscsi-1.19.0/utils/iscsi-readcapacity16.c:81:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "h?udi:s", long_options, data/libiscsi-1.19.0/utils/iscsi-swp.c:89:14: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt_long(argc, argv, "h?udi:s:", long_options, data/libiscsi-1.19.0/aros/aros_compat.c:59:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). sin->sin_port=htons(atoi(service)); data/libiscsi-1.19.0/aros/aros_compat.c:82:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dst, &sin.sin_addr.s_addr, sizeof(sin.sin_addr.s_addr)); data/libiscsi-1.19.0/examples/iscsi-dd.c:205:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(desc + 8, tgt_desig->designator, tgt_desig->designator_length); data/libiscsi-1.19.0/examples/iscsi-dd.c:426:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(_tgt_desig->designator, tgt_desig->designator, tgt_desig->designator_length); data/libiscsi-1.19.0/examples/iscsiclient.c:64:10: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char small_buffer[512]; data/libiscsi-1.19.0/examples/iscsiclient.c:131:18: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static unsigned char wb[512]; data/libiscsi-1.19.0/examples/iscsiclient.c:175:18: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static unsigned char wb[512]; data/libiscsi-1.19.0/examples/ld_iscsi.c:64:5: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int open(const char *path, int flags, mode_t mode) data/libiscsi-1.19.0/examples/ld_iscsi.c:146:39: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). iscsi_fd_list[fd].get_lba_status = atoi(getenv("LD_ISCSI_GET_LBA_STATUS")); data/libiscsi-1.19.0/examples/ld_iscsi.c:164:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). return open(path, flags | O_LARGEFILE, mode); data/libiscsi-1.19.0/examples/ld_iscsi.c:193:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&iscsi_fd_list[i], &iscsi_fd_list[fd], sizeof(struct iscsi_fd_list)); data/libiscsi-1.19.0/examples/ld_iscsi.c:249:8: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = open(path, 0, 0); data/libiscsi-1.19.0/examples/ld_iscsi.c:397:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buf, &task->datain.data[iscsi_fd_list[fd].offset - offset], count); data/libiscsi-1.19.0/examples/ld_iscsi.c:468:92: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. task = iscsi_write16_sync(iscsi_fd_list[fd].iscsi, iscsi_fd_list[fd].lun, lba, (unsigned char *) buf, count, iscsi_fd_list[fd].block_size, 0, 0, 0, 0, 0); data/libiscsi-1.19.0/examples/ld_iscsi.c:596:11: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). debug = atoi(getenv("LD_ISCSI_DEBUG")); data/libiscsi-1.19.0/include/iscsi-private.h:73:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char initiator_name[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/include/iscsi-private.h:74:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char target_name[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/include/iscsi-private.h:75:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char target_address[MAX_STRING_SIZE+1]; /* If a redirect */ data/libiscsi-1.19.0/include/iscsi-private.h:76:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char connected_portal[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/include/iscsi-private.h:77:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char portal[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/include/iscsi-private.h:78:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char alias[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/include/iscsi-private.h:79:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char bind_interfaces[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/include/iscsi-private.h:81:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char user[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/include/iscsi-private.h:82:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char passwd[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/include/iscsi-private.h:83:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char chap_c[MAX_CHAP_C_LENGTH+1]; data/libiscsi-1.19.0/include/iscsi-private.h:85:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char target_user[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/include/iscsi-private.h:86:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char target_passwd[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/include/iscsi-private.h:88:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char target_chap_r[CHAP_R_SIZE]; data/libiscsi-1.19.0/include/iscsi-private.h:90:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char error_string[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/include/iscsi-private.h:93:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char isid[6]; data/libiscsi-1.19.0/include/iscsi.h:147:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char portal[MAX_STRING_SIZE + 1]; data/libiscsi-1.19.0/include/iscsi.h:148:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char target[MAX_STRING_SIZE + 1]; data/libiscsi-1.19.0/include/iscsi.h:149:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char user[MAX_STRING_SIZE + 1]; data/libiscsi-1.19.0/include/iscsi.h:150:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char passwd[MAX_STRING_SIZE + 1]; data/libiscsi-1.19.0/include/iscsi.h:151:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char target_user[MAX_STRING_SIZE + 1]; data/libiscsi-1.19.0/include/iscsi.h:152:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char target_passwd[MAX_STRING_SIZE + 1]; data/libiscsi-1.19.0/include/iser-private.h:124:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char iscsi_header[ISCSI_RAW_HEADER_SIZE]; data/libiscsi-1.19.0/include/iser-private.h:125:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char data[ISER_RECV_DATA_SEG_LEN]; data/libiscsi-1.19.0/include/iser-private.h:128:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pad[ISER_RX_PAD_SIZE]; data/libiscsi-1.19.0/include/iser-private.h:148:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char iscsi_header[ISCSI_RAW_HEADER_SIZE]; data/libiscsi-1.19.0/include/md5.h:56:24: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. void MD5Final(unsigned char digest[16], struct MD5Context *context); data/libiscsi-1.19.0/include/scsi-lowlevel.h:313:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char cdb[SCSI_CDB_MAX_SIZE]; data/libiscsi-1.19.0/include/scsi-lowlevel.h:519:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char vendor_identification[8+1]; data/libiscsi-1.19.0/include/scsi-lowlevel.h:520:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char product_identification[16+1]; data/libiscsi-1.19.0/include/scsi-lowlevel.h:521:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char product_revision_level[4+1]; data/libiscsi-1.19.0/lib/connect.c:460:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(tmp_iscsi->old_iscsi, iscsi, sizeof(struct iscsi_context)); data/libiscsi-1.19.0/lib/connect.c:462:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(iscsi, tmp_iscsi, sizeof(struct iscsi_context)); data/libiscsi-1.19.0/lib/init.c:177:13: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). urand_fd = open("/dev/urandom", O_RDONLY); data/libiscsi-1.19.0/lib/init.c:255:30: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). iscsi_set_log_level(iscsi, atoi(getenv("LIBISCSI_DEBUG"))); data/libiscsi-1.19.0/lib/init.c:260:36: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). iscsi_set_tcp_user_timeout(iscsi,atoi(getenv("LIBISCSI_TCP_USER_TIMEOUT"))); data/libiscsi-1.19.0/lib/init.c:264:31: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). iscsi_set_tcp_keepcnt(iscsi,atoi(getenv("LIBISCSI_TCP_KEEPCNT"))); data/libiscsi-1.19.0/lib/init.c:268:33: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). iscsi_set_tcp_keepintvl(iscsi,atoi(getenv("LIBISCSI_TCP_KEEPINTVL"))); data/libiscsi-1.19.0/lib/init.c:272:32: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). iscsi_set_tcp_keepidle(iscsi,atoi(getenv("LIBISCSI_TCP_KEEPIDLE"))); data/libiscsi-1.19.0/lib/init.c:276:30: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). iscsi_set_tcp_syncnt(iscsi,atoi(getenv("LIBISCSI_TCP_SYNCNT"))); data/libiscsi-1.19.0/lib/init.c:295:13: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). if (!ca || atoi(ca) != 0) { data/libiscsi-1.19.0/lib/init.c:439:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char errstr[MAX_STRING_SIZE + 1] = {0}; data/libiscsi-1.19.0/lib/init.c:541:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/iscsi-command.c:444:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(task->datain.data, in->data, task->datain.size); data/libiscsi-1.19.0/lib/iser.c:362:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(tx_desc->iscsi_header, iscsi_header, ISCSI_RAW_HEADER_SIZE); data/libiscsi-1.19.0/lib/iser.c:468:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(iser_conn->login_req_buf, data, datalen); data/libiscsi-1.19.0/lib/iser.c:584:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&tx_desc->data_buff[offset], iovector->iov[i].iov_base, iovector->iov[i].iov_len); data/libiscsi-1.19.0/lib/iser.c:1079:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(iser_pdu->iscsi_pdu.indata.data, &iser_pdu->desc->data_buff[offset], data/libiscsi-1.19.0/lib/iser.c:1083:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(iovector_in->iov[i].iov_base, &iser_pdu->desc->data_buff[offset], data/libiscsi-1.19.0/lib/iser.c:1328:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&event_copy, iser_conn->cma_event, sizeof(struct rdma_cm_event)); data/libiscsi-1.19.0/lib/logging.c:59:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char message[1024]; data/libiscsi-1.19.0/lib/logging.c:75:10: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char message2[1282]; data/libiscsi-1.19.0/lib/login.c:54:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:78:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:103:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:134:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:167:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:204:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:224:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:249:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:274:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:297:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:320:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:343:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:363:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:383:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:403:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:423:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:443:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:463:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:483:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:503:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:523:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:543:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:563:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:590:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:614:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:642:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:711:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char digest[16]; data/libiscsi-1.19.0/lib/login.c:715:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. return memcpy(h->buf, digest, sizeof(digest)); data/libiscsi-1.19.0/lib/login.c:731:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[MAX_STRING_SIZE+1]; data/libiscsi-1.19.0/lib/login.c:733:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char c, cc[2]; data/libiscsi-1.19.0/lib/login.c:734:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char digest[CHAP_R_SIZE]; data/libiscsi-1.19.0/lib/login.c:792:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char target_chap_c[TARGET_CHAP_C_SIZE]; data/libiscsi-1.19.0/lib/login.c:1261:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). iscsi->chap_a = atoi(ptr+7); data/libiscsi-1.19.0/lib/login.c:1266:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). iscsi->chap_i = atoi(ptr+7); data/libiscsi-1.19.0/lib/md5.c:81:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((md5byte *)ctx->in + 64 - t, buf, len); data/libiscsi-1.19.0/lib/md5.c:85:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((md5byte *)ctx->in + 64 - t, buf, t); data/libiscsi-1.19.0/lib/md5.c:93:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(ctx->in, buf, 64); data/libiscsi-1.19.0/lib/md5.c:101:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(ctx->in, buf, len); data/libiscsi-1.19.0/lib/md5.c:136:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(digest, ctx->buf, 16); data/libiscsi-1.19.0/lib/pdu.c:82:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char dump[ISCSI_RAW_HEADER_SIZE*3+1]={0}; data/libiscsi-1.19.0/lib/pdu.c:128:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&pdu->outdata.data[8], &iscsi->isid[0], 6); data/libiscsi-1.19.0/lib/pdu.c:206:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data->data + data->size, dptr, dsize); data/libiscsi-1.19.0/lib/pdu.c:700:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&pdu->outdata.data[32], task->cdb, task->cdb_size); data/libiscsi-1.19.0/lib/scsi-lowlevel.c:64:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[0]; data/libiscsi-1.19.0/lib/scsi-lowlevel.c:96:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&task->cdb[0], cdb, cdb_size); data/libiscsi-1.19.0/lib/scsi-lowlevel.c:1181:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(rsoc_one->cdb_usage_data, data/libiscsi-1.19.0/lib/scsi-lowlevel.c:1381:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&inq->vendor_identification[0], data/libiscsi-1.19.0/lib/scsi-lowlevel.c:1383:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&inq->product_identification[0], data/libiscsi-1.19.0/lib/scsi-lowlevel.c:1385:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&inq->product_revision_level[0], data/libiscsi-1.19.0/lib/scsi-lowlevel.c:1416:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(inq->pages, &task->datain.data[4], inq->num_pages); data/libiscsi-1.19.0/lib/scsi-lowlevel.c:1436:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(inq->usn, &task->datain.data[4], task_get_uint8(task, 3)); data/libiscsi-1.19.0/lib/scsi-lowlevel.c:1479:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dev->designator, &dptr[4], data/libiscsi-1.19.0/lib/scsi-lowlevel.c:4139:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(iovector->iov, old_iov, iovector->niov * sizeof(struct iovec)); data/libiscsi-1.19.0/lib/scsi-lowlevel.c:4166:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(sense, &task->sense, sizeof(struct scsi_sense)); data/libiscsi-1.19.0/lib/socket.c:327:12: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). port = atoi(str+1); data/libiscsi-1.19.0/lib/socket.c:359:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&sa.sin, ai->ai_addr, socksize); data/libiscsi-1.19.0/lib/socket.c:369:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&sa.sin6, ai->ai_addr, socksize); data/libiscsi-1.19.0/lib/socket.c:651:13: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char padding_buf[3]; data/libiscsi-1.19.0/lib/socket.c:731:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char padding_buf[3]; data/libiscsi-1.19.0/test-tool/iscsi-multipath.c:90:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(des_cp->designator, des->designator, des->designator_length); data/libiscsi-1.19.0/test-tool/iscsi-support.c:124:23: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const unsigned char zeroBlock[4096]; data/libiscsi-1.19.0/test-tool/iscsi-support.c:335:26: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char sense[sense_len]; data/libiscsi-1.19.0/test-tool/iscsi-support.c:336:17: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/libiscsi-1.19.0/test-tool/iscsi-support.c:461:16: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char message[1024]; data/libiscsi-1.19.0/test-tool/iscsi-support.c:1353:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buf, task->datain.data, task->datain.size); data/libiscsi-1.19.0/test-tool/iscsi-support.c:1431:17: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buf, task->datain.data, task->datain.size); data/libiscsi-1.19.0/test-tool/iscsi-support.c:1866:17: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data, task->datain.data, task->datain.size); data/libiscsi-1.19.0/test-tool/iscsi-support.c:1901:17: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data, task->datain.data, task->datain.size); data/libiscsi-1.19.0/test-tool/iscsi-support.c:1936:17: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data, task->datain.data, task->datain.size); data/libiscsi-1.19.0/test-tool/iscsi-support.c:1971:17: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data, task->datain.data, task->datain.size); data/libiscsi-1.19.0/test-tool/iscsi-support.c:2964:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buf + 4, tgt_desig->designator, tgt_desig->designator_length); data/libiscsi-1.19.0/test-tool/iscsi-test-cu.c:824:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char const *initiatornames[MPATH_MAX_DEVS] = { initiatorname1, initiatorname2 }; data/libiscsi-1.19.0/test-tool/iscsi-test-cu.c:986:17: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char t[256]; data/libiscsi-1.19.0/test-tool/iscsi-test-cu.c:988:27: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fh = fopen(test, "r")) == NULL) { data/libiscsi-1.19.0/test-tool/iscsi-test-cu.c:1043:38: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((sdev->sgio_fd = open(sdev->sgio_dev, O_RDWR|O_NONBLOCK)) == -1) { data/libiscsi-1.19.0/test-tool/test_async_abort_simple.c:97:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[blocksize * blocks_per_io]; data/libiscsi-1.19.0/test-tool/test_async_lu_reset_simple.c:96:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[blocksize * blocks_per_io]; data/libiscsi-1.19.0/test-tool/test_async_write.c:66:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[blocksize * blocks_per_io]; data/libiscsi-1.19.0/test-tool/test_compareandwrite_dpofua.c:59:17: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(scratch + block_size, scratch, block_size); data/libiscsi-1.19.0/test-tool/test_compareandwrite_unwritten.c:48:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char read_buf[block_size]; data/libiscsi-1.19.0/test-tool/test_multipathio_async_caw.c:108:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char cmp_buf[block_size * mp_num_sds]; data/libiscsi-1.19.0/test-tool/test_multipathio_async_caw.c:109:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char wr_buf[block_size * mp_num_sds]; data/libiscsi-1.19.0/test-tool/test_write10_residuals.c:34:18: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[10000]; data/libiscsi-1.19.0/test-tool/test_write12_residuals.c:34:18: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[10000]; data/libiscsi-1.19.0/test-tool/test_write16_residuals.c:34:18: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[10000]; data/libiscsi-1.19.0/test-tool/test_writesame10_check.c:35:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char read_buf[ws_max_blocks * block_size]; data/libiscsi-1.19.0/test-tool/test_writesame16_check.c:35:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char read_buf[ws_max_blocks * block_size]; data/libiscsi-1.19.0/test-tool/test_writeverify10_residuals.c:34:18: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[10000]; data/libiscsi-1.19.0/test-tool/test_writeverify12_residuals.c:34:18: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[10000]; data/libiscsi-1.19.0/test-tool/test_writeverify16_residuals.c:34:18: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[10000]; data/libiscsi-1.19.0/tests/prog_reconnect.c:116:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/libiscsi-1.19.0/tests/prog_reconnect_timeout.c:52:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char portal[MAX_STRING_SIZE]; data/libiscsi-1.19.0/tests/prog_reconnect_timeout.c:126:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/libiscsi-1.19.0/utils/iscsi-inq.c:273:11: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). evpd = atoi(optarg); data/libiscsi-1.19.0/utils/iscsi-inq.c:276:15: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). pagecode = atoi(optarg); data/libiscsi-1.19.0/utils/iscsi-perf.c:280:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). max_in_flight = atoi(optarg); data/libiscsi-1.19.0/utils/iscsi-perf.c:283:14: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). runtime = atoi(optarg); data/libiscsi-1.19.0/utils/iscsi-perf.c:286:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). blocks_per_io = atoi(optarg); data/libiscsi-1.19.0/utils/iscsi-perf.c:301:28: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). client.max_reconnects = atoi(optarg); data/libiscsi-1.19.0/win32/win32_compat.c:58:3: [2] (buffer) MultiByteToWideChar: Requires maximum length in CHARACTERS, not bytes (CWE-120). MultiByteToWideChar(CP_ACP, 0, src, -1, srcNonConst, strLen); data/libiscsi-1.19.0/win32/win32_compat.c:77:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dst, &sa.sin_addr, sizeof(struct in_addr)); data/libiscsi-1.19.0/aros/aros_compat.c:172:9: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). return read(fd, iov[0].iov_base, iov[0].iov_len); data/libiscsi-1.19.0/examples/ld_iscsi.c:302:9: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ssize_t read(int fd, void *buf, size_t count) data/libiscsi-1.19.0/examples/ld_iscsi.c:311:11: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). return read(iscsi_fd_list[fd].dup2fd, buf, count); data/libiscsi-1.19.0/examples/ld_iscsi.c:419:7: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if (read(fd, buf, count) < 0) { data/libiscsi-1.19.0/lib/connect.c:217:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi->portal, portal, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/connect.c:434:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(tmp_iscsi->portal, iscsi->portal, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/connect.c:436:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(tmp_iscsi->bind_interfaces, iscsi->bind_interfaces, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/discovery.c:72:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/init.c:182:7: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). rc = read(urand_fd, &seed, sizeof(seed)); data/libiscsi-1.19.0/lib/init.c:225:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi->initiator_name,initiator_name,MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:369:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi->alias,alias,MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:382:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi->target_name,target_name,MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:443:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(errstr, "could not format error string!", MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:448:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi->error_string, errstr,MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:532:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). memmove(tmp, str, strlen(str)); data/libiscsi-1.19.0/lib/init.c:533:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp[strlen(str)] = 0; data/libiscsi-1.19.0/lib/init.c:575:17: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(str, url + 7, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:579:17: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(str, url + 8, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:702:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi_url->portal,portal,MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:705:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi_url->user, user, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:706:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi_url->passwd, passwd, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:711:4: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi_url->target_user, target_user, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:712:4: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi_url->target_passwd, target_passwd, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:727:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi_url->target, target, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:777:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi->user,user,MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:778:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi->passwd,passwd,MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:792:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi->target_user, user, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/init.c:793:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi->target_passwd, passwd, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:67:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:92:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:123:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:145:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"SessionType=Discovery",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:148:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"SessionType=Normal",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:155:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:176:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"HeaderDigest=None",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:179:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"HeaderDigest=None,CRC32C",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:182:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"HeaderDigest=CRC32C,None",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:185:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"HeaderDigest=CRC32C",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:192:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:211:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"DataDigest=None",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:212:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:237:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:262:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:286:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:309:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:332:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:350:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"DataPDUInOrder=Yes",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:351:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:370:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"DefaultTime2Wait=2",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:371:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:390:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"DefaultTime2Retain=0",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:391:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:410:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"IFMarker=No",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:411:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:430:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"OFMarker=No",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:431:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:450:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"MaxConnections=1",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:451:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:470:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"MaxOutstandingR2T=1",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:471:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:490:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"ErrorRecoveryLevel=0",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:491:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:510:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"DataSequenceInOrder=Yes",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:511:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:530:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"AuthMethod=CHAP,None",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:531:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:550:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"CHAP_A=5",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:551:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:570:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"CHAP_N=",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:571:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)) data/libiscsi-1.19.0/lib/login.c:578:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(iscsi->user) +1) != 0) { data/libiscsi-1.19.0/lib/login.c:601:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"RDMAExtensions=Yes",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:602:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:631:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) != 0) { data/libiscsi-1.19.0/lib/login.c:659:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)+1) data/libiscsi-1.19.0/lib/login.c:754:53: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). gcry_md_write(ctx, (unsigned char *)iscsi->passwd, strlen(iscsi->passwd)); data/libiscsi-1.19.0/lib/login.c:765:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str,"CHAP_R=0x",MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:766:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (iscsi_pdu_add_data(iscsi, pdu, (unsigned char *)str, strlen(str)) data/libiscsi-1.19.0/lib/login.c:798:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(str) + 1) != 0) { data/libiscsi-1.19.0/lib/login.c:807:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(str, "CHAP_C=0x", MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:809:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(str)) != 0) { data/libiscsi-1.19.0/lib/login.c:838:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(iscsi->target_passwd)); data/libiscsi-1.19.0/lib/login.c:1196:4: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi->target_address,ptr+14,MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/login.c:1281:4: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. strncat(iscsi->chap_c,ptr+9,len-9); data/libiscsi-1.19.0/lib/socket.c:257:70: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int res = setsockopt(iscsi->fd, SOL_SOCKET, SO_BINDTODEVICE, pchr, strlen(pchr)); data/libiscsi-1.19.0/lib/socket.c:397:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi->connected_portal, portal, MAX_STRING_SIZE); data/libiscsi-1.19.0/lib/socket.c:1093:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iscsi->bind_interfaces,interfaces,MAX_STRING_SIZE); data/libiscsi-1.19.0/test-tool/iscsi-test-cu.c:994:43: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen(t); data/libiscsi-1.19.0/tests/prog_reconnect_timeout.c:332:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(state.portal, iscsi_url->portal, MAX_STRING_SIZE); data/libiscsi-1.19.0/win32/win32_compat.c:54:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int strLen = strlen(src) + 1; data/libiscsi-1.19.0/win32/win32_compat.c:62:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(srcNonConst, src, strLen); ANALYSIS SUMMARY: Hits = 325 Lines analyzed = 54056 in approximately 1.53 seconds (35436 lines/second) Physical Source Lines of Code (SLOC) = 39443 Hits@level = [0] 785 [1] 91 [2] 167 [3] 59 [4] 8 [5] 0 Hits@level+ = [0+] 1110 [1+] 325 [2+] 234 [3+] 67 [4+] 8 [5+] 0 Hits/KSLOC@level+ = [0+] 28.1419 [1+] 8.23974 [2+] 5.93261 [3+] 1.69865 [4+] 0.202824 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.