Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/libksysguard-5.19.5/sensors/SensorTreeModel.cpp Examining data/libksysguard-5.19.5/sensors/SensorQuery.cpp Examining data/libksysguard-5.19.5/sensors/declarative/SensorsPlugin.cpp Examining data/libksysguard-5.19.5/sensors/declarative/SensorsPlugin.h Examining data/libksysguard-5.19.5/sensors/Sensor.h Examining data/libksysguard-5.19.5/sensors/Sensor.cpp Examining data/libksysguard-5.19.5/sensors/SensorInfo_p.h Examining data/libksysguard-5.19.5/sensors/SensorQuery.h Examining data/libksysguard-5.19.5/sensors/SensorDataModel.h Examining data/libksysguard-5.19.5/sensors/SensorDaemonInterface_p.h Examining data/libksysguard-5.19.5/sensors/SensorDaemonInterface.cpp Examining data/libksysguard-5.19.5/sensors/SensorTreeModel.h Examining data/libksysguard-5.19.5/sensors/SensorDataModel.cpp Examining data/libksysguard-5.19.5/formatter/declarative/FormatterPlugin.cpp Examining data/libksysguard-5.19.5/formatter/declarative/FormatterWrapper.h Examining data/libksysguard-5.19.5/formatter/declarative/FormatterWrapper.cpp Examining data/libksysguard-5.19.5/formatter/declarative/FormatterPlugin.h Examining data/libksysguard-5.19.5/formatter/Formatter.h Examining data/libksysguard-5.19.5/formatter/Unit.h Examining data/libksysguard-5.19.5/formatter/Unit.cpp Examining data/libksysguard-5.19.5/formatter/Formatter.cpp Examining data/libksysguard-5.19.5/processcore/formatter.h Examining data/libksysguard-5.19.5/processcore/process_data_model.h Examining data/libksysguard-5.19.5/processcore/process_controller.cpp Examining data/libksysguard-5.19.5/processcore/processes_atop_p.h Examining data/libksysguard-5.19.5/processcore/process_attribute.h Examining data/libksysguard-5.19.5/processcore/process_data_model.cpp Examining data/libksysguard-5.19.5/processcore/processes_linux_p.cpp Examining data/libksysguard-5.19.5/processcore/process_attribute_model.cpp Examining data/libksysguard-5.19.5/processcore/processes_atop_p.cpp Examining data/libksysguard-5.19.5/processcore/declarative/ProcessEnums.h Examining data/libksysguard-5.19.5/processcore/declarative/ProcessPlugin.cpp Examining data/libksysguard-5.19.5/processcore/declarative/ProcessEnums.cpp Examining data/libksysguard-5.19.5/processcore/declarative/ProcessPlugin.h Examining data/libksysguard-5.19.5/processcore/processes_remote_p.cpp Examining data/libksysguard-5.19.5/processcore/processes_local_p.h Examining data/libksysguard-5.19.5/processcore/unit.h Examining data/libksysguard-5.19.5/processcore/process.h Examining data/libksysguard-5.19.5/processcore/process_data_provider.cpp Examining data/libksysguard-5.19.5/processcore/helper.cpp Examining data/libksysguard-5.19.5/processcore/helper.h Examining data/libksysguard-5.19.5/processcore/process_controller.h Examining data/libksysguard-5.19.5/processcore/processes.cpp Examining data/libksysguard-5.19.5/processcore/processes.h Examining data/libksysguard-5.19.5/processcore/processes_base_p.h Examining data/libksysguard-5.19.5/processcore/processes_solaris_p.cpp Examining data/libksysguard-5.19.5/processcore/processes_openbsd_p.cpp Examining data/libksysguard-5.19.5/processcore/processes_gnu_p.cpp Examining data/libksysguard-5.19.5/processcore/process.cpp Examining data/libksysguard-5.19.5/processcore/processes_netbsd_p.cpp Examining data/libksysguard-5.19.5/processcore/process_data_provider.h Examining data/libksysguard-5.19.5/processcore/process_attribute_model.h Examining data/libksysguard-5.19.5/processcore/extended_process_list.cpp Examining data/libksysguard-5.19.5/processcore/processes_base_p.cpp Examining data/libksysguard-5.19.5/processcore/processes_remote_p.h Examining data/libksysguard-5.19.5/processcore/atop_p.h Examining data/libksysguard-5.19.5/processcore/process_attribute.cpp Examining data/libksysguard-5.19.5/processcore/processes_freebsd_p.cpp Examining data/libksysguard-5.19.5/processcore/processes_local_p.cpp Examining data/libksysguard-5.19.5/processcore/processes_dragonfly_p.cpp Examining data/libksysguard-5.19.5/processcore/extended_process_list.h Examining data/libksysguard-5.19.5/processui/ProcessModel.h Examining data/libksysguard-5.19.5/processui/ksysguardprocesslist.h Examining data/libksysguard-5.19.5/processui/timeutil.h Examining data/libksysguard-5.19.5/processui/scripting.cpp Examining data/libksysguard-5.19.5/processui/ProcessFilter.cpp Examining data/libksysguard-5.19.5/processui/KTextEditVT.h Examining data/libksysguard-5.19.5/processui/scripting.h Examining data/libksysguard-5.19.5/processui/ReniceDlg.cpp Examining data/libksysguard-5.19.5/processui/ReniceDlg.h Examining data/libksysguard-5.19.5/processui/ksysguardprocesslist.cpp Examining data/libksysguard-5.19.5/processui/KTextEditVT.cpp Examining data/libksysguard-5.19.5/processui/ProcessModel.cpp Examining data/libksysguard-5.19.5/processui/ProcessModel_p.h Examining data/libksysguard-5.19.5/processui/ProcessFilter.h Examining data/libksysguard-5.19.5/ksgrd/SensorAgent.cpp Examining data/libksysguard-5.19.5/ksgrd/SensorManager.h Examining data/libksysguard-5.19.5/ksgrd/SensorShellAgent.cpp Examining data/libksysguard-5.19.5/ksgrd/SensorShellAgent.h Examining data/libksysguard-5.19.5/ksgrd/SensorManager.cpp Examining data/libksysguard-5.19.5/ksgrd/SensorClient.h Examining data/libksysguard-5.19.5/ksgrd/SensorSocketAgent.cpp Examining data/libksysguard-5.19.5/ksgrd/SensorAgent.h Examining data/libksysguard-5.19.5/ksgrd/SensorSocketAgent.h Examining data/libksysguard-5.19.5/autotests/signalplotterbenchmark.h Examining data/libksysguard-5.19.5/autotests/chronotest.h Examining data/libksysguard-5.19.5/autotests/graphicssignalplotterbenchmark.h Examining data/libksysguard-5.19.5/autotests/ksysguarddtest.cpp Examining data/libksysguard-5.19.5/autotests/graphicssignalplotterbenchmark.cpp Examining data/libksysguard-5.19.5/autotests/signalplotterbenchmark.cpp Examining data/libksysguard-5.19.5/autotests/sensortreemodeltest.cpp Examining data/libksysguard-5.19.5/autotests/processdatamodeltest.cpp Examining data/libksysguard-5.19.5/autotests/formattertest.cpp Examining data/libksysguard-5.19.5/autotests/processtest.cpp Examining data/libksysguard-5.19.5/autotests/signalplottertest.h Examining data/libksysguard-5.19.5/autotests/ksysguarddtest.h Examining data/libksysguard-5.19.5/autotests/guitest.h Examining data/libksysguard-5.19.5/autotests/chronotest.cpp Examining data/libksysguard-5.19.5/autotests/signalplottertest.cpp Examining data/libksysguard-5.19.5/autotests/processtest.h Examining data/libksysguard-5.19.5/autotests/sensordatamodeltest.cpp Examining data/libksysguard-5.19.5/autotests/guitest.cpp Examining data/libksysguard-5.19.5/signalplotter/ksignalplotter_p.h Examining data/libksysguard-5.19.5/signalplotter/kgraphicssignalplotter.h Examining data/libksysguard-5.19.5/signalplotter/kgraphicssignalplotter.cpp Examining data/libksysguard-5.19.5/signalplotter/ksignalplotter.cpp Examining data/libksysguard-5.19.5/signalplotter/ksignalplotter.h Examining data/libksysguard-5.19.5/faces/packagestructure/sensorfacepackage.cpp Examining data/libksysguard-5.19.5/faces/SensorFaceController_p.h Examining data/libksysguard-5.19.5/faces/import/FacesPlugin.cpp Examining data/libksysguard-5.19.5/faces/import/FacesPlugin.h Examining data/libksysguard-5.19.5/faces/SensorFace_p.h Examining data/libksysguard-5.19.5/faces/SensorFaceController.h Examining data/libksysguard-5.19.5/faces/SensorFaceController.cpp Examining data/libksysguard-5.19.5/faces/SensorFace.cpp Examining data/libksysguard-5.19.5/lsofui/LsofSearchWidget.h Examining data/libksysguard-5.19.5/lsofui/LsofSearchWidget.cpp Examining data/libksysguard-5.19.5/lsofui/lsof.h Examining data/libksysguard-5.19.5/lsofui/lsof.cpp FINAL RESULTS: data/libksysguard-5.19.5/lsofui/lsof.cpp:58:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/libksysguard-5.19.5/processcore/atop_p.h:55:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char cfuture[8]; /* future use */ data/libksysguard-5.19.5/processcore/atop_p.h:93:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[PNAMLEN+1];/* process name string */ data/libksysguard-5.19.5/processcore/atop_p.h:97:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char cmdline[CMDLEN+1];/* command-line string */ data/libksysguard-5.19.5/processcore/processes_atop_p.cpp:93:17: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!atopLog.open(QIODevice::ReadOnly)) { data/libksysguard-5.19.5/processcore/processes_dragonfly_p.cpp:124:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/libksysguard-5.19.5/processcore/processes_freebsd_p.cpp:127:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:121:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char mBuffer[PROCESS_BUFFER_SIZE+1]; //used as a buffer to read data into data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:137:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!mFile.open(QIODevice::ReadOnly)) data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:156:45: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). process->setNoNewPrivileges(atol(mBuffer + sizeof("NoNewPrivs:")-1)); data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:187:35: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). process->setTracerpid(atol(mBuffer + sizeof("TracerPid:")-1)); data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:192:36: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). process->setNumThreads(atol(mBuffer + sizeof("Threads:")-1)); data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:209:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!mFile.open(QIODevice::ReadOnly)) data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:225:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!mFile.open(QIODevice::ReadOnly)) data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:239:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!d->mFile.open(QIODevice::ReadOnly)) data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:267:17: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). long ppid = atol(++word); data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:279:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!mFile.open(QIODevice::ReadOnly)) data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:309:37: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). int ttyNo = atoi(word+1); data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:337:38: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). ps->setNiceLevel(atoi(word+1)); /*Or should we use getPriority instead? */ data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:397:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!mFile.open(QIODevice::ReadOnly)) data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:418:19: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). long shared = atol(word+1); data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:433:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!mFile.open(QIODevice::ReadOnly)) data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:462:16: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!mFile.open(QIODevice::ReadOnly)) { data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:533:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!mFile.open(QIODevice::ReadOnly)) data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:597:25: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). pids.insert(atol( entry->d_name )); data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:758:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!d->mFile.open(QIODevice::ReadOnly)) data/libksysguard-5.19.5/processcore/processes_openbsd_p.cpp:159:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/libksysguard-5.19.5/processcore/processes_solaris_p.cpp:62:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char mBuf[PROCESS_BUFFER_SIZE+1]; //used as a buffer to read data into data/libksysguard-5.19.5/processcore/processes_solaris_p.cpp:76:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if( (fd = open( d->mBuf, O_RDONLY )) < 0 ) { data/libksysguard-5.19.5/processcore/processes_solaris_p.cpp:97:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if( (fd = open( d->mBuf, O_RDONLY )) < 0 ) { data/libksysguard-5.19.5/processcore/processes_solaris_p.cpp:102:16: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if( (pfd = open( d->mBuf, O_RDONLY )) < 0 ) { data/libksysguard-5.19.5/processcore/processes_solaris_p.cpp:195:19: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). pid = atol( entry->d_name ); data/libksysguard-5.19.5/processui/scripting.cpp:120:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!file.open(QIODevice::ReadOnly)) data/libksysguard-5.19.5/processui/scripting.cpp:162:22: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). webChannelJsFile.open(QIODevice::ReadOnly); data/libksysguard-5.19.5/faces/SensorFaceController.cpp:636:38: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). d->faceConfigLoader->read(); data/libksysguard-5.19.5/ksgrd/SensorSocketAgent.cpp:87:11: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). mSocket.read( buffer, buflen ); data/libksysguard-5.19.5/processcore/processes_atop_p.cpp:98:28: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). int sizeRead = atopLog.read((char*)(&rh), sizeof(RawHeader)); data/libksysguard-5.19.5/processcore/processes_atop_p.cpp:125:40: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while( !atopLog.atEnd() && atopLog.read((char*)(&rr), sizeof(RawRecord)) == sizeof(RawRecord) ) { data/libksysguard-5.19.5/processcore/processes_atop_p.cpp:144:17: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if( atopLog.read((char*)(&rr), sizeof(RawRecord)) != sizeof(RawRecord) ) { data/libksysguard-5.19.5/processcore/processes_atop_p.cpp:162:27: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). int ret = atopLog.read( processRecord.data() + dataRead, rr.pcomplen - dataRead); data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:468:39: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (qstrncmp(mBuffer, "Pss:", strlen("Pss:")) == 0) { data/libksysguard-5.19.5/processcore/processes_linux_p.cpp:535:15: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if( mFile.read( mBuffer, sizeof(mBuffer)) <= 0) { //-1 indicates nothing read data/libksysguard-5.19.5/processcore/processes_solaris_p.cpp:80:9: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if( read( fd, &psinfo, sizeof( psinfo_t )) != sizeof( psinfo_t )) { data/libksysguard-5.19.5/processcore/processes_solaris_p.cpp:112:9: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if( read( fd, &psinfo, sizeof( psinfo_t )) != sizeof( psinfo_t )) { data/libksysguard-5.19.5/processcore/processes_solaris_p.cpp:118:9: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if( read( pfd, &prusage, sizeof( prusage_t )) != sizeof( prusage_t )) { ANALYSIS SUMMARY: Hits = 45 Lines analyzed = 23924 in approximately 0.94 seconds (25508 lines/second) Physical Source Lines of Code (SLOC) = 16315 Hits@level = [0] 5 [1] 11 [2] 34 [3] 0 [4] 0 [5] 0 Hits@level+ = [0+] 50 [1+] 45 [2+] 34 [3+] 0 [4+] 0 [5+] 0 Hits/KSLOC@level+ = [0+] 3.06466 [1+] 2.7582 [2+] 2.08397 [3+] 0 [4+] 0 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.