Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/libzc-0.4.1/lib/common.c Examining data/libzc-0.4.1/lib/crc32.h Examining data/libzc-0.4.1/lib/decrypt_byte.h Examining data/libzc-0.4.1/lib/find_password.c Examining data/libzc-0.4.1/lib/inflate.c Examining data/libzc-0.4.1/lib/ka.c Examining data/libzc-0.4.1/lib/libzc.c Examining data/libzc-0.4.1/lib/libzc.h Examining data/libzc-0.4.1/lib/libzc_private.h Examining data/libzc-0.4.1/lib/list.h Examining data/libzc-0.4.1/lib/ptext_attack.c Examining data/libzc-0.4.1/lib/ptext_private.h Examining data/libzc-0.4.1/lib/ptext_reduce.c Examining data/libzc-0.4.1/lib/pwstream.c Examining data/libzc-0.4.1/lib/pwstream.h Examining data/libzc-0.4.1/lib/qsort.h Examining data/libzc-0.4.1/lib/zc_crk_bforce.c Examining data/libzc-0.4.1/lib/zc_crk_dict.c Examining data/libzc-0.4.1/lib/zc_crk_ptext.c Examining data/libzc-0.4.1/lib/zc_file.c Examining data/libzc-0.4.1/tests/check_basic.c Examining data/libzc-0.4.1/tests/check_bruteforce.c Examining data/libzc-0.4.1/tests/check_dictionary.c Examining data/libzc-0.4.1/tests/check_file.c Examining data/libzc-0.4.1/tests/check_plaintext.c Examining data/libzc-0.4.1/tests/check_plaintext_password.c Examining data/libzc-0.4.1/tests/check_pwstream.c Examining data/libzc-0.4.1/tests/check_reduce.c Examining data/libzc-0.4.1/tests/test_plaintext.h Examining data/libzc-0.4.1/yazc/yazc-bruteforce.c Examining data/libzc-0.4.1/yazc/yazc-dictionary.c Examining data/libzc-0.4.1/yazc/yazc-info.c Examining data/libzc-0.4.1/yazc/yazc-plaintext.c Examining data/libzc-0.4.1/yazc/yazc.c Examining data/libzc-0.4.1/yazc/yazc.h FINAL RESULTS: data/libzc-0.4.1/lib/libzc.c:65:2: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vfprintf(stderr, format, args); data/libzc-0.4.1/lib/libzc_private.h:36:57: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. static inline void __attribute__((always_inline, format(printf, 2, 3))) data/libzc-0.4.1/lib/libzc_private.h:64:23: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. __attribute__((format(printf, 6, 7))); data/libzc-0.4.1/yazc/yazc.c:92:2: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vfprintf(stderr, format, args); data/libzc-0.4.1/yazc/yazc.c:102:2: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vfprintf(stderr, format, args); data/libzc-0.4.1/yazc/yazc.h:45:23: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. __attribute__((format(printf, 4, 5))); data/libzc-0.4.1/yazc/yazc.h:47:23: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. __attribute__((format(printf, 1, 2))); data/libzc-0.4.1/lib/libzc.c:107:8: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. env = getenv("ZC_LOG"); data/libzc-0.4.1/yazc/yazc-bruteforce.c:203:7: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. c = getopt_long(argc, argv, short_opts, long_opts, &idx); data/libzc-0.4.1/yazc/yazc-dictionary.c:92:7: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. c = getopt_long(argc, argv, short_opts, long_opts, &idx); data/libzc-0.4.1/yazc/yazc-info.c:54:6: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. c = getopt_long(argc, argv, short_opts, long_opts, &idx); data/libzc-0.4.1/yazc/yazc-plaintext.c:218:7: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. c = getopt_long(argc, argv, short_opts, long_opts, &idx); data/libzc-0.4.1/yazc/yazc.c:115:7: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. c = getopt_long(argc, argv, options_s, options, NULL); data/libzc-0.4.1/lib/find_password.c:32:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[PASS_MAX_LEN]; data/libzc-0.4.1/lib/find_password.c:109:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char revpw[PASS_MAX_LEN]; data/libzc-0.4.1/lib/find_password.c:417:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(out, f.pw, ret); data/libzc-0.4.1/lib/libzc.h:93:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char set[ZC_CHARSET_MAXLEN + 1]; data/libzc-0.4.1/lib/libzc.h:96:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char initial[ZC_PW_MAXLEN + 1]; data/libzc-0.4.1/lib/zc_crk_bforce.c:53:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char ipw[ZC_PW_MAXLEN + 1]; data/libzc-0.4.1/lib/zc_crk_bforce.c:58:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char set[ZC_CHARSET_MAXLEN + 1]; data/libzc-0.4.1/lib/zc_crk_bforce.c:82:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[ZC_PW_MAXLEN + 1]; data/libzc-0.4.1/lib/zc_crk_bforce.c:618:23: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. initial[j] = (const char *)memchr(set, ipw[i], setlen) - set; data/libzc-0.4.1/lib/zc_crk_bforce.c:684:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(crk->ipw, cfg->initial, ZC_PW_MAXLEN + 1); data/libzc-0.4.1/lib/zc_crk_bforce.c:685:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(crk->set, cfg->set, ZC_CHARSET_MAXLEN + 1); data/libzc-0.4.1/lib/zc_crk_dict.c:188:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pwbuf[PW_BUF_LEN]; data/libzc-0.4.1/lib/zc_crk_dict.c:195:7: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(dict, "r"); data/libzc-0.4.1/lib/zc_file.c:317:11: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). stream = fopen(file->filename, "r"); data/libzc-0.4.1/lib/zc_file.c:401:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(vdata[valid_files].encryption_header, data/libzc-0.4.1/tests/check_bruteforce.c:49:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(cfg.initial, "test", 5); data/libzc-0.4.1/tests/check_bruteforce.c:60:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cfg.set, "aaaaabcd"); data/libzc-0.4.1/tests/check_bruteforce.c:85:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cfg.set, "abcd"); data/libzc-0.4.1/tests/check_bruteforce.c:107:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char out[7]; data/libzc-0.4.1/tests/check_bruteforce.c:109:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cfg.set, "noradiqwerty"); data/libzc-0.4.1/tests/check_bruteforce.c:124:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char out[7]; data/libzc-0.4.1/tests/check_bruteforce.c:126:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cfg.set, "noradiqwerty"); data/libzc-0.4.1/tests/check_bruteforce.c:145:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char out[7]; data/libzc-0.4.1/tests/check_bruteforce.c:147:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cfg.set, "noradiqwerty"); data/libzc-0.4.1/tests/check_bruteforce.c:161:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char out[7]; data/libzc-0.4.1/tests/check_bruteforce.c:163:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cfg.set, "noradiqwerty"); data/libzc-0.4.1/tests/check_bruteforce.c:178:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char out[5]; data/libzc-0.4.1/tests/check_bruteforce.c:180:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cfg.set, "password"); data/libzc-0.4.1/tests/check_bruteforce.c:195:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char out[5]; data/libzc-0.4.1/tests/check_bruteforce.c:197:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cfg.set, "password"); data/libzc-0.4.1/tests/check_bruteforce.c:216:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char out[7]; data/libzc-0.4.1/tests/check_bruteforce.c:218:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cfg.set, "noradi"); data/libzc-0.4.1/tests/check_bruteforce.c:246:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char out[10]; data/libzc-0.4.1/tests/check_bruteforce.c:248:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cfg.set, "amorpheus!"); data/libzc-0.4.1/tests/check_bruteforce.c:251:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cfg.initial, "moaaaaaaa"); data/libzc-0.4.1/tests/check_bruteforce.c:263:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char out[7]; data/libzc-0.4.1/tests/check_bruteforce.c:265:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cfg.set, "noradiqwerty"); data/libzc-0.4.1/tests/check_dictionary.c:28:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[LEN]; data/libzc-0.4.1/tests/check_file.c:99:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. const char *info_filename[4] = {"lib/test_crk.c", data/libzc-0.4.1/tests/check_file.c:142:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. const char *info_filename[3] = {"config.h", data/libzc-0.4.1/tests/check_plaintext_password.c:79:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/tests/check_plaintext_password.c:88:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/tests/check_plaintext_password.c:98:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/tests/check_plaintext_password.c:108:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/tests/check_plaintext_password.c:118:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/tests/check_plaintext_password.c:128:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/tests/check_plaintext_password.c:138:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/tests/check_plaintext_password.c:148:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/tests/check_plaintext_password.c:158:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/tests/check_plaintext_password.c:168:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/tests/check_plaintext_password.c:178:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/tests/check_plaintext_password.c:188:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/tests/check_plaintext_password.c:198:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/yazc/yazc-bruteforce.c:138:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[ZC_PW_MAXLEN + 1]; data/libzc-0.4.1/yazc/yazc-bruteforce.c:252:18: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). pwcfg.maxlen = atoi(arg_maxlen); data/libzc-0.4.1/yazc/yazc-bruteforce.c:263:18: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). thread_count = atol(arg_threads); data/libzc-0.4.1/yazc/yazc-dictionary.c:48:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[ZC_PW_MAXLEN + 1]; data/libzc-0.4.1/yazc/yazc-info.c:97:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/libzc-0.4.1/yazc/yazc-plaintext.c:168:7: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = open(file->name, O_RDONLY); data/libzc-0.4.1/yazc/yazc-plaintext.c:242:18: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). thread_count = atol(arg_threads); data/libzc-0.4.1/yazc/yazc-plaintext.c:339:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pw[14]; data/libzc-0.4.1/lib/zc_crk_bforce.c:590:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(pw, w->pw, len); data/libzc-0.4.1/lib/zc_crk_dict.c:215:4: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(pw, s, len); data/libzc-0.4.1/tests/check_bruteforce.c:62:2: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(cfg.initial, "a"); data/libzc-0.4.1/tests/check_bruteforce.c:88:2: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(cfg.initial, "a"); data/libzc-0.4.1/tests/check_pwstream.c:300:27: [1] (buffer) equal: Function does not check the second iterator for over-read conditions (CWE-126). This function is often discouraged by most C++ coding standards in favor of its safer alternatives provided since C++14. Consider using a form of this function that checks the second iterator before potentially overflowing it. static const struct entry equal[] = { data/libzc-0.4.1/tests/check_pwstream.c:310:24: [1] (buffer) equal: Function does not check the second iterator for over-read conditions (CWE-126). This function is often discouraged by most C++ coding standards in favor of its safer alternatives provided since C++14. Consider using a form of this function that checks the second iterator before potentially overflowing it. test_generated_stream(equal); data/libzc-0.4.1/yazc/yazc-bruteforce.c:124:3: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. strncat(buf, lowercase_set.set, buflen - strlen(buf) - 1); data/libzc-0.4.1/yazc/yazc-bruteforce.c:124:44: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strncat(buf, lowercase_set.set, buflen - strlen(buf) - 1); data/libzc-0.4.1/yazc/yazc-bruteforce.c:126:3: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. strncat(buf, uppercase_set.set, buflen - strlen(buf) - 1); data/libzc-0.4.1/yazc/yazc-bruteforce.c:126:44: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strncat(buf, uppercase_set.set, buflen - strlen(buf) - 1); data/libzc-0.4.1/yazc/yazc-bruteforce.c:128:3: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. strncat(buf, number_set.set, buflen - strlen(buf) - 1); data/libzc-0.4.1/yazc/yazc-bruteforce.c:128:41: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strncat(buf, number_set.set, buflen - strlen(buf) - 1); data/libzc-0.4.1/yazc/yazc-bruteforce.c:130:3: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. strncat(buf, special_set.set, buflen - strlen(buf) - 1); data/libzc-0.4.1/yazc/yazc-bruteforce.c:130:42: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strncat(buf, special_set.set, buflen - strlen(buf) - 1); data/libzc-0.4.1/yazc/yazc-bruteforce.c:283:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(pwcfg.set, arg_set, ZC_CHARSET_MAXLEN); data/libzc-0.4.1/yazc/yazc-bruteforce.c:290:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(pwcfg.initial, arg_initial, ZC_PW_MAXLEN); data/libzc-0.4.1/yazc/yazc-info.c:99:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). size_t tmp1 = strlen(zc_file_info_name(info)); data/libzc-0.4.1/yazc/yazc-info.c:105:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp1 = strlen(buf); data/libzc-0.4.1/yazc/yazc-info.c:111:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp1 = strlen(buf); data/libzc-0.4.1/yazc/yazc-info.c:117:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp1 = strlen(buf); data/libzc-0.4.1/yazc/yazc-info.c:123:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp1 = strlen(buf); ANALYSIS SUMMARY: Hits = 95 Lines analyzed = 9825 in approximately 0.37 seconds (26310 lines/second) Physical Source Lines of Code (SLOC) = 7441 Hits@level = [0] 47 [1] 21 [2] 61 [3] 6 [4] 7 [5] 0 Hits@level+ = [0+] 142 [1+] 95 [2+] 74 [3+] 13 [4+] 7 [5+] 0 Hits/KSLOC@level+ = [0+] 19.0835 [1+] 12.7671 [2+] 9.9449 [3+] 1.74708 [4+] 0.940734 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.