Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/console.c
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/console.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/data.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/dialog.c
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/dialog.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/font.c
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/font.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/lilyterm.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/main.c
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/main.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/menu.c
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/menu.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/misc.c
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/misc.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/notebook.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/pagename.c
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/pagename.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/profile.c
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/profile.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/property.c
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/property.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/window.c
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/window.h
Examining data/lilyterm-0.9.9.4+git20150208.f600c0/src/notebook.c
FINAL RESULTS:
data/lilyterm-0.9.9.4+git20150208.f600c0/src/data.h:46:10: [3] (buffer) g_get_tmp_dir:
This function is synonymous with 'getenv("TMP")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
#define g_get_tmp_dir() NULL
data/lilyterm-0.9.9.4+git20150208.f600c0/src/main.c:331:25: [3] (buffer) g_get_tmp_dir:
This function is synonymous with 'getenv("TMP")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
const gchar *tmp_dir = g_get_tmp_dir();
data/lilyterm-0.9.9.4+git20150208.f600c0/src/profile.c:2976:35: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
gchar *real_file_name = g_strdup(realpath((const gchar *)profile, resolved_patch));
data/lilyterm-0.9.9.4+git20150208.f600c0/src/dialog.c:3493:58: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dialog_data->current_key_index = dialog_data->KeyTree[atoi(indices[0])][atoi(indices[1])];
data/lilyterm-0.9.9.4+git20150208.f600c0/src/dialog.c:3493:76: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dialog_data->current_key_index = dialog_data->KeyTree[atoi(indices[0])][atoi(indices[1])];
data/lilyterm-0.9.9.4+git20150208.f600c0/src/dialog.c:3509:34: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gchar *group_name = key_groups[atoi(indices[0])];
data/lilyterm-0.9.9.4+git20150208.f600c0/src/dialog.c:3575:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
current_key_group = atoi(string);
data/lilyterm-0.9.9.4+git20150208.f600c0/src/menu.c:2205:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(win_data_backup, win_data, sizeof(* win_data));
data/lilyterm-0.9.9.4+git20150208.f600c0/src/notebook.c:1879:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy( page_data, page_data_prev, sizeof(* page_data_prev));
data/lilyterm-0.9.9.4+git20150208.f600c0/src/pagename.c:940:30: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (stats) current_tpgid = atoi(stats[9]);
data/lilyterm-0.9.9.4+git20150208.f600c0/src/window.c:712:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pid_t entry_pid = atoi(entry);
data/lilyterm-0.9.9.4+git20150208.f600c0/src/window.c:813:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*ppid = atoi(stats[5]);
data/lilyterm-0.9.9.4+git20150208.f600c0/src/window.c:887:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
win_data->init_tab_number = atoi(argv[i]);
data/lilyterm-0.9.9.4+git20150208.f600c0/src/window.c:3173:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy( win_data, win_data_orig, sizeof(* win_data_orig));
data/lilyterm-0.9.9.4+git20150208.f600c0/src/misc.c:527:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(100000);
data/lilyterm-0.9.9.4+git20150208.f600c0/src/pagename.c:886:4: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(150000);
ANALYSIS SUMMARY:
Hits = 16
Lines analyzed = 23643 in approximately 0.54 seconds (43972 lines/second)
Physical Source Lines of Code (SLOC) = 17821
Hits@level = [0] 33 [1] 2 [2] 11 [3] 3 [4] 0 [5] 0
Hits@level+ = [0+] 49 [1+] 16 [2+] 14 [3+] 3 [4+] 0 [5+] 0
Hits/KSLOC@level+ = [0+] 2.74957 [1+] 0.897817 [2+] 0.78559 [3+] 0.168341 [4+] 0 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.