Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/log4cpp-1.1.3/src/RollingFileAppender.cpp
Examining data/log4cpp-1.1.3/src/SyslogAppender.cpp
Examining data/log4cpp-1.1.3/src/OmniThreads.cpp
Examining data/log4cpp-1.1.3/src/PThreads.cpp
Examining data/log4cpp-1.1.3/src/FixedContextCategory.cpp
Examining data/log4cpp-1.1.3/src/LevelEvaluator.cpp
Examining data/log4cpp-1.1.3/src/AppendersFactory.cpp
Examining data/log4cpp-1.1.3/src/LoggingEvent.cpp
Examining data/log4cpp-1.1.3/src/HierarchyMaintainer.cpp
Examining data/log4cpp-1.1.3/src/NTEventLogAppender.cpp
Examining data/log4cpp-1.1.3/src/IdsaAppender.cpp
Examining data/log4cpp-1.1.3/src/SimpleLayout.cpp
Examining data/log4cpp-1.1.3/src/RemoteSyslogAppender.cpp
Examining data/log4cpp-1.1.3/src/StringQueueAppender.cpp
Examining data/log4cpp-1.1.3/src/BasicConfigurator.cpp
Examining data/log4cpp-1.1.3/src/PropertyConfiguratorImpl.cpp
Examining data/log4cpp-1.1.3/src/FileAppender.cpp
Examining data/log4cpp-1.1.3/src/CategoryStream.cpp
Examining data/log4cpp-1.1.3/src/Localtime.cpp
Examining data/log4cpp-1.1.3/src/MSThreads.cpp
Examining data/log4cpp-1.1.3/src/Manipulator.cpp
Examining data/log4cpp-1.1.3/src/PassThroughLayout.cpp
Examining data/log4cpp-1.1.3/src/DllMain.cpp
Examining data/log4cpp-1.1.3/src/SmtpAppender.cpp
Examining data/log4cpp-1.1.3/src/TimeStamp.cpp
Examining data/log4cpp-1.1.3/src/Priority.cpp
Examining data/log4cpp-1.1.3/src/LayoutAppender.cpp
Examining data/log4cpp-1.1.3/src/BufferingAppender.cpp
Examining data/log4cpp-1.1.3/src/Appender.cpp
Examining data/log4cpp-1.1.3/src/AbortAppender.cpp
Examining data/log4cpp-1.1.3/src/Configurator.cpp
Examining data/log4cpp-1.1.3/src/AppenderSkeleton.cpp
Examining data/log4cpp-1.1.3/src/SimpleConfigurator.cpp
Examining data/log4cpp-1.1.3/src/DailyRollingFileAppender.cpp
Examining data/log4cpp-1.1.3/src/Win32DebugAppender.cpp
Examining data/log4cpp-1.1.3/src/LayoutsFactory.cpp
Examining data/log4cpp-1.1.3/src/snprintf.c
Examining data/log4cpp-1.1.3/src/PropertyConfigurator.cpp
Examining data/log4cpp-1.1.3/src/PortabilityImpl.cpp
Examining data/log4cpp-1.1.3/src/OstreamAppender.cpp
Examining data/log4cpp-1.1.3/src/Properties.cpp
Examining data/log4cpp-1.1.3/src/DummyThreads.cpp
Examining data/log4cpp-1.1.3/src/FactoryParams.cpp
Examining data/log4cpp-1.1.3/src/NDC.cpp
Examining data/log4cpp-1.1.3/src/Filter.cpp
Examining data/log4cpp-1.1.3/src/StringUtil.cpp
Examining data/log4cpp-1.1.3/src/Category.cpp
Examining data/log4cpp-1.1.3/src/TriggeringEventEvaluatorFactory.cpp
Examining data/log4cpp-1.1.3/src/BasicLayout.cpp
Examining data/log4cpp-1.1.3/src/PatternLayout.cpp
Examining data/log4cpp-1.1.3/include/log4cpp/config-win32-stlport-boost.h
Examining data/log4cpp-1.1.3/include/log4cpp/config-openvms.h
Examining data/log4cpp-1.1.3/include/log4cpp/convenience.h
Examining data/log4cpp-1.1.3/include/log4cpp/config-MinGW32.h
Examining data/log4cpp-1.1.3/include/log4cpp/config-win32.h
Examining data/log4cpp-1.1.3/tests/testmain.cpp
Examining data/log4cpp-1.1.3/tests/testPropertyConfig.cpp
Examining data/log4cpp-1.1.3/tests/testPattern.cpp
Examining data/log4cpp-1.1.3/tests/testErrorCollision.cpp
Examining data/log4cpp-1.1.3/tests/test_convenience.cpp
Examining data/log4cpp-1.1.3/tests/testNTEventLog.cpp
Examining data/log4cpp-1.1.3/tests/testCategory.cpp
Examining data/log4cpp-1.1.3/tests/testRollingFileAppender.cpp
Examining data/log4cpp-1.1.3/tests/testConfig.cpp
Examining data/log4cpp-1.1.3/tests/testNDC.cpp
Examining data/log4cpp-1.1.3/tests/testFilter.cpp
Examining data/log4cpp-1.1.3/tests/testDLL.cpp
Examining data/log4cpp-1.1.3/tests/Clock.cpp
Examining data/log4cpp-1.1.3/tests/testPriority.cpp
Examining data/log4cpp-1.1.3/tests/testNDCMain.cpp
Examining data/log4cpp-1.1.3/tests/testPropConfig.cpp
Examining data/log4cpp-1.1.3/tests/testProperties.cpp
Examining data/log4cpp-1.1.3/tests/testbench.cpp
Examining data/log4cpp-1.1.3/tests/testFixedContextCategory.cpp
Examining data/log4cpp-1.1.3/tests/testDailyRollingFileAppender.cpp
FINAL RESULTS:
data/log4cpp-1.1.3/src/NTEventLogAppender.cpp:133:9: [4] (buffer) lstrcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using a function version that stops copying at the end
of the buffer.
lstrcpy(subkey, prefix);
data/log4cpp-1.1.3/src/NTEventLogAppender.cpp:134:9: [4] (buffer) lstrcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120).
lstrcat(subkey, source);
data/log4cpp-1.1.3/src/StringUtil.cpp:16:23: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define VSNPRINTF vsnprintf
data/log4cpp-1.1.3/src/snprintf.c:397:27: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define portable_snprintf snprintf
data/log4cpp-1.1.3/src/snprintf.c:399:28: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define portable_vsnprintf vsnprintf
data/log4cpp-1.1.3/src/snprintf.c:859:45: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
if (fmt_spec == 'p') str_arg_l += sprintf(tmp+str_arg_l, f, ptr_arg);
data/log4cpp-1.1.3/src/snprintf.c:863:34: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
case 'h': str_arg_l+=sprintf(tmp+str_arg_l, f, int_arg); break;
data/log4cpp-1.1.3/src/snprintf.c:864:34: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
case 'l': str_arg_l+=sprintf(tmp+str_arg_l, f, long_arg); break;
data/log4cpp-1.1.3/src/snprintf.c:866:34: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
case '2': str_arg_l+=sprintf(tmp+str_arg_l,f,long_long_arg); break;
data/log4cpp-1.1.3/src/snprintf.c:872:34: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
case 'h': str_arg_l+=sprintf(tmp+str_arg_l, f, uint_arg); break;
data/log4cpp-1.1.3/src/snprintf.c:873:34: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
case 'l': str_arg_l+=sprintf(tmp+str_arg_l, f, ulong_arg); break;
data/log4cpp-1.1.3/src/snprintf.c:875:34: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
case '2': str_arg_l+=sprintf(tmp+str_arg_l,f,ulong_long_arg);break;
data/log4cpp-1.1.3/tests/testDailyRollingFileAppender.cpp:187:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(logPathname, 0) != 0) {
data/log4cpp-1.1.3/tests/testDailyRollingFileAppender.cpp:191:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(logPathname, F_OK) != 0) {
data/log4cpp-1.1.3/src/Properties.cpp:138:44: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char* env_value = std::getenv(key.c_str());
data/log4cpp-1.1.3/tests/Clock.cpp:24:30: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
bool Clock::UsingCPU = std::getenv("CLOCK_USE_CPU") ? true : false;
data/log4cpp-1.1.3/tests/testConfig.cpp:48:24: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char* srcdir = getenv("srcdir");
data/log4cpp-1.1.3/tests/testDailyRollingFileAppender.cpp:139:24: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char* srcdir = getenv("srcdir");
data/log4cpp-1.1.3/tests/testPropertyConfig.cpp:48:24: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char* srcdir = getenv("srcdir");
data/log4cpp-1.1.3/src/Appender.cpp:16:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char appenderMapStorage_buf[sizeof(Appender::AppenderMapStorage)]; // memory for the nifty-counter singleton object
data/log4cpp-1.1.3/src/DailyRollingFileAppender.cpp:89:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
_fd = ::open(_fileName.c_str(), _flags, _mode);
data/log4cpp-1.1.3/src/FileAppender.cpp:37:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
_fd = ::open(_fileName.c_str(), _flags, _mode);
data/log4cpp-1.1.3/src/FileAppender.cpp:88:24: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int fd = ::open(_fileName.c_str(), _flags, _mode);
data/log4cpp-1.1.3/src/IdsaAppender.cpp:29:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open();
data/log4cpp-1.1.3/src/IdsaAppender.cpp:36:24: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void IdsaAppender::open() {
data/log4cpp-1.1.3/src/IdsaAppender.cpp:68:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open();
data/log4cpp-1.1.3/src/Localtime.cpp:33:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(t, tmp, sizeof(::tm));
data/log4cpp-1.1.3/src/MSThreads.cpp:16:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[16];
data/log4cpp-1.1.3/src/MSThreads.cpp:17:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%lu", GetCurrentThreadId());
data/log4cpp-1.1.3/src/NTEventLogAppender.cpp:22:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open();
data/log4cpp-1.1.3/src/NTEventLogAppender.cpp:30:30: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void NTEventLogAppender::open()
data/log4cpp-1.1.3/src/NTEventLogAppender.cpp:45:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open();
data/log4cpp-1.1.3/src/NTEventLogAppender.cpp:131:9: [2] (buffer) TCHAR:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
TCHAR subkey[256];
data/log4cpp-1.1.3/src/OmniThreads.cpp:15:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[16];
data/log4cpp-1.1.3/src/OmniThreads.cpp:16:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%d", ::omni_thread::self()->id());
data/log4cpp-1.1.3/src/PThreads.cpp:16:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[4*sizeof(long)];
data/log4cpp-1.1.3/src/PatternLayout.cpp:42:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[20];
data/log4cpp-1.1.3/src/PatternLayout.cpp:43:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
::sprintf(buf,"%I64d", i);
data/log4cpp-1.1.3/src/PatternLayout.cpp:160:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char formatted[100];
data/log4cpp-1.1.3/src/Properties.cpp:26:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[256];
data/log4cpp-1.1.3/src/Properties.cpp:97:53: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
return (key == end()) ? defaultValue : std::atoi((*key).second.c_str());
data/log4cpp-1.1.3/src/RemoteSyslogAppender.cpp:71:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open();
data/log4cpp-1.1.3/src/RemoteSyslogAppender.cpp:84:32: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void RemoteSyslogAppender::open() {
data/log4cpp-1.1.3/src/RemoteSyslogAppender.cpp:146:30: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
int preambleLength = sprintf (buf, "<%d>", priority);
data/log4cpp-1.1.3/src/RemoteSyslogAppender.cpp:147:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (buf + preambleLength, message.data(), messageLength);
data/log4cpp-1.1.3/src/RemoteSyslogAppender.cpp:174:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open();
data/log4cpp-1.1.3/src/RollingFileAppender.cpp:81:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
_fd = ::open(_fileName.c_str(), _flags, _mode);
data/log4cpp-1.1.3/src/SimpleConfigurator.cpp:192:25: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pattern[1000];
data/log4cpp-1.1.3/src/SyslogAppender.cpp:51:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open();
data/log4cpp-1.1.3/src/SyslogAppender.cpp:58:26: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void SyslogAppender::open() {
data/log4cpp-1.1.3/src/SyslogAppender.cpp:74:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open();
data/log4cpp-1.1.3/src/snprintf.c:365:32: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
if (nn >= breakeven_point) memcpy((d), (s), nn); \
data/log4cpp-1.1.3/src/snprintf.c:575:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[32];/* temporary buffer for simple numeric->string conversion */
data/log4cpp-1.1.3/src/snprintf.c:853:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char f[5]; int f_l = 0;
data/log4cpp-1.1.3/tests/testDLL.cpp:207:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char nm[10];
data/log4cpp-1.1.3/tests/testDLL.cpp:208:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(nm, "subs%d", i);
data/log4cpp-1.1.3/tests/testDailyRollingFileAppender.cpp:97:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* f = fopen(filename, "r");
data/log4cpp-1.1.3/tests/testRollingFileAppender.cpp:57:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* f = fopen(filename, "r");
data/log4cpp-1.1.3/tests/testbench.cpp:19:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int count = argc > 1 ? std::atoi(argv[1]) : 100;
data/log4cpp-1.1.3/tests/testbench.cpp:20:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
size_t size = argc > 2 ? std::atoi(argv[2]) : 128;
data/log4cpp-1.1.3/tests/testmain.cpp:82:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ndc2[20];
data/log4cpp-1.1.3/tests/testmain.cpp:83:4: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ndc2, "i=%d", i);
data/log4cpp-1.1.3/src/snprintf.c:561:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t n = !q ? strlen(p) : (q-p);
data/log4cpp-1.1.3/src/snprintf.c:703:54: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
else if (!precision_specified) str_arg_l = strlen(str_arg);
ANALYSIS SUMMARY:
Hits = 64
Lines analyzed = 8177 in approximately 0.26 seconds (31718 lines/second)
Physical Source Lines of Code (SLOC) = 5753
Hits@level = [0] 3 [1] 2 [2] 43 [3] 5 [4] 14 [5] 0
Hits@level+ = [0+] 67 [1+] 64 [2+] 62 [3+] 19 [4+] 14 [5+] 0
Hits/KSLOC@level+ = [0+] 11.6461 [1+] 11.1246 [2+] 10.777 [3+] 3.30262 [4+] 2.43351 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.