Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/lomiri-api-0.1.1/include/lomiri/Exception.h
Examining data/lomiri-api-0.1.1/include/lomiri/LomiriExceptions.h
Examining data/lomiri-api-0.1.1/include/lomiri/SymbolExport.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/application/ApplicationInfoInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/application/ApplicationManagerInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/application/Mir.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/application/MirMousePointerInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/application/MirPlatformCursor.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/application/MirSurfaceInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/application/MirSurfaceItemInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/application/MirSurfaceListInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/application/SurfaceManagerInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/launcher/AppDrawerModelInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/launcher/LauncherItemInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/launcher/LauncherModelInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/launcher/QuickListModelInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/notifications/Enums.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/notifications/ModelInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/notifications/NotificationInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/shell/notifications/SourceInterface.h
Examining data/lomiri-api-0.1.1/include/lomiri/util/Daemon.h
Examining data/lomiri-api-0.1.1/include/lomiri/util/Dbus.h
Examining data/lomiri-api-0.1.1/include/lomiri/util/DefinesPtrs.h
Examining data/lomiri-api-0.1.1/include/lomiri/util/FileIO.h
Examining data/lomiri-api-0.1.1/include/lomiri/util/GObjectMemory.h
Examining data/lomiri-api-0.1.1/include/lomiri/util/GioMemory.h
Examining data/lomiri-api-0.1.1/include/lomiri/util/GlibMemory.h
Examining data/lomiri-api-0.1.1/include/lomiri/util/IniParser.h
Examining data/lomiri-api-0.1.1/include/lomiri/util/NonCopyable.h
Examining data/lomiri-api-0.1.1/include/lomiri/util/ResourcePtr.h
Examining data/lomiri-api-0.1.1/include/lomiri/util/SnapPath.h
Examining data/lomiri-api-0.1.1/include/lomiri/util/internal/DaemonImpl.h
Examining data/lomiri-api-0.1.1/src/lomiri/Exception.cpp
Examining data/lomiri-api-0.1.1/src/lomiri/LomiriExceptions.cpp
Examining data/lomiri-api-0.1.1/src/lomiri/api/Version.cpp
Examining data/lomiri-api-0.1.1/src/lomiri/util/Daemon.cpp
Examining data/lomiri-api-0.1.1/src/lomiri/util/Dbus.cpp
Examining data/lomiri-api-0.1.1/src/lomiri/util/FileIO.cpp
Examining data/lomiri-api-0.1.1/src/lomiri/util/IniParser.cpp
Examining data/lomiri-api-0.1.1/src/lomiri/util/SnapPath.cpp
Examining data/lomiri-api-0.1.1/src/lomiri/util/internal/DaemonImpl.cpp
Examining data/lomiri-api-0.1.1/test/gtest/lomiri/Exceptions_test.cpp
Examining data/lomiri-api-0.1.1/test/gtest/lomiri/api/Version/Version_test.cpp
Examining data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp
Examining data/lomiri-api-0.1.1/test/gtest/lomiri/util/Dbus/Dbus_test.cpp
Examining data/lomiri-api-0.1.1/test/gtest/lomiri/util/DefinesPtrs/DefinesPtrs_test.cpp
Examining data/lomiri-api-0.1.1/test/gtest/lomiri/util/FileIO/FileIO_test.cpp
Examining data/lomiri-api-0.1.1/test/gtest/lomiri/util/GObjectMemory/GObjectMemory_test.cpp
Examining data/lomiri-api-0.1.1/test/gtest/lomiri/util/GioMemory/GioMemory_test.cpp
Examining data/lomiri-api-0.1.1/test/gtest/lomiri/util/GlibMemory/GlibMemory_test.cpp
Examining data/lomiri-api-0.1.1/test/gtest/lomiri/util/IniParser/IniParser_test.cpp
Examining data/lomiri-api-0.1.1/test/gtest/lomiri/util/ResourcePtr/ResourcePtr_test.cpp
Examining data/lomiri-api-0.1.1/test/gtest/lomiri/util/SnapPath/SnapPath_test.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Application/Mocks/MockApplicationInfo.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Application/Mocks/MockApplicationInfo.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Application/Mocks/MockApplicationManager.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Application/Mocks/MockApplicationManager.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Application/TestApplicationPlugin.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Application/TestApplicationPlugin.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Launcher/Mocks/MockAppDrawerModel.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Launcher/Mocks/MockAppDrawerModel.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Launcher/Mocks/MockLauncherItem.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Launcher/Mocks/MockLauncherItem.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Launcher/Mocks/MockLauncherModel.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Launcher/Mocks/MockLauncherModel.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Launcher/Mocks/MockQuickListModel.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Launcher/Mocks/MockQuickListModel.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Launcher/TestLauncherPlugin.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Launcher/TestLauncherPlugin.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Notifications/Mocks/MockActionModel.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Notifications/Mocks/MockActionModel.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Notifications/Mocks/MockModel.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Notifications/Mocks/MockModel.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Notifications/Mocks/MockNotification.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Notifications/Mocks/MockNotification.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Notifications/Mocks/MockNotificationsPlugin.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Notifications/Mocks/MockNotificationsPlugin.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Notifications/Mocks/MockSource.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Notifications/Mocks/MockSource.h
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Notifications/TestNotificationsPlugin.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/mocks/plugins/Lomiri/Notifications/TestNotificationsPlugin.h
Examining data/lomiri-api-0.1.1/test/qmltest/modules/TestUtil/TestUtil.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/modules/TestUtil/TestUtil.h
Examining data/lomiri-api-0.1.1/test/qmltest/modules/TestUtil/TestUtilPlugin.cpp
Examining data/lomiri-api-0.1.1/test/qmltest/modules/TestUtil/TestUtilPlugin.h
FINAL RESULTS:
data/lomiri-api-0.1.1/src/lomiri/util/SnapPath.cpp:28:28: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char* env_snap = getenv("SNAP");
data/lomiri-api-0.1.1/src/lomiri/util/Dbus.cpp:34:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[100];
data/lomiri-api-0.1.1/src/lomiri/util/FileIO.cpp:50:59: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
util::ResourcePtr<int, std::function<void(int)>> fd(::open(filename.c_str(), O_RDONLY),
data/lomiri-api-0.1.1/src/lomiri/util/internal/DaemonImpl.cpp:103:31: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
old_working_dir.reset(open(".", 0)); // Doesn't matter if this fails
data/lomiri-api-0.1.1/src/lomiri/util/internal/DaemonImpl.cpp:220:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int fd = open("/dev/null", O_RDWR);
data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp:46:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int fd = open(error_file, O_CREAT | O_TRUNC | O_WRONLY, 0666);
data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp:59:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int fd = open(error_file, O_APPEND | O_WRONLY);
data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp:155:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int fd = open(".", O_RDONLY);
data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp:334:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int fd = open("/dev/tty", O_RDWR);
data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp:353:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int fd = open(".", O_RDONLY);
data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp:359:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int fd2 = open(".", O_RDONLY);
data/lomiri-api-0.1.1/test/gtest/lomiri/util/FileIO/FileIO_test.cpp:38:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen("testfile", "w");
data/lomiri-api-0.1.1/test/gtest/lomiri/util/FileIO/FileIO_test.cpp:51:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen("empty", "w");
data/lomiri-api-0.1.1/test/gtest/lomiri/util/IniParser/IniParser_test.cpp:222:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
auto f = fopen(INI_TEMP_FILE, "w");
data/lomiri-api-0.1.1/test/gtest/lomiri/util/IniParser/IniParser_test.cpp:309:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
auto f = fopen(INI_TEMP_FILE, "w");
data/lomiri-api-0.1.1/test/gtest/lomiri/util/IniParser/IniParser_test.cpp:390:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
auto f = fopen(INI_TEMP_FILE, "w");
data/lomiri-api-0.1.1/src/lomiri/util/FileIO.cpp:75:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read(fd.get(), &buf[0], st.st_size) != st.st_size)
data/lomiri-api-0.1.1/src/lomiri/util/internal/DaemonImpl.cpp:145:21: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
old_umask = umask(umask_);
data/lomiri-api-0.1.1/src/lomiri/util/internal/DaemonImpl.cpp:168:17: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(old_umask); // Strong exception guarantee
data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp:44:24: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
mode_t old_umask = umask(0); // Make sure we have mode rw-rw-rw for the file, otherwise different
data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp:47:5: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(old_umask);
data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp:257:14: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
TEST(Daemon, umask)
data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp:263:5: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(027);
data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp:265:24: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
mode_t new_umask = umask(022);
data/lomiri-api-0.1.1/test/gtest/lomiri/util/Daemon/Daemon_test.cpp:275:17: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
new_umask = umask(027);
data/lomiri-api-0.1.1/test/gtest/lomiri/util/ResourcePtr/ResourcePtr_test.cpp:484:62: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
std::equal_to<ResourcePtr<Comparable, decltype(&no_op)>> equal;
data/lomiri-api-0.1.1/test/gtest/lomiri/util/ResourcePtr/ResourcePtr_test.cpp:491:17: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
EXPECT_TRUE(equal.operator()(nr1, nr2));
data/lomiri-api-0.1.1/test/gtest/lomiri/util/ResourcePtr/ResourcePtr_test.cpp:492:18: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
EXPECT_FALSE(equal.operator()(nr1, one));
data/lomiri-api-0.1.1/test/gtest/lomiri/util/ResourcePtr/ResourcePtr_test.cpp:493:18: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
EXPECT_FALSE(equal.operator()(one, nr1));
data/lomiri-api-0.1.1/test/gtest/lomiri/util/ResourcePtr/ResourcePtr_test.cpp:494:17: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
EXPECT_TRUE(equal.operator()(one, one));
data/lomiri-api-0.1.1/test/gtest/lomiri/util/ResourcePtr/ResourcePtr_test.cpp:495:18: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
EXPECT_FALSE(equal.operator()(zero, one));
ANALYSIS SUMMARY:
Hits = 31
Lines analyzed = 11751 in approximately 0.36 seconds (32921 lines/second)
Physical Source Lines of Code (SLOC) = 6483
Hits@level = [0] 1 [1] 15 [2] 15 [3] 1 [4] 0 [5] 0
Hits@level+ = [0+] 32 [1+] 31 [2+] 16 [3+] 1 [4+] 0 [5+] 0
Hits/KSLOC@level+ = [0+] 4.93599 [1+] 4.78174 [2+] 2.46799 [3+] 0.15425 [4+] 0 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.