Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/luckybackup-0.5.0/src/qdirdialog.h Examining data/luckybackup-0.5.0/src/emailDialog.h Examining data/luckybackup-0.5.0/src/global.h Examining data/luckybackup-0.5.0/src/manageWizard.h Examining data/luckybackup-0.5.0/src/manage.cpp Examining data/luckybackup-0.5.0/src/readLogFile.cpp Examining data/luckybackup-0.5.0/src/winDialog.cpp Examining data/luckybackup-0.5.0/src/patternEditor.cpp Examining data/luckybackup-0.5.0/src/patternEditor.h Examining data/luckybackup-0.5.0/src/logDialog.cpp Examining data/luckybackup-0.5.0/src/main.cpp Examining data/luckybackup-0.5.0/src/winDialog.h Examining data/luckybackup-0.5.0/src/modifyDialog.h Examining data/luckybackup-0.5.0/src/emailDialog.cpp Examining data/luckybackup-0.5.0/src/readLogFile.h Examining data/luckybackup-0.5.0/src/manage.h Examining data/luckybackup-0.5.0/src/textDialog.cpp Examining data/luckybackup-0.5.0/src/RsyncDirModel.cpp Examining data/luckybackup-0.5.0/src/executenow.cpp Examining data/luckybackup-0.5.0/src/logDialog.h Examining data/luckybackup-0.5.0/src/qurlinfo.h Examining data/luckybackup-0.5.0/src/scheduleDialog.h Examining data/luckybackup-0.5.0/src/commandline.cpp Examining data/luckybackup-0.5.0/src/about.h Examining data/luckybackup-0.5.0/src/about.cpp Examining data/luckybackup-0.5.0/src/luckybackupwindow.cpp Examining data/luckybackup-0.5.0/src/functions.cpp Examining data/luckybackup-0.5.0/src/calcDiffThread.cpp Examining data/luckybackup-0.5.0/src/RsyncDirModel.h Examining data/luckybackup-0.5.0/src/luckybackupwindow.h Examining data/luckybackup-0.5.0/src/helpBrowser.h Examining data/luckybackup-0.5.0/src/operationClass.h Examining data/luckybackup-0.5.0/src/qurlinfo.cpp Examining data/luckybackup-0.5.0/src/scheduleDialog.cpp Examining data/luckybackup-0.5.0/src/helpBrowser.cpp Examining data/luckybackup-0.5.0/src/calcDiffThread.h Examining data/luckybackup-0.5.0/src/manageWizard.cpp Examining data/luckybackup-0.5.0/src/qdirdialog.cpp Examining data/luckybackup-0.5.0/src/textDialog.h Examining data/luckybackup-0.5.0/src/RsyncDirModel_p.h Examining data/luckybackup-0.5.0/src/RsyncDirModel_p.cpp Examining data/luckybackup-0.5.0/src/scheduleClass.h Examining data/luckybackup-0.5.0/src/modifyDialog.cpp Examining data/luckybackup-0.5.0/src/commandline.h Examining data/luckybackup-0.5.0/src/global.cpp FINAL RESULTS: data/luckybackup-0.5.0/src/global.cpp:79:27: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. QString locale = QLocale::system().name(); data/luckybackup-0.5.0/src/main.cpp:80:35: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. QString locale = QLocale::system().name(); data/luckybackup-0.5.0/src/functions.cpp:70:19: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char *isKDE = getenv("KDE_FULL_SESSION"); data/luckybackup-0.5.0/src/functions.cpp:89:21: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char *isGnome = getenv("DESKTOP_SESSION"); data/luckybackup-0.5.0/src/RsyncDirModel_p.cpp:636:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!file.open(QFile::WriteOnly)) data/luckybackup-0.5.0/src/calcDiffThread.cpp:96:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). snapfile.open(QIODevice::ReadOnly | QIODevice::Text); data/luckybackup-0.5.0/src/commandline.cpp:451:29: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (logfile.open(QIODevice::WriteOnly | QIODevice::Text | QIODevice::Append)) //create a new log file data/luckybackup-0.5.0/src/commandline.cpp:663:42: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (snapfile.open(QIODevice::ReadOnly | QIODevice::Text)) data/luckybackup-0.5.0/src/commandline.cpp:677:42: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (snapfile.open(QIODevice::WriteOnly)) data/luckybackup-0.5.0/src/executenow.cpp:690:21: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (logfile.open(QIODevice::WriteOnly | QIODevice::Text)) //create a new log file data/luckybackup-0.5.0/src/executenow.cpp:967:26: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (snapfile.open(QIODevice::ReadOnly | QIODevice::Text)) data/luckybackup-0.5.0/src/executenow.cpp:983:26: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (snapfile.open(QIODevice::WriteOnly)) data/luckybackup-0.5.0/src/executenow.cpp:1494:26: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (snapfile.open(QIODevice::ReadOnly | QIODevice::Text)) data/luckybackup-0.5.0/src/executenow.cpp:1509:26: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (snapfile.open(QIODevice::WriteOnly)) data/luckybackup-0.5.0/src/functions.cpp:590:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (cronFile.open(QIODevice::ReadOnly | QIODevice::Text)) //open the cronFile data/luckybackup-0.5.0/src/functions.cpp:649:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (cronFile.open(QIODevice::ReadOnly | QIODevice::Text)) //open the cronFile data/luckybackup-0.5.0/src/functions.cpp:766:23: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!settingsfile.open(QIODevice::WriteOnly)) // if the settings file cannot be saved (or fails to create) data/luckybackup-0.5.0/src/functions.cpp:818:23: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!settingsfile.open(QIODevice::ReadOnly)) //if the settings file cannot be opened data/luckybackup-0.5.0/src/functions.cpp:894:23: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!settingsfile.open(QIODevice::ReadOnly)) //if the settings file cannot be opened data/luckybackup-0.5.0/src/global.cpp:528:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!profile.open(QIODevice::ReadOnly)) //if the profile cannot be opened data/luckybackup-0.5.0/src/global.cpp:776:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!profile.open(QIODevice::ReadOnly)) //if the profile cannot be opened data/luckybackup-0.5.0/src/global.cpp:985:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!profile.open(QIODevice::WriteOnly)) // if the profile cannot be saved (or fails to create) data/luckybackup-0.5.0/src/global.cpp:2285:26: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!sendlogfile.open(QIODevice::WriteOnly)) // if the log file to send cannot be opened for writing data/luckybackup-0.5.0/src/global.cpp:2310:41: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (logfile.open(QIODevice::ReadOnly)) //if the profile cannot be opened data/luckybackup-0.5.0/src/global.cpp:2411:22: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (emailLog.open(QIODevice::WriteOnly)) // Create the test log file to send data/luckybackup-0.5.0/src/global.cpp:2864:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!command2.open(QIODevice::WriteOnly | QIODevice::Text)) // if the settings file cannot be saved (or fails to create) data/luckybackup-0.5.0/src/manageWizard.cpp:211:21: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (logfile.open(QIODevice::WriteOnly | QIODevice::Text)) //create a new log file data/luckybackup-0.5.0/src/readLogFile.cpp:62:16: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!logfile.open(QIODevice::ReadOnly | QIODevice::Text)) //if it exists try to open it data/luckybackup-0.5.0/src/scheduleDialog.cpp:112:23: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!scheduleFile.open(QIODevice::ReadOnly)) //if there is an error opening it, delete it to create a new one data/luckybackup-0.5.0/src/scheduleDialog.cpp:126:50: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). scheduleFile.close(); scheduleFile.open(QIODevice::ReadOnly); //close & reopen the file data/luckybackup-0.5.0/src/scheduleDialog.cpp:524:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!proFile.open(QIODevice::ReadOnly)) data/luckybackup-0.5.0/src/scheduleDialog.cpp:776:34: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!batFile.open(QIODevice::WriteOnly | QIODevice::Text)) //create a new batFile as textfile data/luckybackup-0.5.0/src/scheduleDialog.cpp:802:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!cronFile.open(QIODevice::WriteOnly | QIODevice::Text)) //create a new cronFile as textfile data/luckybackup-0.5.0/src/scheduleDialog.cpp:903:23: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!scheduleFile.open(QIODevice::WriteOnly)) //create a new schedule file data/luckybackup-0.5.0/src/qurlinfo.cpp:662:16: [1] (buffer) equal: Function does not check the second iterator for over-read conditions (CWE-126). This function is often discouraged by most C++ coding standards in favor of its safer alternatives provided since C++14. Consider using a form of this function that checks the second iterator before potentially overflowing it. bool QUrlInfo::equal(const QUrlInfo &i1, const QUrlInfo &i2, data/luckybackup-0.5.0/src/qurlinfo.h:108:17: [1] (buffer) equal: Function does not check the second iterator for over-read conditions (CWE-126). This function is often discouraged by most C++ coding standards in favor of its safer alternatives provided since C++14. Consider using a form of this function that checks the second iterator before potentially overflowing it. static bool equal(const QUrlInfo &i1, const QUrlInfo &i2, ANALYSIS SUMMARY: Hits = 36 Lines analyzed = 18524 in approximately 0.60 seconds (31029 lines/second) Physical Source Lines of Code (SLOC) = 12573 Hits@level = [0] 0 [1] 2 [2] 30 [3] 2 [4] 2 [5] 0 Hits@level+ = [0+] 36 [1+] 36 [2+] 34 [3+] 4 [4+] 2 [5+] 0 Hits/KSLOC@level+ = [0+] 2.86328 [1+] 2.86328 [2+] 2.70421 [3+] 0.318142 [4+] 0.159071 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.