Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/matchbox-desktop-2.2+git20200512/src/desktop.h Examining data/matchbox-desktop-2.2+git20200512/src/desktop.c Examining data/matchbox-desktop-2.2+git20200512/src/taku-category-bar.c Examining data/matchbox-desktop-2.2+git20200512/src/taku-category-bar.h Examining data/matchbox-desktop-2.2+git20200512/src/main.c Examining data/matchbox-desktop-2.2+git20200512/libtaku/launcher-util.h Examining data/matchbox-desktop-2.2+git20200512/libtaku/inotify/inotify-kernel.c Examining data/matchbox-desktop-2.2+git20200512/libtaku/inotify/inotify-path.c Examining data/matchbox-desktop-2.2+git20200512/libtaku/inotify/inotify-kernel.h Examining data/matchbox-desktop-2.2+git20200512/libtaku/inotify/inotify-diag.c Examining data/matchbox-desktop-2.2+git20200512/libtaku/inotify/inotify-sub.c Examining data/matchbox-desktop-2.2+git20200512/libtaku/inotify/inotify-path.h Examining data/matchbox-desktop-2.2+git20200512/libtaku/inotify/inotify-diag.h Examining data/matchbox-desktop-2.2+git20200512/libtaku/inotify/inotify-sub.h Examining data/matchbox-desktop-2.2+git20200512/libtaku/inotify/inotify-missing.h Examining data/matchbox-desktop-2.2+git20200512/libtaku/inotify/inotify-missing.c Examining data/matchbox-desktop-2.2+git20200512/libtaku/taku-menu.h Examining data/matchbox-desktop-2.2+git20200512/libtaku/taku-icon-tile.h Examining data/matchbox-desktop-2.2+git20200512/libtaku/taku-icon-tile.c Examining data/matchbox-desktop-2.2+git20200512/libtaku/taku-launcher-tile.h Examining data/matchbox-desktop-2.2+git20200512/libtaku/taku-tile.h Examining data/matchbox-desktop-2.2+git20200512/libtaku/xutil.h Examining data/matchbox-desktop-2.2+git20200512/libtaku/taku-queue-source.c Examining data/matchbox-desktop-2.2+git20200512/libtaku/taku-tile.c Examining data/matchbox-desktop-2.2+git20200512/libtaku/taku-launcher-tile.c Examining data/matchbox-desktop-2.2+git20200512/libtaku/taku-queue-source.h Examining data/matchbox-desktop-2.2+git20200512/libtaku/xutil.c Examining data/matchbox-desktop-2.2+git20200512/libtaku/launcher-util.c Examining data/matchbox-desktop-2.2+git20200512/libtaku/taku-menu-desktop.c FINAL RESULTS: data/matchbox-desktop-2.2+git20200512/libtaku/taku-menu-desktop.c:623:35: [3] (buffer) g_get_home_dir: This function is synonymous with 'getenv("HOME")';it returns untrustable input if the environment can beset by an attacker. It can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. vfolder_dir = g_build_filename (g_get_home_dir (), data/matchbox-desktop-2.2+git20200512/libtaku/taku-menu-desktop.c:166:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[NAME_MAX], *filename; data/matchbox-desktop-2.2+git20200512/libtaku/taku-menu-desktop.c:175:8: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen (filename, "r"); data/matchbox-desktop-2.2+git20200512/libtaku/taku-menu-desktop.c:191:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy (name + strlen (name) - 1, ".directory"); data/matchbox-desktop-2.2+git20200512/libtaku/xutil.c:178:19: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). win_found = atoi ((char*) value); /* XXX should check window ID data/matchbox-desktop-2.2+git20200512/libtaku/inotify/inotify-kernel.c:255:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). event->len = strlen (event->name); data/matchbox-desktop-2.2+git20200512/libtaku/inotify/inotify-sub.c:26:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). size_t len = strlen (d_dirname); data/matchbox-desktop-2.2+git20200512/libtaku/launcher-util.c:34:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buf = g_alloca (strlen (exec) + 1); data/matchbox-desktop-2.2+git20200512/libtaku/taku-menu-desktop.c:191:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strcpy (name + strlen (name) - 1, ".directory"); ANALYSIS SUMMARY: Hits = 9 Lines analyzed = 4594 in approximately 0.10 seconds (44800 lines/second) Physical Source Lines of Code (SLOC) = 3161 Hits@level = [0] 0 [1] 4 [2] 4 [3] 1 [4] 0 [5] 0 Hits@level+ = [0+] 9 [1+] 9 [2+] 5 [3+] 1 [4+] 0 [5+] 0 Hits/KSLOC@level+ = [0+] 2.8472 [1+] 2.8472 [2+] 1.58178 [3+] 0.316356 [4+] 0 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.