Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/mbrola-3.3+dfsg/Database/database.c
Examining data/mbrola-3.3+dfsg/Database/database.h
Examining data/mbrola-3.3+dfsg/Database/database_old.c
Examining data/mbrola-3.3+dfsg/Database/database_old.h
Examining data/mbrola-3.3+dfsg/Database/diphone_info.c
Examining data/mbrola-3.3+dfsg/Database/diphone_info.h
Examining data/mbrola-3.3+dfsg/Database/hash_tab.c
Examining data/mbrola-3.3+dfsg/Database/hash_tab.h
Examining data/mbrola-3.3+dfsg/Database/little_big.c
Examining data/mbrola-3.3+dfsg/Database/little_big.h
Examining data/mbrola-3.3+dfsg/Database/rom_database.c
Examining data/mbrola-3.3+dfsg/Database/rom_database.h
Examining data/mbrola-3.3+dfsg/Database/rom_handling.c
Examining data/mbrola-3.3+dfsg/Database/rom_handling.h
Examining data/mbrola-3.3+dfsg/Database/zstring_list.c
Examining data/mbrola-3.3+dfsg/Database/zstring_list.h
Examining data/mbrola-3.3+dfsg/Engine/diphone.c
Examining data/mbrola-3.3+dfsg/Engine/diphone.h
Examining data/mbrola-3.3+dfsg/Engine/mbrola.c
Examining data/mbrola-3.3+dfsg/Engine/mbrola.h
Examining data/mbrola-3.3+dfsg/LibMultiChannel/demo2.c
Examining data/mbrola-3.3+dfsg/LibMultiChannel/lib2.c
Examining data/mbrola-3.3+dfsg/LibMultiChannel/multichannel.c
Examining data/mbrola-3.3+dfsg/LibMultiChannel/multichannel.h
Examining data/mbrola-3.3+dfsg/LibOneChannel/demo1.c
Examining data/mbrola-3.3+dfsg/LibOneChannel/demo1b.c
Examining data/mbrola-3.3+dfsg/LibOneChannel/lib1.c
Examining data/mbrola-3.3+dfsg/LibOneChannel/onechannel.c
Examining data/mbrola-3.3+dfsg/LibOneChannel/onechannel.h
Examining data/mbrola-3.3+dfsg/Misc/audio.c
Examining data/mbrola-3.3+dfsg/Misc/audio.h
Examining data/mbrola-3.3+dfsg/Misc/common.c
Examining data/mbrola-3.3+dfsg/Misc/common.h
Examining data/mbrola-3.3+dfsg/Misc/g711.c
Examining data/mbrola-3.3+dfsg/Misc/g711.h
Examining data/mbrola-3.3+dfsg/Misc/incdll.h
Examining data/mbrola-3.3+dfsg/Misc/mbralloc.c
Examining data/mbrola-3.3+dfsg/Misc/mbralloc.h
Examining data/mbrola-3.3+dfsg/Misc/parser_export.h
Examining data/mbrola-3.3+dfsg/Misc/vp_error.c
Examining data/mbrola-3.3+dfsg/Misc/vp_error.h
Examining data/mbrola-3.3+dfsg/Parser/fifo.c
Examining data/mbrola-3.3+dfsg/Parser/fifo.h
Examining data/mbrola-3.3+dfsg/Parser/input.h
Examining data/mbrola-3.3+dfsg/Parser/input_fifo.c
Examining data/mbrola-3.3+dfsg/Parser/input_fifo.h
Examining data/mbrola-3.3+dfsg/Parser/input_file.h
Examining data/mbrola-3.3+dfsg/Parser/parser.h
Examining data/mbrola-3.3+dfsg/Parser/parser_input.c
Examining data/mbrola-3.3+dfsg/Parser/parser_input.h
Examining data/mbrola-3.3+dfsg/Parser/phonbuff.c
Examining data/mbrola-3.3+dfsg/Parser/phonbuff.h
Examining data/mbrola-3.3+dfsg/Parser/phone.c
Examining data/mbrola-3.3+dfsg/Parser/phone.h
Examining data/mbrola-3.3+dfsg/Parser/phone_export.h
Examining data/mbrola-3.3+dfsg/Parser/input_file.c
Examining data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c
Examining data/mbrola-3.3+dfsg/Standalone/Posix/getopt.h
Examining data/mbrola-3.3+dfsg/Standalone/synth.c
Examining data/mbrola-3.3+dfsg/Standalone/synth.h
FINAL RESULTS:
data/mbrola-3.3+dfsg/Misc/mbralloc.c:57:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(newstr,str);
data/mbrola-3.3+dfsg/Misc/vp_error.c:57:2: [4] (format) vsprintf:
Potential format string problem (CWE-134). Make format string constant.
vsprintf(errbuffer, format, ap);
data/mbrola-3.3+dfsg/Misc/vp_error.c:60:2: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, format, ap);
data/mbrola-3.3+dfsg/Misc/vp_error.c:78:2: [4] (format) vsprintf:
Potential format string problem (CWE-134). Make format string constant.
vsprintf(errbuffer, format, ap);
data/mbrola-3.3+dfsg/Misc/vp_error.c:81:2: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, format, ap);
data/mbrola-3.3+dfsg/Misc/vp_error.c:100:2: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, format, ap);
data/mbrola-3.3+dfsg/Parser/phonbuff.c:53:2: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(flush_symbol(pt),"%s%%n",flush);
data/mbrola-3.3+dfsg/Parser/phonbuff.c:69:2: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(comment_symbol(pt),"%s%%n",comment);
data/mbrola-3.3+dfsg/Parser/phonbuff.c:284:3: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function. If the scanf format is influenceable by an
attacker, it's exploitable.
sscanf(rest, comment_symbol(pt), &comment);
data/mbrola-3.3+dfsg/Parser/phonbuff.c:285:3: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function. If the scanf format is influenceable by an
attacker, it's exploitable.
sscanf(rest, flush_symbol(pt), &stream_flush);
data/mbrola-3.3+dfsg/Parser/phonbuff.c:298:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function. If the scanf format is influenceable by an
attacker, it's exploitable.
sscanf(rest,comment_symbol(pt), &command);
data/mbrola-3.3+dfsg/Parser/phonbuff.c:313:14: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
else if (sscanf(rest," FLUSH %s",new_name)==1)
data/mbrola-3.3+dfsg/Parser/phonbuff.c:395:7: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
val=sscanf(a_line,"%s %f%n",name,&length,&position);
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:511:6: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf (stderr,
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:541:4: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf (stderr,
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:553:4: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf (stderr,
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:575:7: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf (stderr,
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:610:3: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf (stderr,
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:621:3: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf (stderr,
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:652:6: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf (stderr,
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:693:7: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf (stderr,
data/mbrola-3.3+dfsg/Standalone/synth.c:199:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(pos,"RENAME %s %s",source,dest);
data/mbrola-3.3+dfsg/Standalone/synth.c:205:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(pos,"CLONE %s %s",source,dest);
data/mbrola-3.3+dfsg/Standalone/synth.c:211:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(pos,"FLUSH %s",source);
data/mbrola-3.3+dfsg/Standalone/synth.c:217:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(pos,"COMMENT %s",source);
data/mbrola-3.3+dfsg/Standalone/synth.c:223:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(pos,"TIME %s",source);
data/mbrola-3.3+dfsg/Standalone/synth.c:229:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(pos,"FREQ %s",source);
data/mbrola-3.3+dfsg/Standalone/synth.c:235:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(pos,"VOLUME %s",source);
data/mbrola-3.3+dfsg/Standalone/synth.c:241:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(pos,"VOICE %s",source);
data/mbrola-3.3+dfsg/Standalone/synth.c:470:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf( out_name, "%s.rom", argv[argpos] );
data/mbrola-3.3+dfsg/Standalone/synth.c:514:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf( out_name, "%s.rom", dbaname(my_dba) );
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:174:7: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *getenv ();
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:721:1: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
getopt (int argc, char *const *argv, const char *optstring)
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:748:11: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt (argc, argv, "abc:d:0123456789");
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.h:105:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt (int argc, char *const *argv, const char *shortopts);
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.h:107:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt ();
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.h:109:12: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt_long (int argc, char *const *argv, const char *shortopts,
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.h:121:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt ();
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.h:122:12: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt_long ();
data/mbrola-3.3+dfsg/Standalone/synth.c:364:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((c=getopt(argc, argv, "+v:t:f:l:c:F:R:C:I:shiewW"))>0)
data/mbrola-3.3+dfsg/Database/database.c:164:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((database=fopen(dbaname(dba),"rb"))==NULL)
data/mbrola-3.3+dfsg/Database/database.c:799:34: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (( mydba->database= (void*) fopen(dbaname(mydba),"rb")) == NULL)
data/mbrola-3.3+dfsg/Database/database.h:123:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char Version[6]; /* Version of the database */
data/mbrola-3.3+dfsg/Database/database_old.c:48:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char left[2],right[2]; /* Name of the diphone */
data/mbrola-3.3+dfsg/Database/database_old.c:53:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dummy[3]; /* Alignment on multiple of 4 */
data/mbrola-3.3+dfsg/Database/database_old.c:65:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char left[2],right[2]; /* Name of the diphone */
data/mbrola-3.3+dfsg/Database/database_old.c:74:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char left[2],right[2]; /* Name of the diphone */
data/mbrola-3.3+dfsg/Database/database_old.c:75:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char leftr[2],rightr[2]; /* Name of the replacement diphone */
data/mbrola-3.3+dfsg/Database/rom_database.c:161:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* rom_file= fopen(out_name, "wb");
data/mbrola-3.3+dfsg/LibMultiChannel/demo2.c:49:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char err[255];
data/mbrola-3.3+dfsg/LibMultiChannel/demo2.c:122:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
output1=fopen("res1.ulaw","wb");
data/mbrola-3.3+dfsg/LibMultiChannel/demo2.c:123:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
output2=fopen("res2.raw","wb");
data/mbrola-3.3+dfsg/LibMultiChannel/demo2.c:124:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
output3=fopen("res3.lin8","wb");
data/mbrola-3.3+dfsg/LibMultiChannel/multichannel.c:188:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer_err,errbuffer,nb_wanted-1);
data/mbrola-3.3+dfsg/LibOneChannel/demo1.c:41:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char err[255];
data/mbrola-3.3+dfsg/LibOneChannel/demo1.c:78:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
output=fopen("res.ulaw","wb");
data/mbrola-3.3+dfsg/LibOneChannel/demo1b.c:41:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char err[255];
data/mbrola-3.3+dfsg/LibOneChannel/demo1b.c:83:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
output=fopen("res.ulaw","wb");
data/mbrola-3.3+dfsg/LibOneChannel/onechannel.c:269:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer_err,errbuffer,nb_wanted-1);
data/mbrola-3.3+dfsg/Misc/common.h:105:17: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
#define memmove memcpy
data/mbrola-3.3+dfsg/Misc/g711.c:40:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char _u2a[128] = { /* u- to A-law conversions */
data/mbrola-3.3+dfsg/Misc/g711.c:58:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char _a2u[128] = { /* A- to u-law conversions */
data/mbrola-3.3+dfsg/Misc/vp_error.c:42:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errbuffer[300];
data/mbrola-3.3+dfsg/Parser/phonbuff.c:305:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char new_name[100];
data/mbrola-3.3+dfsg/Parser/phonbuff.c:345:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[255];
data/mbrola-3.3+dfsg/Parser/phonbuff.c:352:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char a_line[1024]; /* An input line in the command file */
data/mbrola-3.3+dfsg/Standalone/synth.c:164:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((voice_len= (int16) atoi(val))<=0)
data/mbrola-3.3+dfsg/Standalone/synth.c:181:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* rename_file= fopen(rename_file_name,OPENRT);
data/mbrola-3.3+dfsg/Standalone/synth.c:182:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[255];
data/mbrola-3.3+dfsg/Standalone/synth.c:183:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char source[255];
data/mbrola-3.3+dfsg/Standalone/synth.c:184:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dest[255];
data/mbrola-3.3+dfsg/Standalone/synth.c:266:25: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
else if ((command_file=fopen(file_name,OPENRT)) == NULL)
data/mbrola-3.3+dfsg/Standalone/synth.c:469:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char out_name[1024];
data/mbrola-3.3+dfsg/Standalone/synth.c:473:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
rom_file= fopen(out_name,"rb");
data/mbrola-3.3+dfsg/Standalone/synth.c:513:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char out_name[1024];
data/mbrola-3.3+dfsg/Standalone/synth.c:562:25: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
else if ((output_file=fopen(argv[argc-1],"wb")) == NULL)
data/mbrola-3.3+dfsg/Database/database.c:112:5: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c=fgetc(database);
data/mbrola-3.3+dfsg/Database/database.c:197:27: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
Version(dba)[i]= (char) fgetc(database);
data/mbrola-3.3+dfsg/Database/database.c:600:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return_size= strlen( decode_ZStringList( info(dba), index) ) + 1;
data/mbrola-3.3+dfsg/Database/database.c:603:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg, decode_ZStringList( info(dba), index), size);
data/mbrola-3.3+dfsg/Database/database.c:605:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return_size= strlen(msg); /* effective size */
data/mbrola-3.3+dfsg/Database/database_old.c:149:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy( left_cell , one_oldfcell.left,2);
data/mbrola-3.3+dfsg/Database/database_old.c:150:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy( right_cell , one_oldfcell.right,2);
data/mbrola-3.3+dfsg/Database/database_old.c:163:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy( left_cell, one_fcell.left,2);
data/mbrola-3.3+dfsg/Database/database_old.c:164:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy( right_cell, one_fcell.right,2);
data/mbrola-3.3+dfsg/Database/database_old.c:224:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(left_cell, replace.leftr, 2);
data/mbrola-3.3+dfsg/Database/database_old.c:225:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(right_cell, replace.rightr, 2);
data/mbrola-3.3+dfsg/Database/database_old.c:245:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(left_cell, replace.left, 2);
data/mbrola-3.3+dfsg/Database/database_old.c:248:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(right_cell, replace.right, 2);
data/mbrola-3.3+dfsg/LibMultiChannel/multichannel.c:183:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int length=strlen(errbuffer)+1;
data/mbrola-3.3+dfsg/LibMultiChannel/multichannel.c:204:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg,SYNTH_VERSION,nb_wanted);
data/mbrola-3.3+dfsg/LibOneChannel/onechannel.c:211:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int length= strlen(flush_symbol);
data/mbrola-3.3+dfsg/LibOneChannel/onechannel.c:217:3: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(local,"\n");
data/mbrola-3.3+dfsg/LibOneChannel/onechannel.c:264:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int length=strlen(errbuffer)+1;
data/mbrola-3.3+dfsg/LibOneChannel/onechannel.c:285:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg,SYNTH_VERSION,nb_wanted);
data/mbrola-3.3+dfsg/Misc/audio.c:297:4: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l=strlen(name);
data/mbrola-3.3+dfsg/Misc/audio.c:304:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ll=strlen(format_list[i]);
data/mbrola-3.3+dfsg/Misc/mbralloc.c:56:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *newstr = (char *) MBR_malloc(strlen(str)+1);
data/mbrola-3.3+dfsg/Parser/fifo.c:68:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ( (int) strlen(buffer_in) >= available)
data/mbrola-3.3+dfsg/Parser/phonbuff.c:52:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
flush_symbol(pt)= (char *) MBR_malloc( strlen(flush) + 3);
data/mbrola-3.3+dfsg/Parser/phonbuff.c:68:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
comment_symbol(pt)= (char *) MBR_malloc( strlen(comment) + 3);
data/mbrola-3.3+dfsg/Parser/phonbuff.c:324:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
while (comment || (leading_blank==strlen(line)) || (leading_blank==strlen(line)-1));
data/mbrola-3.3+dfsg/Parser/phonbuff.c:324:69: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
while (comment || (leading_blank==strlen(line)) || (leading_blank==strlen(line)-1));
data/mbrola-3.3+dfsg/Parser/phonbuff.c:326:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
while (comment || (leading_blank==strlen(line)));
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:196:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
extern int strlen (const char *);
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:488:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (nameend - nextchar == strlen (p->name))
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:519:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:563:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:583:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/mbrola-3.3+dfsg/Standalone/Posix/getopt.c:587:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
ANALYSIS SUMMARY:
Hits = 110
Lines analyzed = 10832 in approximately 0.31 seconds (35258 lines/second)
Physical Source Lines of Code (SLOC) = 5389
Hits@level = [0] 62 [1] 34 [2] 36 [3] 9 [4] 31 [5] 0
Hits@level+ = [0+] 172 [1+] 110 [2+] 76 [3+] 40 [4+] 31 [5+] 0
Hits/KSLOC@level+ = [0+] 31.9169 [1+] 20.412 [2+] 14.1028 [3+] 7.42253 [4+] 5.75246 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.