Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/miniupnpd-2.2.0/upnphttp.c
Examining data/miniupnpd-2.2.0/upnphttp.h
Examining data/miniupnpd-2.2.0/upnpdescgen.c
Examining data/miniupnpd-2.2.0/upnpdescgen.h
Examining data/miniupnpd-2.2.0/miniupnpdpath.h
Examining data/miniupnpd-2.2.0/testupnpdescgen.c
Examining data/miniupnpd-2.2.0/upnpsoap.c
Examining data/miniupnpd-2.2.0/upnpsoap.h
Examining data/miniupnpd-2.2.0/pf/obsdrdr.h
Examining data/miniupnpd-2.2.0/pf/obsdrdr.c
Examining data/miniupnpd-2.2.0/pf/testobsdrdr.c
Examining data/miniupnpd-2.2.0/pf/pfpinhole.c
Examining data/miniupnpd-2.2.0/pf/pfpinhole.h
Examining data/miniupnpd-2.2.0/pf/testpfpinhole.c
Examining data/miniupnpd-2.2.0/bsd/getifstats.c
Examining data/miniupnpd-2.2.0/bsd/testgetifstats.c
Examining data/miniupnpd-2.2.0/bsd/ifacewatcher.c
Examining data/miniupnpd-2.2.0/bsd/testifacewatcher.c
Examining data/miniupnpd-2.2.0/bsd/getroute.c
Examining data/miniupnpd-2.2.0/solaris/getifstats.c
Examining data/miniupnpd-2.2.0/getifstats.h
Examining data/miniupnpd-2.2.0/upnpredirect.h
Examining data/miniupnpd-2.2.0/upnpredirect.c
Examining data/miniupnpd-2.2.0/getifaddr.c
Examining data/miniupnpd-2.2.0/getifaddr.h
Examining data/miniupnpd-2.2.0/daemonize.c
Examining data/miniupnpd-2.2.0/daemonize.h
Examining data/miniupnpd-2.2.0/upnpglobalvars.h
Examining data/miniupnpd-2.2.0/upnpglobalvars.c
Examining data/miniupnpd-2.2.0/linux/getifstats.c
Examining data/miniupnpd-2.2.0/linux/ifacewatcher.c
Examining data/miniupnpd-2.2.0/linux/getroute.c
Examining data/miniupnpd-2.2.0/netfilter/iptcrdr.c
Examining data/miniupnpd-2.2.0/netfilter/iptcrdr.h
Examining data/miniupnpd-2.2.0/netfilter/testiptcrdr.c
Examining data/miniupnpd-2.2.0/netfilter/tiny_nf_nat.h
Examining data/miniupnpd-2.2.0/netfilter/iptpinhole.c
Examining data/miniupnpd-2.2.0/netfilter/iptpinhole.h
Examining data/miniupnpd-2.2.0/netfilter/testiptpinhole.c
Examining data/miniupnpd-2.2.0/netfilter/nfct_get.c
Examining data/miniupnpd-2.2.0/netfilter/test_nfct_get.c
Examining data/miniupnpd-2.2.0/netfilter/testiptcrdr_dscp.c
Examining data/miniupnpd-2.2.0/netfilter/testiptcrdr_peer.c
Examining data/miniupnpd-2.2.0/minixml.c
Examining data/miniupnpd-2.2.0/minixml.h
Examining data/miniupnpd-2.2.0/upnpreplyparse.c
Examining data/miniupnpd-2.2.0/upnpreplyparse.h
Examining data/miniupnpd-2.2.0/testgetifstats.c
Examining data/miniupnpd-2.2.0/upnpdescstrings.h
Examining data/miniupnpd-2.2.0/options.h
Examining data/miniupnpd-2.2.0/options.c
Examining data/miniupnpd-2.2.0/upnppermissions.h
Examining data/miniupnpd-2.2.0/upnppermissions.c
Examining data/miniupnpd-2.2.0/testupnppermissions.c
Examining data/miniupnpd-2.2.0/minissdp.h
Examining data/miniupnpd-2.2.0/minissdp.c
Examining data/miniupnpd-2.2.0/miniupnpdctl.c
Examining data/miniupnpd-2.2.0/ipf/ipfrdr.c
Examining data/miniupnpd-2.2.0/ipf/ipfrdr.h
Examining data/miniupnpd-2.2.0/ipf/testipfrdr.c
Examining data/miniupnpd-2.2.0/miniupnpdtypes.h
Examining data/miniupnpd-2.2.0/natpmp.h
Examining data/miniupnpd-2.2.0/natpmp.c
Examining data/miniupnpd-2.2.0/commonrdr.h
Examining data/miniupnpd-2.2.0/upnpevents.h
Examining data/miniupnpd-2.2.0/upnpevents.c
Examining data/miniupnpd-2.2.0/codelength.h
Examining data/miniupnpd-2.2.0/testgetifaddr.c
Examining data/miniupnpd-2.2.0/mac/getifstats.c
Examining data/miniupnpd-2.2.0/mac/testgetifstats.c
Examining data/miniupnpd-2.2.0/ipfw/ipfwaux.c
Examining data/miniupnpd-2.2.0/ipfw/ipfwaux.h
Examining data/miniupnpd-2.2.0/ipfw/ipfwrdr.c
Examining data/miniupnpd-2.2.0/ipfw/ipfwrdr.h
Examining data/miniupnpd-2.2.0/ipfw/testipfwrdr.c
Examining data/miniupnpd-2.2.0/upnputils.c
Examining data/miniupnpd-2.2.0/upnputils.h
Examining data/miniupnpd-2.2.0/upnpurns.h
Examining data/miniupnpd-2.2.0/getconnstatus.c
Examining data/miniupnpd-2.2.0/getconnstatus.h
Examining data/miniupnpd-2.2.0/ifacewatcher.h
Examining data/miniupnpd-2.2.0/macros.h
Examining data/miniupnpd-2.2.0/upnppinhole.c
Examining data/miniupnpd-2.2.0/upnppinhole.h
Examining data/miniupnpd-2.2.0/getroute.h
Examining data/miniupnpd-2.2.0/testgetroute.c
Examining data/miniupnpd-2.2.0/pcpserver.h
Examining data/miniupnpd-2.2.0/pcpserver.c
Examining data/miniupnpd-2.2.0/pcplearndscp.h
Examining data/miniupnpd-2.2.0/pcplearndscp.c
Examining data/miniupnpd-2.2.0/pcp_msg_struct.h
Examining data/miniupnpd-2.2.0/asyncsendto.c
Examining data/miniupnpd-2.2.0/asyncsendto.h
Examining data/miniupnpd-2.2.0/testasyncsendto.c
Examining data/miniupnpd-2.2.0/portinuse.c
Examining data/miniupnpd-2.2.0/portinuse.h
Examining data/miniupnpd-2.2.0/testportinuse.c
Examining data/miniupnpd-2.2.0/netfilter_nft/nfct_get.c
Examining data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr.c
Examining data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr.h
Examining data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c
Examining data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.h
Examining data/miniupnpd-2.2.0/netfilter_nft/test_nfct_get.c
Examining data/miniupnpd-2.2.0/netfilter_nft/testnftnlrdr.c
Examining data/miniupnpd-2.2.0/netfilter_nft/tiny_nf_nat.h
Examining data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c
Examining data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.h
Examining data/miniupnpd-2.2.0/netfilter_nft/testnftpinhole.c
Examining data/miniupnpd-2.2.0/testssdppktgen.c
Examining data/miniupnpd-2.2.0/testminissdp.c
Examining data/miniupnpd-2.2.0/upnpstun.c
Examining data/miniupnpd-2.2.0/upnpstun.h
Examining data/miniupnpd-2.2.0/miniupnpd.c
FINAL RESULTS:
data/miniupnpd-2.2.0/ipf/ipfrdr.c:816:2: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
syslog(LOG_ERR, __FILE__ " update_portmapping() is not implemented");
data/miniupnpd-2.2.0/minissdp.c:1544:7: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
l = snprintf(strbuf, sizeof(strbuf), "http://%s:%u" ROOTDESC_PATH,
data/miniupnpd-2.2.0/miniupnpd.c:1198:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access(optionsfile, F_OK) == 0 || options_flag)
data/miniupnpd-2.2.0/miniupnpd.c:1679:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(val, "%s %s", argv[i+1], argv[i+2]);
data/miniupnpd-2.2.0/netfilter/iptpinhole.c:78:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(p->desc, desc);
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr.c:51:26: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define d_printf(x) do { printf x; } while (0)
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:47:26: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define d_printf(x) do { printf x; } while (0)
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:54:30: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
#define log_error( msg, ...) syslog(LOG_ERR, "%s[%d]: " msg, __func__, __LINE__, ##__VA_ARGS__ )
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:55:30: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
#define log_debug( msg, ...) syslog(LOG_DEBUG, "%s[%d]: " msg, __func__, __LINE__, ##__VA_ARGS__ )
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:58:28: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
#define log_error(args...) syslog(LOG_ERR, args)
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:59:28: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
#define log_debug(args...) syslog(LOG_DEBUG, args)
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:46:26: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define d_printf(x) do { printf x; } while (0)
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:97:2: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(comment, NFT_DESCR_SIZE,
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:154:8: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function. If the scanf format is influenceable by an
attacker, it's exploitable.
if (sscanf(p->desc, PINEHOLE_LABEL_FORMAT_SKIPDESC, &uid, &ts) != 2) {
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:301:2: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(comment, NFT_DESCR_SIZE,
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:376:9: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function. If the scanf format is influenceable by an
attacker, it's exploitable.
if (sscanf(p->desc, PINEHOLE_LABEL_FORMAT_SKIPDESC, &uid_temp, &ts) != 2) {
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:434:7: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function. If the scanf format is influenceable by an
attacker, it's exploitable.
if (sscanf(p->desc, PINEHOLE_LABEL_FORMAT_SKIPDESC, &uid, &ts) != 2) {
data/miniupnpd-2.2.0/pf/pfpinhole.c:114:3: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(pcr.rule.label, PF_RULE_LABEL_SIZE,
data/miniupnpd-2.2.0/pf/pfpinhole.c:207:7: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function. If the scanf format is influenceable by an
attacker, it's exploitable.
if(sscanf(pr.rule.label, PINEHOLE_LABEL_FORMAT_SKIPDESC, &uid, &ts) != 2) {
data/miniupnpd-2.2.0/pf/pfpinhole.c:399:6: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function. If the scanf format is influenceable by an
attacker, it's exploitable.
if(sscanf(pr.rule.label, PINEHOLE_LABEL_FORMAT_SKIPDESC, &uid, &ts) != 2) {
data/miniupnpd-2.2.0/upnpevents.c:457:17: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
obj->tosend = snprintf(obj->buffer, obj->buffersize, notifymsg,
data/miniupnpd-2.2.0/upnphttp.c:1096:18: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
h->res_buflen = snprintf(h->res_buf, h->res_buf_alloclen,
data/miniupnpd-2.2.0/upnppinhole.c:211:5: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if(system(cmd) < 0 || system(cmd_raw) < 0)
data/miniupnpd-2.2.0/upnppinhole.c:211:24: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if(system(cmd) < 0 || system(cmd_raw) < 0)
data/miniupnpd-2.2.0/upnpsoap.c:101:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:125:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:156:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:182:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:208:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:251:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:280:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:314:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:372:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:551:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:723:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:817:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:926:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:1003:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:1081:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:1197:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, bodyalloc, resp_start,
data/miniupnpd-2.2.0/upnpsoap.c:1237:15: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen += snprintf(body+bodylen, bodyalloc-bodylen, entry,
data/miniupnpd-2.2.0/upnpsoap.c:1262:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen += snprintf(body+bodylen, bodyalloc-bodylen, resp_end,
data/miniupnpd-2.2.0/upnpsoap.c:1303:14: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:1334:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:1422:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:1431:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp, "IP_Routed");
data/miniupnpd-2.2.0/upnpsoap.c:1436:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp, "ERROR_NONE");
data/miniupnpd-2.2.0/upnpsoap.c:1445:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:1477:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:1520:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(hostname, host);
data/miniupnpd-2.2.0/upnpsoap.c:1526:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(ifname, tmp);
data/miniupnpd-2.2.0/upnpsoap.c:1527:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(hostname, ifname);
data/miniupnpd-2.2.0/upnpsoap.c:1776:14: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body),
data/miniupnpd-2.2.0/upnpsoap.c:1872:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:1929:14: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:2015:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:2069:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:2133:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:2175:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:2202:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:2232:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/miniupnpd-2.2.0/upnpsoap.c:2390:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp, errCode, errDesc);
data/miniupnpd-2.2.0/upnpstun.c:46:9: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
#define syslog(priority, format, ...) do { switch(priority) { case LOG_ERR: printf("Error: "); break; case LOG_WARNING: printf("Warning: "); } printf(format, ##__VA_ARGS__); putchar('\n'); } while (0)
data/miniupnpd-2.2.0/upnpstun.c:46:144: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define syslog(priority, format, ...) do { switch(priority) { case LOG_ERR: printf("Error: "); break; case LOG_WARNING: printf("Warning: "); } printf(format, ##__VA_ARGS__); putchar('\n'); } while (0)
data/miniupnpd-2.2.0/upnpstun.c:555:9: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
return system(buffer);
data/miniupnpd-2.2.0/upnpstun.c:564:9: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
return system(buffer);
data/miniupnpd-2.2.0/minissdp.c:1228:14: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
delay = random() / (1 + RAND_MAX / (1000 * mx_value));
data/miniupnpd-2.2.0/minissdp.c:1309:13: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
delay = random() / (1 + RAND_MAX / (1000 * mx_value));
data/miniupnpd-2.2.0/miniupnpd.c:1871:2: [3] (random) srandom:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srandom((unsigned int)time(NULL));
data/miniupnpd-2.2.0/miniupnpd.c:1873:52: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
snprintf(random_url, RANDOM_URL_MAX_LEN, "%08lx", random());
data/miniupnpd-2.2.0/upnpevents.c:154:56: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
snprintf(tmp->uuid+sizeof(tmp->uuid)-5, 5, "%04lx", random() & 0xffff);
data/miniupnpd-2.2.0/upnpevents.c:161:54: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
snprintf(tmp->uuid+sizeof(tmp->uuid)-5, 5, "%04lx", random() & 0xffff);
data/miniupnpd-2.2.0/upnppinhole.c:215:2: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(time(NULL));
data/miniupnpd-2.2.0/upnpsoap.c:621:20: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
eport = 1024 + ((random() & 0x7ffffffL) % (65536-1024));
data/miniupnpd-2.2.0/upnpstun.c:55:23: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
transaction_id[i] = random() & 255;
data/miniupnpd-2.2.0/upnpstun.c:587:2: [3] (random) srandom:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srandom(time(NULL) * getpid());
data/miniupnpd-2.2.0/asyncsendto.c:80:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(CMSG_DATA(cmsg), &ipi6, sizeof(ipi6));
data/miniupnpd-2.2.0/asyncsendto.c:147:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(elt->data, dest_addr, addrlen);
data/miniupnpd-2.2.0/asyncsendto.c:152:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((void *)elt->src_addr, src_addr, sizeof(struct sockaddr_in6));
data/miniupnpd-2.2.0/asyncsendto.c:159:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((void *)elt->buf, buf, len);
data/miniupnpd-2.2.0/asyncsendto.c:251:6: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addr_str[64];
data/miniupnpd-2.2.0/bsd/getroute.c:40:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char m_space[512];
data/miniupnpd-2.2.0/bsd/getroute.c:69:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(m_rtmsg.m_space, dst, l);
data/miniupnpd-2.2.0/bsd/getroute.c:99:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[256] = { 0 };
data/miniupnpd-2.2.0/bsd/getroute.c:126:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(src, paddr, len);
data/miniupnpd-2.2.0/bsd/ifacewatcher.c:46:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096];
data/miniupnpd-2.2.0/bsd/ifacewatcher.c:48:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[64];
data/miniupnpd-2.2.0/daemonize.c:47:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
i = open("/dev/null", O_RDWR); /* open stdin */
data/miniupnpd-2.2.0/daemonize.c:66:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pidstring[16];
data/miniupnpd-2.2.0/daemonize.c:73:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if( (pidfile = open(fname, O_WRONLY|O_CREAT, 0644)) < 0)
data/miniupnpd-2.2.0/daemonize.c:101:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[64];
data/miniupnpd-2.2.0/daemonize.c:108:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if( (pidfile = open(fname, O_RDONLY)) < 0)
data/miniupnpd-2.2.0/daemonize.c:115:14: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if( (pid = atol(buffer)) > 0)
data/miniupnpd-2.2.0/getconnstatus.c:33:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addr[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/getifaddr.c:179:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(addr->s6_addr + 12,
data/miniupnpd-2.2.0/getifaddr.c:191:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(addr->s6_addr,
data/miniupnpd-2.2.0/getifaddr.c:213:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(addr->s6_addr + 12, &addr4.s_addr, 4);
data/miniupnpd-2.2.0/getifaddr.c:227:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[64];
data/miniupnpd-2.2.0/ipf/ipfrdr.c:157:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p->str, desc, l);
data/miniupnpd-2.2.0/ipf/ipfrdr.c:202:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dev = open(IPNAT_NAME, O_RDWR);
data/miniupnpd-2.2.0/ipf/ipfrdr.c:207:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dev_ipl = open(IPL_NAME, O_RDWR);
data/miniupnpd-2.2.0/ipfw/ipfwrdr.c:112:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tmp->desc, desc, l);
data/miniupnpd-2.2.0/ipfw/ipfwrdr.c:196:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&rule.fw_dst, &rule.fw_out_if.fu_via_ip, sizeof(struct in_addr));
data/miniupnpd-2.2.0/ipfw/ipfwrdr.c:197:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&rule.fw_fwd_ip.sin_addr, &rule.fw_out_if.fu_via_ip, sizeof(struct in_addr));
data/miniupnpd-2.2.0/ipfw/ipfwrdr.c:500:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[16];
data/miniupnpd-2.2.0/ipfw/ipfwrdr.c:501:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[16];
data/miniupnpd-2.2.0/ipfw/testipfwrdr.c:24:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[16];
data/miniupnpd-2.2.0/ipfw/testipfwrdr.c:27:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/ipfw/testipfwrdr.c:28:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[32];
data/miniupnpd-2.2.0/ipfw/testipfwrdr.c:54:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/ipfw/testipfwrdr.c:55:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addr[16];
data/miniupnpd-2.2.0/ipfw/testipfwrdr.c:56:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[40];
data/miniupnpd-2.2.0/linux/getifstats.c:76:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[512];
data/miniupnpd-2.2.0/linux/getifstats.c:80:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fname[64];
data/miniupnpd-2.2.0/linux/getifstats.c:102:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data, &cache_data, sizeof(struct ifdata));
data/miniupnpd-2.2.0/linux/getifstats.c:107:6: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen("/proc/net/dev", "r");
data/miniupnpd-2.2.0/linux/getifstats.c:146:6: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen(fname, "r");
data/miniupnpd-2.2.0/linux/getifstats.c:149:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(line); /* 65535 means unknown */
data/miniupnpd-2.2.0/linux/getifstats.c:175:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&cache_data, data, sizeof(struct ifdata));
data/miniupnpd-2.2.0/linux/getroute.c:40:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/miniupnpd-2.2.0/linux/getroute.c:72:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dst_str[128];
data/miniupnpd-2.2.0/linux/getroute.c:87:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(RTA_DATA(rta), &dst4->sin_addr, sizeof(dst4->sin_addr));
data/miniupnpd-2.2.0/linux/getroute.c:96:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(RTA_DATA(rta), &dst6->sin6_addr, sizeof(dst6->sin6_addr));
data/miniupnpd-2.2.0/linux/getroute.c:177:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(src, data, RTA_PAYLOAD(rta));
data/miniupnpd-2.2.0/linux/getroute.c:181:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(index, data, sizeof(int));
data/miniupnpd-2.2.0/linux/ifacewatcher.c:101:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ifname[IFNAMSIZ];
data/miniupnpd-2.2.0/linux/ifacewatcher.c:102:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ifstraddr[16];
data/miniupnpd-2.2.0/linux/ifacewatcher.c:236:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[4096];
data/miniupnpd-2.2.0/linux/ifacewatcher.c:275:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char address[48];
data/miniupnpd-2.2.0/linux/ifacewatcher.c:276:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ifname[IFNAMSIZ];
data/miniupnpd-2.2.0/linux/ifacewatcher.c:311:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[128];
data/miniupnpd-2.2.0/mac/getifstats.c:53:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data, &cache_data, sizeof(struct ifdata));
data/miniupnpd-2.2.0/mac/getifstats.c:84:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&cache_data, data, sizeof(struct ifdata));
data/miniupnpd-2.2.0/minissdp.c:146:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(addr6, &(((const struct sockaddr_in6 *)ife->ifa_addr)->sin6_addr), sizeof(struct in6_addr));
data/miniupnpd-2.2.0/minissdp.c:501:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[SSDP_PACKET_MAX_LEN];
data/miniupnpd-2.2.0/minissdp.c:502:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addr_str[64];
data/miniupnpd-2.2.0/minissdp.c:506:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char http_date[64];
data/miniupnpd-2.2.0/minissdp.c:647:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char bufr[SSDP_PACKET_MAX_LEN];
data/miniupnpd-2.2.0/minissdp.c:748:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ver_str[4];
data/miniupnpd-2.2.0/minissdp.c:863:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char bufr[1500];
data/miniupnpd-2.2.0/minissdp.c:872:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmbuf[CMSG_SPACE(sizeof(struct sockaddr_dl))];
data/miniupnpd-2.2.0/minissdp.c:874:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmbuf[CMSG_SPACE(sizeof(struct in_pktinfo))];
data/miniupnpd-2.2.0/minissdp.c:969:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sender_str[64];
data/miniupnpd-2.2.0/minissdp.c:970:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ver_str[4];
data/miniupnpd-2.2.0/minissdp.c:974:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char announced_host_buf[64];
data/miniupnpd-2.2.0/minissdp.c:990:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char atoi_buffer[8];
data/miniupnpd-2.2.0/minissdp.c:1055:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
st_ver = atoi(atoi_buffer);
data/miniupnpd-2.2.0/minissdp.c:1075:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
mx_value = atoi(atoi_buffer);
data/miniupnpd-2.2.0/minissdp.c:1361:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char bufr[SSDP_PACKET_MAX_LEN];
data/miniupnpd-2.2.0/minissdp.c:1416:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ver_str[4];
data/miniupnpd-2.2.0/minissdp.c:1491:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[2048];
data/miniupnpd-2.2.0/minissdp.c:1492:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strbuf[256];
data/miniupnpd-2.2.0/minissdp.c:1495:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ver_str[4];
data/miniupnpd-2.2.0/minissdp.c:1527:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, strbuf, l);
data/miniupnpd-2.2.0/minissdp.c:1538:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, strbuf, l);
data/miniupnpd-2.2.0/minissdp.c:1542:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, MINIUPNPD_SERVER_STRING, l);
data/miniupnpd-2.2.0/minissdp.c:1553:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, strbuf, l);
data/miniupnpd-2.2.0/miniupnpd.c:147:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char proto[4];
data/miniupnpd-2.2.0/miniupnpd.c:148:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[32];
data/miniupnpd-2.2.0/miniupnpd.c:149:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/miniupnpd.c:150:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[32];
data/miniupnpd-2.2.0/miniupnpd.c:154:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[128];
data/miniupnpd-2.2.0/miniupnpd.c:156:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(tmp, "/etc/upnp/saveXXXXXX");
data/miniupnpd-2.2.0/miniupnpd.c:157:11: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
if ((t = mkstemp(tmp)) != -1)
data/miniupnpd-2.2.0/miniupnpd.c:183:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[256];
data/miniupnpd-2.2.0/miniupnpd.c:189:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char proto[4];
data/miniupnpd-2.2.0/miniupnpd.c:190:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[32];
data/miniupnpd-2.2.0/miniupnpd.c:194:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f = fopen("/etc/upnp/data", "r")) != NULL)
data/miniupnpd-2.2.0/miniupnpd.c:236:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[128];
data/miniupnpd-2.2.0/miniupnpd.c:240:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char proto[4];
data/miniupnpd-2.2.0/miniupnpd.c:241:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[32];
data/miniupnpd-2.2.0/miniupnpd.c:242:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/miniupnpd.c:243:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[32];
data/miniupnpd-2.2.0/miniupnpd.c:246:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f = fopen("/etc/upnp/delete", "r")) != NULL)
data/miniupnpd-2.2.0/miniupnpd.c:471:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addr_str[64];
data/miniupnpd-2.2.0/miniupnpd.c:502:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&tmp->clientaddr,
data/miniupnpd-2.2.0/miniupnpd.c:509:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&tmp->clientaddr_v6,
data/miniupnpd-2.2.0/miniupnpd.c:665:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096];
data/miniupnpd-2.2.0/miniupnpd.c:708:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[256];
data/miniupnpd-2.2.0/miniupnpd.c:726:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[256];
data/miniupnpd-2.2.0/miniupnpd.c:742:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[256];
data/miniupnpd-2.2.0/miniupnpd.c:759:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[256];
data/miniupnpd-2.2.0/miniupnpd.c:837:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE * f = fopen("/proc/uptime", "r");
data/miniupnpd-2.2.0/miniupnpd.c:922:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[16];
data/miniupnpd-2.2.0/miniupnpd.c:932:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(lan_addr->ifname, str, n);
data/miniupnpd-2.2.0/miniupnpd.c:951:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(lan_addr->str, str, n);
data/miniupnpd-2.2.0/miniupnpd.c:969:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tmp, q, n);
data/miniupnpd-2.2.0/miniupnpd.c:977:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int nbits = atoi(q);
data/miniupnpd-2.2.0/miniupnpd.c:998:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(lan_addr->ext_ip_str, p, n);
data/miniupnpd-2.2.0/miniupnpd.c:1058:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char ext_addr_str[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/miniupnpd.c:1064:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char if_addr_str[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/miniupnpd.c:1102:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(uuidvalue_wan, uuidvalue_igd, len+1);
data/miniupnpd-2.2.0/miniupnpd.c:1113:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(uuidvalue_wcd, uuidvalue_wan, len+1);
data/miniupnpd-2.2.0/miniupnpd.c:1226:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ext_stun_port = atoi(ary_options[i].value);
data/miniupnpd-2.2.0/miniupnpd.c:1260:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
v->port = atoi(ary_options[i].value);
data/miniupnpd-2.2.0/miniupnpd.c:1264:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
v->https_port = atoi(ary_options[i].value);
data/miniupnpd-2.2.0/miniupnpd.c:1314:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
v->notify_interval = atoi(ary_options[i].value);
data/miniupnpd-2.2.0/miniupnpd.c:1340:34: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
v->clean_ruleset_threshold = atoi(ary_options[i].value);
data/miniupnpd-2.2.0/miniupnpd.c:1343:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
v->clean_ruleset_interval = atoi(ary_options[i].value);
data/miniupnpd-2.2.0/miniupnpd.c:1361:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if(atoi(ary_options[i].value))
data/miniupnpd-2.2.0/miniupnpd.c:1368:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
min_lifetime = atoi(ary_options[i].value);
data/miniupnpd-2.2.0/miniupnpd.c:1374:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
max_lifetime = atoi(ary_options[i].value);
data/miniupnpd-2.2.0/miniupnpd.c:1476:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ext_stun_port = atoi(ptr+1);
data/miniupnpd-2.2.0/miniupnpd.c:1486:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
v->notify_interval = atoi(argv[++i]);
data/miniupnpd-2.2.0/miniupnpd.c:1492:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
v->clean_ruleset_interval = atoi(argv[++i]);
data/miniupnpd-2.2.0/miniupnpd.c:1578:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
v->port = atoi(argv[++i]);
data/miniupnpd-2.2.0/miniupnpd.c:1585:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
v->https_port = atoi(argv[++i]);
data/miniupnpd-2.2.0/miniupnpd.c:1594:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
nfqueue = atoi(argv[++i]);
data/miniupnpd-2.2.0/miniupnpd.c:2163:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char if_addr[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/miniupnpd.c:2234:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ipv6_addr_for_http_with_brackets, "[::1]", 6);
data/miniupnpd-2.2.0/miniupnpd.c:2433:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char if_addr[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/miniupnpd.c:2488:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&lasttimeofday, &timeofday, sizeof(struct timeval));
data/miniupnpd-2.2.0/miniupnpd.c:2521:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&checktime, &timeofday, sizeof(struct timeval));
data/miniupnpd-2.2.0/miniupnpd.c:2721:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[256];
data/miniupnpd-2.2.0/miniupnpd.c:2787:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char msg_buff[PCP_MAX_LEN];
data/miniupnpd-2.2.0/miniupnpd.c:2811:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sender_str[64];
data/miniupnpd-2.2.0/miniupnpd.c:2834:6: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sender_str[64];
data/miniupnpd-2.2.0/miniupnpd.c:2849:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char msg_buff[PCP_MAX_LEN];
data/miniupnpd-2.2.0/miniupnpdctl.c:31:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[256];
data/miniupnpd-2.2.0/miniupnpdtypes.h:18:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ifname[IFNAMSIZ]; /* example: eth0 */
data/miniupnpd-2.2.0/miniupnpdtypes.h:20:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[16]; /* example: 192.168.0.1 */
data/miniupnpd-2.2.0/miniupnpdtypes.h:23:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ext_ip_str[16];
data/miniupnpd-2.2.0/natpmp.c:98:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[16];
data/miniupnpd-2.2.0/natpmp.c:124:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(resp+8, &lan_addr->ext_ip_addr,
data/miniupnpd-2.2.0/natpmp.c:181:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/natpmp.c:223:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char resp[32]; /* response udp packet */
data/miniupnpd-2.2.0/natpmp.c:226:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char senderaddrstr[16];
data/miniupnpd-2.2.0/natpmp.c:274:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr_old[16];
data/miniupnpd-2.2.0/natpmp.c:299:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr2[16];
data/miniupnpd-2.2.0/natpmp.c:301:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/natpmp.c:334:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/natpmp.c:427:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char notif[12];
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:205:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p->str, desc, l);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1243:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(e->elems, match, match->u.match_size);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1244:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(e->elems + match->u.match_size, target, target->u.target_size);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1317:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(e->elems, match, match->u.match_size);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1318:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(e->elems + match->u.match_size, target, target->u.target_size);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1404:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(e->elems, match, match->u.match_size);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1405:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(e->elems + match->u.match_size, target, target->u.target_size);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1482:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(e->elems, match, match->u.match_size);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1483:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(e->elems + match->u.match_size, target, target->u.target_size);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1571:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(e->elems, match, match->u.match_size);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1572:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(e->elems + match->u.match_size, target, target->u.target_size);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1821:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new_e, e, entry_len);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1899:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new_e, e, entry_len);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1999:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new_e, e, entry_len);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:2103:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addr[16], mask[16];
data/miniupnpd-2.2.0/netfilter/iptpinhole.c:79:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&p->saddr, saddr, sizeof(struct in6_addr));
data/miniupnpd-2.2.0/netfilter/iptpinhole.c:81:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&p->daddr, daddr, sizeof(struct in6_addr));
data/miniupnpd-2.2.0/netfilter/iptpinhole.c:255:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(e->elems, match, match->u.match_size);
data/miniupnpd-2.2.0/netfilter/iptpinhole.c:256:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(e->elems + match->u.match_size, target, target->u.target_size);
data/miniupnpd-2.2.0/netfilter/nfct_get.c:47:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MNL_SOCKET_BUFFER_SIZE];
data/miniupnpd-2.2.0/netfilter/nfct_get.c:151:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f = fopen(NF_CONNTRACK_LOCATION, "r")) == NULL) {
data/miniupnpd-2.2.0/netfilter/nfct_get.c:152:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f = fopen(IP_CONNTRACK_LOCATION, "r")) == NULL) {
data/miniupnpd-2.2.0/netfilter/nfct_get.c:160:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[256], *str;
data/miniupnpd-2.2.0/netfilter/nfct_get.c:174:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((j==2)&&(af!=atoi(token)))
data/miniupnpd-2.2.0/netfilter/nfct_get.c:176:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((j==4)&&(proto!=atoi(token)))
data/miniupnpd-2.2.0/netfilter/nfct_get.c:200:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
uint16_t port=atoi(src_port);
data/miniupnpd-2.2.0/netfilter/nfct_get.c:233:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
uint16_t port=atoi(dst_port);
data/miniupnpd-2.2.0/netfilter/test_nfct_get.c:6:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/netfilter/test_nfct_get.c:17:54: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
((struct sockaddr_in6*)(&src))->sin6_port = htons(atoi(argv[2]));
data/miniupnpd-2.2.0/netfilter/test_nfct_get.c:21:51: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
((struct sockaddr_in*)(&src))->sin_port = htons(atoi(argv[2]));
data/miniupnpd-2.2.0/netfilter/test_nfct_get.c:31:54: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
((struct sockaddr_in6*)(&dst))->sin6_port = htons(atoi(argv[4]));
data/miniupnpd-2.2.0/netfilter/test_nfct_get.c:35:51: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
((struct sockaddr_in*)(&dst))->sin_port = htons(atoi(argv[4]));
data/miniupnpd-2.2.0/netfilter/testiptcrdr.c:34:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
eport = (unsigned short)atoi(argv[1]);
data/miniupnpd-2.2.0/netfilter/testiptcrdr.c:36:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
iport = (unsigned short)atoi(argv[3]);
data/miniupnpd-2.2.0/netfilter/testiptcrdr.c:61:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addr[16];
data/miniupnpd-2.2.0/netfilter/testiptcrdr.c:63:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[256];
data/miniupnpd-2.2.0/netfilter/testiptcrdr.c:64:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[256];
data/miniupnpd-2.2.0/netfilter/testiptcrdr_dscp.c:32:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dscp = (unsigned short)atoi(argv[1]);
data/miniupnpd-2.2.0/netfilter/testiptcrdr_dscp.c:34:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
iport = (unsigned short)atoi(argv[3]);
data/miniupnpd-2.2.0/netfilter/testiptcrdr_dscp.c:36:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
rport = (unsigned short)atoi(argv[5]);
data/miniupnpd-2.2.0/netfilter/testiptcrdr_dscp.c:44:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addr[16];
data/miniupnpd-2.2.0/netfilter/testiptcrdr_dscp.c:46:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[256];
data/miniupnpd-2.2.0/netfilter/testiptcrdr_dscp.c:47:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[256];
data/miniupnpd-2.2.0/netfilter/testiptcrdr_peer.c:32:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
eport = (unsigned short)atoi(argv[2]);
data/miniupnpd-2.2.0/netfilter/testiptcrdr_peer.c:34:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
iport = (unsigned short)atoi(argv[4]);
data/miniupnpd-2.2.0/netfilter/testiptcrdr_peer.c:36:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
rport = (unsigned short)atoi(argv[6]);
data/miniupnpd-2.2.0/netfilter/testiptcrdr_peer.c:45:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addr[16];
data/miniupnpd-2.2.0/netfilter/testiptcrdr_peer.c:47:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[256];
data/miniupnpd-2.2.0/netfilter/testiptcrdr_peer.c:48:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[256];
data/miniupnpd-2.2.0/netfilter_nft/nfct_get.c:47:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MNL_SOCKET_BUFFER_SIZE];
data/miniupnpd-2.2.0/netfilter_nft/nfct_get.c:151:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f = fopen(NF_CONNTRACK_LOCATION, "r")) == NULL) {
data/miniupnpd-2.2.0/netfilter_nft/nfct_get.c:152:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f = fopen(IP_CONNTRACK_LOCATION, "r")) == NULL) {
data/miniupnpd-2.2.0/netfilter_nft/nfct_get.c:160:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[256], *str;
data/miniupnpd-2.2.0/netfilter_nft/nfct_get.c:174:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((j==2)&&(af!=atoi(token)))
data/miniupnpd-2.2.0/netfilter_nft/nfct_get.c:176:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((j==4)&&(proto!=atoi(token)))
data/miniupnpd-2.2.0/netfilter_nft/nfct_get.c:200:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
uint16_t port=atoi(src_port);
data/miniupnpd-2.2.0/netfilter_nft/nfct_get.c:233:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
uint16_t port=atoi(dst_port);
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr.c:760:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr_str[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr.c:761:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:553:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(r->desc, descr, r->desc_len);
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:679:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MNL_SOCKET_BUFFER_SIZE];
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:1192:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MNL_SOCKET_BUFFER_SIZE*2];
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:1233:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MNL_SOCKET_BUFFER_SIZE*2];
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:1282:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MNL_SOCKET_BUFFER_SIZE*2];
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:1370:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MNL_SOCKET_BUFFER_SIZE];
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:77:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char comment[NFT_DESCR_SIZE];
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:182:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char label_start[NFT_DESCR_SIZE];
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:183:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp_label[NFT_DESCR_SIZE];
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:215:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:217:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char raddr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:218:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char label_start[NFT_DESCR_SIZE];
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:219:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp_label[NFT_DESCR_SIZE];
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:220:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[NFT_DESCR_SIZE];
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:221:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ifname[IFNAMSIZ];
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:222:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char comment[NFT_DESCR_SIZE];
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:331:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char label_start[NFT_DESCR_SIZE];
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:332:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp_label[NFT_DESCR_SIZE];
data/miniupnpd-2.2.0/netfilter_nft/test_nfct_get.c:9:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/netfilter_nft/test_nfct_get.c:24:54: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
((struct sockaddr_in6*)(&src))->sin6_port = htons(atoi(argv[2]));
data/miniupnpd-2.2.0/netfilter_nft/test_nfct_get.c:28:51: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
((struct sockaddr_in*)(&src))->sin_port = htons(atoi(argv[2]));
data/miniupnpd-2.2.0/netfilter_nft/test_nfct_get.c:38:54: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
((struct sockaddr_in6*)(&dst))->sin6_port = htons(atoi(argv[4]));
data/miniupnpd-2.2.0/netfilter_nft/test_nfct_get.c:42:51: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
((struct sockaddr_in*)(&dst))->sin_port = htons(atoi(argv[4]));
data/miniupnpd-2.2.0/netfilter_nft/testnftnlrdr.c:59:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
eport = (unsigned short)atoi(argv[1]);
data/miniupnpd-2.2.0/netfilter_nft/testnftnlrdr.c:61:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
iport = (unsigned short)atoi(argv[3]);
data/miniupnpd-2.2.0/netfilter_nft/testnftnlrdr.c:74:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addr[16];
data/miniupnpd-2.2.0/netfilter_nft/testnftnlrdr.c:76:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[256];
data/miniupnpd-2.2.0/netfilter_nft/testnftnlrdr.c:77:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[256];
data/miniupnpd-2.2.0/options.c:105:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/miniupnpd-2.2.0/options.c:126:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if(!(hfile = fopen(fname, "r")))
data/miniupnpd-2.2.0/options.c:270:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(string_repo + string_repo_len, value, len);
data/miniupnpd-2.2.0/pcp_msg_struct.h:252:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char app_name[0];
data/miniupnpd-2.2.0/pcplearndscp.c:107:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dscpvalues->delay = (unsigned char)atoi(p);
data/miniupnpd-2.2.0/pcplearndscp.c:130:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dscpvalues->loss = (unsigned char)atoi(p);
data/miniupnpd-2.2.0/pcplearndscp.c:152:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dscpvalues->jitter = (unsigned char)atoi(p);
data/miniupnpd-2.2.0/pcplearndscp.c:192:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
af_value = atoi(p);
data/miniupnpd-2.2.0/pcplearndscp.c:246:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
cs_value = atoi(p);
data/miniupnpd-2.2.0/pcplearndscp.c:279:44: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dscpvalues->dscp_value = (unsigned char)atoi(p);
data/miniupnpd-2.2.0/pcpserver.c:149:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mapped_str[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:153:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/pcpserver.c:182:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dest, src, sizeof(struct in6_addr));
data/miniupnpd-2.2.0/pcpserver.c:268:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char map_addr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:279:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char map_addr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:306:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(pcp_msg_info->nonce, map_v2, 12);
data/miniupnpd-2.2.0/pcpserver.c:318:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ext_addr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:319:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char peer_addr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:333:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ext_addr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:334:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char peer_addr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:374:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(pcp_msg_info->nonce, buf, 12);
data/miniupnpd-2.2.0/pcpserver.c:426:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char third_addr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:630:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:698:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char peerip_s[INET6_ADDRSTRLEN], extip_s[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:790:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char peerip_s[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:836:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:842:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr2[INET6_ADDRSTRLEN], rhost2[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:844:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/pcpserver.c:908:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr_old[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:1100:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr2[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/pcpserver.c:1102:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/pcpserver.c:1548:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addr_str[64];
data/miniupnpd-2.2.0/pcpserver.c:1557:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(pcp_msg_info.sender_ip.s6_addr+12,
data/miniupnpd-2.2.0/pcpserver.c:1664:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buff[PCP_MIN_LEN];
data/miniupnpd-2.2.0/pf/obsdrdr.c:159:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dev = open("/dev/pf", O_RDWR);
data/miniupnpd-2.2.0/pf/obsdrdr.c:304:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char extaddr_buf[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/pf/obsdrdr.c:409:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&pp.addr, a, sizeof(struct pf_pooladdr));
data/miniupnpd-2.2.0/pf/obsdrdr.c:629:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&pp.addr, a, sizeof(struct pf_pooladdr));
data/miniupnpd-2.2.0/pf/obsdrdr.c:1390:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr_str[16];
data/miniupnpd-2.2.0/pf/obsdrdr.c:1391:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[32];
data/miniupnpd-2.2.0/pf/obsdrdr.c:1417:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr_str[16];
data/miniupnpd-2.2.0/pf/obsdrdr.c:1418:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[32];
data/miniupnpd-2.2.0/pf/obsdrdr.c:1450:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32];
data/miniupnpd-2.2.0/pf/obsdrdr.c:1451:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf2[32];
data/miniupnpd-2.2.0/pf/pfpinhole.c:229:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char label_start[PF_RULE_LABEL_SIZE];
data/miniupnpd-2.2.0/pf/pfpinhole.c:230:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp_label[PF_RULE_LABEL_SIZE];
data/miniupnpd-2.2.0/pf/pfpinhole.c:285:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char label_start[PF_RULE_LABEL_SIZE];
data/miniupnpd-2.2.0/pf/pfpinhole.c:286:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp_label[PF_RULE_LABEL_SIZE];
data/miniupnpd-2.2.0/pf/testobsdrdr.c:46:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ifname[16/*IFNAMSIZ*/];
data/miniupnpd-2.2.0/pf/testobsdrdr.c:47:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[32];
data/miniupnpd-2.2.0/pf/testobsdrdr.c:48:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/pf/testobsdrdr.c:49:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[32];
data/miniupnpd-2.2.0/pf/testobsdrdr.c:75:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32];
data/miniupnpd-2.2.0/pf/testobsdrdr.c:76:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/pf/testobsdrdr.c:77:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[64];
data/miniupnpd-2.2.0/pf/testpfpinhole.c:31:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rem_host[64];
data/miniupnpd-2.2.0/pf/testpfpinhole.c:33:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char int_client[64];
data/miniupnpd-2.2.0/pf/testpfpinhole.c:38:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/portinuse.c:73:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ip_addr_str[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/portinuse.c:77:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[256];
data/miniupnpd-2.2.0/portinuse.c:94:6: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen((proto==IPPROTO_TCP)?tcpfile:udpfile, "r");
data/miniupnpd-2.2.0/portinuse.c:101:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char eaddr[68];
data/miniupnpd-2.2.0/portinuse.c:113:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp_addr[4];
data/miniupnpd-2.2.0/portinuse.c:141:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errstr[_POSIX2_LINE_MAX];
data/miniupnpd-2.2.0/portinuse.c:396:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr_old[16];
data/miniupnpd-2.2.0/solaris/getifstats.c:20:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[64], *s;
data/miniupnpd-2.2.0/solaris/getifstats.c:38:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
instance = atoi(s);
data/miniupnpd-2.2.0/testgetifaddr.c:22:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str_addr[64];
data/miniupnpd-2.2.0/testgetifaddr.c:27:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str_addr6[64];
data/miniupnpd-2.2.0/testgetroute.c:92:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char src_str[128];
data/miniupnpd-2.2.0/testminissdp.c:41:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1500];
data/miniupnpd-2.2.0/testminissdp.c:58:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen(argv[1], "rb");
data/miniupnpd-2.2.0/testportinuse.c:37:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
eport = (unsigned)atoi(argv[2]);
data/miniupnpd-2.2.0/testportinuse.c:40:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
iport = (unsigned)atoi(argv[5]);
data/miniupnpd-2.2.0/testssdppktgen.c:27:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char bufr[SSDP_PACKET_MAX_LEN];
data/miniupnpd-2.2.0/testupnpdescgen.c:178:6: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen("testdescs/rootdesc.xml", "w");
data/miniupnpd-2.2.0/testupnpdescgen.c:188:6: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen("testdescs/wanipc_scpd.xml", "w");
data/miniupnpd-2.2.0/testupnpdescgen.c:198:6: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen("testdescs/wanconfig_scpd.xml", "w");
data/miniupnpd-2.2.0/testupnpdescgen.c:209:6: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen("testdescs/l3f_scpd.xml", "w");
data/miniupnpd-2.2.0/testupnpdescgen.c:221:6: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen("testdescs/wanipv6fc_scpd.xml", "w");
data/miniupnpd-2.2.0/testupnpdescgen.c:233:6: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen("testdescs/dp_scpd.xml", "w");
data/miniupnpd-2.2.0/upnpdescgen.c:828:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str + *len, s2, s2len + 1);
data/miniupnpd-2.2.0/upnpdescgen.c:864:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[16];
data/miniupnpd-2.2.0/upnpdescgen.c:975:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char configid_str[16];
data/miniupnpd-2.2.0/upnpdescgen.c:1016:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, xmlver, *len + 1);
data/miniupnpd-2.2.0/upnpdescgen.c:1040:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, xmlver, *len + 1);
data/miniupnpd-2.2.0/upnpdescgen.c:1225:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[16];
data/miniupnpd-2.2.0/upnpdescgen.c:1292:6: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ext_ip_addr[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/upnpevents.c:49:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char uuid[42];
data/miniupnpd-2.2.0/upnpevents.c:70:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addrstr[48];
data/miniupnpd-2.2.0/upnpevents.c:72:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addrstr[16];
data/miniupnpd-2.2.0/upnpevents.c:74:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char portstr[8];
data/miniupnpd-2.2.0/upnpevents.c:117:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tmp->callback, callback, callbacklen);
data/miniupnpd-2.2.0/upnpevents.c:123:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tmp->uuid, "uuid:", 5);
data/miniupnpd-2.2.0/upnpevents.c:143:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tmp->uuid, "uuid:", 5);
data/miniupnpd-2.2.0/upnpevents.c:144:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tmp->uuid + 5, uuid_str, 36);
data/miniupnpd-2.2.0/upnpevents.c:344:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = (unsigned short)atoi(p);
data/miniupnpd-2.2.0/upnpevents.c:357:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addrstr_tmp[48];
data/miniupnpd-2.2.0/upnpevents.c:363:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(addrstr_tmp, obj->addrstr + 1, i);
data/miniupnpd-2.2.0/upnpevents.c:665:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[80];
data/miniupnpd-2.2.0/upnpglobalvars.c:65:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char serialnumber[SERIALNUMBER_MAX_LEN] = "00000000";
data/miniupnpd-2.2.0/upnpglobalvars.c:67:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char modelnumber[MODELNUMBER_MAX_LEN] = "1";
data/miniupnpd-2.2.0/upnpglobalvars.c:71:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char presentationurl[PRESENTATIONURL_MAX_LEN];
data/miniupnpd-2.2.0/upnpglobalvars.c:75:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char friendly_name[FRIENDLY_NAME_MAX_LEN] = OS_NAME " router";
data/miniupnpd-2.2.0/upnpglobalvars.c:78:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char manufacturer_name[MANUFACTURER_NAME_MAX_LEN] = ROOTDEV_MANUFACTURER;
data/miniupnpd-2.2.0/upnpglobalvars.c:81:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char manufacturer_url[MANUFACTURER_URL_MAX_LEN] = ROOTDEV_MANUFACTURERURL;
data/miniupnpd-2.2.0/upnpglobalvars.c:84:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char model_name[MODEL_NAME_MAX_LEN] = ROOTDEV_MODELNAME;
data/miniupnpd-2.2.0/upnpglobalvars.c:87:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char model_description[MODEL_DESCRIPTION_MAX_LEN] = ROOTDEV_MODELDESCRIPTION;
data/miniupnpd-2.2.0/upnpglobalvars.c:90:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char model_url[MODEL_URL_MAX_LEN] = ROOTDEV_MODELURL;
data/miniupnpd-2.2.0/upnpglobalvars.c:122:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ipv6_addr_for_http_with_brackets[64];
data/miniupnpd-2.2.0/upnpglobalvars.c:158:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char random_url[RANDOM_URL_MAX_LEN] = "random";
data/miniupnpd-2.2.0/upnpglobalvars.h:156:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char ipv6_addr_for_http_with_brackets[64];
data/miniupnpd-2.2.0/upnphttp.c:53:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[256];
data/miniupnpd-2.2.0/upnphttp.c:244:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
h->req_contentlen = atoi(p);
data/miniupnpd-2.2.0/upnphttp.c:295:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->accept_language, p, n);
data/miniupnpd-2.2.0/upnphttp.c:355:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
h->req_Timeout = atoi(p+7);
data/miniupnpd-2.2.0/upnphttp.c:543:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addrstr[48];
data/miniupnpd-2.2.0/upnphttp.c:768:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char HttpCommand[16];
data/miniupnpd-2.2.0/upnphttp.c:769:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char HttpUrl[128];
data/miniupnpd-2.2.0/upnphttp.c:907:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[2048];
data/miniupnpd-2.2.0/upnphttp.c:969:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->req_buf + h->req_buflen, buf, n);
data/miniupnpd-2.2.0/upnphttp.c:1036:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->req_buf + h->req_buflen, buf, n);
data/miniupnpd-2.2.0/upnphttp.c:1106:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char http_date[64];
data/miniupnpd-2.2.0/upnphttp.c:1183:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->res_buf + h->res_buflen, body, bodylen);
data/miniupnpd-2.2.0/upnphttp.h:59:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char clientaddr_str[64]; /* used for syslog() output */
data/miniupnpd-2.2.0/upnphttp.h:61:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char HttpVer[16];
data/miniupnpd-2.2.0/upnphttp.h:64:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char accept_language[8];
data/miniupnpd-2.2.0/upnppermissions.c:59:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(p);
data/miniupnpd-2.2.0/upnppermissions.c:68:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(p);
data/miniupnpd-2.2.0/upnppermissions.c:78:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(p);
data/miniupnpd-2.2.0/upnppermissions.c:119:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
n_bits = atoi(p);
data/miniupnpd-2.2.0/upnppermissions.c:147:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(p);
data/miniupnpd-2.2.0/upnppermissions.c:156:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(p);
data/miniupnpd-2.2.0/upnppermissions.c:166:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(p);
data/miniupnpd-2.2.0/upnppermissions.c:192:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128];
data/miniupnpd-2.2.0/upnppinhole.c:161:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmd[256], cmd_raw[256], cuid[42];
data/miniupnpd-2.2.0/upnppinhole.c:177:6: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if(atoi(proto) == IPPROTO_UDPLITE)
data/miniupnpd-2.2.0/upnppinhole.c:192:6: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if(atoi(proto) == IPPROTO_UDPLITE)
data/miniupnpd-2.2.0/upnppinhole.c:217:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*uid = atoi(cuid);
data/miniupnpd-2.2.0/upnppinhole.c:337:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024], filename[] = "/var/log/kern.log", expire_time[32]="";
data/miniupnpd-2.2.0/upnppinhole.c:342:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = fopen(filename, "r");
data/miniupnpd-2.2.0/upnppinhole.c:365:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char time[15]="", src_addr[40], dst_addr[40], proto_tmp[8];
data/miniupnpd-2.2.0/upnppinhole.c:375:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
printf("\trule line = %d\n", atoi(line));
data/miniupnpd-2.2.0/upnppinhole.c:395:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
proto_int = atoi(protocol);
data/miniupnpd-2.2.0/upnppinhole.c:397:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(proto_tmp, "UDP");
data/miniupnpd-2.2.0/upnppinhole.c:399:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(proto_tmp, "TCP");
data/miniupnpd-2.2.0/upnppinhole.c:402:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(proto_tmp, "UDPLITE");
data/miniupnpd-2.2.0/upnppinhole.c:405:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(proto_tmp, "UnsupportedProto");
data/miniupnpd-2.2.0/upnppinhole.c:417:68: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
printf("\tCompare eport: %hu\n\t to port: %d\n", *eport, atoi(sport));
data/miniupnpd-2.2.0/upnppinhole.c:418:68: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
printf("\tCompare iport: %hu\n\t to port: %d\n", *iport, atoi(dport));
data/miniupnpd-2.2.0/upnppinhole.c:419:46: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if(/*eport != atoi(sport) &&*/ *iport != atoi(dport))
data/miniupnpd-2.2.0/upnppinhole.c:432:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*rulenum_used = atoi(line);
data/miniupnpd-2.2.0/upnppinhole.c:457:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char time[15], src_addr[40], dst_addr[40], proto_tmp[8];
data/miniupnpd-2.2.0/upnppinhole.c:467:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
printf("\trule line = %d\n", atoi(line));
data/miniupnpd-2.2.0/upnppinhole.c:487:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
proto_int = atoi(protocol);
data/miniupnpd-2.2.0/upnppinhole.c:489:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(proto_tmp, "UDP");
data/miniupnpd-2.2.0/upnppinhole.c:491:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(proto_tmp, "TCP");
data/miniupnpd-2.2.0/upnppinhole.c:494:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(proto_tmp, "UDPLITE");
data/miniupnpd-2.2.0/upnppinhole.c:497:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(proto_tmp, "UnsupportedProto");
data/miniupnpd-2.2.0/upnppinhole.c:508:68: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
printf("\tCompare eport: %hu\n\t to port: %d\n", *eport, atoi(sport));
data/miniupnpd-2.2.0/upnppinhole.c:509:68: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
printf("\tCompare iport: %hu\n\t to port: %d\n", *iport, atoi(dport));
data/miniupnpd-2.2.0/upnppinhole.c:510:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if(*eport != atoi(sport) && *iport != atoi(dport))
data/miniupnpd-2.2.0/upnppinhole.c:510:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if(*eport != atoi(sport) && *iport != atoi(dport))
data/miniupnpd-2.2.0/upnpredirect.c:106:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = fopen( lease_file, "a");
data/miniupnpd-2.2.0/upnpredirect.c:134:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[512];
data/miniupnpd-2.2.0/upnpredirect.c:135:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[32];
data/miniupnpd-2.2.0/upnpredirect.c:136:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmpfilename[128];
data/miniupnpd-2.2.0/upnpredirect.c:149:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = fopen( lease_file, "r");
data/miniupnpd-2.2.0/upnpredirect.c:157:8: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
tmp = mkstemp(tmpfilename);
data/miniupnpd-2.2.0/upnpredirect.c:204:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[128];
data/miniupnpd-2.2.0/upnpredirect.c:208:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = fopen( lease_file, "r");
data/miniupnpd-2.2.0/upnpredirect.c:236:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
eport = (unsigned short)atoi(p);
data/miniupnpd-2.2.0/upnpredirect.c:243:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
iport = (unsigned short)atoi(p);
data/miniupnpd-2.2.0/upnpredirect.c:305:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[32];
data/miniupnpd-2.2.0/upnpredirect.c:306:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/upnpredirect.c:307:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[40];
data/miniupnpd-2.2.0/upnpredirect.c:341:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr_old[32];
data/miniupnpd-2.2.0/upnpredirect.c:342:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost_old[32];
data/miniupnpd-2.2.0/upnpredirect.c:541:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(protocol, "TCP", 4);
data/miniupnpd-2.2.0/upnpredirect.c:544:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(protocol, "UDPLITE", 8);
data/miniupnpd-2.2.0/upnpredirect.c:547:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(protocol, "UDP", 4);
data/miniupnpd-2.2.0/upnpredirect.c:591:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char protocol[4], iaddr[32], desc[64], rhost[32];
data/miniupnpd-2.2.0/upnpredirect.c:707:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ifname[IFNAMSIZ];
data/miniupnpd-2.2.0/upnpredirect.c:763:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/upnpredirect.c:764:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[32];
data/miniupnpd-2.2.0/upnpredirect.c:765:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[32];
data/miniupnpd-2.2.0/upnpredirect.c:770:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[256];
data/miniupnpd-2.2.0/upnpreplyparse.c:23:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data->curelt, name, l);
data/miniupnpd-2.2.0/upnpreplyparse.c:59:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(nv->value, data->cdata, l);
data/miniupnpd-2.2.0/upnpreplyparse.c:92:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data->portListing, datas, l);
data/miniupnpd-2.2.0/upnpreplyparse.h:17:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[64];
data/miniupnpd-2.2.0/upnpreplyparse.h:18:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char value[128];
data/miniupnpd-2.2.0/upnpreplyparse.h:23:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char curelt[64];
data/miniupnpd-2.2.0/upnpsoap.c:66:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->res_buf + h->res_buflen, beforebody, sizeof(beforebody) - 1);
data/miniupnpd-2.2.0/upnpsoap.c:69:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->res_buf + h->res_buflen, body, bodylen);
data/miniupnpd-2.2.0/upnpsoap.c:72:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->res_buf + h->res_buflen, afterbody, sizeof(afterbody) - 1);
data/miniupnpd-2.2.0/upnpsoap.c:98:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:120:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:146:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:177:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:203:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:232:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[2048];
data/miniupnpd-2.2.0/upnpsoap.c:238:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ext_ip_addr[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/upnpsoap.c:270:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:304:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:329:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:331:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ext_ip_addr[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/upnpsoap.c:392:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:441:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&result_ip, &(h->clientaddr), sizeof(struct in_addr));
data/miniupnpd-2.2.0/upnpsoap.c:494:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
eport = (unsigned short)atoi(ext_port);
data/miniupnpd-2.2.0/upnpsoap.c:495:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
iport = (unsigned short)atoi(int_port);
data/miniupnpd-2.2.0/upnpsoap.c:504:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
leaseduration = leaseduration_str ? atoi(leaseduration_str) : 0;
data/miniupnpd-2.2.0/upnpsoap.c:584:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:608:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
leaseduration = leaseduration_str ? atoi(leaseduration_str) : 0;
data/miniupnpd-2.2.0/upnpsoap.c:619:61: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
eport = (0 == strcmp(ext_port, "*")) ? 0 : (unsigned short)atoi(ext_port);
data/miniupnpd-2.2.0/upnpsoap.c:623:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
iport = (unsigned short)atoi(int_port);
data/miniupnpd-2.2.0/upnpsoap.c:754:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[1024];
data/miniupnpd-2.2.0/upnpsoap.c:759:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char int_ip[32];
data/miniupnpd-2.2.0/upnpsoap.c:760:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/upnpsoap.c:789:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
eport = (unsigned short)atoi(ext_port);
data/miniupnpd-2.2.0/upnpsoap.c:841:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:878:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
eport = (unsigned short)atoi(ext_port);
data/miniupnpd-2.2.0/upnpsoap.c:895:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char int_ip[32];
data/miniupnpd-2.2.0/upnpsoap.c:947:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:968:30: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
startport = (unsigned short)atoi(startport_s);
data/miniupnpd-2.2.0/upnpsoap.c:969:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
endport = (unsigned short)atoi(endport_s);
data/miniupnpd-2.2.0/upnpsoap.c:1032:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char protocol[8], iaddr[32];
data/miniupnpd-2.2.0/upnpsoap.c:1033:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/upnpsoap.c:1034:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[40];
data/miniupnpd-2.2.0/upnpsoap.c:1080:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[2048];
data/miniupnpd-2.2.0/upnpsoap.c:1129:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char int_ip[32];
data/miniupnpd-2.2.0/upnpsoap.c:1130:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc[64];
data/miniupnpd-2.2.0/upnpsoap.c:1131:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rhost[64];
data/miniupnpd-2.2.0/upnpsoap.c:1158:30: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
startport = (unsigned short)atoi(startport_s);
data/miniupnpd-2.2.0/upnpsoap.c:1159:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
endport = (unsigned short)atoi(endport_s);
data/miniupnpd-2.2.0/upnpsoap.c:1161:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
number = atoi(number_s);
data/miniupnpd-2.2.0/upnpsoap.c:1205:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(body+bodylen, list_start, sizeof(list_start));
data/miniupnpd-2.2.0/upnpsoap.c:1260:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(body+bodylen, list_end, sizeof(list_end));
data/miniupnpd-2.2.0/upnpsoap.c:1282:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:1330:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[1024];
data/miniupnpd-2.2.0/upnpsoap.c:1401:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:1442:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strn[10];
data/miniupnpd-2.2.0/upnpsoap.c:1474:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:1506:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hostname[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/upnpsoap.c:1507:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char port_str[8], ifname[8], tmp[4];
data/miniupnpd-2.2.0/upnpsoap.c:1540:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp_host[256];
data/miniupnpd-2.2.0/upnpsoap.c:1541:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp_service[256];
data/miniupnpd-2.2.0/upnpsoap.c:1561:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char senderAddr[INET6_ADDRSTRLEN]="";
data/miniupnpd-2.2.0/upnpsoap.c:1642:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:1650:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rem_ip[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/upnpsoap.c:1663:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
rport = (unsigned short)(rem_port ? atoi(rem_port) : 0);
data/miniupnpd-2.2.0/upnpsoap.c:1664:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
iport = (unsigned short)(int_port ? atoi(int_port) : 0);
data/miniupnpd-2.2.0/upnpsoap.c:1665:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ltime = leaseTime ? atoi(leaseTime) : -1;
data/miniupnpd-2.2.0/upnpsoap.c:1744:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
&& atoi(protocol) != IPPROTO_UDPLITE
data/miniupnpd-2.2.0/upnpsoap.c:1814:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:1818:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/upnpsoap.c:1830:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
uid = uid_str ? atoi(uid_str) : -1;
data/miniupnpd-2.2.0/upnpsoap.c:1831:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ltime = leaseTime ? atoi(leaseTime) : -1;
data/miniupnpd-2.2.0/upnpsoap.c:1889:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:1917:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
rport = (unsigned short)atoi(rem_port);
data/miniupnpd-2.2.0/upnpsoap.c:1918:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
iport = (unsigned short)atoi(int_port);
data/miniupnpd-2.2.0/upnpsoap.c:1957:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:1962:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/upnpsoap.c:1973:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
uid = uid_str ? atoi(uid_str) : -1;
data/miniupnpd-2.2.0/upnpsoap.c:2028:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:2034:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/upnpsoap.c:2043:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
uid = uid_str ? atoi(uid_str) : -1;
data/miniupnpd-2.2.0/upnpsoap.c:2088:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/miniupnpd-2.2.0/upnpsoap.c:2093:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iaddr[INET6_ADDRSTRLEN];
data/miniupnpd-2.2.0/upnpsoap.c:2105:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
uid = uid_str ? atoi(uid_str) : -1;
data/miniupnpd-2.2.0/upnpsoap.c:2149:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[1024];
data/miniupnpd-2.2.0/upnpsoap.c:2190:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[1024];
data/miniupnpd-2.2.0/upnpsoap.c:2216:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[1024];
data/miniupnpd-2.2.0/upnpsoap.c:2311:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char namespace[256];
data/miniupnpd-2.2.0/upnpsoap.c:2386:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[2048];
data/miniupnpd-2.2.0/upnpstun.c:50:46: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static void generate_transaction_id(unsigned char transaction_id[12])
data/miniupnpd-2.2.0/upnpstun.c:59:35: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static void fill_request(unsigned char buffer[28], int change_ip, int change_port)
data/miniupnpd-2.2.0/upnpstun.c:105:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char service[6];
data/miniupnpd-2.2.0/upnpstun.c:130:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(sock_addr, rp->ai_addr, rp->ai_addrlen);
data/miniupnpd-2.2.0/upnpstun.c:143:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addr_str[48];
data/miniupnpd-2.2.0/upnpstun.c:193:54: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static size_t receive_stun_response(int fd, unsigned char *buffer, unsigned char transaction_id[12], size_t buffer_len, struct sockaddr_in *peer_addr)
data/miniupnpd-2.2.0/upnpstun.c:193:77: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static size_t receive_stun_response(int fd, unsigned char *buffer, unsigned char transaction_id[12], size_t buffer_len, struct sockaddr_in *peer_addr)
data/miniupnpd-2.2.0/upnpstun.c:231:57: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static int wait_for_stun_responses(int fds[4], unsigned char *transaction_ids[4], unsigned char *buffers[4], size_t buffers_lens[4], struct sockaddr_in peer_addrs[4], size_t lens[4])
data/miniupnpd-2.2.0/upnpstun.c:231:92: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static int wait_for_stun_responses(int fds[4], unsigned char *transaction_ids[4], unsigned char *buffers[4], size_t buffers_lens[4], struct sockaddr_in peer_addrs[4], size_t lens[4])
data/miniupnpd-2.2.0/upnpstun.c:404:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char responses_bufs[4][1024];
data/miniupnpd-2.2.0/upnpstun.c:405:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char *responses[4];
data/miniupnpd-2.2.0/upnpstun.c:407:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char requests[4][28];
data/miniupnpd-2.2.0/upnpstun.c:408:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char *transaction_ids[4];
data/miniupnpd-2.2.0/upnpstun.c:485:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ext_addr, &mapped_addrs[i].sin_addr, sizeof(*ext_addr));
data/miniupnpd-2.2.0/upnpstun.c:547:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[100];
data/miniupnpd-2.2.0/upnpstun.c:560:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[100];
data/miniupnpd-2.2.0/upnpstun.c:572:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[INET_ADDRSTRLEN];
data/miniupnpd-2.2.0/upnpstun.c:589:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ret = perform_stun(NULL, NULL, argv[1], atoi(argv[2]), &ext_addr, &restrictive_nat);
data/miniupnpd-2.2.0/upnputils.c:34:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[64];
data/miniupnpd-2.2.0/upnputils.c:49:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ifname[IF_NAMESIZE];
data/miniupnpd-2.2.0/upnputils.c:112:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dbg_str[64];
data/miniupnpd-2.2.0/upnputils.c:122:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&peer_addr, &peer6->sin6_addr.s6_addr[12], 4);
data/miniupnpd-2.2.0/bsd/getroute.c:81:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
l = read(s, &m_rtmsg, sizeof(m_rtmsg));
data/miniupnpd-2.2.0/daemonize.c:51:3: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(027);
data/miniupnpd-2.2.0/daemonize.c:113:5: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(read(pidfile, buffer, 63))
data/miniupnpd-2.2.0/getifaddr.c:50:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ifr.ifr_name, ifname, IFNAMSIZ-1);
data/miniupnpd-2.2.0/getifaddr.c:64:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ifr.ifr_name, ifname, IFNAMSIZ-1);
data/miniupnpd-2.2.0/getifaddr.c:85:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ifr.ifr_name, ifname, IFNAMSIZ-1);
data/miniupnpd-2.2.0/ipf/ipfrdr.c:150:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = strlen(desc) + 1;
data/miniupnpd-2.2.0/ipf/ipfrdr.c:191:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(desc, p->str, desclen);
data/miniupnpd-2.2.0/ipf/ipfrdr.c:279:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ipnat.in_namelen = strlen(ipnat.in_names) + 1;
data/miniupnpd-2.2.0/ipf/ipfrdr.c:608:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
fr.fr_namelen += strlen(ifname) + 1;
data/miniupnpd-2.2.0/ipf/ipfrdr.c:618:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
fr.fr_namelen += strlen(group_name) + 1;
data/miniupnpd-2.2.0/ipf/testipfrdr.c:60:6: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c = getchar();
data/miniupnpd-2.2.0/ipfw/ipfwaux.c:100:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(value);
data/miniupnpd-2.2.0/ipfw/ipfwrdr.c:104:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = strlen(desc) + 1;
data/miniupnpd-2.2.0/linux/getifstats.c:163:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(iwr.ifr_name, ifname, IFNAMSIZ);
data/miniupnpd-2.2.0/linux/ifacewatcher.c:148:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(lan_iface->iface.name, ifname, IFNAMSIZ);
data/miniupnpd-2.2.0/linux/ifacewatcher.c:320:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(address, tmp, sizeof(address));
data/miniupnpd-2.2.0/linux/ifacewatcher.c:323:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(tmp, RTA_DATA(rth), sizeof(tmp));
data/miniupnpd-2.2.0/linux/ifacewatcher.c:324:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ifname, tmp, sizeof(ifname));
data/miniupnpd-2.2.0/linux/ifacewatcher.c:335:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(tmp, "*unknown*", sizeof(tmp));
data/miniupnpd-2.2.0/minissdp.c:239:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(lan_addrs.lh_first->ifname)) < 0)
data/miniupnpd-2.2.0/minissdp.c:263:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(lan_addr->str) ? lan_addr->str : "NULL");
data/miniupnpd-2.2.0/minissdp.c:276:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(lan_addr->str) ? lan_addr->str : "NULL");
data/miniupnpd-2.2.0/minissdp.c:516:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
st_is_uuid = (st_len == (int)strlen(uuidvalue)) &&
data/miniupnpd-2.2.0/minissdp.c:1168:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = strlen(announced_host_buf);
data/miniupnpd-2.2.0/minissdp.c:1197:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = (int)strlen(known_service_types[i].s);
data/miniupnpd-2.2.0/minissdp.c:1265:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = (int)strlen(known_service_types[i].s);
data/miniupnpd-2.2.0/minissdp.c:1279:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
SendSSDPResponse(s, sender, uuidvalue_igd, strlen(uuidvalue_igd), "",
data/miniupnpd-2.2.0/minissdp.c:1288:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
SendSSDPResponse(s, sender, uuidvalue_wan, strlen(uuidvalue_wan), "",
data/miniupnpd-2.2.0/minissdp.c:1297:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
SendSSDPResponse(s, sender, uuidvalue_wcd, strlen(uuidvalue_wcd), "",
data/miniupnpd-2.2.0/minissdp.c:1305:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = (int)strlen(uuidvalue_igd);
data/miniupnpd-2.2.0/minissdp.c:1503:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(addr.sun_path, minissdpdsocketpath, sizeof(addr.sun_path));
data/miniupnpd-2.2.0/minissdp.c:1540:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = (int)strlen(MINIUPNPD_SERVER_STRING);
data/miniupnpd-2.2.0/miniupnpd.c:199:8: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
if (sscanf(s, "%3s %hu %31s %hu [%*[^]]] %u", proto, &eport, iaddr, &iport, ×tamp) >= 4)
data/miniupnpd-2.2.0/miniupnpd.c:251:8: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
if (sscanf(s, "%3s %hu", proto, &eport) == 2)
data/miniupnpd-2.2.0/miniupnpd.c:397:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(lan_addrs.lh_first->ifname)) < 0)
data/miniupnpd-2.2.0/miniupnpd.c:687:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(localun.sun_path, path,
data/miniupnpd-2.2.0/miniupnpd.c:1101:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(uuidvalue_igd);
data/miniupnpd-2.2.0/miniupnpd.c:1278:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(friendly_name, ary_options[i].value, FRIENDLY_NAME_MAX_LEN);
data/miniupnpd-2.2.0/miniupnpd.c:1282:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(manufacturer_name, ary_options[i].value, MANUFACTURER_NAME_MAX_LEN);
data/miniupnpd-2.2.0/miniupnpd.c:1286:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(manufacturer_url, ary_options[i].value, MANUFACTURER_URL_MAX_LEN);
data/miniupnpd-2.2.0/miniupnpd.c:1290:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(model_name, ary_options[i].value, MODEL_NAME_MAX_LEN);
data/miniupnpd-2.2.0/miniupnpd.c:1294:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(model_description, ary_options[i].value, MODEL_DESCRIPTION_MAX_LEN);
data/miniupnpd-2.2.0/miniupnpd.c:1298:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(model_url, ary_options[i].value, MODEL_URL_MAX_LEN);
data/miniupnpd-2.2.0/miniupnpd.c:1327:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(uuidvalue_igd+5, ary_options[i].value,
data/miniupnpd-2.2.0/miniupnpd.c:1328:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(uuidvalue_igd+5) + 1);
data/miniupnpd-2.2.0/miniupnpd.c:1332:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(serialnumber, ary_options[i].value, SERIALNUMBER_MAX_LEN);
data/miniupnpd-2.2.0/miniupnpd.c:1336:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(modelnumber, ary_options[i].value, MODELNUMBER_MAX_LEN);
data/miniupnpd-2.2.0/miniupnpd.c:1498:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(uuidvalue_igd+5, argv[++i], strlen(uuidvalue_igd+5) + 1);
data/miniupnpd-2.2.0/miniupnpd.c:1498:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(uuidvalue_igd+5, argv[++i], strlen(uuidvalue_igd+5) + 1);
data/miniupnpd-2.2.0/miniupnpd.c:1506:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(friendly_name, argv[++i], FRIENDLY_NAME_MAX_LEN);
data/miniupnpd-2.2.0/miniupnpd.c:1514:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(serialnumber, argv[++i], SERIALNUMBER_MAX_LEN);
data/miniupnpd-2.2.0/miniupnpd.c:1521:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(modelnumber, argv[++i], MODELNUMBER_MAX_LEN);
data/miniupnpd-2.2.0/miniupnpd.c:1673:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *val = calloc((strlen(argv[i+1]) + strlen(argv[i+2]) + 2), sizeof(char));
data/miniupnpd-2.2.0/miniupnpd.c:1673:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *val = calloc((strlen(argv[i+1]) + strlen(argv[i+2]) + 2), sizeof(char));
data/miniupnpd-2.2.0/miniupnpd.c:1822:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(presentationurl, presurl, PRESENTATIONURL_MAX_LEN);
data/miniupnpd-2.2.0/miniupnpd.c:2723:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
l = read(ectl->socket, buf, sizeof(buf));
data/miniupnpd-2.2.0/miniupnpdctl.c:46:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(addr.sun_path, "/var/run/miniupnpd.ctl",
data/miniupnpd-2.2.0/miniupnpdctl.c:64:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
l = read(s, buf, sizeof(buf));
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:90:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (string == NULL || strlen(string) > 30 || string[0] == '\0') {
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:197:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = strlen(desc) + 1;
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:245:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(desc, p->str, desclen);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:253:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(desc, "miniupnpd", desclen);
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:989:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(match->u.user.name, "tcp", sizeof(match->u.user.name));
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1018:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(match->u.user.name, "udp", sizeof(match->u.user.name));
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1049:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(target->u.user.name, "DNAT", sizeof(target->u.user.name));
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1073:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(target->u.user.name, "SNAT", sizeof(target->u.user.name));
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1096:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(target->u.user.name, "DSCP", sizeof(target->u.user.name));
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1116:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(target->u.user.name, "MASQUERADE", sizeof(target->u.user.name));
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1328:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(e->ip.outiface, extif, sizeof(e->ip.outiface));
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1329:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset(e->ip.outiface_mask, 0xff, strlen(e->ip.outiface) + 1);/* Include nul-terminator in match */
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1522:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(target->u.user.name, "ACCEPT", sizeof(target->u.user.name));
data/miniupnpd-2.2.0/netfilter/iptcrdr.c:1902:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(target->u.user.name, iptc_get_target(e, h), sizeof(target->u.user.name));
data/miniupnpd-2.2.0/netfilter/iptpinhole.c:73:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p = calloc(1, sizeof(struct pinhole_t) + strlen(desc) + 1);
data/miniupnpd-2.2.0/netfilter/iptpinhole.c:138:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(match->u.user.name, name, sizeof(match->u.user.name));
data/miniupnpd-2.2.0/netfilter/iptpinhole.c:163:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(target->u.user.name, "ACCEPT", sizeof(target->u.user.name));
data/miniupnpd-2.2.0/netfilter/iptpinhole.c:230:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(e->ipv6.iniface, ifname, IFNAMSIZ);
data/miniupnpd-2.2.0/netfilter/iptpinhole.c:299:13: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
if(desc) strncpy(desc, p->desc, desc_len);
data/miniupnpd-2.2.0/netfilter/iptpinhole.c:413:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(desc, p->desc, desclen);
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr.c:164:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (string == NULL || strlen(string) > 30 || string[0] == '\0') {
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr.c:499:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(desc, r->desc, desclen);
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr.c:614:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(desc, r->desc, desclen);
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr.c:675:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(desc, p->desc, desclen);
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:885:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
descr, strlen(descr));
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:963:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
descr, strlen(descr));
data/miniupnpd-2.2.0/netfilter_nft/nftnlrdr_misc.c:1108:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
descr, strlen(descr));
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:166:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(desc, pd, desc_len);
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:199:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(tmp_label, p->desc, p->desc_len);
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:250:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(tmp_label, p->desc, p->desc_len);
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:281:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(desc, tmp_p, NFT_DESCR_SIZE);
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:348:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(tmp_label, p->desc, p->desc_len);
data/miniupnpd-2.2.0/netfilter_nft/nftpinhole.c:385:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(desc, p->desc, desclen);
data/miniupnpd-2.2.0/options.c:159:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(name); /* length of the whole line excluding leading
data/miniupnpd-2.2.0/options.c:260:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(value) + 1; /* +1 for terminating '\0' */
data/miniupnpd-2.2.0/solaris/getifstats.c:32:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s = (char *)ifname + strlen(ifname);
data/miniupnpd-2.2.0/testupnpdescgen.c:54:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(buf, "1.2.3.4", len);
data/miniupnpd-2.2.0/upnpdescgen.c:811:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s2len = (int)strlen(s2);
data/miniupnpd-2.2.0/upnpdescgen.c:1014:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
* len = strlen(xmlver);
data/miniupnpd-2.2.0/upnpdescgen.c:1039:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*len = strlen(xmlver);
data/miniupnpd-2.2.0/upnpdescgen.c:1075:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
plen = strlen(p);
data/miniupnpd-2.2.0/upnpevents.c:139:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(uuid_str) != 36) {
data/miniupnpd-2.2.0/upnpevents.c:152:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(tmp->uuid, uuidvalue_igd, sizeof(tmp->uuid));
data/miniupnpd-2.2.0/upnpevents.c:159:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(tmp->uuid, uuidvalue_igd, sizeof(tmp->uuid));
data/miniupnpd-2.2.0/upnpevents.c:360:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = (int)strlen(obj->addrstr);
data/miniupnpd-2.2.0/upnphttp.c:828:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(HttpUrl[0] != '/' || memcmp(HttpUrl+1, random_url, strlen(random_url)) != 0)
data/miniupnpd-2.2.0/upnphttp.c:834:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p = HttpUrl + strlen(random_url) + 1;
data/miniupnpd-2.2.0/upnphttp.c:835:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memmove(HttpUrl, p, strlen(p) + 1);
data/miniupnpd-2.2.0/upnppinhole.c:367:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(time, buf, sizeof(time));
data/miniupnpd-2.2.0/upnppinhole.c:411:107: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( /*(strcmp(eaddr, src_addr) == 0) &&*/ (strcmp(iaddr, dst_addr) == 0) && (strncmp(proto_tmp, proto, strlen(proto_tmp))==0))
data/miniupnpd-2.2.0/upnppinhole.c:459:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(time, buf, sizeof(time));
data/miniupnpd-2.2.0/upnpredirect.c:142:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen( lease_file) + 7 > sizeof(tmpfilename)) {
data/miniupnpd-2.2.0/upnpredirect.c:155:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
str_size = strlen(str);
data/miniupnpd-2.2.0/upnpredirect.c:168:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf_size = strlen(buf);
data/miniupnpd-2.2.0/upnpreplyparse.c:55:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(nv->name, data->curelt, 64);
data/miniupnpd-2.2.0/upnpsoap.c:338:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ext_ip_addr, use_ext_ip_addr, INET_ADDRSTRLEN);
data/miniupnpd-2.2.0/upnpsoap.c:348:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(ext_ip_addr, "0.0.0.0", INET_ADDRSTRLEN);
data/miniupnpd-2.2.0/upnpsoap.c:351:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(ext_ip_addr, "0.0.0.0", INET_ADDRSTRLEN);
data/miniupnpd-2.2.0/upnpsoap.c:356:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(ext_ip_addr, "0.0.0.0", INET_ADDRSTRLEN);
data/miniupnpd-2.2.0/upnpsoap.c:362:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ext_ip_addr, lan_addr->ext_ip_str, INET_ADDRSTRLEN);
data/miniupnpd-2.2.0/upnpsoap.c:1524:3: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(ifname, "%");
data/miniupnpd-2.2.0/upnpsoap.c:2329:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(soapMethods[i].methodName);
data/miniupnpd-2.2.0/upnputils.c:51:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(ifname, "ERROR", sizeof(ifname));
ANALYSIS SUMMARY:
Hits = 738
Lines analyzed = 33170 in approximately 0.95 seconds (34897 lines/second)
Physical Source Lines of Code (SLOC) = 26951
Hits@level = [0] 1248 [1] 122 [2] 540 [3] 10 [4] 66 [5] 0
Hits@level+ = [0+] 1986 [1+] 738 [2+] 616 [3+] 76 [4+] 66 [5+] 0
Hits/KSLOC@level+ = [0+] 73.6893 [1+] 27.383 [2+] 22.8563 [3+] 2.81993 [4+] 2.44889 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.