Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.h
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/pathnames.h
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/domacro.c
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.h
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmdtab.c
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.h
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/sslapp.c
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/sslapp.h
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/ssl_port.h
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c
Examining data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h
Examining data/netkit-ftp-ssl-0.17.34+0.2/version.h
FINAL RESULTS:
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1096:8: [5] (race) chmod:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchmod( ) instead.
chmod(local, 0600) < 0) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:112:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(nu, name);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:324:10: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(typename, p->t_name);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:916:10: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(temp, _PATH_TMP);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1644:10: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
(void) strcat(shellnam, namep);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1652:4: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl(theshell, shellnam, "-c", arg, NULL);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1655:4: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl(theshell, shellnam, NULL);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1699:14: [4] (misc) getpass:
This function is obsolete and not portable. It was in SUSv2 but removed by
POSIX.2. What it does exactly varies considerably between systems,
particularly in where its prompt is displayed and where it gets its data
(e.g., /dev/tty, stdin, stderr, etc.). In addition, some implementations
overflow buffers. (CWE-676, CWE-120, CWE-20). Make the specific calls to do
exactly what you want. If you continue to use it, or write your own, be
sure to zero the password as soon as possible to avoid leaving the
cleartext password visible in the process' address space.
argv[2] = getpass("Password: "), argc++;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2034:8: [4] (misc) getpass:
This function is obsolete and not portable. It was in SUSv2 but removed by
POSIX.2. What it does exactly varies considerably between systems,
particularly in where its prompt is displayed and where it gets its data
(e.g., /dev/tty, stdin, stderr, etc.). In addition, some implementations
overflow buffers. (CWE-676, CWE-120, CWE-20). Make the specific calls to do
exactly what you want. If you continue to use it, or write your own, be
sure to zero the password as soon as possible to avoid leaving the
cleartext password visible in the process' address space.
ap = getpass("Account:");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:399:18: [4] (misc) getlogin:
It's often easy to fool getlogin. Sometimes it does not work at all,
because some program messed up the utmp file. Often, it gives only the
first 8 characters of the login name. The user currently logged in on the
controlling tty of our program need not be the user who started it. Avoid
getlogin() for security-related purposes (CWE-807). Use getpwuid(geteuid())
and extract the desired information instead.
char *myname = getlogin();
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:427:11: [4] (misc) getpass:
This function is obsolete and not portable. It was in SUSv2 but removed by
POSIX.2. What it does exactly varies considerably between systems,
particularly in where its prompt is displayed and where it gets its data
(e.g., /dev/tty, stdin, stderr, etc.). In addition, some implementations
overflow buffers. (CWE-676, CWE-120, CWE-20). Make the specific calls to do
exactly what you want. If you continue to use it, or write your own, be
sure to zero the password as soon as possible to avoid leaving the
cleartext password visible in the process' address space.
zacct = getpass("Account:");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:473:4: [4] (format) vprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vprintf(fmt, ap);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:488:2: [4] (format) vsprintf:
Potential format string problem (CWE-134). Make format string constant.
vsprintf(outputbuf,fmt,ap);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:497:2: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(cout, fmt, ap);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:736:9: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
fin = popen(local + 1, "r");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1073:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(local, W_OK) < 0) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1085:8: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
d = access(dir ? local : ".", W_OK);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1162:10: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
fout = popen(local + 1, "w");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1228:4: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(errbuf,"ftp: SSL_read DATA error %s\n",
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1700:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(errbuf,"ftp: SSL_connect DATA error %d - %s\n",
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1854:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(ntin, op->nti);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1857:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(ntout, op->nto);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1862:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(mapin, op->mi);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1865:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(mapout, op->mo);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:2037:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
d = access(cp ? local : ".", W_OK);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:2044:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(new, local);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:2058:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if ((d = access(new, F_OK)) < 0)
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:2261:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(errbuf,"ftp: SSL_connect %s",
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:2310:7: [4] (misc) getpass:
This function is obsolete and not portable. It was in SUSv2 but removed by
POSIX.2. What it does exactly varies considerably between systems,
particularly in where its prompt is displayed and where it gets its data
(e.g., /dev/tty, stdin, stderr, etc.). In addition, some implementations
overflow buffers. (CWE-676, CWE-120, CWE-20). Make the specific calls to do
exactly what you want. If you continue to use it, or write your own, be
sure to zero the password as soon as possible to avoid leaving the
cleartext password visible in the process' address space.
p = getpass("Password:");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:232:12: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(gpath, home);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:361:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(lm, pl);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:367:10: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
(void) strcat(restbuf, pe + 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:686:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ep, cp);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:687:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(ep, dp);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:748:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(homedir, pp->pw_dir);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:384:7: [4] (misc) getlogin:
It's often easy to fool getlogin. Sometimes it does not work at all,
because some program messed up the utmp file. Often, it gives only the
first 8 characters of the login name. The user currently logged in on the
controlling tty of our program need not be the user who started it. Avoid
getlogin() for security-related purposes (CWE-807). Use getpwuid(geteuid())
and extract the desired information instead.
cp = getlogin();
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1635:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
theshell = getenv("SHELL");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:370:22: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
rl_terminal_name = getenv("TERM");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:88:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
hdir = getenv("HOME");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/sslapp.c:144:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
p=getenv("SSL_CIPHER");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:255:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(argv[2]);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:270:10: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
(void) strcpy(typename, "ascii"), type = TYPE_A;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:272:10: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
(void) strcpy(formname, "non-print"), form = FORM_N;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:273:10: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
(void) strcpy(modename, "stream"), mode = MODE_S;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:274:10: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
(void) strcpy(structname, "file"), stru = STRU_F;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:535:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *cp, *tp2, tmpbuf[PATH_MAX];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:809:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *cp, *tp, *tp2, tmpbuf[PATH_MAX];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:880:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[PATH_MAX];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:908:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char temp[16] = "";
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:934:8: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
fd = mkstemp(temp);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1068:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[MAXPATHLEN], dotdot[MAXPATHLEN];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1364:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
val = atoi(argv[1]);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1408:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1433:25: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
if (errno==ERANGE) strcpy(buf, "<too long>");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1434:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
else strcpy(buf, "???");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1526:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char foo[2] = "-";
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1625:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char shellnam[40];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1680:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char theacct[80];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1942:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char lyne[BUFSIZ];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2021:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128], *ap;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2168:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char new[PATH_MAX];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2228:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char new[PATH_MAX];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2230:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *tp[9], *te[9];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2658:10: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
(void) strcpy(typename, "binary");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/domacro.c:55:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, s, slen);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:89:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char ipstring[INET6_ADDRSTRLEN]; /* Scribble area for resolver. */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:154:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char hostnamebuf[256];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:180:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&hisctladdr, aiptr->ai_addr, aiptr->ai_addrlen);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:252:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&hisctladdr, aiptr->ai_addr,
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:386:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[80];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:464:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char outputbuf[2048]; /* allow for a 2k command string */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:489:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(outputbuf,"\r\n");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:526:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char reply_string[BUFSIZ]; /* last line of previous reply */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:540:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[16];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:558:6: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf,
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:573:6: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf, "%c%c%c", IAC, WONT, c);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:693:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZ], *bufp;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:747:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fin = fopen(local, "r");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1172:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fout = fopen(local, lmode);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1226:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char errbuf[1024];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1695:24: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char errbuf[1024];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1784:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[MAXHOSTNAMELEN];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1796:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char nti[17];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1797:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char nto[17];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1799:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mi[MAXPATHLEN];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1800:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mo[MAXPATHLEN];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:2030:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char new[MAXPATHLEN];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:2075:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZ];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:2254:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char errbuf[1024];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:2343:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char putc_buf[BUFSIZ];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h:104:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
Extern char pasv[64]; /* passive port for proxy data connection */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h:107:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
Extern char ntin[17]; /* input translation table */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h:108:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
Extern char ntout[17]; /* output translation table */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h:109:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
Extern char mapin[MAXPATHLEN]; /* input map template */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h:110:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
Extern char mapout[MAXPATHLEN]; /* output map template */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h:111:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
Extern char typename[32]; /* name of file transfer type */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h:114:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
Extern char structname[32]; /* name of file transfer structure */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h:116:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
Extern char formname[32]; /* name of file transfer format */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h:118:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
Extern char modename[32]; /* name of file transfer mode */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h:120:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
Extern char bytename[32]; /* local byte size in ascii */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h:158:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mac_name[9]; /* macro name */
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp_var.h:165:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
Extern char macbuf[4096];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:117:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char agpath[BUFSIZ];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:312:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char restbuf[BUFSIZ + 2];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:234:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char homedir[MAXPATHLEN];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:335:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ssl_verify_flag=atoi(optarg+strlen("verify="));
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:62:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char tokval[100];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:82:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZ], *tmp;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:83:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char myname[MAXHOSTNAMELEN];
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:92:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
cfile = fopen(buf, "r");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:108:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nu = obstack_alloc(&mainobstack, strlen(name)+3);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:110:2: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(nu, ".");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:111:20: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
if (*name != '/') strcat(nu, "/");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:125:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(name)+1;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:163:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
unsigned len = strlen(line);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:275:10: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
(void) strcpy(bytename, "8"), bytesize = 8;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:932:14: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
oldumask = umask(077);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:936:3: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(oldumask);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1643:10: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
(void) strcpy(shellnam,"-");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1819:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
obstack_grow(&mainobstack, initial, strlen(initial));
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1821:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
obstack_grow(&mainobstack, argv[1], strlen(argv[1]));
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:1824:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
obstack_grow(&mainobstack, argv[i], strlen(argv[i]));
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2012:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
rv = obstack_copy0(&mainobstack, rv, strlen(rv));
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2028:4: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(buf, *argv, sizeof(buf)-strlen(buf));
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2028:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncat(buf, *argv, sizeof(buf)-strlen(buf));
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2155:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(ntin, argv[1], 16);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2161:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(ntout, argv[2], 16);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2217:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(mapin, altarg, sizeof(mapin) - 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2220:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(mapout, cp, sizeof(mapout) - 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2461:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(macros[macnum].mac_name, argv[1], 8);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2472:12: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((c = getchar()) == EOF) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2493:15: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c = getchar()) != '\n' && c != EOF)
data/netkit-ftp-ssl-0.17.34+0.2/ftp/cmds.c:2495:19: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (c == EOF || getchar() == '\n') {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/domacro.c:50:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t slen = strlen(s);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/domacro.c:94:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(cp1) + 1;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:181:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(hostnamebuf, aiptr->ai_canonname,
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:415:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n = strlen(tmp);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:491:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
SSL_write(ssl_con,outputbuf,strlen(outputbuf));
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:847:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c = read(fileno(fin), buf, sizeof (buf))) > 0) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:896:15: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c = getc(fin)) != EOF) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1241:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c = read(fileno(din), buf, bufsize)) > 0) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1291:15: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((ch = getc(fout)) == EOF)
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1823:10: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(ip->name, hostname, sizeof(ip->name) - 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1852:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(ip->nti, ntin, sizeof(ip->nti) - 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1855:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(ip->nto, ntout, sizeof(ip->nto) - 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1860:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(ip->mi, mapin, sizeof(ip->mi) - 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:1863:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(ip->mo, mapout, sizeof(ip->mo) - 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:2045:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cp = new + strlen(new);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ftp.c:2108:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while (read(fileno(din), buf, BUFSIZ) > 0)
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:229:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memmove(gpath, gpath+1, strlen(gpath+1)+1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:364:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(lm, pl, pm-pl);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:572:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(s1) + strlen(s2) + 1;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:572:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(s1) + strlen(s2) + 1;
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:683:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *ep = malloc(strlen(cp) + strlen(dp) + 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:683:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *ep = malloc(strlen(cp) + strlen(dp) + 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/glob.c:746:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!pp || homedir + strlen(pp->pw_dir) >= lastgpathp)
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:334:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp(optarg, "verify=", strlen("verify=")) == 0 ) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:335:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ssl_verify_flag=atoi(optarg+strlen("verify="));
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:337:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp(optarg, "cert=", strlen("cert=")) == 0 ) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:338:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
my_ssl_cert_file=optarg+strlen("cert=");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:340:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp(optarg, "cacert=", strlen("cacert=")) == 0 ) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:341:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
my_ssl_cacert_file=optarg+strlen("cacert=");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:343:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp(optarg, "cipher=", strlen("cipher=")) == 0 ) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:344:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ssl_cipher_list=optarg+strlen("cipher=");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:346:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp(optarg, "key=", strlen("key=")) == 0 ) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:347:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
my_ssl_key_file=optarg+strlen("key=");
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:391:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(homedir, pw->pw_dir, sizeof(homedir));
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:542:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(lineread);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:593:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = strlen(line);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:680:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
argbuf = obstack_alloc(&mainobstack, strlen(line) + 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:844:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(c->c_name);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:861:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (k=0; k < strlen(c->c_name); k++) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/main.c:869:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
w = strlen(c->c_name);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:140:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*aname = obstack_copy(&mainobstack, tokval, strlen(tokval) + 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:160:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*apass = obstack_copy(&mainobstack, tokval, strlen(tokval) + 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:171:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*aacct = obstack_copy(&mainobstack, tokval, strlen(tokval) + 1);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:179:14: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c=getc(cfile)) != EOF && (c == ' ' || c == '\t'));
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:190:26: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
for (i=0; i < 8 && (c=getc(cfile)) != EOF &&
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:200:15: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c=getc(cfile)) != EOF && c != '\n');
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:214:12: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((c=getc(cfile)) == EOF) {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:257:14: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c = getc(cfile)) != EOF &&
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:264:15: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c = getc(cfile)) != EOF && c != '"') {
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:266:9: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c = getc(cfile);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:271:15: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c = getc(cfile)) != EOF
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ruserpass.c:274:9: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c = getc(cfile);
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ssl_port.h:71:95: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
#define GETC(X) (ssl_active_flag && (((X)==cin)||((X)==cout)) ? ssl_getc(ssl_con) : getc((X)) )
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ssl_port.h:73:119: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
#define DATAGETC(X) (ssl_data_active_flag && ((fileno(X)==data)||(fileno(X)==pdata)) ? ssl_getc(ssl_data_con) : getc((X)) )
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ssl_port.h:79:27: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
#define GETC(X) getc((X))
data/netkit-ftp-ssl-0.17.34+0.2/ftp/ssl_port.h:80:27: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
#define DATAGETC(X) getc((X))
data/netkit-ftp-ssl-0.17.34+0.2/ftp/sslapp.c:244:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(id_ctx));
ANALYSIS SUMMARY:
Hits = 190
Lines analyzed = 8202 in approximately 0.26 seconds (31418 lines/second)
Physical Source Lines of Code (SLOC) = 6619
Hits@level = [0] 267 [1] 80 [2] 70 [3] 4 [4] 35 [5] 1
Hits@level+ = [0+] 457 [1+] 190 [2+] 110 [3+] 40 [4+] 36 [5+] 1
Hits/KSLOC@level+ = [0+] 69.0437 [1+] 28.7052 [2+] 16.6188 [3+] 6.04321 [4+] 5.43889 [5+] 0.15108
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.