Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/netkit-ntalk-0.17/talk/ctl.c
Examining data/netkit-ntalk-0.17/talk/display.c
Examining data/netkit-ntalk-0.17/talk/get_addrs.c
Examining data/netkit-ntalk-0.17/talk/get_names.c
Examining data/netkit-ntalk-0.17/talk/init_disp.c
Examining data/netkit-ntalk-0.17/talk/invite.c
Examining data/netkit-ntalk-0.17/talk/io.c
Examining data/netkit-ntalk-0.17/talk/look_up.c
Examining data/netkit-ntalk-0.17/talk/msgs.c
Examining data/netkit-ntalk-0.17/talk/talk.c
Examining data/netkit-ntalk-0.17/talk/convert.c
Examining data/netkit-ntalk-0.17/talk/ctl_transact.c
Examining data/netkit-ntalk-0.17/talk/talk.h
Examining data/netkit-ntalk-0.17/version.h
Examining data/netkit-ntalk-0.17/include/prot_talkd.h
Examining data/netkit-ntalk-0.17/talkd/print.c
Examining data/netkit-ntalk-0.17/talkd/process.c
Examining data/netkit-ntalk-0.17/talkd/proto.h
Examining data/netkit-ntalk-0.17/talkd/repairs.c
Examining data/netkit-ntalk-0.17/talkd/announce.c
Examining data/netkit-ntalk-0.17/talkd/table.c
Examining data/netkit-ntalk-0.17/talkd/talkd.c
FINAL RESULTS:
data/netkit-ntalk-0.17/talk/get_names.c:70:17: [4] (misc) getlogin:
It's often easy to fool getlogin. Sometimes it does not work at all,
because some program messed up the utmp file. Often, it gives only the
first 8 characters of the login name. The user currently logged in on the
controlling tty of our program need not be the user who started it. Avoid
getlogin() for security-related purposes (CWE-807). Use getpwuid(geteuid())
and extract the desired information instead.
if ((my_name = getlogin()) == NULL || my_name[0] == 0) {
data/netkit-ntalk-0.17/talkd/announce.c:164:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(full_tty, F_OK) != 0)
data/netkit-ntalk-0.17/talkd/print.c:178:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buf, sizeof(buf), format, ap);
data/netkit-ntalk-0.17/talkd/process.c:148:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(besttty, uptr->ut_line);
data/netkit-ntalk-0.17/talkd/process.c:152:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(tty, besttty);
data/netkit-ntalk-0.17/talk/display.c:304:21: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *foo = getenv("LC_CTYPE");
data/netkit-ntalk-0.17/talkd/talkd.c:353:15: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((ch = getopt(argc, argv, "dpq"))!=-1) {
data/netkit-ntalk-0.17/include/prot_talkd.h:86:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char l_name[NAME_SIZE];/* caller's name */
data/netkit-ntalk-0.17/include/prot_talkd.h:87:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char r_name[NAME_SIZE];/* callee's name */
data/netkit-ntalk-0.17/include/prot_talkd.h:88:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char r_tty[TTY_SIZE];/* callee's tty name */
data/netkit-ntalk-0.17/talk/convert.c:31:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&(msg_S->addr), &(msg->addr), sizeof(msg_S->addr));
data/netkit-ntalk-0.17/talk/convert.c:34:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&(msg_S->ctl_addr), &(msg->ctl_addr), sizeof(msg_S->ctl_addr));
data/netkit-ntalk-0.17/talk/convert.c:44:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&(resp->addr), &(resp_S->addr), sizeof(resp->addr));
data/netkit-ntalk-0.17/talk/display.c:581:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msgbuf[256];
data/netkit-ntalk-0.17/talk/get_addrs.c:68:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&his_machine_addr, hp->h_addr, hp->h_length);
data/netkit-ntalk-0.17/talk/get_names.c:55:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hostname[MAXHOSTNAMELEN];
data/netkit-ntalk-0.17/talk/init_disp.c:79:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[3];
data/netkit-ntalk-0.17/talk/io.c:62:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[BUFSIZ];
data/netkit-ntalk-0.17/talk/talk.h:58:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char l_name[NAME_SIZE_S];/* caller's name */
data/netkit-ntalk-0.17/talk/talk.h:59:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char r_name[NAME_SIZE_S];/* callee's name */
data/netkit-ntalk-0.17/talk/talk.h:63:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char r_tty[TTY_SIZE];/* callee's tty name */
data/netkit-ntalk-0.17/talkd/announce.c:96:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line_buf[N_LINES][N_CHARS];
data/netkit-ntalk-0.17/talkd/announce.c:98:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char big_buf[N_LINES*(N_CHARS+2)+16];
data/netkit-ntalk-0.17/talkd/announce.c:158:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char full_tty[32];
data/netkit-ntalk-0.17/talkd/announce.c:166:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(full_tty, O_WRONLY|O_NOCTTY);
data/netkit-ntalk-0.17/talkd/print.c:63:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char *types[NTYPES] = {
data/netkit-ntalk-0.17/talkd/print.c:71:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char *answers[NANSWERS] = {
data/netkit-ntalk-0.17/talkd/print.c:94:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
logfd = open(file, O_WRONLY|O_APPEND);
data/netkit-ntalk-0.17/talkd/print.c:102:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
packfd = open(file, O_WRONLY|O_APPEND);
data/netkit-ntalk-0.17/talkd/print.c:113:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char rv[80];
data/netkit-ntalk-0.17/talkd/print.c:124:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char rv[80];
data/netkit-ntalk-0.17/talkd/print.c:135:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char lu[NAME_SIZE+1], ru[NAME_SIZE+1], tt[TTY_SIZE+1];
data/netkit-ntalk-0.17/talkd/print.c:136:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/netkit-ntalk-0.17/talkd/print.c:157:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/netkit-ntalk-0.17/talkd/print.c:173:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/netkit-ntalk-0.17/talkd/print.c:187:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[4], buf[128];
data/netkit-ntalk-0.17/talkd/process.c:81:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char nametmp1[UT_NAMESIZE+NAME_SIZE+1];
data/netkit-ntalk-0.17/talkd/process.c:82:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char nametmp2[UT_NAMESIZE+NAME_SIZE+1];
data/netkit-ntalk-0.17/talkd/process.c:122:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char besttty[PATH_MAX];
data/netkit-ntalk-0.17/talkd/repairs.c:114:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char l_name[OLD_NAME_SIZE];
data/netkit-ntalk-0.17/talkd/repairs.c:115:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char r_name[OLD_NAME_SIZE];
data/netkit-ntalk-0.17/talkd/repairs.c:119:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char r_tty[TTY_SIZE];
data/netkit-ntalk-0.17/talkd/repairs.c:156:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&otp, buf, len);
data/netkit-ntalk-0.17/talkd/repairs.c:208:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(m.l_name, otp.l_name, OLD_NAME_SIZE);
data/netkit-ntalk-0.17/talkd/repairs.c:210:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(m.r_name, otp.r_name, OLD_NAME_SIZE);
data/netkit-ntalk-0.17/talkd/repairs.c:212:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(m.r_tty, otp.r_tty, TTY_SIZE);
data/netkit-ntalk-0.17/talkd/repairs.c:214:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, &m, sizeof(m));
data/netkit-ntalk-0.17/talkd/repairs.c:236:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, &or, sizeof(or));
data/netkit-ntalk-0.17/talkd/talkd.c:77:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ourhostname[MAXHOSTNAMELEN];
data/netkit-ntalk-0.17/talkd/talkd.c:126:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[2*sizeof(CTL_RESPONSE)];
data/netkit-ntalk-0.17/talkd/talkd.c:130:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, response, sz);
data/netkit-ntalk-0.17/talkd/talkd.c:165:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char inbuf[2*sizeof(CTL_MSG)];
data/netkit-ntalk-0.17/talkd/talkd.c:169:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char theirhost[MAXHOSTNAMELEN];
data/netkit-ntalk-0.17/talk/convert.c:22:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (msg_S->l_name, msg->l_name, NAME_SIZE_S);
data/netkit-ntalk-0.17/talk/convert.c:24:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (msg_S->r_name, msg->r_name, NAME_SIZE_S);
data/netkit-ntalk-0.17/talk/convert.c:29:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (msg_S->r_tty, msg->r_tty, TTY_SIZE);
data/netkit-ntalk-0.17/talk/display.c:547:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
width = 2 + strlen(string) + strlen(string2) + 2;
data/netkit-ntalk-0.17/talk/display.c:547:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
width = 2 + strlen(string) + strlen(string2) + 2;
data/netkit-ntalk-0.17/talk/get_names.c:110:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg.l_name, my_name, NAME_SIZE);
data/netkit-ntalk-0.17/talk/get_names.c:112:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg.r_name, his_name, NAME_SIZE);
data/netkit-ntalk-0.17/talk/get_names.c:114:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg.r_tty, his_tty, TTY_SIZE);
data/netkit-ntalk-0.17/talk/init_disp.c:102:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
cc = read(sockt, buf, sizeof(buf));
data/netkit-ntalk-0.17/talk/io.c:88:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
nb = read(sockt, buf, sizeof(buf));
data/netkit-ntalk-0.17/talkd/announce.c:109:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sizes[i] = strlen(line_buf[i]);
data/netkit-ntalk-0.17/talkd/announce.c:115:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sizes[i] = strlen(line_buf[i]);
data/netkit-ntalk-0.17/talkd/announce.c:120:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sizes[i] = strlen(line_buf[i]);
data/netkit-ntalk-0.17/talkd/announce.c:125:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sizes[i] = strlen(line_buf[i]);
data/netkit-ntalk-0.17/talkd/announce.c:129:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sizes[i] = strlen(line_buf[i]);
data/netkit-ntalk-0.17/talkd/announce.c:148:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(fd, big_buf, strlen(big_buf));
data/netkit-ntalk-0.17/talkd/print.c:141:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(lu, mp->l_name, sizeof(lu));
data/netkit-ntalk-0.17/talkd/print.c:142:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ru, mp->r_name, sizeof(ru));
data/netkit-ntalk-0.17/talkd/print.c:143:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(tt, mp->r_tty, sizeof(tt));
data/netkit-ntalk-0.17/talkd/print.c:151:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(logfd, buf, strlen(buf));
data/netkit-ntalk-0.17/talkd/print.c:167:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(logfd, buf, strlen(buf));
data/netkit-ntalk-0.17/talkd/print.c:180:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(logfd, buf, strlen(buf));
data/netkit-ntalk-0.17/talkd/print.c:191:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(packfd, buf, strlen(buf));
data/netkit-ntalk-0.17/talkd/print.c:195:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(packfd, tmp, strlen(tmp));
data/netkit-ntalk-0.17/talkd/process.c:84:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(nametmp1, name, NAME_SIZE);
data/netkit-ntalk-0.17/talkd/process.c:85:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(nametmp2, ut->ut_name, UT_NAMESIZE);
data/netkit-ntalk-0.17/talkd/talkd.c:246:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(theirhost, eval_hostinfo(request.client), sizeof(theirhost));
ANALYSIS SUMMARY:
Hits = 80
Lines analyzed = 3796 in approximately 0.18 seconds (21634 lines/second)
Physical Source Lines of Code (SLOC) = 2228
Hits@level = [0] 49 [1] 27 [2] 46 [3] 2 [4] 5 [5] 0
Hits@level+ = [0+] 129 [1+] 80 [2+] 53 [3+] 7 [4+] 5 [5+] 0
Hits/KSLOC@level+ = [0+] 57.8995 [1+] 35.9066 [2+] 23.7882 [3+] 3.14183 [4+] 2.24417 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.