Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/netrw-1.3.2/src/getopt.c
Examining data/netrw-1.3.2/src/keepalive.c
Examining data/netrw-1.3.2/src/snprintf.h
Examining data/netrw-1.3.2/src/common.c
Examining data/netrw-1.3.2/src/vsnprintf.h
Examining data/netrw-1.3.2/src/proto.h
Examining data/netrw-1.3.2/src/proto_types.h
Examining data/netrw-1.3.2/src/checksum.c
Examining data/netrw-1.3.2/src/checksum.h
Examining data/netrw-1.3.2/src/progress.h
Examining data/netrw-1.3.2/src/progress.c
Examining data/netrw-1.3.2/src/checksum_proto.h
Examining data/netrw-1.3.2/src/netwrite.c
Examining data/netrw-1.3.2/src/net.c
Examining data/netrw-1.3.2/src/vsnprintf.c
Examining data/netrw-1.3.2/src/common.h
Examining data/netrw-1.3.2/src/md5.h
Examining data/netrw-1.3.2/src/getopt1.c
Examining data/netrw-1.3.2/src/net.h
Examining data/netrw-1.3.2/src/keepalive.h
Examining data/netrw-1.3.2/src/getopt.h
Examining data/netrw-1.3.2/src/md5.c
Examining data/netrw-1.3.2/src/netread.c
Examining data/netrw-1.3.2/src/snprintf.c
Examining data/netrw-1.3.2/src/proto.c
FINAL RESULTS:
data/netrw-1.3.2/src/common.c:83:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, msg, args);
data/netrw-1.3.2/src/net.c:704:11: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
len = vsnprintf(w_tmp, BUFFSIZE, fmt, args);
data/netrw-1.3.2/src/netread.c:69:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr,
data/netrw-1.3.2/src/netwrite.c:70:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr,
data/netrw-1.3.2/src/proto.c:158:15: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
len = snprintf(str, STRLEN, PROTO_REQ_PARAMS ":");
data/netrw-1.3.2/src/proto.c:162:20: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
len += snprintf(str + len, STRLEN - len, " " PAR_STR_CHECKSUM);
data/netrw-1.3.2/src/proto.c:167:20: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
len += snprintf(str + len, STRLEN - len, " " PAR_STR_KEEPALIVE);
data/netrw-1.3.2/src/proto.c:180:15: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
len = snprintf(str, STRLEN, PAR_STR_CHECKSUM ":");
data/netrw-1.3.2/src/snprintf.c:33:5: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int snprintf(char *str, size_t size, const char *format, ...)
data/netrw-1.3.2/src/snprintf.c:39:11: [4] (format) vsprintf:
Potential format string problem (CWE-134). Make format string constant.
ret = vsprintf(str, format, args);
data/netrw-1.3.2/src/snprintf.h:31:5: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int snprintf(char *str, size_t size, const char *format, ...);
data/netrw-1.3.2/src/vsnprintf.c:31:5: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int vsnprintf(char *str, size_t size, const char *format, va_list ap)
data/netrw-1.3.2/src/vsnprintf.c:33:12: [4] (format) vsprintf:
Potential format string problem (CWE-134). Make format string constant.
return vsprintf(str, format, ap);
data/netrw-1.3.2/src/vsnprintf.h:34:5: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int vsnprintf(char *str, size_t size, const char *format, va_list ap);
data/netrw-1.3.2/src/getopt.c:214:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
#ifndef getenv
data/netrw-1.3.2/src/getopt.c:215:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
extern char *getenv ();
data/netrw-1.3.2/src/getopt.c:400:21: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
posixly_correct = getenv ("POSIXLY_CORRECT");
data/netrw-1.3.2/src/getopt.c:1169:1: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
getopt (argc, argv, optstring)
data/netrw-1.3.2/src/getopt.c:1199:11: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt (argc, argv, "abc:d:0123456789");
data/netrw-1.3.2/src/getopt.h:145:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt (int ___argc, char *const *___argv, const char *__shortopts);
data/netrw-1.3.2/src/getopt.h:147:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt ();
data/netrw-1.3.2/src/getopt.h:151:12: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt_long (int ___argc, char *const *___argv,
data/netrw-1.3.2/src/getopt.h:165:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt ();
data/netrw-1.3.2/src/getopt.h:167:12: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt_long ();
data/netrw-1.3.2/src/getopt1.c:67:1: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
getopt_long (argc, argv, options, long_options, opt_index)
data/netrw-1.3.2/src/getopt1.c:123:11: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt_long (argc, argv, "abc:d:0123456789",
data/netrw-1.3.2/src/netread.c:118:19: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((opt = getopt(argc - udp, argv + udp, "f:o:s"
data/netrw-1.3.2/src/netwrite.c:115:19: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((opt = getopt(argc - udp, argv + udp, "fi:"
data/netrw-1.3.2/src/checksum.c:46:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char HEXDIGIT[16] = "0123456789abcdef";
data/netrw-1.3.2/src/checksum.c:71:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char checksum[MAX_LEN + 1];
data/netrw-1.3.2/src/checksum.c:72:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char remote_sum[MAX_LEN + 1];
data/netrw-1.3.2/src/checksum.c:109:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char checksum[MAX_LEN + 1];
data/netrw-1.3.2/src/checksum.c:110:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char remote_sum[MAX_LEN + 1];
data/netrw-1.3.2/src/checksum.c:127:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char hash[EVP_MAX_MD_SIZE];
data/netrw-1.3.2/src/checksum.c:143:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char checksum[SUM_LEN + 1];
data/netrw-1.3.2/src/checksum.c:144:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char remote_sum[SUM_LEN + 1];
data/netrw-1.3.2/src/checksum.c:153:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char checksum[SUM_LEN + 1];
data/netrw-1.3.2/src/checksum.c:154:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char remote_sum[SUM_LEN + 1];
data/netrw-1.3.2/src/checksum.c:198:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char sig[MD5_SIZE];
data/netrw-1.3.2/src/checksum.c:203:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char sig[MD5_SIZE];
data/netrw-1.3.2/src/checksum.c:214:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char header[100];
data/netrw-1.3.2/src/md5.c:33:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char HEXDIGIT[16] = "0123456789abcdef";
data/netrw-1.3.2/src/md5.c:96:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, buf, len);
data/netrw-1.3.2/src/md5.c:99:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, buf, t);
data/netrw-1.3.2/src/md5.c:108:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ctx->in, buf, 64);
data/netrw-1.3.2/src/md5.c:117:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ctx->in, buf, len);
data/netrw-1.3.2/src/md5.c:163:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(digest, ctx->buf, 16);
data/netrw-1.3.2/src/md5.h:15:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char in[64];
data/netrw-1.3.2/src/net.c:677:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(w_buf + w_buflen, line, len);
data/netrw-1.3.2/src/netread.c:101:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFFSIZE];
data/netrw-1.3.2/src/netread.c:153:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
(fd = open(file, O_WRONLY | O_CREAT | O_TRUNC | sync, 0666)) == -1) {
data/netrw-1.3.2/src/netwrite.c:99:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFFSIZE];
data/netrw-1.3.2/src/netwrite.c:143:31: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (file != NULL && (fd = open(file, O_RDONLY)) == -1) {
data/netrw-1.3.2/src/progress.h:47:29: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
progress_hash_after(atoi(optarg) * 1024 * 1024); \
data/netrw-1.3.2/src/progress.h:50:29: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
progress_hash_after(atoi(optarg) * 1024); \
data/netrw-1.3.2/src/proto.c:63:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char str[STRLEN];
data/netrw-1.3.2/src/checksum.c:235:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
|| strlen(++line) != SUM_LEN) {
data/netrw-1.3.2/src/checksum.c:240:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(remote_sum, line, SUM_LEN);
data/netrw-1.3.2/src/common.c:117:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(header);
data/netrw-1.3.2/src/common.c:120:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
|| strlen(*line) <= len
data/netrw-1.3.2/src/getopt.c:237:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
# if (!defined __STDC__ || !__STDC__) && !defined strlen
data/netrw-1.3.2/src/getopt.c:240:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
extern int strlen (const char *);
data/netrw-1.3.2/src/getopt.c:431:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = nonoption_flags_max_len = strlen (orig_str);
data/netrw-1.3.2/src/getopt.c:659:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
== (unsigned int) strlen (p->name))
data/netrw-1.3.2/src/getopt.c:702:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/netrw-1.3.2/src/getopt.c:764:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/netrw-1.3.2/src/getopt.c:797:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/netrw-1.3.2/src/getopt.c:802:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/netrw-1.3.2/src/getopt.c:979:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((unsigned int) (nameend - nextchar) == strlen (p->name))
data/netrw-1.3.2/src/getopt.c:1018:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/netrw-1.3.2/src/getopt.c:1055:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/netrw-1.3.2/src/getopt.c:1086:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/netrw-1.3.2/src/getopt.c:1090:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/netrw-1.3.2/src/net.c:523:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ret = read(s_data, buf, count);
data/netrw-1.3.2/src/net.c:606:29: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((r_buflen = read(s_control, r_buf, BUFFSIZE - 1)) < 0) {
data/netrw-1.3.2/src/net.c:655:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((len = strlen(line)) + 1 > BUFFSIZE) {
data/netrw-1.3.2/src/netwrite.c:204:21: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((count = read(fd, buf, BUFFSIZE)) > 0) {
ANALYSIS SUMMARY:
Hits = 77
Lines analyzed = 5676 in approximately 0.15 seconds (37596 lines/second)
Physical Source Lines of Code (SLOC) = 3279
Hits@level = [0] 41 [1] 21 [2] 28 [3] 14 [4] 14 [5] 0
Hits@level+ = [0+] 118 [1+] 77 [2+] 56 [3+] 28 [4+] 14 [5+] 0
Hits/KSLOC@level+ = [0+] 35.9866 [1+] 23.4828 [2+] 17.0784 [3+] 8.53919 [4+] 4.26959 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.