Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/network-manager-pptp-1.2.8/auth-dialog/main.c
Examining data/network-manager-pptp-1.2.8/properties/nm-pptp-editor-plugin.c
Examining data/network-manager-pptp-1.2.8/properties/nm-pptp-editor-plugin.h
Examining data/network-manager-pptp-1.2.8/properties/resources.c
Examining data/network-manager-pptp-1.2.8/properties/resources.h
Examining data/network-manager-pptp-1.2.8/properties/advanced-dialog.c
Examining data/network-manager-pptp-1.2.8/properties/advanced-dialog.h
Examining data/network-manager-pptp-1.2.8/properties/nm-pptp-editor.c
Examining data/network-manager-pptp-1.2.8/properties/nm-pptp-editor.h
Examining data/network-manager-pptp-1.2.8/shared/nm-utils/nm-glib.h
Examining data/network-manager-pptp-1.2.8/shared/nm-utils/nm-vpn-plugin-macros.h
Examining data/network-manager-pptp-1.2.8/shared/nm-utils/gsystem-local-alloc.h
Examining data/network-manager-pptp-1.2.8/shared/nm-utils/nm-macros-internal.h
Examining data/network-manager-pptp-1.2.8/shared/nm-utils/nm-shared-utils.c
Examining data/network-manager-pptp-1.2.8/shared/nm-utils/nm-shared-utils.h
Examining data/network-manager-pptp-1.2.8/shared/nm-utils/nm-vpn-plugin-utils.h
Examining data/network-manager-pptp-1.2.8/shared/nm-utils/nm-vpn-plugin-utils.c
Examining data/network-manager-pptp-1.2.8/shared/nm-default.h
Examining data/network-manager-pptp-1.2.8/shared/nm-service-defines.h
Examining data/network-manager-pptp-1.2.8/src/nm-pptp-pppd-plugin.c
Examining data/network-manager-pptp-1.2.8/src/nm-ppp-status.h
Examining data/network-manager-pptp-1.2.8/src/nm-pptp-service.h
Examining data/network-manager-pptp-1.2.8/src/nm-pptp-service.c
FINAL RESULTS:
data/network-manager-pptp-1.2.8/src/nm-pptp-pppd-plugin.c:63:14: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
syslog (nm_utils_syslog_coerce_from_nm (level), \
data/network-manager-pptp-1.2.8/src/nm-pptp-pppd-plugin.c:317:13: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
bus_name = getenv ("NM_DBUS_SERVICE_PPTP");
data/network-manager-pptp-1.2.8/src/nm-pptp-pppd-plugin.c:321:47: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
gl.log_level = _nm_utils_ascii_str_to_int64 (getenv ("NM_VPN_LOG_LEVEL"),
data/network-manager-pptp-1.2.8/src/nm-pptp-pppd-plugin.c:324:24: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
gl.log_prefix_token = getenv ("NM_VPN_LOG_PREFIX_TOKEN") ?: "???";
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:903:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ( getenv ("NM_PPP_DUMP_CONNECTION")
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:1164:6: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv ("NM_PPP_DEBUG"))
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:1167:47: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
gl.log_level = _nm_utils_ascii_str_to_int64 (getenv ("NM_VPN_LOG_LEVEL"),
data/network-manager-pptp-1.2.8/shared/nm-utils/nm-macros-internal.h:766:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&_r[1], _s, _l - 3); \
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:787:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[INET_ADDRSTRLEN];
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:842:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&naddr, &(inptr->sin_addr), sizeof (struct in_addr));
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:1126:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sbuf[30];
data/network-manager-pptp-1.2.8/auth-dialog/main.c:213:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
n = read (0, &c, 1);
data/network-manager-pptp-1.2.8/properties/advanced-dialog.c:461:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (value && strlen (value)) {
data/network-manager-pptp-1.2.8/properties/nm-pptp-editor.c:62:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!str || !strlen (str)) {
data/network-manager-pptp-1.2.8/properties/nm-pptp-editor.c:239:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (value && strlen (value))
data/network-manager-pptp-1.2.8/properties/nm-pptp-editor.c:250:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (value && strlen (value))
data/network-manager-pptp-1.2.8/properties/nm-pptp-editor.c:261:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (value && strlen (value))
data/network-manager-pptp-1.2.8/properties/nm-pptp-editor.c:328:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (password && strlen (password))
data/network-manager-pptp-1.2.8/properties/nm-pptp-editor.c:360:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (str && strlen (str))
data/network-manager-pptp-1.2.8/properties/nm-pptp-editor.c:366:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (str && strlen (str))
data/network-manager-pptp-1.2.8/properties/nm-pptp-editor.c:378:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (str && strlen (str))
data/network-manager-pptp-1.2.8/properties/resources.c:3393:31: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
__pragma(section(".CRT$XCU",read)) \
data/network-manager-pptp-1.2.8/properties/resources.c:3401:31: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
__pragma(section(".CRT$XCU",read)) \
data/network-manager-pptp-1.2.8/properties/resources.c:3413:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
section(".CRT$XCU",read)
data/network-manager-pptp-1.2.8/properties/resources.c:3420:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
section(".CRT$XCU",read)
data/network-manager-pptp-1.2.8/shared/nm-utils/nm-glib.h:439:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
bytes = g_bytes_new_take (string, strlen (string) + 1);
data/network-manager-pptp-1.2.8/shared/nm-utils/nm-macros-internal.h:760:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
_l = strlen (_s) + 3; \
data/network-manager-pptp-1.2.8/shared/nm-utils/nm-shared-utils.c:177:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen (str);
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:145:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!gateway || !strlen (gateway))
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:269:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!value || !strlen (value)) {
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:455:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!gwaddr || !strlen (gwaddr)) {
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:560:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (value && strlen (value)) {
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:689:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!user || !strlen (user))
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:691:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!user || !strlen (user)) {
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:700:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!password || !strlen (password)) {
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:712:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (domain && strlen (domain))
data/network-manager-pptp-1.2.8/src/nm-pptp-service.c:877:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!gwaddr || !strlen (gwaddr)) {
ANALYSIS SUMMARY:
Hits = 37
Lines analyzed = 9314 in approximately 0.39 seconds (23994 lines/second)
Physical Source Lines of Code (SLOC) = 7344
Hits@level = [0] 5 [1] 26 [2] 4 [3] 6 [4] 1 [5] 0
Hits@level+ = [0+] 42 [1+] 37 [2+] 11 [3+] 7 [4+] 1 [5+] 0
Hits/KSLOC@level+ = [0+] 5.71895 [1+] 5.03813 [2+] 1.49782 [3+] 0.953159 [4+] 0.136166 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.