Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/nfs4-acl-tools-0.3.3/GUI/nfs4-acl-editor/dirfiledialog.h
Examining data/nfs4-acl-tools-0.3.3/GUI/nfs4-acl-editor/main.cpp
Examining data/nfs4-acl-tools-0.3.3/GUI/nfs4-acl-editor/nfs4acleditor.h
Examining data/nfs4-acl-tools-0.3.3/GUI/nfs4-acl-editor/dirfiledialog.cpp
Examining data/nfs4-acl-tools-0.3.3/GUI/nfs4-acl-editor/nfs4acleditor.cpp
Examining data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_get_whotype.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_set_who.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/strtoul_reals.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_get_who.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_print_ace_verbose.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_acl_utils.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_get_ace_access.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_free_acl.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_insert_file_aces.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_get_ace_type.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_copy_acl.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_remove_string_aces.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_set_acl.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_acl_spec_from_file.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_xattr_load.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_xattr_pack.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_xattr_size.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_get_ace_flags.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_remove_file_aces.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_insert_string_aces.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_print_ace.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_print_acl.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_new_ace.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_new_acl.c
Examining data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_acl_for_path.c
Examining data/nfs4-acl-tools-0.3.3/nfs4_getfacl/nfs4_getfacl.c
Examining data/nfs4-acl-tools-0.3.3/include/libacl_nfs4.h
Examining data/nfs4-acl-tools-0.3.3/include/config.h
Examining data/nfs4-acl-tools-0.3.3/include/nfs4.h
FINAL RESULTS:
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_acl_spec_from_file.c:60:3: [5] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is high; the length parameter
appears to be a constant, instead of computing the number of characters
left.
strncat(acl_spec, ace_buf, NFS4_MAX_ACESIZE);
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_remove_file_aces.c:49:3: [5] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is high; the length parameter
appears to be a constant, instead of computing the number of characters
left.
strncat(acl_spec, ace_buf, NFS4_MAX_ACESIZE);
data/nfs4-acl-tools-0.3.3/GUI/nfs4-acl-editor/nfs4acleditor.h:79:34: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define dprintf(format, args...) printf(format, ## args)
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_get_who.c:89:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy((*who), iwho);
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_set_who.c:79:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ace->who, iwho);
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c:154:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(bufp,ace_buf);
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_get_ace_type.c:43:4: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf, "%s", "ALLOW");
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_get_ace_type.c:45:4: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf, "%s", "DENY");
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_get_ace_type.c:47:4: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf, "%s", "AUDIT");
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_get_ace_type.c:49:4: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf, "%s", "ALARM");
data/nfs4-acl-tools-0.3.3/nfs4_getfacl/nfs4_getfacl.c:131:2: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf(info, execname, VERSION);
data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c:453:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(tmp_name, MKTMPLATE);
data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c:507:3: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(edargv[0], edargv);
data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c:569:2: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, is_ef ? efusage : sfusage, name, VERSION, name);
data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c:144:16: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((opt = getopt_long(argc, argv, "-:a:A:s:S:x:X:m:ethvHRPL", long_options, NULL)) != -1) {
data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c:304:14: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
if ((tmp = realpath(path, NULL)) == NULL) {
data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c:343:14: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
if ((path = realpath(path, NULL)) == NULL) {
data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c:497:16: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((editor = getenv("EDITOR")) == NULL)
data/nfs4-acl-tools-0.3.3/GUI/nfs4-acl-editor/nfs4acleditor.h:243:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[16];
data/nfs4-acl-tools-0.3.3/include/nfs4.h:121:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char who[NFS4_MAX_PRINCIPALSIZE];
data/nfs4-acl-tools-0.3.3/include/nfs4.h:133:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
typedef struct { char data[NFS4_VERIFIER_SIZE]; } nfs4_verifier;
data/nfs4-acl-tools-0.3.3/include/nfs4.h:134:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
typedef struct { char data[16]; } nfs4_stateid;
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_xattr_load.c:148:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(who, bufp, wholen);
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_xattr_pack.c:113:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, who, wholen);
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c:85:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
free_fields(char *fields[NUMFIELDS])
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c:95:20: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
parse_alloc_fields(char *buf, char *fields[NUMFIELDS])
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c:95:31: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
parse_alloc_fields(char *buf, char *fields[NUMFIELDS])
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c:119:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(fields[i], field, len);
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c:139:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *fields[NUMFIELDS], *bufp, *field;
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_acl_spec_from_file.c:39:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ace_buf[NFS4_MAX_ACESIZE];
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_print_ace.c:39:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *who, buf[16];
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_remove_file_aces.c:44:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ace_buf[NFS4_MAX_ACESIZE];
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_remove_file_aces.c:45:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char acl_spec[NFS4_MAX_ACLSIZE];
data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c:288:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
s_fp = fopen(spec_file, "r");
data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c:448:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp_name[strlen(MKTMPLATE) + 1];
data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c:454:16: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
if ((tmp_fd = mkstemp(tmp_name)) == -1) {
data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c:493:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *edargv[3];
data/nfs4-acl-tools-0.3.3/GUI/nfs4-acl-editor/nfs4acleditor.cpp:122:82: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
dprintf("%d) i see %x is '%s' in %x, length %d\n", i, ace, ace->who, ace->who, strlen(ace->who));
data/nfs4-acl-tools-0.3.3/GUI/nfs4-acl-editor/nfs4acleditor.cpp:568:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = strlen(who);
data/nfs4-acl-tools-0.3.3/GUI/nfs4-acl-editor/nfs4acleditor.cpp:569:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (i > strlen(ace->who)) {
data/nfs4-acl-tools-0.3.3/GUI/nfs4-acl-editor/nfs4acleditor.cpp:570:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
dprintf("syncWho(): fromlen %d tolen %u\n", strlen(ace->who), i);
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_get_who.c:80:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
wholen = strlen(iwho);
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_get_whotype.c:45:4: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(p) == strlen(NFS4_ACL_WHO_OWNER_STRING)) {
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_get_whotype.c:45:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(p) == strlen(NFS4_ACL_WHO_OWNER_STRING)) {
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_get_whotype.c:49:4: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(p) == strlen(NFS4_ACL_WHO_GROUP_STRING)) {
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_get_whotype.c:49:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(p) == strlen(NFS4_ACL_WHO_GROUP_STRING)) {
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_get_whotype.c:53:4: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(p) == strlen(NFS4_ACL_WHO_EVERYONE_STRING)) {
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_get_whotype.c:53:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(p) == strlen(NFS4_ACL_WHO_EVERYONE_STRING)) {
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_set_who.c:74:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
wholen = strlen(iwho);
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_xattr_pack.c:108:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
wholen = strlen(who);
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_xattr_size.c:73:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size += (strlen(ace->who) / NFS4_XDR_MOD) * NFS4_XDR_MOD * sizeof(char);
data/nfs4-acl-tools-0.3.3/libnfs4acl/acl_nfs4_xattr_size.c:74:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(ace->who) % NFS4_XDR_MOD) {
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c:114:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(field);
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c:151:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
bufp = malloc(strlen(ace_buf) + 1);
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c:161:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if (strlen(fields[WHO_INDEX]) > NFS4_MAX_PRINCIPALSIZE) {
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c:185:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (buflen = strlen(field); buflen > 0; buflen--) {
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c:228:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (buflen = strlen(field); buflen > 0; buflen--) {
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_ace_from_string.c:313:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if (12 + strlen(ace->who) > NFS4_MAX_ACESIZE) {
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_acl_spec_from_file.c:53:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
consumed += strlen(ace_buf);
data/nfs4-acl-tools-0.3.3/libnfs4acl/nfs4_insert_string_aces.c:49:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strlen(ssp))
data/nfs4-acl-tools-0.3.3/libnfs4acl/strtoul_reals.c:48:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(s);
data/nfs4-acl-tools-0.3.3/nfs4_setfacl/nfs4_setfacl.c:448:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char tmp_name[strlen(MKTMPLATE) + 1];
ANALYSIS SUMMARY:
Hits = 62
Lines analyzed = 5408 in approximately 0.21 seconds (25645 lines/second)
Physical Source Lines of Code (SLOC) = 3338
Hits@level = [0] 117 [1] 25 [2] 19 [3] 4 [4] 12 [5] 2
Hits@level+ = [0+] 179 [1+] 62 [2+] 37 [3+] 18 [4+] 14 [5+] 2
Hits/KSLOC@level+ = [0+] 53.6249 [1+] 18.574 [2+] 11.0845 [3+] 5.39245 [4+] 4.19413 [5+] 0.599161
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.