Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/nfswatch-4.99.11/nit.c
Examining data/nfswatch-4.99.11/ipports.h
Examining data/nfswatch-4.99.11/logfile.c
Examining data/nfswatch-4.99.11/xdr.c
Examining data/nfswatch-4.99.11/pktfilter.c
Examining data/nfswatch-4.99.11/nfslogsum.c
Examining data/nfswatch-4.99.11/rpcfilter.c
Examining data/nfswatch-4.99.11/snoop.c
Examining data/nfswatch-4.99.11/screen.c
Examining data/nfswatch-4.99.11/rpcdefs.h
Examining data/nfswatch-4.99.11/nfsfh.h
Examining data/nfswatch-4.99.11/os.h
Examining data/nfswatch-4.99.11/netaddr.c
Examining data/nfswatch-4.99.11/pfilt.c
Examining data/nfswatch-4.99.11/osf.map.h
Examining data/nfswatch-4.99.11/linux.map.h
Examining data/nfswatch-4.99.11/linux.c
Examining data/nfswatch-4.99.11/rpcutil.c
Examining data/nfswatch-4.99.11/ultrix.map.h
Examining data/nfswatch-4.99.11/parsenfsfh.c
Examining data/nfswatch-4.99.11/screen.h
Examining data/nfswatch-4.99.11/sgi.map.h
Examining data/nfswatch-4.99.11/dlpi.c
Examining data/nfswatch-4.99.11/pfopen.c
Examining data/nfswatch-4.99.11/externs.h
Examining data/nfswatch-4.99.11/nfswatch.h
Examining data/nfswatch-4.99.11/nfswatch.c
Examining data/nfswatch-4.99.11/util.c
FINAL RESULTS:
data/nfswatch-4.99.11/dlpi.c:126:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(devname, DLPI_DEVDIR);
data/nfswatch-4.99.11/dlpi.c:317:3: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr,
data/nfswatch-4.99.11/logfile.c:180:10: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
(void) sprintf(buf, "%s:", pkt_counters[i].pc_name);
data/nfswatch-4.99.11/logfile.c:214:10: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
(void) sprintf(buf, "%s:", nfs_counters[i].nc_name);
data/nfswatch-4.99.11/logfile.c:254:10: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
(void) sprintf(buf, "%s:", fil_counters[i].fc_name);
data/nfswatch-4.99.11/netaddr.c:75:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(myhost, hp->h_name);
data/nfswatch-4.99.11/netaddr.c:94:10: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(dsthost, hp->h_name);
data/nfswatch-4.99.11/netaddr.c:101:10: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(dsthost, myhost);
data/nfswatch-4.99.11/netaddr.c:137:10: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(serverhost, hp->h_name);
data/nfswatch-4.99.11/netaddr.c:173:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(srchost, hp->h_name);
data/nfswatch-4.99.11/nfslogsum.c:194:11: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(srchost, line + 19);
data/nfswatch-4.99.11/nfslogsum.c:202:11: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(dsthost, line + 19);
data/nfswatch-4.99.11/nfslogsum.c:311:12: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(enddate, line + 6);
data/nfswatch-4.99.11/nfslogsum.c:564:10: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
(void) sprintf(buf, "%s:", pkt_counters[i].pc_name);
data/nfswatch-4.99.11/nfslogsum.c:597:10: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
(void) sprintf(buf, "%s:", nfs_counters[i].nc_name);
data/nfswatch-4.99.11/nfslogsum.c:621:10: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
(void) sprintf(buf, "%s:", fil_counters[i].fc_name);
data/nfswatch-4.99.11/nfswatch.c:253:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(dsthost, myhost);
data/nfswatch-4.99.11/nfswatch.c:269:11: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(dsthost, *++argv);
data/nfswatch-4.99.11/nfswatch.c:281:11: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(srchost, *++argv);
data/nfswatch-4.99.11/nfswatch.c:293:11: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(serverhost, *++argv);
data/nfswatch-4.99.11/rpcfilter.c:624:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(prefix, "%s", hp->h_name);
data/nfswatch-4.99.11/rpcfilter.c:632:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(prefix, "%s", inet_ntoa(ia));
data/nfswatch-4.99.11/rpcfilter.c:644:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(fsname, "%.8s:%s %s", prefix, temp, osname);
data/nfswatch-4.99.11/rpcfilter.c:647:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(fsname, "%.12s(%ld,%ld)%s", prefix,
data/nfswatch-4.99.11/rpcfilter.c:860:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(clnt_name, "%s", hp->h_name);
data/nfswatch-4.99.11/rpcfilter.c:868:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(clnt_name, "%s", inet_ntoa(ia));
data/nfswatch-4.99.11/screen.c:222:10: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
(void) sprintf(buf, "Monitoring packets from interface %s",
data/nfswatch-4.99.11/screen.c:709:6: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(message, "%d %s [%d not displayed]", number, legend,
data/nfswatch-4.99.11/screen.c:713:6: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(message, "%d %s", number, legend);
data/nfswatch-4.99.11/util.c:145:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
(void) sprintf(buf, "%s: %s", pname, str);
data/nfswatch-4.99.11/util.c:524:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access("/var/lib/nfs/etab", R_OK) == 0) {
data/nfswatch-4.99.11/util.c:1033:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(line, "%s", path);
data/nfswatch-4.99.11/util.c:1247:7: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
if (sscanf(line, "%s %s", fs, alias) != 2)
data/nfswatch-4.99.11/util.c:1250:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(trans, fs);
data/nfswatch-4.99.11/util.c:1253:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(trans + len, alias);
data/nfswatch-4.99.11/dlpi.c:66:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cbuf[BUFSIZ];
data/nfswatch-4.99.11/dlpi.c:70:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char devname[BUFSIZ];
data/nfswatch-4.99.11/dlpi.c:128:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
devppa = atoi(p);
data/nfswatch-4.99.11/dlpi.c:133:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(devname, O_RDWR)) < 0) {
data/nfswatch-4.99.11/linux.c:38:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZ];
data/nfswatch-4.99.11/linux.c:83:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errbuf[PCAP_ERRBUF_SIZE];
data/nfswatch-4.99.11/linux.c:148:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(bp, data, hdr->caplen);
data/nfswatch-4.99.11/linux.map.h:116:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char f3[4];
data/nfswatch-4.99.11/linux.map.h:118:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char f5[4];
data/nfswatch-4.99.11/linux.map.h:125:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fh_data[NFS_FHMAXDATA]; /* and data */
data/nfswatch-4.99.11/linux.map.h:127:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fh_xdata[NFS_FHMAXDATA]; /* and data */
data/nfswatch-4.99.11/linux.map.h:136:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fh_data[NFS_FHSIZE]; /* opaque data */
data/nfswatch-4.99.11/linux.map.h:445:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char data[NFS3_FHSIZE];
data/nfswatch-4.99.11/logfile.c:41:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[BUFSIZ];
data/nfswatch-4.99.11/logfile.c:46:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fp = fopen(snapshotfile, "a")) == NULL) {
data/nfswatch-4.99.11/logfile.c:128:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZ];
data/nfswatch-4.99.11/logfile.c:134:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char nfsprocs_header[80] =
data/nfswatch-4.99.11/netaddr.c:82:10: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
(void) sprintf(dsthost, "all hosts");
data/nfswatch-4.99.11/netaddr.c:120:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&dstaddrs[n], *cp, hp->h_length);
data/nfswatch-4.99.11/netaddr.c:149:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&serveraddrs[n], *cp, hp->h_length);
data/nfswatch-4.99.11/netaddr.c:185:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&srcaddrs[n], *cp, hp->h_length);
data/nfswatch-4.99.11/nfslogsum.c:39:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char srchost[MAXHOSTNAMELEN]; /* source host name */
data/nfswatch-4.99.11/nfslogsum.c:40:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dsthost[MAXHOSTNAMELEN]; /* destination host name*/
data/nfswatch-4.99.11/nfslogsum.c:73:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ];
data/nfswatch-4.99.11/nfslogsum.c:91:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
maxlogentries = atoi(*argv);
data/nfswatch-4.99.11/nfslogsum.c:99:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((logfp = fopen(logfile, "r")) == NULL) {
data/nfswatch-4.99.11/nfslogsum.c:285:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ];
data/nfswatch-4.99.11/nfslogsum.c:328:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ];
data/nfswatch-4.99.11/nfslogsum.c:370:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ];
data/nfswatch-4.99.11/nfslogsum.c:419:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ];
data/nfswatch-4.99.11/nfslogsum.c:468:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ];
data/nfswatch-4.99.11/nfslogsum.c:520:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ctrs[i] += atoi(s);
data/nfswatch-4.99.11/nfslogsum.c:536:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZ];
data/nfswatch-4.99.11/nfswatch.c:102:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pad[ETHERHDRPAD];
data/nfswatch-4.99.11/nfswatch.c:104:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char data[ETHERMTU];
data/nfswatch-4.99.11/nfswatch.c:115:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *nfs_procnams[NFSHIGHPROTO + 1][MAXNFS3PROC] = {
data/nfswatch-4.99.11/nfswatch.c:203:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char myhost[MAXHOSTNAMELEN]; /* local host name */
data/nfswatch-4.99.11/nfswatch.c:204:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char srchost[MAXHOSTNAMELEN]; /* source host name */
data/nfswatch-4.99.11/nfswatch.c:205:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dsthost[MAXHOSTNAMELEN]; /* destination host name*/
data/nfswatch-4.99.11/nfswatch.c:206:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char serverhost[MAXHOSTNAMELEN]; /* server host name */
data/nfswatch-4.99.11/nfswatch.c:363:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
totaltime = atoi(*++argv);
data/nfswatch-4.99.11/nfswatch.c:374:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
cycletime = atoi(*++argv);
data/nfswatch-4.99.11/nfswatch.c:773:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((logfp = fopen(logfile, "a")) == NULL) {
data/nfswatch-4.99.11/nfswatch.c:1173:12: [2] (buffer) bcopy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void) bcopy(bp, &stamp, sizeof(stamp));
data/nfswatch-4.99.11/nit.c:49:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZ];
data/nfswatch-4.99.11/nit.c:110:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(NIT_DEV, O_RDONLY)) < 0) {
data/nfswatch-4.99.11/os.h:64:9: [2] (buffer) bcopy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
#define bcopy(a,b,n) memcpy(b,a,n)
data/nfswatch-4.99.11/os.h:64:22: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
#define bcopy(a,b,n) memcpy(b,a,n)
data/nfswatch-4.99.11/parsenfsfh.c:457:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(fsidp, fh, 14); /* just use the whole thing */
data/nfswatch-4.99.11/parsenfsfh.c:463:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tempa, fh, 14); /* ensure alignment */
data/nfswatch-4.99.11/pktfilter.c:99:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char packet[PACKETSIZE];
data/nfswatch-4.99.11/pktfilter.c:106:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&eheader, cp, sizeof(struct ether_header));
data/nfswatch-4.99.11/pktfilter.c:107:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(packet, cp + sizeof(struct ether_header),
data/nfswatch-4.99.11/pktfilter.c:140:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char packet[PACKETSIZE];
data/nfswatch-4.99.11/pktfilter.c:164:9: [2] (buffer) bcopy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void) bcopy(cp, (char *) &fheader, sizeof(struct fddi_header));
data/nfswatch-4.99.11/pktfilter.c:165:9: [2] (buffer) bcopy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void) bcopy(cp + sizeof(struct fddi_header), (char *) &lheader,
data/nfswatch-4.99.11/pktfilter.c:167:9: [2] (buffer) bcopy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void) bcopy(cp + FDDI_LLC_LEN, (char *) packet,
data/nfswatch-4.99.11/pktfilter.c:226:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char packet[PACKETSIZE];
data/nfswatch-4.99.11/pktfilter.c:233:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&sheader, cp, sizeof(struct sll_header));
data/nfswatch-4.99.11/pktfilter.c:234:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(packet, cp + sizeof(struct sll_header),
data/nfswatch-4.99.11/rpcdefs.h:129:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char su_verfbody[MAX_AUTH_BYTES]; /* verifier body */
data/nfswatch-4.99.11/rpcfilter.c:381:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cred_area[2*MAX_AUTH_BYTES];
data/nfswatch-4.99.11/rpcfilter.c:594:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char fsname[64], prefix[64];
data/nfswatch-4.99.11/rpcfilter.c:638:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char temp[17];
data/nfswatch-4.99.11/rpcfilter.c:836:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char clnt_name[64];
data/nfswatch-4.99.11/rpcfilter.c:914:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char user_name[MAXUSERNAMELEN + 1] = {'\0'};
data/nfswatch-4.99.11/rpcfilter.c:1049:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cred_area[2*MAX_AUTH_BYTES];
data/nfswatch-4.99.11/rpcutil.c:196:9: [2] (buffer) bcopy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void) bcopy(data, rpc_buffer(xprt), min(length, su->su_iosz));
data/nfswatch-4.99.11/screen.c:168:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZ];
data/nfswatch-4.99.11/screen.c:220:10: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
(void) sprintf(buf, "Monitoring packets from all interfaces");
data/nfswatch-4.99.11/screen.c:313:8: [2] (buffer) bcopy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
bcopy(&clnt_counters[i].cl_ipaddr, &tmp,
data/nfswatch-4.99.11/screen.c:700:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char message[80];
data/nfswatch-4.99.11/screen.c:834:17: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((logfp = fopen(logfile, "a")) == NULL) {
data/nfswatch-4.99.11/sgi.map.h:167:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char f3[4];
data/nfswatch-4.99.11/sgi.map.h:169:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char f5[4];
data/nfswatch-4.99.11/sgi.map.h:176:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fh_data[NFS_FHMAXDATA]; /* and data */
data/nfswatch-4.99.11/sgi.map.h:178:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fh_xdata[NFS_FHMAXDATA]; /* and data */
data/nfswatch-4.99.11/sgi.map.h:187:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fh_data[NFS_FHSIZE]; /* opaque data */
data/nfswatch-4.99.11/snoop.c:52:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZ];
data/nfswatch-4.99.11/util.c:123:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char tbuf[16];
data/nfswatch-4.99.11/util.c:133:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
(void) sprintf(tbuf, "%02d:%02d:%02d", hh, mm, ss);
data/nfswatch-4.99.11/util.c:143:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZ];
data/nfswatch-4.99.11/util.c:406:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fp = fopen(MOUNTTABLE, "r")) == NULL) {
data/nfswatch-4.99.11/util.c:525:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX << 1];
data/nfswatch-4.99.11/util.c:529:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fp = fopen("/var/lib/nfs/etab", "r")) == NULL) {
data/nfswatch-4.99.11/util.c:546:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
nc->nc_dev.Minor = atoi(s + 5);
data/nfswatch-4.99.11/util.c:676:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fname[MAXPATHLEN];
data/nfswatch-4.99.11/util.c:691:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fp = fopen(filelist, "r")) == NULL) {
data/nfswatch-4.99.11/util.c:1021:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ], path[BUFSIZ];
data/nfswatch-4.99.11/util.c:1026:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fp = fopen(SHARETAB, "r")) == NULL)
data/nfswatch-4.99.11/util.c:1231:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char *fs_maps[1024];
data/nfswatch-4.99.11/util.c:1238:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fs[BUFSIZ], alias[BUFSIZ];
data/nfswatch-4.99.11/util.c:1239:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ], trans[BUFSIZ];
data/nfswatch-4.99.11/util.c:1241:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fp = fopen(mapfile, "r")) == NULL) {
data/nfswatch-4.99.11/util.c:1261:3: [2] (buffer) bcopy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
bcopy(trans, fs_maps[nummap], len);
data/nfswatch-4.99.11/xdr.c:276:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char fn3_buf[2][1024];
data/nfswatch-4.99.11/dlpi.c:120:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p = *device + strlen(*device);
data/nfswatch-4.99.11/dlpi.c:127:2: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(devname, *device, p - *device);
data/nfswatch-4.99.11/logfile.c:98:10: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(buffer, curscr->_y[y], x);
data/nfswatch-4.99.11/nfswatch.c:1049:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((cc = read(if_fd[i], buf, NIT_CHUNKSIZE)) <= 0)
data/nfswatch-4.99.11/nfswatch.c:1152:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((cc = read(if_fd[i], buf, PFILT_CHUNKSIZE)) < 0) {
data/nfswatch-4.99.11/nfswatch.c:1158:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((cc = read(if_fd[i], buf, PFILT_CHUNKSIZE)) < 0) {
data/nfswatch-4.99.11/nfswatch.c:1268:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((cc = read(if_fd[i], &ep, sizeof(ep))) <= 0)
data/nfswatch-4.99.11/nit.c:166:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void) strncpy(ifr.ifr_name, *device, sizeof(ifr.ifr_name));
data/nfswatch-4.99.11/rpcfilter.c:641:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(temp, sfsname, 16);
data/nfswatch-4.99.11/rpcfilter.c:965:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(user_name, pw->pw_name, MAXUSERNAMELEN);
data/nfswatch-4.99.11/screen.c:225:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(buf);
data/nfswatch-4.99.11/screen.c:715:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mlen = strlen(message);
data/nfswatch-4.99.11/screen.c:747:11: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((c = getchar()) == EOF)
data/nfswatch-4.99.11/snoop.c:115:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(sr.sr_ifname, *device, sizeof(sr.sr_ifname));
data/nfswatch-4.99.11/util.c:704:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
fname[strlen(fname)-1] = '\0';
data/nfswatch-4.99.11/util.c:1251:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(fs) + 1;
data/nfswatch-4.99.11/util.c:1254:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(alias) + 1;
data/nfswatch-4.99.11/util.c:1275:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return(fs_maps[i] + strlen(fs_maps[i]) + 1);
ANALYSIS SUMMARY:
Hits = 149
Lines analyzed = 11481 in approximately 0.30 seconds (38201 lines/second)
Physical Source Lines of Code (SLOC) = 7430
Hits@level = [0] 134 [1] 18 [2] 96 [3] 0 [4] 35 [5] 0
Hits@level+ = [0+] 283 [1+] 149 [2+] 131 [3+] 35 [4+] 35 [5+] 0
Hits/KSLOC@level+ = [0+] 38.0888 [1+] 20.0538 [2+] 17.6312 [3+] 4.71063 [4+] 4.71063 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.