Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/obexftp-0.24/apps/discovery.c
Examining data/obexftp-0.24/apps/obexftp.c
Examining data/obexftp-0.24/apps/obexftpd.c
Examining data/obexftp-0.24/bfb/bfb.c
Examining data/obexftp-0.24/bfb/bfb.h
Examining data/obexftp-0.24/bfb/bfb_io.c
Examining data/obexftp-0.24/bfb/bfb_io.h
Examining data/obexftp-0.24/bfb/crc.c
Examining data/obexftp-0.24/bfb/crc.h
Examining data/obexftp-0.24/examples/c_example.c
Examining data/obexftp-0.24/examples/c_example_obex_push.c
Examining data/obexftp-0.24/fuse/obexautofs.c
Examining data/obexftp-0.24/fuse/obexfs.c
Examining data/obexftp-0.24/includes/common.h
Examining data/obexftp-0.24/multicobex/multi_cobex.c
Examining data/obexftp-0.24/multicobex/multi_cobex.h
Examining data/obexftp-0.24/multicobex/multi_cobex_private.h
Examining data/obexftp-0.24/obexftp/bt_kit.c
Examining data/obexftp-0.24/obexftp/bt_kit.h
Examining data/obexftp-0.24/obexftp/bt_kit_test.c
Examining data/obexftp-0.24/obexftp/cache.c
Examining data/obexftp-0.24/obexftp/cache.h
Examining data/obexftp-0.24/obexftp/client.c
Examining data/obexftp-0.24/obexftp/client.h
Examining data/obexftp-0.24/obexftp/obexftp.h
Examining data/obexftp-0.24/obexftp/obexftp_io.c
Examining data/obexftp-0.24/obexftp/obexftp_io.h
Examining data/obexftp-0.24/obexftp/object.c
Examining data/obexftp-0.24/obexftp/object.h
Examining data/obexftp-0.24/obexftp/unicode.c
Examining data/obexftp-0.24/obexftp/unicode.h
Examining data/obexftp-0.24/obexftp/uuid.h
FINAL RESULTS:
data/obexftp-0.24/apps/obexftpd.c:364:3: [5] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is high; the length parameter
appears to be a constant, instead of computing the number of characters
left.
strncat(fullname, name, sizeof(fullname)-1);
data/obexftp-0.24/fuse/obexautofs.c:767:2: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
readlink: ofs_readlink,
data/obexftp-0.24/fuse/obexautofs.c:779:2: [5] (race) chmod:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchmod( ) instead.
chmod: NULL,
data/obexftp-0.24/fuse/obexautofs.c:780:2: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
chown: NULL,
data/obexftp-0.24/fuse/obexfs.c:470:2: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
readlink: NULL,
data/obexftp-0.24/fuse/obexfs.c:482:2: [5] (race) chmod:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchmod( ) instead.
chmod: NULL,
data/obexftp-0.24/fuse/obexfs.c:483:2: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
chown: NULL,
data/obexftp-0.24/apps/obexftpd.c:174:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(stream->data, data);
data/obexftp-0.24/apps/obexftpd.c:222:2: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(str_size,sizeof(str_size), format, size);
data/obexftp-0.24/apps/obexftpd.c:231:2: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(str_perm,sizeof(str_perm),format,
data/obexftp-0.24/apps/obexftpd.c:363:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(fullname, CUR_DIR);
data/obexftp-0.24/apps/obexftpd.c:455:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(type, (char *)hv.bs);
data/obexftp-0.24/apps/obexftpd.c:505:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(filename, CUR_DIR);
data/obexftp-0.24/apps/obexftpd.c:506:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(filename, dirp->d_name);
data/obexftp-0.24/apps/obexftpd.c:691:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(fullname, CUR_DIR);
data/obexftp-0.24/apps/obexftpd.c:692:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(fullname, name);
data/obexftp-0.24/fuse/obexautofs.c:57:20: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define DEBUG(...) fprintf(stderr, __VA_ARGS__)
data/obexftp-0.24/fuse/obexautofs.c:416:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(link, conn->addr);
data/obexftp-0.24/fuse/obexfs.c:52:20: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define DEBUG(...) fprintf(stderr, __VA_ARGS__)
data/obexftp-0.24/includes/common.h:37:9: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define snprintf _snprintf
data/obexftp-0.24/includes/common.h:37:18: [4] (format) _snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define snprintf _snprintf
data/obexftp-0.24/includes/common.h:46:49: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define DEBUG(n, ...) if (OBEXFTP_DEBUG >= (n)) fprintf(stderr, __VA_ARGS__)
data/obexftp-0.24/includes/common.h:48:55: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define DEBUG(n, format...) if (OBEXFTP_DEBUG >= (n)) fprintf (stderr, format)
data/obexftp-0.24/includes/common.h:56:3: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf (stderr, format, args);
data/obexftp-0.24/obexftp/bt_kit.c:817:31: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
sdp_get_access_protos(rec, &access);
data/obexftp-0.24/obexftp/bt_kit.c:819:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access) {
data/obexftp-0.24/obexftp/bt_kit.c:820:33: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
channel = sdp_get_proto_port(access, RFCOMM_UUID);
data/obexftp-0.24/obexftp/cache.c:349:25: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(dir->name, name);
data/obexftp-0.24/obexftp/cache.c:360:25: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(dir->name, name);
data/obexftp-0.24/apps/obexftp.c:460:6: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv(OBEXFTP_CHANNEL) != NULL) {
data/obexftp-0.24/apps/obexftp.c:461:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
channel = atoi(getenv(OBEXFTP_CHANNEL));
data/obexftp-0.24/apps/obexftp.c:467:6: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv(OBEXFTP_CABLE) != NULL) {
data/obexftp-0.24/apps/obexftp.c:468:12: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
device = getenv(OBEXFTP_CABLE);
data/obexftp-0.24/apps/obexftp.c:472:6: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv(OBEXFTP_BLUETOOTH) != NULL) {
data/obexftp-0.24/apps/obexftp.c:473:12: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
device = getenv(OBEXFTP_BLUETOOTH);
data/obexftp-0.24/apps/obexftp.c:477:6: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv(OBEXFTP_INET) != NULL) {
data/obexftp-0.24/apps/obexftp.c:478:12: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
device = getenv(OBEXFTP_INET);
data/obexftp-0.24/apps/obexftp.c:521:7: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt_long (argc, argv, "-ib::B:d:u::t:n:U::HST:L::l::c:C:f:o:g:G:p:k:XYxm:VvhN:FP",
data/obexftp-0.24/apps/obexftpd.c:958:7: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt_long (argc, argv, "-ib::t:n:c:vVh",
data/obexftp-0.24/fuse/obexautofs.c:813:7: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt_long (argc, argv, "+IBUt:d:Nh",
data/obexftp-0.24/fuse/obexfs.c:520:7: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt_long (argc, argv, "+ib:B:d:u:t:n:Nh",
data/obexftp-0.24/apps/discovery.c:100:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmpbuf[200] = {0,};
data/obexftp-0.24/apps/discovery.c:196:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rspbuf[200];
data/obexftp-0.24/apps/discovery.c:255:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if( (ttyfd = open(ttyname, O_RDWR | O_NONBLOCK | O_NOCTTY, 0)) < 0 ) {
data/obexftp-0.24/apps/obexftp.c:461:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
channel = atoi(getenv(OBEXFTP_CHANNEL));
data/obexftp-0.24/apps/obexftp.c:549:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
channel = atoi(optarg);
data/obexftp-0.24/apps/obexftp.c:569:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
channel = atoi(optarg);
data/obexftp-0.24/apps/obexftp.c:595:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
channel = atoi(++p);
data/obexftp-0.24/apps/obexftp.c:629:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
timeout = atoi(optarg);
data/obexftp-0.24/apps/obexftpd.c:82:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char init_work_path[WORK_PATH_MAX];
data/obexftp-0.24/apps/obexftpd.c:103:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*port = atoi(++s);
data/obexftp-0.24/apps/obexftpd.c:220:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str_size[sizeof(format)+14];
data/obexftp-0.24/apps/obexftpd.c:229:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str_perm[sizeof(format)];
data/obexftp-0.24/apps/obexftpd.c:243:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str_tm[sizeof("=\"yyyymmddThhmmssZ\" ")];
data/obexftp-0.24/apps/obexftpd.c:283:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(target,hv.bs,target_len);
data/obexftp-0.24/apps/obexftpd.c:318:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fullname[WORK_PATH_MAX];
data/obexftp-0.24/apps/obexftpd.c:409:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(filename, O_RDONLY, 0);
data/obexftp-0.24/apps/obexftpd.c:597:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename[255] = {0,};
data/obexftp-0.24/apps/obexftpd.c:611:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(filename, O_RDWR | O_CREAT | O_EXCL, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH);
data/obexftp-0.24/apps/obexftpd.c:642:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fullname[WORK_PATH_MAX];
data/obexftp-0.24/apps/obexftpd.c:971:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
channel = atoi(optarg);
data/obexftp-0.24/bfb/bfb.c:137:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&buffer[5], data, len);
data/obexftp-0.24/bfb/bfb.c:338:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(frame->payload, &buffer[i], l);
data/obexftp-0.24/bfb/bfb.c:442:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(frame, buffer, l);
data/obexftp-0.24/bfb/bfb.c:485:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&((uint8_t *)*data)[*len], frame->payload, frame->len);
data/obexftp-0.24/bfb/bfb_io.c:221:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmpbuf[100] = {0,};
data/obexftp-0.24/bfb/bfb_io.c:327:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rspbuf[200];
data/obexftp-0.24/bfb/bfb_io.c:385:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if( (ttyfd = open(ttyname, O_RDWR | O_NONBLOCK | O_NOCTTY, 0)) < 0 ) {
data/obexftp-0.24/examples/c_example.c:27:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
channel = atoi(argv[2]);
data/obexftp-0.24/examples/c_example_obex_push.c:30:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
channel = atoi(argv[3]);
data/obexftp-0.24/fuse/obexautofs.c:92:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[25], *p;
data/obexftp-0.24/fuse/obexautofs.c:99:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(name, "usb");
data/obexftp-0.24/fuse/obexautofs.c:104:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
DEBUG("Found %s (%d), %s\n", name, atoi(*dev), *dev);
data/obexftp-0.24/fuse/obexautofs.c:121:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
conn->channel = atoi(*dev);
data/obexftp-0.24/fuse/obexautofs.c:626:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, wb->data + offset, actual);
data/obexftp-0.24/fuse/obexautofs.c:656:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void) memcpy(&wb->data[offset], buf, size);
data/obexftp-0.24/fuse/obexautofs.c:783:2: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open: ofs_open,
data/obexftp-0.24/fuse/obexfs.c:354:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, wb->data + offset, actual);
data/obexftp-0.24/fuse/obexfs.c:384:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void) memcpy(&wb->data[offset], buf, size);
data/obexftp-0.24/fuse/obexfs.c:486:2: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open: ofs_open,
data/obexftp-0.24/fuse/obexfs.c:540:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
channel = atoi(optarg);
data/obexftp-0.24/fuse/obexfs.c:552:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
channel = atoi(optarg);
data/obexftp-0.24/obexftp/bt_kit.c:130:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
return sprintf(straddr, "%2.2X:%2.2X:%2.2X:%2.2X:%2.2X:%2.2X",
data/obexftp-0.24/obexftp/bt_kit.c:162:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addressAsString[18];
data/obexftp-0.24/obexftp/bt_kit.c:209:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addressAsString[18];
data/obexftp-0.24/obexftp/bt_kit.c:260:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addressAsString[20]; // "(XX:XX:XX:XX:XX:XX)"
data/obexftp-0.24/obexftp/bt_kit.c:431:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(ep.name, "No Name");
data/obexftp-0.24/obexftp/bt_kit.c:717:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dev_id = atoi(src);
data/obexftp-0.24/obexftp/bt_kit.c:760:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[248];
data/obexftp-0.24/obexftp/bt_kit.c:769:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dev_id = atoi(src);
data/obexftp-0.24/obexftp/bt_kit.c:783:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(name, "No Name");
data/obexftp-0.24/obexftp/bt_kit.c:853:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dev_id = atoi(src);
data/obexftp-0.24/obexftp/bt_kit.c:880:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&root_uuid.value.uuid128.data[2], &data1, 2);
data/obexftp-0.24/obexftp/bt_kit.h:77:24: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
#define bacpy(dst,src) memcpy((dst),(src),sizeof(BTH_ADDR))
data/obexftp-0.24/obexftp/bt_kit_test.c:41:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
svclass = atoi(argv[2]);
data/obexftp-0.24/obexftp/cache.c:267:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tagname[201];
data/obexftp-0.24/obexftp/cache.c:268:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[201]; // bad coder
data/obexftp-0.24/obexftp/cache.c:269:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char perm[201];
data/obexftp-0.24/obexftp/cache.c:270:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mod[201]; // - no biscuits!
data/obexftp-0.24/obexftp/cache.c:271:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char acc[201];
data/obexftp-0.24/obexftp/cache.c:272:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cre[201];
data/obexftp-0.24/obexftp/cache.c:273:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char size[201]; // int would be ok too.
data/obexftp-0.24/obexftp/cache.c:322:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(perm, "RW"); //default permissions
data/obexftp-0.24/obexftp/client.c:296:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, hv.bs, hlen);
data/obexftp-0.24/obexftp/client.c:343:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(cli-> target_fn, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, CREATE_MODE_FILE);
data/obexftp-0.24/obexftp/client.c:671:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
hci_devba(atoi(src + 3), &src_addr);
data/obexftp-0.24/obexftp/client.c:673:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
else if (atoi(src) != 0) {
data/obexftp-0.24/obexftp/client.c:674:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
hci_devba(atoi(src), &src_addr);
data/obexftp-0.24/obexftp/client.c:1121:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
cli->fd = open(filename, O_RDONLY | O_BINARY, 0);
data/obexftp-0.24/obexftp/client.h:62:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[256];
data/obexftp-0.24/obexftp/obexftp_io.c:197:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(diskname, O_RDWR | O_CREAT | O_TRUNC, DEFFILEMOD);
data/obexftp-0.24/obexftp/object.c:159:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(appstr_p, opname, sizeof(opname));
data/obexftp-0.24/obexftp/unicode.c:73:8: [2] (buffer) MultiByteToWideChar:
Requires maximum length in CHARACTERS, not bytes (CWE-120).
ret = MultiByteToWideChar(CP_ACP, 0, c, -1, (LPWSTR)uc, size);
data/obexftp-0.24/obexftp/unicode.c:256:8: [2] (buffer) MultiByteToWideChar:
Requires maximum length in CHARACTERS, not bytes (CWE-120).
ret = MultiByteToWideChar(CP_UTF8, 0, uc, -1, (LPWSTR)le, n);
data/obexftp-0.24/apps/discovery.c:108:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cmdlen = strlen(cmd);
data/obexftp-0.24/apps/discovery.c:135:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
actual = read(fd, &tmpbuf[total], sizeof(tmpbuf) - total);
data/obexftp-0.24/apps/discovery.c:186:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(rspbuf, answer, answer_size);
data/obexftp-0.24/apps/obexftp.c:126:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (i >= strlen(progress))
data/obexftp-0.24/apps/obexftp.c:208:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!addr || strlen(addr) < (6*2+5) || addr[2]!=':') {
data/obexftp-0.24/apps/obexftpd.c:158:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size = strlen(data);
data/obexftp-0.24/apps/obexftpd.c:422:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
actual = read(fd, buf, *file_size);
data/obexftp-0.24/apps/obexftpd.c:504:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
filename = malloc(strlen(CUR_DIR) + strlen(dirp->d_name) + 1);
data/obexftp-0.24/apps/obexftpd.c:504:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
filename = malloc(strlen(CUR_DIR) + strlen(dirp->d_name) + 1);
data/obexftp-0.24/apps/obexftpd.c:610:2: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(filename, s, 250);
data/obexftp-0.24/apps/obexftpd.c:810:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (i >= strlen(progress))
data/obexftp-0.24/bfb/bfb.h:93:55: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
bfb_write_packets(fd, BFB_FRAME_AT, (uint8_t *)data, strlen(data))
data/obexftp-0.24/bfb/bfb_io.c:104:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
actual = read(fd, buffer, length);
data/obexftp-0.24/bfb/bfb_io.c:227:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cmdlen = strlen(cmd);
data/obexftp-0.24/bfb/bfb_io.c:283:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(rspbuf, answer, answer_size);
data/obexftp-0.24/fuse/obexautofs.c:100:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(&name[3], *dev, sizeof(name)-4);
data/obexftp-0.24/fuse/obexautofs.c:315:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
namelen = strlen(path);
data/obexftp-0.24/fuse/obexautofs.c:784:2: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read: ofs_read,
data/obexftp-0.24/fuse/obexfs.c:487:2: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read: ofs_read,
data/obexftp-0.24/multicobex/multi_cobex.c:40:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
#define usleep(t) Sleep((t) < 500 ? 1 : ((t) + 500) / 1000);
data/obexftp-0.24/multicobex/multi_cobex.c:169:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(1); // This mysteriously avoids a resource not available error on write()
data/obexftp-0.24/multicobex/multi_cobex.c:236:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
actual = read(c->fd, &(c->recv[c->recv_len]), sizeof(c->recv) - c->recv_len);
data/obexftp-0.24/obexftp/bt_kit.c:263:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!addr || strlen(addr) != 17) {
data/obexftp-0.24/obexftp/bt_kit.c:387:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(arg, di->devname, HCI_DEVNAME_SIZE);
data/obexftp-0.24/obexftp/bt_kit.c:714:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (src && strlen(src) == 17)
data/obexftp-0.24/obexftp/bt_kit.c:766:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (src && strlen(src) == 17)
data/obexftp-0.24/obexftp/bt_kit.c:845:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!addr || strlen(addr) != 17)
data/obexftp-0.24/obexftp/bt_kit.c:850:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (src && strlen(src) == 17)
data/obexftp-0.24/obexftp/cache.c:61:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p = copy = malloc(strlen(name) + 2); /* at most add two slashes */
data/obexftp-0.24/obexftp/cache.c:127:59: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
while (*root && !strncmp((*root)->name, pathonly, strlen(pathonly))) {
data/obexftp-0.24/obexftp/cache.c:133:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(cache->next->name, pathonly, strlen(pathonly))) {
data/obexftp-0.24/obexftp/cache.c:209:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
put_cache_object(cli, path, listing, strlen(listing));
data/obexftp-0.24/obexftp/cache.c:216:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
put_cache_object(cli, path, listing, strlen(listing));
data/obexftp-0.24/obexftp/cache.c:282:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n = strlen(xml) + 1;
data/obexftp-0.24/obexftp/client.c:155:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p = *basepath = malloc(strlen(name) + 1); /* cant be longer, can it? */
data/obexftp-0.24/obexftp/client.c:226:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
actual = read(cli->fd, cli->stream_chunk, STREAM_CHUNK);
data/obexftp-0.24/obexftp/obexftp_io.c:88:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ucname_len = strlen(remotename)*2 + 2;
data/obexftp-0.24/obexftp/obexftp_io.c:108:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
OBEX_ObjectAddHeader(obex, object, OBEX_HDR_TIME, hv, strlen(lastmod)+1, 0);
data/obexftp-0.24/obexftp/obexftp_io.c:130:5: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(name) >= 3) {
data/obexftp-0.24/obexftp/obexftp_io.c:154:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dest, name, n);
data/obexftp-0.24/obexftp/obexftp_io.c:157:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dest, path, n);
data/obexftp-0.24/obexftp/obexftp_io.c:159:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(dest);
data/obexftp-0.24/obexftp/obexftp_io.c:166:3: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(dest, name, n - strlen(dest) - 1);
data/obexftp-0.24/obexftp/obexftp_io.c:166:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncat(dest, name, n - strlen(dest) - 1);
data/obexftp-0.24/obexftp/obexftp_io.c:187:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
maxlen = strlen(name) + 1;
data/obexftp-0.24/obexftp/obexftp_io.c:189:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
maxlen += strlen(path);
data/obexftp-0.24/obexftp/obexftp_io.c:217:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
maxlen = strlen(dir) + 1;
data/obexftp-0.24/obexftp/obexftp_io.c:219:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
maxlen += strlen(path);
data/obexftp-0.24/obexftp/object.c:92:64: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(void) OBEX_ObjectAddHeader(obex, object, OBEX_HDR_TYPE, hv, strlen(type)+1, OBEX_FL_FIT_ONE_PACKET);
data/obexftp-0.24/obexftp/object.c:96:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ucname_len = strlen(name)*2 + 2;
data/obexftp-0.24/obexftp/object.c:148:3: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(from)*2 + 2 +
data/obexftp-0.24/obexftp/object.c:149:3: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(to)*2 + 2 + 2;
data/obexftp-0.24/obexftp/object.c:163:66: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ucname_len = CharToUnicode(appstr_p + 1, (uint8_t*)from, strlen(from)*2 + 2);
data/obexftp-0.24/obexftp/object.c:168:64: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ucname_len = CharToUnicode(appstr_p + 1, (uint8_t*)to, strlen(to)*2 + 2);
data/obexftp-0.24/obexftp/object.c:208:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ucname_len = strlen(name)*2 + 2;
data/obexftp-0.24/obexftp/object.c:262:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ucname_len = strlen(name)*2 + 2;
data/obexftp-0.24/obexftp/object.c:315:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ucname_len = strlen(name)*2 + 2;
data/obexftp-0.24/obexftp/unicode.c:94:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ni = strlen(cc) + 1;
data/obexftp-0.24/obexftp/unicode.c:110:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ni = strlen(cc) + 1;
data/obexftp-0.24/obexftp/unicode.c:124:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ni = strlen(cc) + 1;
data/obexftp-0.24/obexftp/unicode.c:141:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = n = strlen((char *) c);
data/obexftp-0.24/obexftp/unicode.c:253:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n = strlen(uc)*2+2;
data/obexftp-0.24/obexftp/unicode.c:276:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ni = strlen(ucc);
data/obexftp-0.24/obexftp/unicode.c:287:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n = strlen(uc);
data/obexftp-0.24/obexftp/unicode.c:288:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(c, uc, size);
ANALYSIS SUMMARY:
Hits = 179
Lines analyzed = 10445 in approximately 0.31 seconds (33806 lines/second)
Physical Source Lines of Code (SLOC) = 7132
Hits@level = [0] 217 [1] 65 [2] 73 [3] 12 [4] 22 [5] 7
Hits@level+ = [0+] 396 [1+] 179 [2+] 114 [3+] 41 [4+] 29 [5+] 7
Hits/KSLOC@level+ = [0+] 55.5244 [1+] 25.0981 [2+] 15.9843 [3+] 5.74874 [4+] 4.06618 [5+] 0.981492
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.