Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/osslsigncode-2.1/osslsigncode.c
Examining data/osslsigncode-2.1/tests/sources/myapp.c
FINAL RESULTS:
data/osslsigncode-2.1/osslsigncode.c:1312:24: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define DO_EXIT_0(x) { printf(x); goto err_cleanup; }
data/osslsigncode-2.1/osslsigncode.c:1313:27: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define DO_EXIT_1(x, y) { printf(x, y); goto err_cleanup; }
data/osslsigncode-2.1/osslsigncode.c:1314:30: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define DO_EXIT_2(x, y, z) { printf(x, y, z); goto err_cleanup; }
data/osslsigncode-2.1/osslsigncode.c:3102:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(options->outfile, R_OK)) {
data/osslsigncode-2.1/osslsigncode.c:3189:8: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(options->outfile, R_OK)) {
data/osslsigncode-2.1/osslsigncode.c:4692:9: [4] (misc) getpass:
This function is obsolete and not portable. It was in SUSv2 but removed by
POSIX.2. What it does exactly varies considerably between systems,
particularly in where its prompt is displayed and where it gets its data
(e.g., /dev/tty, stdin, stderr, etc.). In addition, some implementations
overflow buffers. (CWE-676, CWE-120, CWE-20). Make the specific calls to do
exactly what you want. If you continue to use it, or write your own, be
sure to zero the password as soon as possible to avoid leaving the
cleartext password visible in the process' address space.
return getpass(prompt);
data/osslsigncode-2.1/osslsigncode.c:5121:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(cafile, openssl_dir);
data/osslsigncode-2.1/osslsigncode.c:5122:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(cafile, sslpart2);
data/osslsigncode-2.1/osslsigncode.c:5213:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(options->outfile, R_OK)) {
data/osslsigncode-2.1/osslsigncode.c:5312:2: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf(PACKAGE_STRING ", using:\n\t%s (Library: %s)\n\t%s\n",
data/osslsigncode-2.1/osslsigncode.c:5320:2: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf(
data/osslsigncode-2.1/osslsigncode.c:5558:52: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if ((*cmd == CMD_VERIFY || *cmd == CMD_ATTACH) && access(options->cafile, R_OK)) {
data/osslsigncode-2.1/osslsigncode.c:5681:8: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(options.outfile, R_OK))
data/osslsigncode-2.1/osslsigncode.c:5801:2: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf(ret ? "Failed\n" : "Succeeded\n");
data/osslsigncode-2.1/osslsigncode.c:240:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *turl[MAX_TS_SERVERS];
data/osslsigncode-2.1/osslsigncode.c:242:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *tsurl[MAX_TS_SERVERS];
data/osslsigncode-2.1/osslsigncode.c:663:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(b+i*2, "%02X", v[i]);
data/osslsigncode-2.1/osslsigncode.c:739:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char mdbuf[EVP_MAX_MD_SIZE];
data/osslsigncode-2.1/osslsigncode.c:1435:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hexbuf[EVP_MAX_MD_SIZE*2+1];
data/osslsigncode-2.1/osslsigncode.c:1589:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char mdbuf[EVP_MAX_MD_SIZE];
data/osslsigncode-2.1/osslsigncode.c:1596:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf+len, mdbuf, mdlen);
data/osslsigncode-2.1/osslsigncode.c:1632:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char buf[64*1024];
data/osslsigncode-2.1/osslsigncode.c:1637:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, p, len);
data/osslsigncode-2.1/osslsigncode.c:1675:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4];
data/osslsigncode-2.1/osslsigncode.c:1687:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char cmdbuf[EVP_MAX_MD_SIZE];
data/osslsigncode-2.1/osslsigncode.c:1688:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hexbuf[EVP_MAX_MD_SIZE*2+1];
data/osslsigncode-2.1/osslsigncode.c:1861:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char object_txt[128];
data/osslsigncode-2.1/osslsigncode.c:2108:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char object_txt[128];
data/osslsigncode-2.1/osslsigncode.c:2218:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char mdbuf[EVP_MAX_MD_SIZE];
data/osslsigncode-2.1/osslsigncode.c:2219:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hexbuf[EVP_MAX_MD_SIZE*2+1];
data/osslsigncode-2.1/osslsigncode.c:2860:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char mdbuf[EVP_MAX_MD_SIZE];
data/osslsigncode-2.1/osslsigncode.c:2861:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char cmdbuf[EVP_MAX_MD_SIZE];
data/osslsigncode-2.1/osslsigncode.c:2863:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char cexmdbuf[EVP_MAX_MD_SIZE];
data/osslsigncode-2.1/osslsigncode.c:2865:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hexbuf[EVP_MAX_MD_SIZE*2+1];
data/osslsigncode-2.1/osslsigncode.c:2876:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(mdbuf, idc->messageDigest->digest->data, idc->messageDigest->digest->length);
data/osslsigncode-2.1/osslsigncode.c:3088:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hexbuf[EVP_MAX_MD_SIZE*2+1];
data/osslsigncode-2.1/osslsigncode.c:3336:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char bfb[16*1024*1024];
data/osslsigncode-2.1/osslsigncode.c:3378:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128];
data/osslsigncode-2.1/osslsigncode.c:3421:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(*ph, obj->value->value.sequence->data + l, *phlen);
data/osslsigncode-2.1/osslsigncode.c:3429:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char mdbuf[EVP_MAX_MD_SIZE];
data/osslsigncode-2.1/osslsigncode.c:3430:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char cmdbuf[EVP_MAX_MD_SIZE];
data/osslsigncode-2.1/osslsigncode.c:3431:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hexbuf[EVP_MAX_MD_SIZE*2+1];
data/osslsigncode-2.1/osslsigncode.c:3444:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(mdbuf, idc->messageDigest->digest->data, idc->messageDigest->digest->length);
data/osslsigncode-2.1/osslsigncode.c:3640:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[64*1024];
data/osslsigncode-2.1/osslsigncode.c:3731:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char bfb[16*1024*1024];
data/osslsigncode-2.1/osslsigncode.c:3846:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char mdbuf[EVP_MAX_MD_SIZE];
data/osslsigncode-2.1/osslsigncode.c:3847:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char cmdbuf[EVP_MAX_MD_SIZE];
data/osslsigncode-2.1/osslsigncode.c:3848:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hexbuf[EVP_MAX_MD_SIZE*2+1];
data/osslsigncode-2.1/osslsigncode.c:3858:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(mdbuf, idc->messageDigest->digest->data, idc->messageDigest->digest->length);
data/osslsigncode-2.1/osslsigncode.c:4007:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[64*1024];
data/osslsigncode-2.1/osslsigncode.c:4068:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[64*1024];
data/osslsigncode-2.1/osslsigncode.c:4125:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[64*1024];
data/osslsigncode-2.1/osslsigncode.c:4154:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf+4, indata+20, 10);
data/osslsigncode-2.1/osslsigncode.c:4158:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf+16, indata+32, 2);
data/osslsigncode-2.1/osslsigncode.c:4162:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(cabsigned+8, buf, 4);
data/osslsigncode-2.1/osslsigncode.c:4349:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, prefix, sizeof(prefix));
data/osslsigncode-2.1/osslsigncode.c:4350:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p+len-sizeof(postfix), postfix, sizeof(postfix));
data/osslsigncode-2.1/osslsigncode.c:4372:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[64*1024];
data/osslsigncode-2.1/osslsigncode.c:4433:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[64*1024];
data/osslsigncode-2.1/osslsigncode.c:4516:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int fd = open(infile, O_RDONLY);
data/osslsigncode-2.1/osslsigncode.c:4667:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *p, passbuf[1024], *pass;
data/osslsigncode-2.1/osslsigncode.c:4699:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char passbuf[4096];
data/osslsigncode-2.1/osslsigncode.c:4703:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
passfd = open(options->readpass, O_RDONLY);
data/osslsigncode-2.1/osslsigncode.c:4891:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char magic[4];
data/osslsigncode-2.1/osslsigncode.c:4893:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char pvkhdr[4] = { 0x1e, 0xf1, 0xb5, 0xb0 };
data/osslsigncode-2.1/osslsigncode.c:624:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(const unsigned char*)desc, strlen(desc));
data/osslsigncode-2.1/osslsigncode.c:631:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(const unsigned char*)url, strlen(url));
data/osslsigncode-2.1/osslsigncode.c:4687:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
passbuf[strlen(passbuf)-1] = 0x00;
data/osslsigncode-2.1/osslsigncode.c:4708:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
passlen = read(passfd, passbuf, sizeof(passbuf)-1);
data/osslsigncode-2.1/osslsigncode.c:5070:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset(options->pass, 0, strlen(options->pass));
data/osslsigncode-2.1/osslsigncode.c:5120:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cafile = OPENSSL_malloc(strlen(sslpart1) + strlen(sslpart2) + 1);
data/osslsigncode-2.1/osslsigncode.c:5120:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cafile = OPENSSL_malloc(strlen(sslpart1) + strlen(sslpart2) + 1);
data/osslsigncode-2.1/osslsigncode.c:5417:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset(*argv, 0, strlen(*argv));
ANALYSIS SUMMARY:
Hits = 73
Lines analyzed = 5819 in approximately 0.20 seconds (29716 lines/second)
Physical Source Lines of Code (SLOC) = 4665
Hits@level = [0] 345 [1] 8 [2] 51 [3] 0 [4] 14 [5] 0
Hits@level+ = [0+] 418 [1+] 73 [2+] 65 [3+] 14 [4+] 14 [5+] 0
Hits/KSLOC@level+ = [0+] 89.6034 [1+] 15.6484 [2+] 13.9335 [3+] 3.00107 [4+] 3.00107 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.