Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-config.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-config.h
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-databases.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-databases.h
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-depends.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-environment.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-environment.h
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-error.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-error.h
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-groups.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-groups.h
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-install.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-packages.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-packages.h
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-remove.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-search.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-sync.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-transaction.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-transaction.h
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-update.c
Examining data/packagekit-1.2.1/backends/alpm/pk-alpm-update.h
Examining data/packagekit-1.2.1/backends/alpm/pk-backend-alpm.c
Examining data/packagekit-1.2.1/backends/alpm/pk-backend-alpm.h
Examining data/packagekit-1.2.1/backends/aptcc/acqpkitstatus.cpp
Examining data/packagekit-1.2.1/backends/aptcc/acqpkitstatus.h
Examining data/packagekit-1.2.1/backends/aptcc/apt-cache-file.cpp
Examining data/packagekit-1.2.1/backends/aptcc/apt-cache-file.h
Examining data/packagekit-1.2.1/backends/aptcc/apt-intf.h
Examining data/packagekit-1.2.1/backends/aptcc/apt-messages.cpp
Examining data/packagekit-1.2.1/backends/aptcc/apt-messages.h
Examining data/packagekit-1.2.1/backends/aptcc/apt-sourceslist.cpp
Examining data/packagekit-1.2.1/backends/aptcc/apt-sourceslist.h
Examining data/packagekit-1.2.1/backends/aptcc/apt-utils.cpp
Examining data/packagekit-1.2.1/backends/aptcc/apt-utils.h
Examining data/packagekit-1.2.1/backends/aptcc/deb-file.cpp
Examining data/packagekit-1.2.1/backends/aptcc/deb-file.h
Examining data/packagekit-1.2.1/backends/aptcc/gst-matcher.cpp
Examining data/packagekit-1.2.1/backends/aptcc/gst-matcher.h
Examining data/packagekit-1.2.1/backends/aptcc/pk-backend-aptcc.cpp
Examining data/packagekit-1.2.1/backends/aptcc/pk-debconf-helper.c
Examining data/packagekit-1.2.1/backends/aptcc/pkg-list.cpp
Examining data/packagekit-1.2.1/backends/aptcc/pkg-list.h
Examining data/packagekit-1.2.1/backends/aptcc/apt-intf.cpp
Examining data/packagekit-1.2.1/backends/dnf/dnf-backend-vendor-fedora.c
Examining data/packagekit-1.2.1/backends/dnf/dnf-backend-vendor-mageia.c
Examining data/packagekit-1.2.1/backends/dnf/dnf-backend-vendor-openmandriva.c
Examining data/packagekit-1.2.1/backends/dnf/dnf-backend-vendor-opensuse.c
Examining data/packagekit-1.2.1/backends/dnf/dnf-backend-vendor-rosa.c
Examining data/packagekit-1.2.1/backends/dnf/dnf-backend-vendor.h
Examining data/packagekit-1.2.1/backends/dnf/dnf-backend.c
Examining data/packagekit-1.2.1/backends/dnf/dnf-backend.h
Examining data/packagekit-1.2.1/backends/dnf/pk-backend-dnf.c
Examining data/packagekit-1.2.1/backends/dummy/pk-backend-dummy.c
Examining data/packagekit-1.2.1/backends/entropy/pk-backend-entropy.c
Examining data/packagekit-1.2.1/backends/nix/nix-helpers.cc
Examining data/packagekit-1.2.1/backends/nix/nix-lib-plus.cc
Examining data/packagekit-1.2.1/backends/nix/pk-backend-nix.cc
Examining data/packagekit-1.2.1/backends/poldek/pk-backend-poldek.c
Examining data/packagekit-1.2.1/backends/portage/pk-backend-portage.c
Examining data/packagekit-1.2.1/backends/slack/dl.cc
Examining data/packagekit-1.2.1/backends/slack/dl.h
Examining data/packagekit-1.2.1/backends/slack/job.cc
Examining data/packagekit-1.2.1/backends/slack/job.h
Examining data/packagekit-1.2.1/backends/slack/pk-backend-slack.cc
Examining data/packagekit-1.2.1/backends/slack/pkgtools.cc
Examining data/packagekit-1.2.1/backends/slack/pkgtools.h
Examining data/packagekit-1.2.1/backends/slack/slackpkg.cc
Examining data/packagekit-1.2.1/backends/slack/slackpkg.h
Examining data/packagekit-1.2.1/backends/slack/tests/definitions.cc
Examining data/packagekit-1.2.1/backends/slack/tests/dl-test.cc
Examining data/packagekit-1.2.1/backends/slack/tests/job-test.cc
Examining data/packagekit-1.2.1/backends/slack/tests/slackpkg-test.cc
Examining data/packagekit-1.2.1/backends/slack/utils.cc
Examining data/packagekit-1.2.1/backends/slack/utils.h
Examining data/packagekit-1.2.1/backends/test/pk-backend-test-fail.c
Examining data/packagekit-1.2.1/backends/test/pk-backend-test-nop.c
Examining data/packagekit-1.2.1/backends/test/pk-backend-test-spawn.c
Examining data/packagekit-1.2.1/backends/test/pk-backend-test-succeed.c
Examining data/packagekit-1.2.1/backends/test/pk-backend-test-thread.c
Examining data/packagekit-1.2.1/backends/zypp/pk-backend-zypp.cpp
Examining data/packagekit-1.2.1/client/pk-console.c
Examining data/packagekit-1.2.1/client/pk-monitor.c
Examining data/packagekit-1.2.1/client/pk-offline-update.c
Examining data/packagekit-1.2.1/contrib/command-not-found/pk-command-not-found.c
Examining data/packagekit-1.2.1/contrib/gstreamer-plugin/pk-gstreamer-install.c
Examining data/packagekit-1.2.1/contrib/gtk-module/pk-gtk-module.c
Examining data/packagekit-1.2.1/docs/html/files/session.c
Examining data/packagekit-1.2.1/docs/html/files/system.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/packagekit-private.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/packagekit.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-bitfield.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-bitfield.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-category.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-category.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-client-helper.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-client-helper.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-client-sync.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-client-sync.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-client.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-client.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-common-private.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-common.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-common.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-console-shared.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-console-shared.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-control-sync.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-control-sync.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-control.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-control.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-debug.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-debug.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-desktop.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-desktop.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-details.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-details.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-distro-upgrade.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-distro-upgrade.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-enum.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-enum.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-error.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-error.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-eula-required.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-eula-required.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-files.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-files.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-item-progress.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-item-progress.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-media-change-required.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-media-change-required.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-offline-private.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-offline-private.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-offline.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-offline.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-package-id.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-package-id.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-package-ids.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-package-ids.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-package-sack-sync.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-package-sack-sync.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-package-sack.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-package-sack.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-package.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-package.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-progress-bar.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-progress-bar.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-progress.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-progress.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-repo-detail.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-repo-detail.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-repo-signature-required.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-repo-signature-required.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-require-restart.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-require-restart.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-results.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-results.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-socket-example.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-source.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-source.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-spawn-polkit-agent.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-spawn-polkit-agent.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-task-sync.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-task-sync.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-task-text.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-task-text.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-task-wrapper.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-task-wrapper.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-task.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-task.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-test-daemon.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-test-private.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-transaction-list.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-transaction-list.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-transaction-past.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-transaction-past.h
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-update-detail.c
Examining data/packagekit-1.2.1/lib/packagekit-glib2/pk-update-detail.h
Examining data/packagekit-1.2.1/src/packagekit-plugin.h
Examining data/packagekit-1.2.1/src/pk-backend-job.c
Examining data/packagekit-1.2.1/src/pk-backend-job.h
Examining data/packagekit-1.2.1/src/pk-backend-spawn.c
Examining data/packagekit-1.2.1/src/pk-backend-spawn.h
Examining data/packagekit-1.2.1/src/pk-backend.c
Examining data/packagekit-1.2.1/src/pk-backend.h
Examining data/packagekit-1.2.1/src/pk-dbus.c
Examining data/packagekit-1.2.1/src/pk-dbus.h
Examining data/packagekit-1.2.1/src/pk-direct.c
Examining data/packagekit-1.2.1/src/pk-engine.c
Examining data/packagekit-1.2.1/src/pk-engine.h
Examining data/packagekit-1.2.1/src/pk-main.c
Examining data/packagekit-1.2.1/src/pk-scheduler.c
Examining data/packagekit-1.2.1/src/pk-scheduler.h
Examining data/packagekit-1.2.1/src/pk-self-test.c
Examining data/packagekit-1.2.1/src/pk-shared.c
Examining data/packagekit-1.2.1/src/pk-shared.h
Examining data/packagekit-1.2.1/src/pk-spawn.c
Examining data/packagekit-1.2.1/src/pk-spawn.h
Examining data/packagekit-1.2.1/src/pk-transaction-db.c
Examining data/packagekit-1.2.1/src/pk-transaction-db.h
Examining data/packagekit-1.2.1/src/pk-transaction-private.h
Examining data/packagekit-1.2.1/src/pk-transaction.h
Examining data/packagekit-1.2.1/src/pk-transaction.c

FINAL RESULTS:

data/packagekit-1.2.1/backends/aptcc/apt-cache-file.cpp:216:29:  [4] (buffer) sprintf:
  Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
  vsnprintf.
                            sprintf(buffer, "but %s is installed", Ver.VerStr());
data/packagekit-1.2.1/backends/aptcc/apt-cache-file.cpp:218:29:  [4] (buffer) sprintf:
  Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
  vsnprintf.
                            sprintf(buffer, "but %s is to be installed", Ver.VerStr());
data/packagekit-1.2.1/backends/aptcc/apt-intf.cpp:2042:13:  [4] (buffer) strcat:
  Does not check for buffer overflows when concatenating to destination
  [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
  snprintf (warning: strncat is easily misused).
            strcat(line, buf);
data/packagekit-1.2.1/backends/nix/nix-helpers.cc:32:9:  [4] (shell) system:
  This causes a new program to execute and is difficult to use safely
  (CWE-78). try using a library call that implements the same functionality
  if available.
	string system (package_id_parts[2]);
data/packagekit-1.2.1/backends/nix/nix-helpers.cc:36:56:  [4] (shell) system:
  This causes a new program to execute and is difficult to use safely
  (CWE-78). try using a library call that implements the same functionality
  if available.
		if (drv.attrPath == attrPath && drv.querySystem() == system)
data/packagekit-1.2.1/backends/nix/nix-lib-plus.cc:61:14:  [4] (shell) system:
  This causes a new program to execute and is difficult to use safely
  (CWE-78). try using a library call that implements the same functionality
  if available.
        if (!system.empty())
data/packagekit-1.2.1/backends/nix/nix-lib-plus.cc:62:58:  [4] (shell) system:
  This causes a new program to execute and is difficult to use safely
  (CWE-78). try using a library call that implements the same functionality
  if available.
            mkString(*state.allocAttr(v, state.sSystem), system);
data/packagekit-1.2.1/backends/poldek/pk-backend-poldek.c:399:9:  [4] (race) access:
  This usually indicates a security flaw. If an attacker can change anything
  along the path between the call to access() and the file's actual use
  (e.g., by moving files), the attacker can exploit the race condition
  (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
  and try to open the file directly.
				if (access(path, R_OK) != 0) {
data/packagekit-1.2.1/backends/zypp/pk-backend-zypp.cpp:3836:26:  [4] (race) access:
  This usually indicates a security flaw. If an attacker can change anything
  along the path between the call to access() and the file's actual use
  (e.g., by moving files), the attacker can exploit the race condition
  (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
  and try to open the file directly.
			repo::RepoMediaAccess access;
data/packagekit-1.2.1/backends/zypp/pk-backend-zypp.cpp:3841:42:  [4] (race) access:
  This usually indicates a security flaw. If an attacker can change anything
  along the path between the call to access() and the file's actual use
  (e.g., by moving files), the attacker can exploit the race condition
  (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
  and try to open the file directly.
				repo::SrcPackageProvider pkgProvider(access);
data/packagekit-1.2.1/backends/zypp/pk-backend-zypp.cpp:3845:39:  [4] (race) access:
  This usually indicates a security flaw. If an attacker can change anything
  along the path between the call to access() and the file's actual use
  (e.g., by moving files), the attacker can exploit the race condition
  (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
  and try to open the file directly.
				repo::PackageProvider pkgProvider(access, package, deltas);
data/packagekit-1.2.1/lib/packagekit-glib2/pk-spawn-polkit-agent.c:130:2:  [4] (shell) execv:
  This causes a new program to execute and is difficult to use safely
  (CWE-78). try using a library call that implements the same functionality
  if available.
	execv (path, l);
data/packagekit-1.2.1/backends/dnf/pk-backend-dnf.c:634:9:  [3] (buffer) realpath:
  This function does not protect against buffer overflows, and some
  implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
  destination buffer is at least of size MAXPATHLEN, andto protect against
  implementation problems, the input argument should also be checked to
  ensure it is no larger than MAXPATHLEN.
	temp = realpath (path, NULL);
data/packagekit-1.2.1/lib/packagekit-glib2/pk-client.c:296:9:  [3] (buffer) realpath:
  This function does not protect against buffer overflows, and some
  implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
  destination buffer is at least of size MAXPATHLEN, andto protect against
  implementation problems, the input argument should also be checked to
  ensure it is no larger than MAXPATHLEN.
	temp = realpath (path, abs_path);
data/packagekit-1.2.1/lib/packagekit-glib2/pk-client.c:1991:38:  [3] (buffer) g_get_tmp_dir:
  This function is synonymous with 'getenv("TMP")';it returns untrustable
  input if the environment can beset by an attacker. It can have any content
  and length, and the same variable can be set more than once (CWE-807,
  CWE-20). Check environment variables carefully before using them.
	socket_filename = g_build_filename (g_get_tmp_dir (), socket_id, NULL);
data/packagekit-1.2.1/lib/packagekit-glib2/pk-test-daemon.c:246:31:  [3] (buffer) g_get_tmp_dir:
  This function is synonymous with 'getenv("TMP")';it returns untrustable
  input if the environment can beset by an attacker. It can have any content
  and length, and the same variable can be set more than once (CWE-807,
  CWE-20). Check environment variables carefully before using them.
	filename = g_build_filename (g_get_tmp_dir (), "pk-self-test.socket", NULL);
data/packagekit-1.2.1/src/pk-backend-spawn.c:822:12:  [3] (random) g_random_int_range:
  This function is not sufficiently random for security-related functions
  such as key and nonce creation (CWE-327). Use a more secure technique for
  acquiring random values.
						     g_random_int_range (1, 999999)));
data/packagekit-1.2.1/src/pk-transaction-db.c:505:9:  [3] (random) g_rand_int_range:
  This function is not sufficiently random for security-related functions
  such as key and nonce creation (CWE-327). Use a more secure technique for
  acquiring random values.
		num = g_rand_int_range (gen, (gint32) 'a', (gint32) 'f');
data/packagekit-1.2.1/backends/alpm/pk-alpm-update.c:487:10:  [2] (misc) fopen:
  Check when opening files - can an attacker redirect it (via symlinks),
  force the opening of special file type (e.g., device files), move things
  around to create a race condition, control its ancestors, or change its
  contents? (CWE-362).
		file = fopen("/tmp/packagekit-alpm-updates", "r");
data/packagekit-1.2.1/backends/alpm/pk-alpm-update.c:503:9:  [2] (misc) fopen:
  Check when opening files - can an attacker redirect it (via symlinks),
  force the opening of special file type (e.g., device files), move things
  around to create a race condition, control its ancestors, or change its
  contents? (CWE-362).
	file = fopen("/tmp/packagekit-alpm-updates", "w");
data/packagekit-1.2.1/backends/aptcc/apt-cache-file.cpp:214:25:  [2] (buffer) char:
  Statically-sized arrays can be improperly restricted, leading to potential
  overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
  functions that limit length, or ensure that the size is larger than the
  maximum possible length.
                        char buffer[1024];
data/packagekit-1.2.1/backends/aptcc/apt-cache-file.cpp:342:17:  [2] (buffer) char:
  Statically-sized arrays can be improperly restricted, leading to potential
  overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
  functions that limit length, or ensure that the size is larger than the
  maximum possible length.
                char S[300];
data/packagekit-1.2.1/backends/aptcc/apt-intf.cpp:1747:5:  [2] (buffer) char:
  Statically-sized arrays can be improperly restricted, leading to potential
  overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
  functions that limit length, or ensure that the size is larger than the
  maximum possible length.
    char buf[2];
data/packagekit-1.2.1/backends/aptcc/apt-intf.cpp:1748:12:  [2] (buffer) char:
  Statically-sized arrays can be improperly restricted, leading to potential
  overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
  functions that limit length, or ensure that the size is larger than the
  maximum possible length.
    static char line[1024] = "";
data/packagekit-1.2.1/backends/aptcc/apt-intf.cpp:2032:23:  [2] (integer) atoi:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
            int val = atoi(percent);
data/packagekit-1.2.1/backends/aptcc/apt-intf.cpp:2562:5:  [2] (buffer) char:
  Statically-sized arrays can be improperly restricted, leading to potential
  overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
  functions that limit length, or ensure that the size is larger than the
  maximum possible length.
    char masterbuf[1024];
data/packagekit-1.2.1/backends/aptcc/apt-sourceslist.cpp:67:5:  [2] (buffer) char:
  Statically-sized arrays can be improperly restricted, leading to potential
  overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
  functions that limit length, or ensure that the size is larger than the
  maximum possible length.
    char buf[512];
data/packagekit-1.2.1/backends/dummy/pk-backend-dummy.c:1379:23:  [2] (integer) atoi:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
		priv->use_blocked = atoi (value);
data/packagekit-1.2.1/backends/dummy/pk-backend-dummy.c:1381:20:  [2] (integer) atoi:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
		priv->use_eula = atoi (value);
data/packagekit-1.2.1/backends/dummy/pk-backend-dummy.c:1383:21:  [2] (integer) atoi:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
		priv->use_media = atoi (value);
data/packagekit-1.2.1/backends/dummy/pk-backend-dummy.c:1385:19:  [2] (integer) atoi:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
		priv->use_gpg = atoi (value);
data/packagekit-1.2.1/backends/dummy/pk-backend-dummy.c:1387:23:  [2] (integer) atoi:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
		priv->use_trusted = atoi (value);
data/packagekit-1.2.1/backends/dummy/pk-backend-dummy.c:1389:30:  [2] (integer) atoi:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
		priv->use_distro_upgrade = atoi (value);
data/packagekit-1.2.1/backends/poldek/pk-backend-poldek.c:286:2:  [2] (buffer) memcpy:
  Does not check for buffer overflows when copying to destination (CWE-120).
  Make sure destination can always hold the source data.
	memcpy (copy, lang, len);
data/packagekit-1.2.1/backends/slack/dl.cc:174:31:  [2] (integer) atoi:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
				sqlite3_bind_int(stmt, 7, atoi(line_tokens[5]));
data/packagekit-1.2.1/backends/slack/dl.cc:175:31:  [2] (integer) atoi:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
				sqlite3_bind_int(stmt, 8, atoi(line_tokens[5]));
data/packagekit-1.2.1/backends/slack/slackpkg.cc:40:13:  [2] (misc) fopen:
  Check when opening files - can an attacker redirect it (via symlinks),
  force the opening of special file type (e.g., device files), move things
  around to create a race condition, control its ancestors, or change its
  contents? (CWE-362).
	manifest = fopen(path, "rb");
data/packagekit-1.2.1/backends/slack/slackpkg.cc:352:21:  [2] (integer) atoi:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
			pkg_compressed = atoi(g_strndup(line + 28, strlen(line + 28) - 2)) * 1024;
data/packagekit-1.2.1/backends/slack/slackpkg.cc:357:23:  [2] (integer) atoi:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
			pkg_uncompressed = atoi(g_strndup(line + 30, strlen(line + 30) - 2)) * 1024;
data/packagekit-1.2.1/backends/slack/utils.cc:54:15:  [2] (misc) fopen:
  Check when opening files - can an attacker redirect it (via symlinks),
  force the opening of special file type (e.g., device files), move things
  around to create a race condition, control its ancestors, or change its
  contents? (CWE-362).
		if ((fout = fopen(dest, "ab")) == NULL)
data/packagekit-1.2.1/client/pk-console.c:2053:11:  [2] (integer) atoi:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
					     atoi (details),
data/packagekit-1.2.1/lib/packagekit-glib2/pk-console-shared.c:59:3:  [2] (buffer) char:
  Statically-sized arrays can be improperly restricted, leading to potential
  overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
  functions that limit length, or ensure that the size is larger than the
  maximum possible length.
		char buffer[64];
data/packagekit-1.2.1/lib/packagekit-glib2/pk-console-shared.c:97:8:  [2] (misc) fopen:
  Check when opening files - can an attacker redirect it (via symlinks),
  force the opening of special file type (e.g., device files), move things
  around to create a race condition, control its ancestors, or change its
  contents? (CWE-362).
	tty = fopen (tty_name, "r+");
data/packagekit-1.2.1/lib/packagekit-glib2/pk-progress-bar.c:401:23:  [2] (misc) open:
  Check when opening files - can an attacker redirect it (via symlinks),
  force the opening of special file type (e.g., device files), move things
  around to create a race condition, control its ancestors, or change its
  contents? (CWE-362).
	self->priv->tty_fd = open ("/dev/tty", O_RDWR, 0);
data/packagekit-1.2.1/lib/packagekit-glib2/pk-progress-bar.c:403:24:  [2] (misc) open:
  Check when opening files - can an attacker redirect it (via symlinks),
  force the opening of special file type (e.g., device files), move things
  around to create a race condition, control its ancestors, or change its
  contents? (CWE-362).
		self->priv->tty_fd = open ("/dev/console", O_RDWR, 0);
data/packagekit-1.2.1/lib/packagekit-glib2/pk-progress-bar.c:405:24:  [2] (misc) open:
  Check when opening files - can an attacker redirect it (via symlinks),
  force the opening of special file type (e.g., device files), move things
  around to create a race condition, control its ancestors, or change its
  contents? (CWE-362).
		self->priv->tty_fd = open ("/dev/stdout", O_RDWR, 0);
data/packagekit-1.2.1/lib/packagekit-glib2/pk-spawn-polkit-agent.c:99:8:  [2] (misc) open:
  Check when opening files - can an attacker redirect it (via symlinks),
  force the opening of special file type (e.g., device files), move things
  around to create a race condition, control its ancestors, or change its
  contents? (CWE-362).
		fd = open("/dev/tty", O_WRONLY);
data/packagekit-1.2.1/lib/packagekit-glib2/pk-spawn-polkit-agent.c:199:2:  [2] (buffer) char:
  Statically-sized arrays can be improperly restricted, leading to potential
  overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
  functions that limit length, or ensure that the size is larger than the
  maximum possible length.
	char notify_fd[10 + 1];
data/packagekit-1.2.1/src/pk-shared.c:449:3:  [2] (buffer) memcpy:
  Does not check for buffer overflows when copying to destination (CWE-120).
  Make sure destination can always hold the source data.
		memcpy (tmp, replace, replace_len);
data/packagekit-1.2.1/backends/alpm/pk-alpm-config.c:222:11:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	length = strlen (path) + 1;
data/packagekit-1.2.1/backends/alpm/pk-alpm-update.c:100:14:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
		length_a = strlen (version_a);
data/packagekit-1.2.1/backends/alpm/pk-alpm-update.c:106:14:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
		length_b = strlen (version_b);
data/packagekit-1.2.1/backends/aptcc/apt-cache-file.cpp:142:27:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
        unsigned Indent = strlen(I.Name()) + 3;
data/packagekit-1.2.1/backends/aptcc/apt-cache-file.cpp:187:47:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
                    for (unsigned J = 0; J != strlen(End.DepType()) + 3; J++) {
data/packagekit-1.2.1/backends/aptcc/apt-intf.cpp:1213:13:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
        if (strlen(value) < 1) {
data/packagekit-1.2.1/backends/aptcc/apt-intf.cpp:1752:19:  [1] (buffer) read:
  Check buffer boundaries if used in a loop including recursive loops
  (CWE-120, CWE-20).
        int len = read(fd, buf, 1);
data/packagekit-1.2.1/backends/aptcc/apt-intf.cpp:2049:9:  [1] (obsolete) usleep:
  This C routine is considered obsolete (as opposed to the shell command by
  the same name). The interaction of this function with SIGALRM and other
  timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
  unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
        usleep(100000);
data/packagekit-1.2.1/backends/aptcc/apt-intf.cpp:2062:5:  [1] (obsolete) usleep:
  This C routine is considered obsolete (as opposed to the shell command by
  the same name). The interaction of this function with SIGALRM and other
  timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
  unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
    usleep(5000);
data/packagekit-1.2.1/backends/aptcc/apt-intf.cpp:2565:15:  [1] (buffer) read:
  Check buffer boundaries if used in a loop including recursive loops
  (CWE-120, CWE-20).
        while(read(pty_master, masterbuf, sizeof(masterbuf)) > 0);
data/packagekit-1.2.1/backends/aptcc/apt-sourceslist.cpp:207:34:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
        if (strcmp(Ent->d_name + strlen(Ent->d_name) - 5, ".list") != 0) {
data/packagekit-1.2.1/backends/aptcc/apt-utils.cpp:242:70:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
                        _system->VS->DoCmpVersion(version, version + strlen(version),
data/packagekit-1.2.1/backends/aptcc/apt-utils.cpp:243:88:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
                                                  currver.VerStr(), currver.VerStr() + strlen(currver.VerStr())) <= 0) {
data/packagekit-1.2.1/backends/aptcc/apt-utils.cpp:384:22:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
    size_t endSize = strlen(end);
data/packagekit-1.2.1/backends/aptcc/apt-utils.cpp:390:24:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
    size_t startSize = strlen(start);
data/packagekit-1.2.1/backends/poldek/pk-backend-poldek.c:244:20:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	newlang = malloc (strlen (lang));
data/packagekit-1.2.1/backends/poldek/pk-backend-poldek.c:249:20:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
		n_strncpy (p, q, strlen (q) + 1);
data/packagekit-1.2.1/backends/poldek/pk-backend-poldek.c:251:19:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
		n_strncpy(p, q, strlen(q) + 1);
data/packagekit-1.2.1/backends/poldek/pk-backend-poldek.c:284:8:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	len = strlen (lang) + 1;
data/packagekit-1.2.1/backends/poldek/pk-backend-poldek.c:425:49:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
		pkgname = g_strndup (filename, (sizeof(gchar)*strlen(filename)-4));
data/packagekit-1.2.1/backends/poldek/pk-backend-poldek.c:1031:15:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	if (chlog && strlen (chlog) > 0) {
data/packagekit-1.2.1/backends/poldek/pk-backend-poldek.c:1043:8:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
			if (strlen (s) < 13) /* CVE-XXXX-YYYY has 13 chars */
data/packagekit-1.2.1/backends/poldek/pk-backend-poldek.c:1973:33:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	return strncmp (p->name, name, strlen (name));
data/packagekit-1.2.1/backends/slack/slackpkg.cc:352:47:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
			pkg_compressed = atoi(g_strndup(line + 28, strlen(line + 28) - 2)) * 1024;
data/packagekit-1.2.1/backends/slack/slackpkg.cc:357:49:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
			pkg_uncompressed = atoi(g_strndup(line + 30, strlen(line + 30) - 2)) * 1024;
data/packagekit-1.2.1/backends/slack/slackpkg.cc:367:38:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
				summary = g_strndup(summary + 1, strlen(summary) - 2); /* Without ( ) */
data/packagekit-1.2.1/backends/slack/slackpkg.cc:370:19:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
			pkg_name_len = strlen(pkg_tokens[0]); /* Description begins with pkg_name: */
data/packagekit-1.2.1/backends/slack/utils.cc:81:13:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	gint len = strlen(pkg_filename);
data/packagekit-1.2.1/backends/slack/utils.cc:149:30:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
    for (it = pkg_fullname + strlen(pkg_fullname); it != pkg_fullname; --it)
data/packagekit-1.2.1/backends/slack/utils.cc:190:20:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
			for (it = dir + strlen(dir); it != dir; --it)
data/packagekit-1.2.1/backends/zypp/pk-backend-zypp.cpp:3592:18:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
			gint length = strlen (value);
data/packagekit-1.2.1/contrib/command-not-found/pk-command-not-found.c:766:8:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	len = strlen (argv[1]);
data/packagekit-1.2.1/lib/packagekit-glib2/pk-console-shared.c:64:7:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
		if (strlen (buffer) == sizeof (buffer) - 1)
data/packagekit-1.2.1/lib/packagekit-glib2/pk-console-shared.c:117:7:  [1] (buffer) getc:
  Check buffer boundaries if used in a loop including recursive loops
  (CWE-120, CWE-20).
		c = getc (tty);
data/packagekit-1.2.1/lib/packagekit-glib2/pk-debug.c:114:15:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
		guint len = strlen (log_domain);
data/packagekit-1.2.1/lib/packagekit-glib2/pk-progress-bar.c:62:10:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	count = strlen (tmp) + 1;
data/packagekit-1.2.1/src/pk-direct.c:124:9:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
		len = strlen (item->name) + 2;
data/packagekit-1.2.1/src/pk-direct.c:128:11:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
			len += strlen (item->arguments) + 1;
data/packagekit-1.2.1/src/pk-shared.c:427:15:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	search_len = strlen (search);
data/packagekit-1.2.1/src/pk-shared.c:428:16:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	replace_len = strlen (replace);

ANALYSIS SUMMARY:

Hits = 89
Lines analyzed = 92328 in approximately 1.96 seconds (47123 lines/second)
Physical Source Lines of Code (SLOC) = 62474
Hits@level = [0]  38 [1]  40 [2]  31 [3]   6 [4]  12 [5]   0
Hits@level+ = [0+] 127 [1+]  89 [2+]  49 [3+]  18 [4+]  12 [5+]   0
Hits/KSLOC@level+ = [0+] 2.03285 [1+] 1.42459 [2+] 0.784326 [3+] 0.28812 [4+] 0.19208 [5+]   0
Symlinks skipped = 1 (--allowlink overrides but see doc for security issue)
Dot directories skipped = 2 (--followdotdir overrides)
Suppressed hits = 11 (use --neverignore to show them)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.