Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/paperkey-1.6/extract.c
Examining data/paperkey-1.6/extract.h
Examining data/paperkey-1.6/restore.c
Examining data/paperkey-1.6/parse.c
Examining data/paperkey-1.6/paperkey.c
Examining data/paperkey-1.6/gl/unistd.in.h
Examining data/paperkey-1.6/gl/arg-nonnull.h
Examining data/paperkey-1.6/gl/sys_types.in.h
Examining data/paperkey-1.6/gl/stdalign.in.h
Examining data/paperkey-1.6/gl/stdint.in.h
Examining data/paperkey-1.6/gl/c++defs.h
Examining data/paperkey-1.6/gl/gl_openssl.h
Examining data/paperkey-1.6/gl/sha1.c
Examining data/paperkey-1.6/gl/getopt-pfx-ext.h
Examining data/paperkey-1.6/gl/getopt-ext.h
Examining data/paperkey-1.6/gl/getopt.c
Examining data/paperkey-1.6/gl/getopt.in.h
Examining data/paperkey-1.6/gl/limits.in.h
Examining data/paperkey-1.6/gl/sha1.h
Examining data/paperkey-1.6/gl/unistd.c
Examining data/paperkey-1.6/gl/getopt-core.h
Examining data/paperkey-1.6/gl/getopt-pfx-core.h
Examining data/paperkey-1.6/gl/warn-on-use.h
Examining data/paperkey-1.6/gl/getopt-cdefs.in.h
Examining data/paperkey-1.6/gl/gettext.h
Examining data/paperkey-1.6/gl/getopt_int.h
Examining data/paperkey-1.6/gl/stddef.in.h
Examining data/paperkey-1.6/gl/getopt1.c
Examining data/paperkey-1.6/packets.c
Examining data/paperkey-1.6/output.h
Examining data/paperkey-1.6/restore.h
Examining data/paperkey-1.6/parse.h
Examining data/paperkey-1.6/output.c
Examining data/paperkey-1.6/packets.h
FINAL RESULTS:
data/paperkey-1.6/gl/unistd.in.h:263:18: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
_GL_WARN_ON_USE (chown, "chdir is not always in <unistd.h> - "
data/paperkey-1.6/gl/unistd.in.h:277:11: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
# undef chown
data/paperkey-1.6/gl/unistd.in.h:278:12: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
# define chown rpl_chown
data/paperkey-1.6/gl/unistd.in.h:280:19: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
_GL_FUNCDECL_RPL (chown, int, (const char *file, uid_t uid, gid_t gid)
data/paperkey-1.6/gl/unistd.in.h:282:19: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
_GL_CXXALIAS_RPL (chown, int, (const char *file, uid_t uid, gid_t gid));
data/paperkey-1.6/gl/unistd.in.h:285:19: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
_GL_FUNCDECL_SYS (chown, int, (const char *file, uid_t uid, gid_t gid)
data/paperkey-1.6/gl/unistd.in.h:288:19: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
_GL_CXXALIAS_SYS (chown, int, (const char *file, uid_t uid, gid_t gid));
data/paperkey-1.6/gl/unistd.in.h:290:19: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
_GL_CXXALIASWARN (chown);
data/paperkey-1.6/gl/unistd.in.h:292:9: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
# undef chown
data/paperkey-1.6/gl/unistd.in.h:294:18: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
_GL_WARN_ON_USE (chown, "chown fails to follow symlinks on some systems and "
data/paperkey-1.6/gl/unistd.in.h:1272:12: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
# define readlink rpl_readlink
data/paperkey-1.6/gl/unistd.in.h:1274:19: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
_GL_FUNCDECL_RPL (readlink, ssize_t,
data/paperkey-1.6/gl/unistd.in.h:1277:19: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
_GL_CXXALIAS_RPL (readlink, ssize_t,
data/paperkey-1.6/gl/unistd.in.h:1281:19: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
_GL_FUNCDECL_SYS (readlink, ssize_t,
data/paperkey-1.6/gl/unistd.in.h:1285:19: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
_GL_CXXALIAS_SYS (readlink, ssize_t,
data/paperkey-1.6/gl/unistd.in.h:1288:19: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
_GL_CXXALIASWARN (readlink);
data/paperkey-1.6/gl/unistd.in.h:1290:9: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
# undef readlink
data/paperkey-1.6/gl/unistd.in.h:1292:18: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
_GL_WARN_ON_USE (readlink, "readlink is unportable - "
data/paperkey-1.6/gl/getopt.c:40:10: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
# define fprintf __fxprintf_nocancel
data/paperkey-1.6/gl/unistd.in.h:252:18: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
_GL_WARN_ON_USE (access, "the access function is a security risk - "
data/paperkey-1.6/gl/unistd.in.h:783:19: [4] (misc) getlogin:
It's often easy to fool getlogin. Sometimes it does not work at all,
because some program messed up the utmp file. Often, it gives only the
first 8 characters of the login name. The user currently logged in on the
controlling tty of our program need not be the user who started it. Avoid
getlogin() for security-related purposes (CWE-807). Use getpwuid(geteuid())
and extract the desired information instead.
_GL_FUNCDECL_SYS (getlogin, char *, (void));
data/paperkey-1.6/gl/unistd.in.h:785:19: [4] (misc) getlogin:
It's often easy to fool getlogin. Sometimes it does not work at all,
because some program messed up the utmp file. Often, it gives only the
first 8 characters of the login name. The user currently logged in on the
controlling tty of our program need not be the user who started it. Avoid
getlogin() for security-related purposes (CWE-807). Use getpwuid(geteuid())
and extract the desired information instead.
_GL_CXXALIAS_SYS (getlogin, char *, (void));
data/paperkey-1.6/gl/unistd.in.h:786:19: [4] (misc) getlogin:
It's often easy to fool getlogin. Sometimes it does not work at all,
because some program messed up the utmp file. Often, it gives only the
first 8 characters of the login name. The user currently logged in on the
controlling tty of our program need not be the user who started it. Avoid
getlogin() for security-related purposes (CWE-807). Use getpwuid(geteuid())
and extract the desired information instead.
_GL_CXXALIASWARN (getlogin);
data/paperkey-1.6/gl/unistd.in.h:788:9: [4] (misc) getlogin:
It's often easy to fool getlogin. Sometimes it does not work at all,
because some program messed up the utmp file. Often, it gives only the
first 8 characters of the login name. The user currently logged in on the
controlling tty of our program need not be the user who started it. Avoid
getlogin() for security-related purposes (CWE-807). Use getpwuid(geteuid())
and extract the desired information instead.
# undef getlogin
data/paperkey-1.6/gl/unistd.in.h:790:18: [4] (misc) getlogin:
It's often easy to fool getlogin. Sometimes it does not work at all,
because some program messed up the utmp file. Often, it gives only the
first 8 characters of the login name. The user currently logged in on the
controlling tty of our program need not be the user who started it. Avoid
getlogin() for security-related purposes (CWE-807). Use getpwuid(geteuid())
and extract the desired information instead.
_GL_WARN_ON_USE (getlogin, "getlogin is unportable - "
data/paperkey-1.6/gl/getopt-core.h:91:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt (int ___argc, char *const *___argv, const char *__shortopts)
data/paperkey-1.6/gl/getopt-ext.h:66:12: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt_long (int ___argc, char *__getopt_argv_const *___argv,
data/paperkey-1.6/gl/getopt-pfx-core.h:40:9: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
# undef getopt
data/paperkey-1.6/gl/getopt-pfx-core.h:45:10: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
# define getopt __GETOPT_ID (getopt)
data/paperkey-1.6/gl/getopt-pfx-core.h:45:30: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
# define getopt __GETOPT_ID (getopt)
data/paperkey-1.6/gl/getopt-pfx-ext.h:40:9: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
# undef getopt_long
data/paperkey-1.6/gl/getopt-pfx-ext.h:44:10: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
# define getopt_long __GETOPT_ID (getopt_long)
data/paperkey-1.6/gl/getopt-pfx-ext.h:44:35: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
# define getopt_long __GETOPT_ID (getopt_long)
data/paperkey-1.6/gl/getopt.c:405:33: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
else if (posixly_correct || !!getenv ("POSIXLY_CORRECT"))
data/paperkey-1.6/gl/getopt.c:736:14: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
GETOPT_ENTRY(getopt, 0)
data/paperkey-1.6/gl/getopt.c:739:14: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
GETOPT_ENTRY(getopt, 1)
data/paperkey-1.6/gl/getopt.c:758:11: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt (argc, argv, "abc:d:0123456789");
data/paperkey-1.6/gl/getopt1.c:28:1: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
getopt_long (int argc, char *__getopt_argv_const *argv, const char *options,
data/paperkey-1.6/gl/getopt1.c:94:11: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt_long (argc, argv, "abc:d:0123456789",
data/paperkey-1.6/paperkey.c:109:14: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while((arg=getopt_long(argc,argv,"hVvo:",long_options,NULL))!=-1)
data/paperkey-1.6/extract.c:33:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char fingerprint[20];
data/paperkey-1.6/gl/gettext.h:220:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg_ctxt_id[msgctxt_len + msgid_len];
data/paperkey-1.6/gl/gettext.h:222:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/paperkey-1.6/gl/gettext.h:231:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (msg_ctxt_id, msgctxt, msgctxt_len - 1);
data/paperkey-1.6/gl/gettext.h:233:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (msg_ctxt_id + msgctxt_len, msgid, msgid_len);
data/paperkey-1.6/gl/gettext.h:268:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg_ctxt_id[msgctxt_len + msgid_len];
data/paperkey-1.6/gl/gettext.h:270:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/paperkey-1.6/gl/gettext.h:279:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (msg_ctxt_id, msgctxt, msgctxt_len - 1);
data/paperkey-1.6/gl/gettext.h:281:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (msg_ctxt_id + msgctxt_len, msgid, msgid_len);
data/paperkey-1.6/gl/sha1.c:55:23: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const unsigned char fillbuf[64] = { 0x80, 0 /* , 0, 0, ... */ };
data/paperkey-1.6/gl/sha1.c:80:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (cp, &v, sizeof v);
data/paperkey-1.6/gl/sha1.c:116:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&((char *) ctx->buffer)[bytes], fillbuf, (size - 2) * 4 - bytes);
data/paperkey-1.6/gl/sha1.c:228:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&((char *) ctx->buffer)[left_over], buffer, add);
data/paperkey-1.6/gl/sha1.c:238:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (ctx->buffer,
data/paperkey-1.6/gl/sha1.c:255:33: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
sha1_process_block (memcpy (ctx->buffer, buffer, 64), 64, ctx);
data/paperkey-1.6/gl/sha1.c:273:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&((char *) ctx->buffer)[left_over], buffer, len);
data/paperkey-1.6/gl/sha1.c:281:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (ctx->buffer, &ctx->buffer[16], left_over);
data/paperkey-1.6/output.c:130:20: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
output_start(const char *name,enum data_type type,
data/paperkey-1.6/output.c:131:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char fingerprint[20])
data/paperkey-1.6/output.c:136:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
output=fopen(name,"wb");
data/paperkey-1.6/output.c:138:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
output=fopen(name,"w");
data/paperkey-1.6/output.c:193:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char crc[3];
data/paperkey-1.6/output.c:218:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char encoded[2];
data/paperkey-1.6/output.c:231:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char encoded[6];
data/paperkey-1.6/output.h:31:24: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
int output_start(const char *name,enum data_type type,
data/paperkey-1.6/output.h:32:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char fingerprint[20]);
data/paperkey-1.6/packets.c:53:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&packet->buf[packet->len],buf,len);
data/paperkey-1.6/packets.c:64:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(packet->buf,buf,len);
data/paperkey-1.6/paperkey.c:166:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
output_width=atoi(optarg);
data/paperkey-1.6/paperkey.c:170:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
secret_key=fopen(optarg,"rb");
data/paperkey-1.6/paperkey.c:179:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
pubring=fopen(optarg,"rb");
data/paperkey-1.6/paperkey.c:189:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
secrets=fopen(optarg,"rb");
data/paperkey-1.6/parse.c:199:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char fingerprint[20])
data/paperkey-1.6/parse.c:208:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char head[3];
data/paperkey-1.6/parse.c:342:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[1024];
data/paperkey-1.6/parse.c:367:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[1024];
data/paperkey-1.6/parse.c:379:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
linenum=atoi(line);
data/paperkey-1.6/parse.h:24:15: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char fingerprint[20]);
data/paperkey-1.6/restore.c:32:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char fpr[20];
data/paperkey-1.6/restore.c:65:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(newkey->fpr,&packet->buf[idx],20);
data/paperkey-1.6/restore.c:162:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char fpr[20];
data/paperkey-1.6/extract.c:99:14: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while((fgetc(input)!=EOF))
data/paperkey-1.6/gl/getopt.c:214:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
&& namelen == strlen (p->name))
data/paperkey-1.6/gl/getopt.c:301:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
d->__nextchar += strlen (d->__nextchar);
data/paperkey-1.6/gl/gettext.h:216:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t msgctxt_len = strlen (msgctxt) + 1;
data/paperkey-1.6/gl/gettext.h:217:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t msgid_len = strlen (msgid) + 1;
data/paperkey-1.6/gl/gettext.h:264:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t msgctxt_len = strlen (msgctxt) + 1;
data/paperkey-1.6/gl/gettext.h:265:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t msgid_len = strlen (msgid) + 1;
data/paperkey-1.6/gl/unistd.in.h:1248:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
# undef read
data/paperkey-1.6/gl/unistd.in.h:1249:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
# define read rpl_read
data/paperkey-1.6/gl/unistd.in.h:1251:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
_GL_FUNCDECL_RPL (read, ssize_t, (int fd, void *buf, size_t count)
data/paperkey-1.6/gl/unistd.in.h:1253:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
_GL_CXXALIAS_RPL (read, ssize_t, (int fd, void *buf, size_t count));
data/paperkey-1.6/gl/unistd.in.h:1258:24: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
_GL_CXXALIAS_SYS_CAST (read, ssize_t, (int fd, void *buf, size_t count));
data/paperkey-1.6/gl/unistd.in.h:1260:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
_GL_CXXALIASWARN (read);
data/paperkey-1.6/gl/unistd.in.h:1573:11: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
# undef usleep
data/paperkey-1.6/gl/unistd.in.h:1574:12: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
# define usleep rpl_usleep
data/paperkey-1.6/gl/unistd.in.h:1576:19: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
_GL_FUNCDECL_RPL (usleep, int, (useconds_t n));
data/paperkey-1.6/gl/unistd.in.h:1577:19: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
_GL_CXXALIAS_RPL (usleep, int, (useconds_t n));
data/paperkey-1.6/gl/unistd.in.h:1580:19: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
_GL_FUNCDECL_SYS (usleep, int, (useconds_t n));
data/paperkey-1.6/gl/unistd.in.h:1582:19: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
_GL_CXXALIAS_SYS (usleep, int, (useconds_t n));
data/paperkey-1.6/gl/unistd.in.h:1584:19: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
_GL_CXXALIASWARN (usleep);
data/paperkey-1.6/gl/unistd.in.h:1586:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
# undef usleep
data/paperkey-1.6/gl/unistd.in.h:1588:18: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
_GL_WARN_ON_USE (usleep, "usleep is unportable - "
data/paperkey-1.6/paperkey.c:107:3: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(077);
data/paperkey-1.6/parse.c:37:15: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while((byte=fgetc(input))!=EOF)
data/paperkey-1.6/parse.c:61:13: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
byte=fgetc(input);
data/paperkey-1.6/parse.c:68:9: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
tmp=fgetc(input);
data/paperkey-1.6/parse.c:72:9: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
tmp=fgetc(input);
data/paperkey-1.6/parse.c:76:9: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
tmp=fgetc(input);
data/paperkey-1.6/parse.c:80:9: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
tmp=fgetc(input);
data/paperkey-1.6/parse.c:95:9: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
tmp=fgetc(input);
data/paperkey-1.6/parse.c:110:10: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
byte=fgetc(input);
data/paperkey-1.6/parse.c:118:10: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
byte=fgetc(input);
data/paperkey-1.6/parse.c:121:9: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
tmp=fgetc(input);
data/paperkey-1.6/parse.c:130:9: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
tmp=fgetc(input);
data/paperkey-1.6/parse.c:134:9: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
tmp=fgetc(input);
data/paperkey-1.6/parse.c:138:9: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
tmp=fgetc(input);
data/paperkey-1.6/parse.c:142:9: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
tmp=fgetc(input);
data/paperkey-1.6/parse.c:187:6: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
fgetc(input);
data/paperkey-1.6/restore.c:123:16: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int test=fgetc(secrets);
ANALYSIS SUMMARY:
Hits = 120
Lines analyzed = 7242 in approximately 0.25 seconds (29469 lines/second)
Physical Source Lines of Code (SLOC) = 4682
Hits@level = [0] 127 [1] 39 [2] 41 [3] 15 [4] 7 [5] 18
Hits@level+ = [0+] 247 [1+] 120 [2+] 81 [3+] 40 [4+] 25 [5+] 18
Hits/KSLOC@level+ = [0+] 52.7552 [1+] 25.6301 [2+] 17.3003 [3+] 8.54336 [4+] 5.3396 [5+] 3.84451
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.