Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/pd-hcs-0.1/screensize.c
Examining data/pd-hcs-0.1/setenv.c
Examining data/pd-hcs-0.1/split_path.c
Examining data/pd-hcs-0.1/cursor.c
Examining data/pd-hcs-0.1/window_name.c
Examining data/pd-hcs-0.1/ifeel.c
Examining data/pd-hcs-0.1/uname.c
Examining data/pd-hcs-0.1/ifeel.h
Examining data/pd-hcs-0.1/sys_gui.c
Examining data/pd-hcs-0.1/folder_list.c
Examining data/pd-hcs-0.1/unsetenv.c
Examining data/pd-hcs-0.1/keyboard_layout.c
Examining data/pd-hcs-0.1/colorpanel.c
Examining data/pd-hcs-0.1/sql_query.c
Examining data/pd-hcs-0.1/canvas_name.c
Examining data/pd-hcs-0.1/debian/extra/searchpath.h
Examining data/pd-hcs-0.1/ce_path.c
Examining data/pd-hcs-0.1/classpath.c
Examining data/pd-hcs-0.1/helppath.c
Examining data/pd-hcs-0.1/version.c
Examining data/pd-hcs-0.1/group.c
Examining data/pd-hcs-0.1/passwd.c
Examining data/pd-hcs-0.1/stat.c
FINAL RESULTS:
data/pd-hcs-0.1/folder_list.c:193:9: [5] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is high; the length parameter
appears to be a constant, instead of computing the number of characters
left.
strncat(patternBuffer, s->s_name + 1, FILENAME_MAX - 1);
data/pd-hcs-0.1/folder_list.c:238:3: [5] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is high; the length parameter
appears to be a constant, instead of computing the number of characters
left.
strncat(buffer,"/*",MAXPDSTRING);
data/pd-hcs-0.1/folder_list.c:150:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(outputBuffer,findData.cFileName);
data/pd-hcs-0.1/setenv.c:61:24: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
envvar_value = getenv(x->x_variable_name->s_name);
data/pd-hcs-0.1/canvas_name.c:24:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXPDSTRING];
data/pd-hcs-0.1/canvas_name.c:54:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXPDSTRING];
data/pd-hcs-0.1/ce_path.c:48:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[FILENAME_MAX];
data/pd-hcs-0.1/classpath.c:97:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[MAXPDSTRING];
data/pd-hcs-0.1/classpath.c:100:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buffer, "/extra");
data/pd-hcs-0.1/colorpanel.c:14:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char current_color[MAXPDSTRING];
data/pd-hcs-0.1/colorpanel.c:35:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char color_buffer[3];
data/pd-hcs-0.1/colorpanel.c:36:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char color_string[MAXPDSTRING];
data/pd-hcs-0.1/colorpanel.c:54:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(x->current_color, color_string, 7);
data/pd-hcs-0.1/colorpanel.c:82:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXPDSTRING];
data/pd-hcs-0.1/colorpanel.c:84:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf, "#%lx", (t_int)x);
data/pd-hcs-0.1/colorpanel.c:88:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(x->current_color,"#ffffff");
data/pd-hcs-0.1/cursor.c:218:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXPDSTRING];
data/pd-hcs-0.1/cursor.c:223:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf, "#%lx", (t_int)x);
data/pd-hcs-0.1/folder_list.c:63:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[FILENAME_MAX];
data/pd-hcs-0.1/folder_list.c:97:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char normalized_path[FILENAME_MAX] = "";
data/pd-hcs-0.1/folder_list.c:105:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fullPathNameBuffer[FILENAME_MAX] = "";
data/pd-hcs-0.1/folder_list.c:106:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char unbashBuffer[FILENAME_MAX] = "";
data/pd-hcs-0.1/folder_list.c:107:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char outputBuffer[FILENAME_MAX] = "";
data/pd-hcs-0.1/folder_list.c:188:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char envVarBuffer[FILENAME_MAX];
data/pd-hcs-0.1/folder_list.c:192:9: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(patternBuffer,"%USERPROFILE%");
data/pd-hcs-0.1/folder_list.c:222:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[MAXPDSTRING];
data/pd-hcs-0.1/group.c:75:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new_atom_list, x->output, x->output_count * sizeof(t_atom));
data/pd-hcs-0.1/group.c:78:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(x->output + x->output_count, new_atom, sizeof(t_atom));
data/pd-hcs-0.1/ifeel.c:240:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((x->x_fd = open((char *) device->s_name, O_RDWR | O_NONBLOCK, 0)) <= 0)
data/pd-hcs-0.1/keyboard_layout.c:26:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cKeyboardName[100];
data/pd-hcs-0.1/keyboard_layout.c:39:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cKeyboardName[100];
data/pd-hcs-0.1/keyboard_layout.c:63:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cKeyboardName[100];
data/pd-hcs-0.1/screensize.c:29:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXPDSTRING];
data/pd-hcs-0.1/screensize.c:32:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf, "#%lx", (t_int)x);
data/pd-hcs-0.1/split_path.c:33:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path_buffer[MAXPATHLEN] = "";
data/pd-hcs-0.1/stat.c:79:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new_atom_list, x->output, x->output_count * sizeof(t_atom));
data/pd-hcs-0.1/stat.c:82:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(x->output + x->output_count, new_atom, sizeof(t_atom));
data/pd-hcs-0.1/stat.c:245:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char string_buffer[MAX_PATH];
data/pd-hcs-0.1/sys_gui.c:25:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXPDSTRING];
data/pd-hcs-0.1/sys_gui.c:42:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXPDSTRING];
data/pd-hcs-0.1/unsetenv.c:61:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXPDSTRING];
data/pd-hcs-0.1/window_name.c:24:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXPDSTRING];
data/pd-hcs-0.1/window_name.c:54:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXPDSTRING];
data/pd-hcs-0.1/ce_path.c:55:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(buffer, x->x_current->nl_string, FILENAME_MAX);
data/pd-hcs-0.1/classpath.c:99:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(buffer, sys_libdir->s_name, MAXPDSTRING - 6);
data/pd-hcs-0.1/colorpanel.c:26:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(x->current_color, s->s_name, MAXPDSTRING);
data/pd-hcs-0.1/colorpanel.c:38:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant character.
strncpy(color_string,"#",MAXPDSTRING);
data/pd-hcs-0.1/colorpanel.c:47:13: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(color_string, color_buffer, 3);
data/pd-hcs-0.1/colorpanel.c:66:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(x->current_color, color->s_name, MAXPDSTRING);
data/pd-hcs-0.1/folder_list.c:68:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(buf, original, FILENAME_MAX);
data/pd-hcs-0.1/folder_list.c:71:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(normalized, buf, FILENAME_MAX);
data/pd-hcs-0.1/folder_list.c:74:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(normalized, cwd->s_name, FILENAME_MAX);
data/pd-hcs-0.1/folder_list.c:75:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(normalized[(strlen(normalized)-1)] != '/') {
data/pd-hcs-0.1/folder_list.c:76:9: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is low because the source is a
constant character.
strncat(normalized, "/", 1);
data/pd-hcs-0.1/folder_list.c:80:13: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(normalized, buf + 2,
data/pd-hcs-0.1/folder_list.c:81:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
FILENAME_MAX - strlen(normalized));
data/pd-hcs-0.1/folder_list.c:83:13: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(normalized, buf,
data/pd-hcs-0.1/folder_list.c:84:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
FILENAME_MAX - strlen(normalized));
data/pd-hcs-0.1/folder_list.c:87:9: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(normalized, buf,
data/pd-hcs-0.1/folder_list.c:88:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
FILENAME_MAX - strlen(normalized));
data/pd-hcs-0.1/folder_list.c:90:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(normalized, buf, FILENAME_MAX);
data/pd-hcs-0.1/folder_list.c:142:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(pathBuffer, unbashBuffer, unbashBuffer_position - unbashBuffer);
data/pd-hcs-0.1/folder_list.c:148:13: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(outputBuffer, pathBuffer, FILENAME_MAX);
data/pd-hcs-0.1/folder_list.c:149:4: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(outputBuffer,"/");
data/pd-hcs-0.1/folder_list.c:237:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(buffer,currentdir->s_name,MAXPDSTRING);
data/pd-hcs-0.1/split_path.c:32:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int length = strlen(s->s_name);
data/pd-hcs-0.1/split_path.c:49:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(path_buffer, s->s_name, length + 1);
data/pd-hcs-0.1/sys_gui.c:31:9: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(x->send_buffer, buf, MAXPDSTRING - strlen(x->send_buffer));
data/pd-hcs-0.1/sys_gui.c:31:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncat(x->send_buffer, buf, MAXPDSTRING - strlen(x->send_buffer));
data/pd-hcs-0.1/sys_gui.c:32:9: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is low because the source is a
constant character.
strncat(x->send_buffer, " ", MAXPDSTRING - strlen(x->send_buffer));
data/pd-hcs-0.1/sys_gui.c:32:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncat(x->send_buffer, " ", MAXPDSTRING - strlen(x->send_buffer));
data/pd-hcs-0.1/sys_gui.c:34:5: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is low because the source is a
constant string.
strncat(x->send_buffer, " ;\n", 3);
data/pd-hcs-0.1/sys_gui.c:47:9: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(x->send_buffer, buf, MAXPDSTRING - strlen(x->send_buffer));
data/pd-hcs-0.1/sys_gui.c:47:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncat(x->send_buffer, buf, MAXPDSTRING - strlen(x->send_buffer));
data/pd-hcs-0.1/sys_gui.c:48:9: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is low because the source is a
constant character.
strncat(x->send_buffer, " ", MAXPDSTRING - strlen(x->send_buffer));
data/pd-hcs-0.1/sys_gui.c:48:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncat(x->send_buffer, " ", MAXPDSTRING - strlen(x->send_buffer));
data/pd-hcs-0.1/sys_gui.c:50:5: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is low because the source is a
constant string.
strncat(x->send_buffer, " ;\n", 3);
data/pd-hcs-0.1/unsetenv.c:62:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(buf, x->x_variable_name->s_name, MAXPDSTRING - 1);
data/pd-hcs-0.1/unsetenv.c:63:9: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(buf, "=");
ANALYSIS SUMMARY:
Hits = 79
Lines analyzed = 3336 in approximately 0.10 seconds (33422 lines/second)
Physical Source Lines of Code (SLOC) = 2294
Hits@level = [0] 8 [1] 36 [2] 39 [3] 1 [4] 1 [5] 2
Hits@level+ = [0+] 87 [1+] 79 [2+] 43 [3+] 4 [4+] 3 [5+] 2
Hits/KSLOC@level+ = [0+] 37.925 [1+] 34.4377 [2+] 18.7446 [3+] 1.74368 [4+] 1.30776 [5+] 0.87184
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.