Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/pidgin-nateon-0.0.0.svn147/config.h
Examining data/pidgin-nateon-0.0.0.svn147/src/cmdproc.c
Examining data/pidgin-nateon-0.0.0.svn147/src/cmdproc.h
Examining data/pidgin-nateon-0.0.0.svn147/src/command.c
Examining data/pidgin-nateon-0.0.0.svn147/src/command.h
Examining data/pidgin-nateon-0.0.0.svn147/src/dialog.c
Examining data/pidgin-nateon-0.0.0.svn147/src/dialog.h
Examining data/pidgin-nateon-0.0.0.svn147/src/error.c
Examining data/pidgin-nateon-0.0.0.svn147/src/error.h
Examining data/pidgin-nateon-0.0.0.svn147/src/group.c
Examining data/pidgin-nateon-0.0.0.svn147/src/group.h
Examining data/pidgin-nateon-0.0.0.svn147/src/history.c
Examining data/pidgin-nateon-0.0.0.svn147/src/history.h
Examining data/pidgin-nateon-0.0.0.svn147/src/internal.h
Examining data/pidgin-nateon-0.0.0.svn147/src/memo.c
Examining data/pidgin-nateon-0.0.0.svn147/src/memo.h
Examining data/pidgin-nateon-0.0.0.svn147/src/msg.c
Examining data/pidgin-nateon-0.0.0.svn147/src/msg.h
Examining data/pidgin-nateon-0.0.0.svn147/src/nateon-utils.c
Examining data/pidgin-nateon-0.0.0.svn147/src/nateon-utils.h
Examining data/pidgin-nateon-0.0.0.svn147/src/nateon.c
Examining data/pidgin-nateon-0.0.0.svn147/src/nateon.h
Examining data/pidgin-nateon-0.0.0.svn147/src/notification.h
Examining data/pidgin-nateon-0.0.0.svn147/src/servconn.c
Examining data/pidgin-nateon-0.0.0.svn147/src/servconn.h
Examining data/pidgin-nateon-0.0.0.svn147/src/session.c
Examining data/pidgin-nateon-0.0.0.svn147/src/session.h
Examining data/pidgin-nateon-0.0.0.svn147/src/slplink.c
Examining data/pidgin-nateon-0.0.0.svn147/src/slplink.h
Examining data/pidgin-nateon-0.0.0.svn147/src/state.c
Examining data/pidgin-nateon-0.0.0.svn147/src/state.h
Examining data/pidgin-nateon-0.0.0.svn147/src/switchboard.c
Examining data/pidgin-nateon-0.0.0.svn147/src/switchboard.h
Examining data/pidgin-nateon-0.0.0.svn147/src/sync.c
Examining data/pidgin-nateon-0.0.0.svn147/src/sync.h
Examining data/pidgin-nateon-0.0.0.svn147/src/table.c
Examining data/pidgin-nateon-0.0.0.svn147/src/table.h
Examining data/pidgin-nateon-0.0.0.svn147/src/transaction.c
Examining data/pidgin-nateon-0.0.0.svn147/src/transaction.h
Examining data/pidgin-nateon-0.0.0.svn147/src/user.c
Examining data/pidgin-nateon-0.0.0.svn147/src/user.h
Examining data/pidgin-nateon-0.0.0.svn147/src/userlist.c
Examining data/pidgin-nateon-0.0.0.svn147/src/userlist.h
Examining data/pidgin-nateon-0.0.0.svn147/src/xfer.c
Examining data/pidgin-nateon-0.0.0.svn147/src/xfer.h
Examining data/pidgin-nateon-0.0.0.svn147/src/notification.c
FINAL RESULTS:
data/pidgin-nateon-0.0.0.svn147/src/internal.h:160:19: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
# define g_access access
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:950:5: [3] (random) g_random_int_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
g_random_int_range(100,999), nate_xfer->session->user->id,
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:951:5: [3] (random) g_random_int_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
g_random_int_range(100,999));
data/pidgin-nateon-0.0.0.svn147/src/cmdproc.c:132:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data + len, trans->payload, trans->payload_len);
data/pidgin-nateon-0.0.0.svn147/src/cmdproc.c:270:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
error = atoi(cmd->command);
data/pidgin-nateon-0.0.0.svn147/src/command.c:67:31: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
cmd->trId = is_num(param) ? atoi(param) : 0;
data/pidgin-nateon-0.0.0.svn147/src/error.c:30:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char msg[NATEON_BUF_LEN];
data/pidgin-nateon-0.0.0.svn147/src/error.c:260:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[NATEON_BUF_LEN];
data/pidgin-nateon-0.0.0.svn147/src/internal.h:148:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
# define g_fopen fopen
data/pidgin-nateon-0.0.0.svn147/src/internal.h:156:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
# define g_open open
data/pidgin-nateon-0.0.0.svn147/src/msg.c:533:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(msg->body, data, len);
data/pidgin-nateon-0.0.0.svn147/src/nateon-utils.c:60:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
fontcolor = g_strdup_printf("%06X", atoi(split[1]));
data/pidgin-nateon-0.0.0.svn147/src/nateon-utils.c:122:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tag[64];
data/pidgin-nateon-0.0.0.svn147/src/nateon-utils.c:195:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[BUF_LEN];
data/pidgin-nateon-0.0.0.svn147/src/nateon-utils.c:233:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fonteffect[4];
data/pidgin-nateon-0.0.0.svn147/src/nateon-utils.c:376:6: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char color[7] = {0};
data/pidgin-nateon-0.0.0.svn147/src/nateon.c:83:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[BUF_LEN];
data/pidgin-nateon-0.0.0.svn147/src/notification.c:123:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer [80];
data/pidgin-nateon-0.0.0.svn147/src/notification.c:128:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strTime[19];
data/pidgin-nateon-0.0.0.svn147/src/notification.c:402:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(cmd->params[3]);
data/pidgin-nateon-0.0.0.svn147/src/notification.c:545:35: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
cmdproc->servconn->payload_len = atoi(cmd->params[2]);
data/pidgin-nateon-0.0.0.svn147/src/notification.c:650:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
group_id = atoi(params[3]);
data/pidgin-nateon-0.0.0.svn147/src/notification.c:817:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
group_id = atoi(cmd->params[2]);
data/pidgin-nateon-0.0.0.svn147/src/notification.c:1099:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
group_id = atoi(params[1]);
data/pidgin-nateon-0.0.0.svn147/src/notification.c:1114:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
group_id = atoi(params[1]);
data/pidgin-nateon-0.0.0.svn147/src/notification.c:1145:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
group_id = atoi(params[3]);
data/pidgin-nateon-0.0.0.svn147/src/notification.c:1178:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
group_id = atoi(params[1]);
data/pidgin-nateon-0.0.0.svn147/src/notification.c:1197:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
old_group_id = atoi(params[4]);
data/pidgin-nateon-0.0.0.svn147/src/notification.c:1198:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
new_group_id = atoi(params[5]);
data/pidgin-nateon-0.0.0.svn147/src/notification.c:1490:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(cmd->params[2]);
data/pidgin-nateon-0.0.0.svn147/src/servconn.c:393:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[NATEON_BUF_LEN];
data/pidgin-nateon-0.0.0.svn147/src/servconn.c:414:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(servconn->rx_buf + servconn->rx_len, buf, len + 1);
data/pidgin-nateon-0.0.0.svn147/src/switchboard.c:750:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
num_files = atoi(split[1]);
data/pidgin-nateon-0.0.0.svn147/src/switchboard.c:760:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(file_data[1]), file_data[2]);
data/pidgin-nateon-0.0.0.svn147/src/switchboard.c:777:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
num_files = atoi(split[1]);
data/pidgin-nateon-0.0.0.svn147/src/switchboard.c:803:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
num_files = atoi(split[1]);
data/pidgin-nateon-0.0.0.svn147/src/switchboard.c:826:6: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(file_data[1]), file_data[2]);
data/pidgin-nateon-0.0.0.svn147/src/switchboard.c:1070:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
swboard->total_users = atoi(cmd->params[2]);
data/pidgin-nateon-0.0.0.svn147/src/switchboard.c:1452:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(cmd->params[2]);
data/pidgin-nateon-0.0.0.svn147/src/sync.c:50:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
group_id = atoi(cmd->params[4]);
data/pidgin-nateon-0.0.0.svn147/src/sync.c:78:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
group_id = atoi(cmd->params[5]);
data/pidgin-nateon-0.0.0.svn147/src/sync.c:95:6: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (atoi(cmd->params[1])+1 == atoi(cmd->params[2]))
data/pidgin-nateon-0.0.0.svn147/src/sync.c:95:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (atoi(cmd->params[1])+1 == atoi(cmd->params[2]))
data/pidgin-nateon-0.0.0.svn147/src/sync.c:151:34: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (session->sync->num_users == atoi(cmd->params[2]))
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:77:51: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
buf = g_strdup_printf("ATHC %d 100 6004 0\r\n", atoi(split[1]));
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:105:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
xfer->chunk_len = atoi(split[3]);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:151:51: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
buf = g_strdup_printf("ATHC %d 100 6004 0\r\n", atoi(split[1]));
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:179:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
xfer->send_data_trid = atoi(split[1]);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:197:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[NATEON_BUF_LEN];
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:222:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(conn->rx_buf + conn->rx_len, buf, len + 1);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:238:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(*buffer + buffer_len, end, cur_len);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:309:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(conn->rx_buf + conn->rx_len, buf, len + 1);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:410:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(filepath, "rb");
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:907:25: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
nate_xfer->dest_fp = fopen(purple_xfer_get_local_filename(xfer), "wb");
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:940:25: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
nate_xfer->local_fp = fopen(purple_xfer_get_local_filename(nate_xfer->prpl_xfer),
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:1072:36: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (t_xfer->fr_initiate_trid == atoi(params[0])) {
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:1083:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
xfer->fr_port = atoi(params[2]);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:1107:5: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(split[1]), p2p_connect_cb, xfer);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:1154:5: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(split[1]), p2p_connect_cb, xfer);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:1168:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
xfer->fr_port = atoi(split[1]);
data/pidgin-nateon-0.0.0.svn147/src/xfer.h:111:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char send_buf[NATEON_XFER_SEND_BUFFER_SIZE];
data/pidgin-nateon-0.0.0.svn147/src/cmdproc.c:87:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(command);
data/pidgin-nateon-0.0.0.svn147/src/cmdproc.c:122:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(data);
data/pidgin-nateon-0.0.0.svn147/src/memo.c:88:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memo->to, memo->from, memo->to, date, strlen(body), body);
data/pidgin-nateon-0.0.0.svn147/src/memo.c:93:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*ret_size = strlen(str);
data/pidgin-nateon-0.0.0.svn147/src/msg.c:136:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_message_set_bin_data(msg, message_enc, strlen(message_enc));
data/pidgin-nateon-0.0.0.svn147/src/nateon-utils.c:273:6: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(fonteffect, "B");
data/pidgin-nateon-0.0.0.svn147/src/nateon-utils.c:282:6: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(fonteffect, "I");
data/pidgin-nateon-0.0.0.svn147/src/nateon-utils.c:291:6: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(fonteffect, "S");
data/pidgin-nateon-0.0.0.svn147/src/nateon-utils.c:300:6: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(fonteffect, "U");
data/pidgin-nateon-0.0.0.svn147/src/nateon.c:92:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(buf, tmp, sizeof(buf));
data/pidgin-nateon-0.0.0.svn147/src/nateon.c:132:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(entry && strlen(entry))
data/pidgin-nateon-0.0.0.svn147/src/nateon.c:137:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(alias) > BUDDY_ALIAS_MAXLEN)
data/pidgin-nateon-0.0.0.svn147/src/notification.c:114:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
params += strlen("OK\r\n");
data/pidgin-nateon-0.0.0.svn147/src/notification.c:181:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
"%s", strlen(body), body );
data/pidgin-nateon-0.0.0.svn147/src/notification.c:1832:53: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_cmdproc_send(cmdproc, "MVBG", "0 %d\r\n%s", strlen(cmd)+2, cmd);
data/pidgin-nateon-0.0.0.svn147/src/notification.c:1843:53: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_cmdproc_send(cmdproc, "CPBG", "0 %d\r\n%s", strlen(cmd)+2, cmd);
data/pidgin-nateon-0.0.0.svn147/src/servconn.c:400:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
len = read(servconn->fd, buf, sizeof(buf) - 1);
data/pidgin-nateon-0.0.0.svn147/src/switchboard.c:741:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
!strncmp(cmd->params[3], "REQUEST", strlen("REQUEST")))
data/pidgin-nateon-0.0.0.svn147/src/switchboard.c:769:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
!strncmp(cmd->params[3], "NACK", strlen("NACK")) )
data/pidgin-nateon-0.0.0.svn147/src/switchboard.c:795:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
!strncmp(cmd->params[3], "CANCEL", strlen("CANCEL")) )
data/pidgin-nateon-0.0.0.svn147/src/switchboard.c:810:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
!strncmp(cmd->params[3], "REQUEST", strlen("REQUEST")) )
data/pidgin-nateon-0.0.0.svn147/src/switchboard.c:1405:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
payload_len = strlen(payload);
data/pidgin-nateon-0.0.0.svn147/src/transaction.c:156:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
trans->payload_len = payload_len ? payload_len : strlen(trans->payload);
data/pidgin-nateon-0.0.0.svn147/src/userlist.c:148:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(store_name) > BUDDY_ALIAS_MAXLEN)
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:78:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_xfer_sock_write(&xfer->conn, buf, strlen(buf));
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:82:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_xfer_sock_write(&xfer->conn, buf, strlen(buf));
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:91:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_xfer_sock_write(&xfer->conn, buf, strlen(buf));
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:98:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_xfer_sock_write(&xfer->conn, buf, strlen(buf));
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:124:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
payload_len = strlen(payload);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:152:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_xfer_sock_write(&xfer->conn, buf, strlen(buf));
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:172:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_xfer_sock_write(&xfer->conn, buf, strlen(buf));
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:208:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
len = read(conn->fd, buf, sizeof(buf) - 1);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:260:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_xfer_sock_write(&nate_xfer->conn, buf, strlen(buf));
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:295:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
len = read(conn->fd, buf, sizeof(buf) - 1);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:517:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cmd_len = strlen(buf);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:702:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
payload_len = strlen(payload);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:722:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
payload_len = strlen(payload);
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:792:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_xfer_sock_write(&nate_xfer->conn, buf, strlen(buf));
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:878:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_xfer_sock_write(&nate_xfer->conn, buf, strlen(buf));
data/pidgin-nateon-0.0.0.svn147/src/xfer.c:887:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nateon_xfer_sock_write(&nate_xfer->conn, buf, strlen(buf));
ANALYSIS SUMMARY:
Hits = 101
Lines analyzed = 16541 in approximately 0.32 seconds (51865 lines/second)
Physical Source Lines of Code (SLOC) = 6698
Hits@level = [0] 5 [1] 40 [2] 58 [3] 2 [4] 1 [5] 0
Hits@level+ = [0+] 106 [1+] 101 [2+] 61 [3+] 3 [4+] 1 [5+] 0
Hits/KSLOC@level+ = [0+] 15.8256 [1+] 15.0791 [2+] 9.1072 [3+] 0.447895 [4+] 0.149298 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.