Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/pipexec-2.5.5/src/pipe_info.c Examining data/pipexec-2.5.5/src/version.c Examining data/pipexec-2.5.5/src/ptee.c Examining data/pipexec-2.5.5/src/command_info.h Examining data/pipexec-2.5.5/src/version.h Examining data/pipexec-2.5.5/src/logging.c Examining data/pipexec-2.5.5/src/command_info.c Examining data/pipexec-2.5.5/src/peet.c Examining data/pipexec-2.5.5/src/logging.h Examining data/pipexec-2.5.5/src/pipexec.c Examining data/pipexec-2.5.5/src/pipe_info.h Examining data/pipexec-2.5.5/test/ptest.c FINAL RESULTS: data/pipexec-2.5.5/src/logging.c:41:11: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. return vsnprintf(buf, free_bytes, fmt, ap); data/pipexec-2.5.5/src/pipexec.c:212:3: [4] (shell) execv: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execv(params->path, params->argv); data/pipexec-2.5.5/src/peet.c:95:17: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((opt = getopt(argc, argv, "dhw:")) != -1) { data/pipexec-2.5.5/src/pipexec.c:320:17: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((opt = getopt(argc, argv, "hkl:p:s:-")) != -1) { data/pipexec-2.5.5/src/ptee.c:35:18: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((opt = getopt(argc, argv, "hr:")) != -1) { data/pipexec-2.5.5/src/logging.c:63:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pbuf[free_bytes]; data/pipexec-2.5.5/src/peet.c:104:18: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). write_fd = atoi(optarg); data/pipexec-2.5.5/src/peet.c:123:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). fds[fdidx].fd = atoi(argv[aidx]); data/pipexec-2.5.5/src/peet.c:150:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[buffer_size]; data/pipexec-2.5.5/src/pipexec.c:84:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pbuf[pilen]; data/pipexec-2.5.5/src/pipexec.c:290:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pbuf[20]; data/pipexec-2.5.5/src/pipexec.c:293:7: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). open(pid_file, O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IRGRP | S_IROTH); data/pipexec-2.5.5/src/pipexec.c:332:27: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). int const logfd = atoi(optarg); data/pipexec-2.5.5/src/pipexec.c:340:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). sleep_timer = atoi(optarg); data/pipexec-2.5.5/src/ptee.c:41:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). read_fd = atoi(optarg); data/pipexec-2.5.5/src/ptee.c:59:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). fds[fdidx] = atoi(argv[aidx]); data/pipexec-2.5.5/src/ptee.c:62:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[4096]; data/pipexec-2.5.5/test/ptest.c:7:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[10]; data/pipexec-2.5.5/src/peet.c:56:34: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ssize_t const bytes_read = read(fds[fdidx].fd, buffer, buffer_size); data/pipexec-2.5.5/src/ptee.c:64:34: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ssize_t const bytes_read = read(read_fd, buffer, sizeof(buffer)); data/pipexec-2.5.5/test/ptest.c:8:9: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). r=read(0, buf, 10); ANALYSIS SUMMARY: Hits = 21 Lines analyzed = 1160 in approximately 0.04 seconds (27625 lines/second) Physical Source Lines of Code (SLOC) = 861 Hits@level = [0] 43 [1] 3 [2] 13 [3] 3 [4] 2 [5] 0 Hits@level+ = [0+] 64 [1+] 21 [2+] 18 [3+] 5 [4+] 2 [5+] 0 Hits/KSLOC@level+ = [0+] 74.3322 [1+] 24.3902 [2+] 20.9059 [3+] 5.8072 [4+] 2.32288 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.