Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/pms-0.42/src/list.cpp Examining data/pms-0.42/src/message.h Examining data/pms-0.42/src/libmpdclient.h Examining data/pms-0.42/src/display.h Examining data/pms-0.42/src/mycurses.h Examining data/pms-0.42/src/types.h Examining data/pms-0.42/src/list.h Examining data/pms-0.42/src/mediator.cpp Examining data/pms-0.42/src/song.h Examining data/pms-0.42/src/filter.h Examining data/pms-0.42/src/action.h Examining data/pms-0.42/src/action.cpp Examining data/pms-0.42/src/field.cpp Examining data/pms-0.42/src/field.h Examining data/pms-0.42/src/settings.cpp Examining data/pms-0.42/src/pms.h Examining data/pms-0.42/src/song.cpp Examining data/pms-0.42/src/input.cpp Examining data/pms-0.42/src/command.h Examining data/pms-0.42/src/conn.cpp Examining data/pms-0.42/src/color.h Examining data/pms-0.42/src/libmpdclient.c Examining data/pms-0.42/src/i18n.h Examining data/pms-0.42/src/input.h Examining data/pms-0.42/src/config.cpp Examining data/pms-0.42/src/config.h Examining data/pms-0.42/src/topbar.h Examining data/pms-0.42/src/color.cpp Examining data/pms-0.42/src/mediator.h Examining data/pms-0.42/src/conn.h Examining data/pms-0.42/src/message.cpp Examining data/pms-0.42/src/settings.h Examining data/pms-0.42/src/display.cpp Examining data/pms-0.42/src/command.cpp Examining data/pms-0.42/src/pms.cpp FINAL RESULTS: data/pms-0.42/src/command.cpp:234:4: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buffer, _("Error: %s"), pms->msg->str.c_str()); data/pms-0.42/src/command.cpp:236:4: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buffer, _("Error %d: %s"), pms->msg->code, pms->msg->str.c_str()); data/pms-0.42/src/display.cpp:1755:6: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s", output.c_str()); data/pms-0.42/src/field.cpp:667:4: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(s, "%d %s (%s)", list->size(), data/pms-0.42/src/field.cpp:684:7: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(s, "%ld/%d %s (%s)", static_cast<unsigned long>(list->selection.size), data/pms-0.42/src/field.cpp:691:7: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(s, "%ld/%d/%d %s (%s)", static_cast<unsigned long>(list->selection.size), data/pms-0.42/src/field.cpp:702:7: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(s, "%d %s (%s)", list->size(), data/pms-0.42/src/field.cpp:708:7: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(s, "%d/%d %s (%s)", data/pms-0.42/src/libmpdclient.c:479:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(connection->buffer,rt+1); data/pms-0.42/src/libmpdclient.c:664:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(connection->errorStr, output); data/pms-0.42/src/libmpdclient.c:1231:6: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(&((entity->info.song->artist)[length + 2]), re->value); data/pms-0.42/src/libmpdclient.c:1280:6: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(&((entity->info.song->genre)[length + 3]), re->value); data/pms-0.42/src/libmpdclient.c:1292:6: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(&((entity->info.song->composer)[length + 2]), re->value); data/pms-0.42/src/libmpdclient.c:1304:6: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(&((entity->info.song->performer)[length + 2]), re->value); data/pms-0.42/src/message.cpp:48:2: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. vsprintf(buffer, format, ap); data/pms-0.42/src/pms.cpp:287:17: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. int code = system(options->get_string("onplaylistfinish").c_str()); data/pms-0.42/src/pms.cpp:741:14: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. msg->code = system(cmd.c_str()); data/pms-0.42/src/pms.cpp:949:2: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. vsprintf(buffer, format, ap); data/pms-0.42/src/action.cpp:1813:15: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. pms->comm->random(pms->options->get_long("playmode") == PLAYMODE_RANDOM && pms->comm->activelist() == pms->comm->playlist()); data/pms-0.42/src/color.cpp:77:16: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. delete topbar.random; data/pms-0.42/src/color.h:99:12: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. color * random; data/pms-0.42/src/command.cpp:615:16: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. bool Control::random(int set) data/pms-0.42/src/command.cpp:1084:10: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. if (st->random) data/pms-0.42/src/command.cpp:1478:3: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. random(pms->options->get_long("playmode") == PLAYMODE_RANDOM && activelist() == playlist()); data/pms-0.42/src/command.h:98:8: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. bool random; data/pms-0.42/src/command.h:142:8: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. bool random; data/pms-0.42/src/command.h:278:9: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. bool random(int); data/pms-0.42/src/config.cpp:698:12: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. homedir = getenv("HOME"); data/pms-0.42/src/config.cpp:699:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. xdgconfighome = getenv("XDG_CONFIG_HOME"); data/pms-0.42/src/config.cpp:700:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. xdgconfigdirs = getenv("XDG_CONFIG_DIRS"); data/pms-0.42/src/config.cpp:826:21: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. dest = (c->topbar.random); data/pms-0.42/src/display.cpp:1355:7: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("WINDOWID")) data/pms-0.42/src/field.cpp:941:37: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. c = pms->options->colors->topbar.random; data/pms-0.42/src/libmpdclient.h:179:6: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int random; data/pms-0.42/src/pms.cpp:381:9: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. host = getenv("MPD_HOST"); data/pms-0.42/src/pms.cpp:382:9: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. port = getenv("MPD_PORT"); data/pms-0.42/src/pms.cpp:383:13: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. password = getenv("MPD_PASSWORD"); data/pms-0.42/src/pms.cpp:452:2: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srand(time(NULL)); data/pms-0.42/src/action.cpp:84:17: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). clear_topbar(atoi(param.c_str())); data/pms-0.42/src/action.cpp:171:14: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). crossfade(atoi(param.c_str())); data/pms-0.42/src/action.cpp:175:9: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). seek(atoi(param.c_str())); data/pms-0.42/src/action.cpp:824:29: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). ok = pms->comm->setvolume(atoi(vol.c_str())); data/pms-0.42/src/action.cpp:833:26: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). ok = pms->comm->volume(atoi(vol.c_str())); data/pms-0.42/src/action.cpp:1290:9: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). i = atoi(pms->input->param.c_str()); data/pms-0.42/src/action.cpp:1333:30: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). i = pms->comm->move(list, atoi(pms->input->param.c_str())); data/pms-0.42/src/action.cpp:1341:27: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). pms->disp->movecursor(atoi(pms->input->param.c_str())); data/pms-0.42/src/config.cpp:242:9: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). i = atoi(string(b.substr(1)).c_str()); data/pms-0.42/src/config.cpp:401:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[1024]; data/pms-0.42/src/config.cpp:406:7: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = fopen(fn.c_str(), "r"); data/pms-0.42/src/display.cpp:37:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char chararray[4]; data/pms-0.42/src/display.cpp:49:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(chararray, "%2d", 100 * win->cursordrawstart() / (win->size() - (win->bheight() - 1))); data/pms-0.42/src/display.cpp:1660:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/pms-0.42/src/display.cpp:1736:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", i); data/pms-0.42/src/display.cpp:1744:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%f", f); data/pms-0.42/src/display.cpp:1764:10: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). i = atoi(fmt); data/pms-0.42/src/field.cpp:374:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char s[30]; data/pms-0.42/src/field.cpp:719:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(s, "Total of %d items", pms->disp->actwin()->size()); data/pms-0.42/src/libmpdclient.c:95:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, data/pms-0.42/src/libmpdclient.c:130:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char service[INTLEN+1]; data/pms-0.42/src/libmpdclient.c:224:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((char *)&sin.sin_addr.s_addr,(char *)he->h_addr, data/pms-0.42/src/libmpdclient.c:230:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"address type is not IPv4"); data/pms-0.42/src/libmpdclient.c:239:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"problems creating socket"); data/pms-0.42/src/libmpdclient.c:259:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char * mpdTagItemKeys[MPD_TAG_NUM_OF_ITEM_TYPES] = data/pms-0.42/src/libmpdclient.c:368:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, "unix socket path is too long"); data/pms-0.42/src/libmpdclient.c:374:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(saun.sun_path, host, path_length + 1); data/pms-0.42/src/libmpdclient.c:378:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, "problems creating socket"); data/pms-0.42/src/libmpdclient.c:510:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"not done processing current command"); data/pms-0.42/src/libmpdclient.c:573:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"already done processing current command"); data/pms-0.42/src/libmpdclient.c:591:4: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"buffer overrun"); data/pms-0.42/src/libmpdclient.c:611:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"connection" data/pms-0.42/src/libmpdclient.c:623:4: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"connection timeout"); data/pms-0.42/src/libmpdclient.c:637:4: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, "expected more list_OK's"); data/pms-0.42/src/libmpdclient.c:648:4: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, data/pms-0.42/src/libmpdclient.c:768:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->volume = atoi(re->value); data/pms-0.42/src/libmpdclient.c:771:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->repeat = atoi(re->value); data/pms-0.42/src/libmpdclient.c:774:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->single = atoi(re->value); data/pms-0.42/src/libmpdclient.c:777:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->random = atoi(re->value); data/pms-0.42/src/libmpdclient.c:783:29: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->playlistLength = atoi(re->value); data/pms-0.42/src/libmpdclient.c:786:22: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->bitRate = atoi(re->value); data/pms-0.42/src/libmpdclient.c:803:19: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->song = atol(re->value); data/pms-0.42/src/libmpdclient.c:806:21: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->songid = atol(re->value); data/pms-0.42/src/libmpdclient.c:813:27: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->elapsedTime = atoi(re->value); data/pms-0.42/src/libmpdclient.c:814:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->totalTime = atoi(tok+1); data/pms-0.42/src/libmpdclient.c:821:24: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->crossfade = atoi(re->value); data/pms-0.42/src/libmpdclient.c:824:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->updatingDb = atoi(re->value); data/pms-0.42/src/libmpdclient.c:829:26: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->sampleRate = atoi(re->value); data/pms-0.42/src/libmpdclient.c:830:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->bits = atoi(++tok); data/pms-0.42/src/libmpdclient.c:833:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status->channels = atoi(tok+1); data/pms-0.42/src/libmpdclient.c:849:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"state not found"); data/pms-0.42/src/libmpdclient.c:898:29: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). stats->numberOfArtists = atoi(re->value); data/pms-0.42/src/libmpdclient.c:901:28: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). stats->numberOfAlbums = atoi(re->value); data/pms-0.42/src/libmpdclient.c:904:27: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). stats->numberOfSongs = atoi(re->value); data/pms-0.42/src/libmpdclient.c:961:27: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). stats->numberOfSongs = atoi(re->value); data/pms-0.42/src/libmpdclient.c:1204:29: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). entity->info.song->pos = atol(connection->returnElement->value); data/pms-0.42/src/libmpdclient.c:1208:4: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"problem parsing song info"); data/pms-0.42/src/libmpdclient.c:1230:6: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(&((entity->info.song->artist)[length]), ", "); data/pms-0.42/src/libmpdclient.c:1255:31: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). entity->info.song->time = atoi(re->value); data/pms-0.42/src/libmpdclient.c:1259:30: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). entity->info.song->pos = atol(re->value); data/pms-0.42/src/libmpdclient.c:1263:29: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). entity->info.song->id = atol(re->value); data/pms-0.42/src/libmpdclient.c:1279:6: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(&((entity->info.song->genre)[length]), ", "); data/pms-0.42/src/libmpdclient.c:1291:6: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(&((entity->info.song->composer)[length]), ", "); data/pms-0.42/src/libmpdclient.c:1303:6: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(&((entity->info.song->performer)[length]), ", "); data/pms-0.42/src/libmpdclient.c:1470:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char st[10]; data/pms-0.42/src/libmpdclient.c:1473:32: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. if(table == MPD_TABLE_ARTIST) strcpy(st,"artist"); data/pms-0.42/src/libmpdclient.c:1474:36: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. else if(table == MPD_TABLE_ALBUM) strcpy(st,"album"); data/pms-0.42/src/libmpdclient.c:1477:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"unknown table for list"); data/pms-0.42/src/libmpdclient.c:1520:12: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). retval = atoi(string); data/pms-0.42/src/libmpdclient.c:1699:9: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). ret = atoi(jobid); data/pms-0.42/src/libmpdclient.c:1770:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"already in command list mode"); data/pms-0.42/src/libmpdclient.c:1780:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"already in command list mode"); data/pms-0.42/src/libmpdclient.c:1791:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr,"not in command list mode"); data/pms-0.42/src/libmpdclient.c:1825:17: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). output->id = atoi(re->value); data/pms-0.42/src/libmpdclient.c:1831:22: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). output->enabled = atoi(re->value); data/pms-0.42/src/libmpdclient.c:1916:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, "search already in progress"); data/pms-0.42/src/libmpdclient.c:1928:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, "search already in progress"); data/pms-0.42/src/libmpdclient.c:1939:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, "search already in progress"); data/pms-0.42/src/libmpdclient.c:1954:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, "search already in progress"); data/pms-0.42/src/libmpdclient.c:1960:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, "invalid type specified"); data/pms-0.42/src/libmpdclient.c:1982:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, "no search in progress"); data/pms-0.42/src/libmpdclient.c:1988:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, "invalid type specified"); data/pms-0.42/src/libmpdclient.c:1994:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, "no name specified"); data/pms-0.42/src/libmpdclient.c:2017:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(connection->errorStr, "no search in progress"); data/pms-0.42/src/libmpdclient.h:102:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. extern char * mpdTagItemKeys[MPD_TAG_NUM_OF_ITEM_TYPES]; data/pms-0.42/src/libmpdclient.h:118:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char errorStr[MPD_ERRORSTR_MAX_LENGTH+1]; data/pms-0.42/src/libmpdclient.h:125:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[MPD_BUFFER_MAX_LENGTH+1]; data/pms-0.42/src/list.cpp:1344:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). else return atoi(a->track.c_str()) < atoi(b->track.c_str()); data/pms-0.42/src/list.cpp:1344:45: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). else return atoi(a->track.c_str()) < atoi(b->track.c_str()); data/pms-0.42/src/list.cpp:1408:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). else return atoi(a->disc.c_str()) < atoi(b->disc.c_str()); data/pms-0.42/src/list.cpp:1408:44: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). else return atoi(a->disc.c_str()) < atoi(b->disc.c_str()); data/pms-0.42/src/message.cpp:45:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[1024]; data/pms-0.42/src/pms.cpp:78:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pass[512] = ""; data/pms-0.42/src/pms.cpp:434:36: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). options->set_long("port", (port ? atoi(port) : 6600)); data/pms-0.42/src/pms.cpp:934:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[1024]; data/pms-0.42/src/pms.cpp:935:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tbuffer[20]; data/pms-0.42/src/pms.cpp:1289:32: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). options->set_long("port", atoi(argv[argn])); data/pms-0.42/src/settings.cpp:297:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). return set_long(key, atoi(val.c_str())); data/pms-0.42/src/settings.cpp:575:11: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). column = atoi(name.substr(6).c_str()); data/pms-0.42/src/config.cpp:708:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (xdgconfighome == NULL || strlen(xdgconfighome) == 0) data/pms-0.42/src/config.cpp:710:26: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (homedir != NULL && strlen(homedir) > 0) data/pms-0.42/src/config.cpp:722:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (xdgconfigdirs == NULL || strlen(xdgconfigdirs) == 0) data/pms-0.42/src/display.cpp:1677:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(fmt) < abs(x)) data/pms-0.42/src/display.cpp:1738:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). printlen += strlen(buf); data/pms-0.42/src/display.cpp:1746:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). printlen += strlen(buf); data/pms-0.42/src/display.cpp:1757:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). printlen += strlen(buf); data/pms-0.42/src/libmpdclient.c:288:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ret = malloc(strlen(arg) * 2 + 1); data/pms-0.42/src/libmpdclient.c:292:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for(i = strlen(arg)+1; i != 0; --i) { data/pms-0.42/src/libmpdclient.c:330:40: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(strncmp(output,MPD_WELCOME_MESSAGE,strlen(MPD_WELCOME_MESSAGE))) { data/pms-0.42/src/libmpdclient.c:338:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp = &output[strlen(MPD_WELCOME_MESSAGE)]; data/pms-0.42/src/libmpdclient.c:348:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). &output[strlen(MPD_WELCOME_MESSAGE)]); data/pms-0.42/src/libmpdclient.c:366:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). path_length = strlen(host); data/pms-0.42/src/libmpdclient.c:412:2: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(connection->buffer,""); data/pms-0.42/src/libmpdclient.c:416:2: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(connection->errorStr,""); data/pms-0.42/src/libmpdclient.c:480:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). connection->buflen = strlen(connection->buffer); data/pms-0.42/src/libmpdclient.c:507:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int commandLen = strlen(command); data/pms-0.42/src/libmpdclient.c:659:26: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(strncmp(output,"ACK",strlen("ACK"))==0) { data/pms-0.42/src/libmpdclient.c:1224:5: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(re->value)) { data/pms-0.42/src/libmpdclient.c:1227:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int length = strlen(entity->info.song->artist); data/pms-0.42/src/libmpdclient.c:1229:51: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). length + strlen(re->value) + 3); data/pms-0.42/src/libmpdclient.c:1276:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int length = strlen(entity->info.song->genre); data/pms-0.42/src/libmpdclient.c:1278:50: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). length + strlen(re->value) + 4); data/pms-0.42/src/libmpdclient.c:1288:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int length = strlen(entity->info.song->composer); data/pms-0.42/src/libmpdclient.c:1290:53: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). length + strlen(re->value) + 3); data/pms-0.42/src/libmpdclient.c:1300:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int length = strlen(entity->info.song->performer); data/pms-0.42/src/libmpdclient.c:1302:54: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). length + strlen(re->value) + 3); data/pms-0.42/src/libmpdclient.c:1386:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("playlistinfo")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1394:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("playlistid")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1402:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("plchanges")+2+LONGLONGLEN+3; data/pms-0.42/src/libmpdclient.c:1410:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("plchangesposid")+2+LONGLONGLEN+3; data/pms-0.42/src/libmpdclient.c:1419:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("listall")+2+strlen(sDir)+3; data/pms-0.42/src/libmpdclient.c:1419:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("listall")+2+strlen(sDir)+3; data/pms-0.42/src/libmpdclient.c:1429:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("listallinfo")+2+strlen(sDir)+3; data/pms-0.42/src/libmpdclient.c:1429:36: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("listallinfo")+2+strlen(sDir)+3; data/pms-0.42/src/libmpdclient.c:1439:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("lsinfo")+2+strlen(sDir)+3; data/pms-0.42/src/libmpdclient.c:1439:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("lsinfo")+2+strlen(sDir)+3; data/pms-0.42/src/libmpdclient.c:1482:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen("list")+1+strlen(sanitArg1)+2+strlen(st)+3; data/pms-0.42/src/libmpdclient.c:1482:26: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen("list")+1+strlen(sanitArg1)+2+strlen(st)+3; data/pms-0.42/src/libmpdclient.c:1482:46: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen("list")+1+strlen(sanitArg1)+2+strlen(st)+3; data/pms-0.42/src/libmpdclient.c:1488:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen("list")+1+strlen(st)+2; data/pms-0.42/src/libmpdclient.c:1488:26: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen("list")+1+strlen(st)+2; data/pms-0.42/src/libmpdclient.c:1498:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("add")+2+strlen(sFile)+3; data/pms-0.42/src/libmpdclient.c:1498:28: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("add")+2+strlen(sFile)+3; data/pms-0.42/src/libmpdclient.c:1510:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("addid")+2+strlen(sFile)+3; data/pms-0.42/src/libmpdclient.c:1510:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("addid")+2+strlen(sFile)+3; data/pms-0.42/src/libmpdclient.c:1528:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("delete")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1536:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("deleteid")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1545:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("save")+2+strlen(sName)+3; data/pms-0.42/src/libmpdclient.c:1545:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("save")+2+strlen(sName)+3; data/pms-0.42/src/libmpdclient.c:1555:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("load")+2+strlen(sName)+3; data/pms-0.42/src/libmpdclient.c:1555:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("load")+2+strlen(sName)+3; data/pms-0.42/src/libmpdclient.c:1565:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("rm")+2+strlen(sName)+3; data/pms-0.42/src/libmpdclient.c:1565:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("rm")+2+strlen(sName)+3; data/pms-0.42/src/libmpdclient.c:1578:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("rename")+2+strlen(sFrom)+3+strlen(sTo)+3; data/pms-0.42/src/libmpdclient.c:1578:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("rename")+2+strlen(sFrom)+3+strlen(sTo)+3; data/pms-0.42/src/libmpdclient.c:1578:47: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("rename")+2+strlen(sFrom)+3+strlen(sTo)+3; data/pms-0.42/src/libmpdclient.c:1600:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("play")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1608:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("playid")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1620:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("pause")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1636:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("move")+2+INTLEN+3+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1644:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("moveid")+2+INTLEN+3+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1652:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("swap")+2+INTLEN+3+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1660:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("swapid")+2+INTLEN+3+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1668:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("seek")+2+INTLEN+3+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1676:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("seekid")+2+INTLEN+3+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1685:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("update")+2+strlen(sPath)+3; data/pms-0.42/src/libmpdclient.c:1685:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("update")+2+strlen(sPath)+3; data/pms-0.42/src/libmpdclient.c:1711:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("repeat")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1719:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("single")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1727:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("random")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1735:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("setvol")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1743:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("volume")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1751:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("crossfade")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1760:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("password")+2+strlen(sPass)+3; data/pms-0.42/src/libmpdclient.c:1760:33: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("password")+2+strlen(sPass)+3; data/pms-0.42/src/libmpdclient.c:1846:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("enableoutput")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1854:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("disableoutput")+2+INTLEN+3; data/pms-0.42/src/libmpdclient.c:1967:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = 5+strlen(strtype)+1; data/pms-0.42/src/libmpdclient.c:2003:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(string)+1+strlen(strtype)+2+strlen(arg)+2; data/pms-0.42/src/libmpdclient.c:2003:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(string)+1+strlen(strtype)+2+strlen(arg)+2; data/pms-0.42/src/libmpdclient.c:2003:43: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(string)+1+strlen(strtype)+2+strlen(arg)+2; data/pms-0.42/src/libmpdclient.c:2022:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(connection->request)+2; data/pms-0.42/src/libmpdclient.c:2042:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("listplaylistinfo")+2+strlen(arg)+3; data/pms-0.42/src/libmpdclient.c:2042:41: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("listplaylistinfo")+2+strlen(arg)+3; data/pms-0.42/src/libmpdclient.c:2060:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("listplaylist")+2+strlen(arg)+3; data/pms-0.42/src/libmpdclient.c:2060:37: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("listplaylist")+2+strlen(arg)+3; data/pms-0.42/src/libmpdclient.c:2071:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("playlistclear")+2+strlen(sPath)+3; data/pms-0.42/src/libmpdclient.c:2071:38: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("playlistclear")+2+strlen(sPath)+3; data/pms-0.42/src/libmpdclient.c:2084:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("playlistadd")+2+strlen(sPlaylist)+3+strlen(sPath)+3; data/pms-0.42/src/libmpdclient.c:2084:36: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("playlistadd")+2+strlen(sPlaylist)+3+strlen(sPath)+3; data/pms-0.42/src/libmpdclient.c:2084:56: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("playlistadd")+2+strlen(sPlaylist)+3+strlen(sPath)+3; data/pms-0.42/src/libmpdclient.c:2097:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("playlistmove")+ data/pms-0.42/src/libmpdclient.c:2098:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). 2+strlen(sPlaylist)+3+INTLEN+3+INTLEN+3; data/pms-0.42/src/libmpdclient.c:2111:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("playlistdelete")+2+strlen(sPlaylist)+3+INTLEN+3; data/pms-0.42/src/libmpdclient.c:2111:39: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("playlistdelete")+2+strlen(sPlaylist)+3+INTLEN+3; data/pms-0.42/src/libmpdclient.c:2145:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("sticker get song ")+strlen(sSong)+3+strlen(sSticker)+4; data/pms-0.42/src/libmpdclient.c:2145:43: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("sticker get song ")+strlen(sSong)+3+strlen(sSticker)+4; data/pms-0.42/src/libmpdclient.c:2145:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("sticker get song ")+strlen(sSong)+3+strlen(sSticker)+4; data/pms-0.42/src/libmpdclient.c:2160:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("sticker set song ")+strlen(sSong)+3+strlen(sSticker)+3+strlen(sValue)+4; data/pms-0.42/src/libmpdclient.c:2160:43: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("sticker set song ")+strlen(sSong)+3+strlen(sSticker)+3+strlen(sValue)+4; data/pms-0.42/src/libmpdclient.c:2160:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("sticker set song ")+strlen(sSong)+3+strlen(sSticker)+3+strlen(sValue)+4; data/pms-0.42/src/libmpdclient.c:2160:78: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen("sticker set song ")+strlen(sSong)+3+strlen(sSticker)+3+strlen(sValue)+4; data/pms-0.42/src/pms.cpp:116:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (pass[strlen(pass)-1] == '\n') data/pms-0.42/src/pms.cpp:117:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). pass[strlen(pass)-1] = '\0'; ANALYSIS SUMMARY: Hits = 242 Lines analyzed = 17662 in approximately 0.40 seconds (43860 lines/second) Physical Source Lines of Code (SLOC) = 12653 Hits@level = [0] 103 [1] 105 [2] 99 [3] 20 [4] 18 [5] 0 Hits@level+ = [0+] 345 [1+] 242 [2+] 137 [3+] 38 [4+] 18 [5+] 0 Hits/KSLOC@level+ = [0+] 27.2663 [1+] 19.1259 [2+] 10.8275 [3+] 3.00324 [4+] 1.42259 [5+] 0 Dot directories skipped = 2 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.