Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/pptpd-1.4.0/our_syslog.h
Examining data/pptpd-1.4.0/config.embed.h
Examining data/pptpd-1.4.0/ctrlpacket.h
Examining data/pptpd-1.4.0/compat.h
Examining data/pptpd-1.4.0/inststr.c
Examining data/pptpd-1.4.0/defaults.h
Examining data/pptpd-1.4.0/acconfig.h
Examining data/pptpd-1.4.0/ppphdlc.h
Examining data/pptpd-1.4.0/pqueue.c
Examining data/pptpd-1.4.0/our_getopt.h
Examining data/pptpd-1.4.0/pptpgre.h
Examining data/pptpd-1.4.0/getopt.c
Examining data/pptpd-1.4.0/ppphdlc.c
Examining data/pptpd-1.4.0/pptpgre.c
Examining data/pptpd-1.4.0/configfile.h
Examining data/pptpd-1.4.0/pptpdefs.h
Examining data/pptpd-1.4.0/configfile.c
Examining data/pptpd-1.4.0/pptpctrl.h
Examining data/pptpd-1.4.0/compat.c
Examining data/pptpd-1.4.0/pqueue.h
Examining data/pptpd-1.4.0/pptpmanager.h
Examining data/pptpd-1.4.0/getopt1.c
Examining data/pptpd-1.4.0/plugins/patchlevel.h
Examining data/pptpd-1.4.0/plugins/pptpd-logwtmp.c
Examining data/pptpd-1.4.0/inststr.h
Examining data/pptpd-1.4.0/bcrelay.c
Examining data/pptpd-1.4.0/pptpmanager.c
Examining data/pptpd-1.4.0/pptpctrl.c
Examining data/pptpd-1.4.0/pptpd.c
Examining data/pptpd-1.4.0/ctrlpacket.c
FINAL RESULTS:
data/pptpd-1.4.0/bcrelay.c:225:53: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
if ((vdaemon == 0) && (do_org_info_printfs == 1)) printf args
data/pptpd-1.4.0/compat.c:64:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ttydev, TTYDEV);
data/pptpd-1.4.0/compat.c:65:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ptydev, PTYDEV);
data/pptpd-1.4.0/compat.c:92:17: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(name, ttydev); /* no way to bounds check */
data/pptpd-1.4.0/compat.c:117:8: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(proctitle, sizeof(proctitle), format, parms);
data/pptpd-1.4.0/compat.h:59:32: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
__attribute__ ((format (printf, 3, 4)));
data/pptpd-1.4.0/configfile.c:119:17: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(value, buff_ptr);
data/pptpd-1.4.0/inststr.c:25:17: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(argv[0], src);
data/pptpd-1.4.0/our_syslog.h:24:9: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
#define syslog(a,b,c...) ({fprintf(stderr, "pptpd syslog: " b "\n" , ## c);})
data/pptpd-1.4.0/pptpctrl.c:788:17: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(pppInterfaceIPs, "%s:%s", pppaddrs[0], pppaddrs[1]);
data/pptpd-1.4.0/pptpctrl.c:814:9: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(pppd_argv[0], pppd_argv);
data/pptpd-1.4.0/pptpd.c:393:13: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(ppp_binary, X_OK) < 0) {
data/pptpd-1.4.0/pptpd.c:399:27: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (pppdoptstr && access(pppdoptstr, R_OK) < 0) {
data/pptpd-1.4.0/pptpd.c:406:24: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (bcrelay && access(BCRELAY_BIN, X_OK) < 0) {
data/pptpd-1.4.0/pptpd.c:773:33: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(tmpstr5, "%s%d%s", ip_pre, n, ip_post);
data/pptpd-1.4.0/pptpd.c:830:12: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(bcrelay_argv[0], bcrelay_argv);
data/pptpd-1.4.0/pptpmanager.c:377:41: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
syslog(LOG_ERR, "MGR: fork() failed launching " PPTP_CTRL_BIN);
data/pptpd-1.4.0/bcrelay.c:354:9: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt_long(argc, argv, "ndhi:o:s:v", long_options, &option_index);
data/pptpd-1.4.0/getopt.c:221:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
#ifndef getenv
data/pptpd-1.4.0/getopt.c:222:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
extern char *getenv ();
data/pptpd-1.4.0/getopt.c:414:21: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
posixly_correct = getenv ("POSIXLY_CORRECT");
data/pptpd-1.4.0/getopt.c:979:1: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
getopt (argc, argv, optstring)
data/pptpd-1.4.0/getopt.c:1009:11: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt (argc, argv, "abc:d:0123456789");
data/pptpd-1.4.0/getopt1.c:76:1: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
getopt_long (argc, argv, options, long_options, opt_index)
data/pptpd-1.4.0/getopt1.c:132:11: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt_long (argc, argv, "abc:d:0123456789",
data/pptpd-1.4.0/our_getopt.h:140:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt (int __argc, char *const *__argv, const char *__shortopts);
data/pptpd-1.4.0/our_getopt.h:142:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt ();
data/pptpd-1.4.0/our_getopt.h:146:12: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt_long (int __argc, char *const *__argv, const char *__shortopts,
data/pptpd-1.4.0/our_getopt.h:159:12: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt ();
data/pptpd-1.4.0/our_getopt.h:161:12: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
extern int getopt_long ();
data/pptpd-1.4.0/pptpd.c:191:21: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt_long(argc, argv, optstring, long_options, &option_index);
data/pptpd-1.4.0/bcrelay.c:164:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char data[ETHERMTU];
data/pptpd-1.4.0/bcrelay.c:178:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ifname[16+1];
data/pptpd-1.4.0/bcrelay.c:227:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char empty[1] = "";
data/pptpd-1.4.0/bcrelay.c:228:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char reg_interfaces[MAX_IFLOGTOSTR*2+2];
data/pptpd-1.4.0/bcrelay.c:229:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char log_interfaces[MAX_IFLOGTOSTR*MAXIF];
data/pptpd-1.4.0/bcrelay.c:230:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char log_relayed[MAX_IFLOGTOSTR*MAXIF+81];
data/pptpd-1.4.0/bcrelay.c:275:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fdr = open("/dev/null", O_RDONLY);
data/pptpd-1.4.0/bcrelay.c:290:14: [2] (race) vfork:
On some old systems, vfork() permits race conditions, and it's very
difficult to use correctly (CWE-362). Use fork() instead.
if ((pid = vfork()) == 0) {
data/pptpd-1.4.0/bcrelay.c:452:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[1518];
data/pptpd-1.4.0/bcrelay.c:955:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&(iflist[cntr++].bcast), hp->h_addr, sizeof(u_int32_t));
data/pptpd-1.4.0/bcrelay.c:1025:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char str_tr[MAX_IFLOGTOSTR+90];
data/pptpd-1.4.0/bcrelay.c:1043:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char str_tr[MAX_IFLOGTOSTR];
data/pptpd-1.4.0/bcrelay.c:1050:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char str_tr[MAX_IFLOGTOSTR+64];
data/pptpd-1.4.0/compat.c:28:9: [2] (buffer) bcopy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
bcopy(src, dst, size);
data/pptpd-1.4.0/compat.c:61:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ttydev[PTYMAX], ptydev[TTYMAX];
data/pptpd-1.4.0/compat.c:70:36: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd1 = open(ptydev, O_RDWR)) >= 0) {
data/pptpd-1.4.0/compat.c:71:44: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd2 = open(ttydev, O_RDWR)) >= 0) {
data/pptpd-1.4.0/compat.c:99:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[16];
data/pptpd-1.4.0/compat.c:100:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf, "Error %d", errnum);
data/pptpd-1.4.0/compat.c:114:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char proctitle[64];
data/pptpd-1.4.0/configfile.c:44:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[MAX_CONFIG_STRING_SIZE];
data/pptpd-1.4.0/configfile.c:142:19: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((in = fopen(filename, "r")) == NULL) {
data/pptpd-1.4.0/ctrlpacket.c:214:17: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(packet, buffer, buffered);
data/pptpd-1.4.0/ctrlpacket.c:236:41: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, packet, bytes_ttl);
data/pptpd-1.4.0/ctrlpacket.c:253:33: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, packet, bytes_ttl);
data/pptpd-1.4.0/ctrlpacket.c:290:33: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, packet, bytes_ttl);
data/pptpd-1.4.0/ctrlpacket.c:307:25: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, packet, bytes_ttl);
data/pptpd-1.4.0/ctrlpacket.c:345:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(to, &from, ((*size) = sizeof(from)))
data/pptpd-1.4.0/plugins/pptpd-logwtmp.c:19:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char pptpd_original_ip[PATH_MAX+1];
data/pptpd-1.4.0/pptpctrl.c:61:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char speed[32];
data/pptpd-1.4.0/pptpctrl.c:62:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char pppdxfig[256];
data/pptpd-1.4.0/pptpctrl.c:104:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
X = atoi(argv[arg++])
data/pptpd-1.4.0/pptpctrl.c:114:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (atoi(argv[arg++]) != 0) { \
data/pptpd-1.4.0/pptpctrl.c:122:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pppLocal[16]; /* local IP to pass to pppd */
data/pptpd-1.4.0/pptpctrl.c:123:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pppRemote[16]; /* remote IP address to pass to pppd */
data/pptpd-1.4.0/pptpctrl.c:129:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *pppaddrs[2] = { pppLocal, pppRemote };
data/pptpd-1.4.0/pptpctrl.c:497:26: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char packet[PPTP_MAX_CTRL_PCKT_SIZE];
data/pptpd-1.4.0/pptpctrl.c:624:24: [2] (race) vfork:
On some old systems, vfork() permits race conditions, and it's very
difficult to use correctly (CWE-362). Use fork() instead.
switch(pppfork=vfork()){
data/pptpd-1.4.0/pptpctrl.c:684:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *pppd_argv[16];
data/pptpd-1.4.0/pptpctrl.c:687:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pppInterfaceIPs[33];
data/pptpd-1.4.0/pptpd.c:155:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[MAX_CONFIG_STRING_SIZE], *tmpstr;
data/pptpd-1.4.0/pptpd.c:253:44: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pptp_connections = atoi(optarg);
data/pptpd-1.4.0/pptpd.c:276:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pptp_stimeout = atoi(optarg);
data/pptpd-1.4.0/pptpd.c:282:43: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(optarg, "r"))) {
data/pptpd-1.4.0/pptpd.c:307:36: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pptp_connections = atoi(tmp);
data/pptpd-1.4.0/pptpd.c:323:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pptp_stimeout = atoi(tmp);
data/pptpd-1.4.0/pptpd.c:438:35: [2] (race) vfork:
On some old systems, vfork() permits race conditions, and it's very
difficult to use correctly (CWE-362). Use fork() instead.
switch(bcrelayfork = vfork()){
data/pptpd-1.4.0/pptpd.c:481:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f = fopen(pid_file, "w")) == NULL) {
data/pptpd-1.4.0/pptpd.c:501:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fdr = open("/dev/null", O_RDONLY);
data/pptpd-1.4.0/pptpd.c:504:20: [2] (race) vfork:
On some old systems, vfork() permits race conditions, and it's very
difficult to use correctly (CWE-362). Use fork() instead.
if ((pid = vfork()) == 0) {
data/pptpd-1.4.0/pptpd.c:509:17: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new_argv + 1, argv, (argc + 1) * sizeof(char **));
data/pptpd-1.4.0/pptpd.c:558:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&hst_addr.s_addr, ent->h_addr, ent->h_length);
data/pptpd-1.4.0/pptpd.c:608:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmpstr2[128]; /* allow hostnames */
data/pptpd-1.4.0/pptpd.c:610:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmpstr5[16];
data/pptpd-1.4.0/pptpd.c:615:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ipa[8]; /* xxx-xxx (largest we can get) */
data/pptpd-1.4.0/pptpd.c:616:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ipb[8];
data/pptpd-1.4.0/pptpd.c:617:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ipc[8];
data/pptpd-1.4.0/pptpd.c:618:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ipd[8];
data/pptpd-1.4.0/pptpd.c:620:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ip_pre[13]; /* xxx.xxx.xxx. (largest we can get) */
data/pptpd-1.4.0/pptpd.c:621:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ip_post[13];
data/pptpd-1.4.0/pptpd.c:623:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ipl[4];
data/pptpd-1.4.0/pptpd.c:624:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ipu[4];
data/pptpd-1.4.0/pptpd.c:699:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
lower = atoi(ipl);
data/pptpd-1.4.0/pptpd.c:700:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
upper = atoi(ipu);
data/pptpd-1.4.0/pptpd.c:704:33: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ip_pre, "%.3s.%.3s.%.3s.", ipa, ipb, ipc);
data/pptpd-1.4.0/pptpd.c:716:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
lower = atoi(ipl);
data/pptpd-1.4.0/pptpd.c:717:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
upper = atoi(ipu);
data/pptpd-1.4.0/pptpd.c:721:33: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ip_pre, "%.3s.%.3s.", ipa, ipb);
data/pptpd-1.4.0/pptpd.c:722:33: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ip_post, ".%.3s", ipd);
data/pptpd-1.4.0/pptpd.c:733:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
lower = atoi(ipl);
data/pptpd-1.4.0/pptpd.c:734:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
upper = atoi(ipu);
data/pptpd-1.4.0/pptpd.c:738:33: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ip_pre, "%.3s.", ipa);
data/pptpd-1.4.0/pptpd.c:739:33: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ip_post, ".%.3s.%.3s", ipc, ipd);
data/pptpd-1.4.0/pptpd.c:750:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
lower = atoi(ipl);
data/pptpd-1.4.0/pptpd.c:751:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
upper = atoi(ipu);
data/pptpd-1.4.0/pptpd.c:756:33: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ip_post, ".%.3s.%.3s.%.3s", ipb, ipc, ipd);
data/pptpd-1.4.0/pptpd.c:813:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *bcrelay_argv[8];
data/pptpd-1.4.0/pptpgre.c:113:25: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char buffer[PACKET_MAX], copy[PACKET_MAX];
data/pptpd-1.4.0/pptpgre.c:271:25: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char dest[2 * PACKET_MAX + 6];
data/pptpd-1.4.0/pptpgre.c:344:25: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char buffer[PACKET_MAX + 64 /*ip header */ ];
data/pptpd-1.4.0/pptpgre.c:447:26: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[PACKET_MAX + sizeof(struct pptp_gre_header)];
data/pptpd-1.4.0/pptpgre.c:504:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(u.buffer + header_len, pack, len);
data/pptpd-1.4.0/pptpmanager.c:372:52: [2] (race) vfork:
On some old systems, vfork() permits race conditions, and it's very
difficult to use correctly (CWE-362). Use fork() instead.
switch (ctrl_pid = vfork()) {
data/pptpd-1.4.0/pptpmanager.c:468:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *ctrl_argv[16]; /* arguments for launching 'pptpctrl' binary */
data/pptpd-1.4.0/pptpmanager.c:473:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ctrl_debug[2];
data/pptpd-1.4.0/pptpmanager.c:474:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ctrl_noipparam[2];
data/pptpd-1.4.0/pptpmanager.c:475:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pppdoptfile_argv[2];
data/pptpd-1.4.0/pptpmanager.c:476:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char speedgiven_argv[2];
data/pptpd-1.4.0/pptpmanager.c:479:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char callid_argv[16];
data/pptpd-1.4.0/pqueue.c:110:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(newent->packet, packet, packlen);
data/pptpd-1.4.0/bcrelay.c:296:5: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(0);
data/pptpd-1.4.0/bcrelay.c:623:30: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int rlen = read(cur_ifsnr[i].sock_nr, buf, sizeof(buf));
data/pptpd-1.4.0/bcrelay.c:876:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ifrflags.ifr_name, ifs.ifc_req[i].ifr_name, strlen(ifs.ifc_req[i].ifr_name));
data/pptpd-1.4.0/bcrelay.c:876:61: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(ifrflags.ifr_name, ifs.ifc_req[i].ifr_name, strlen(ifs.ifc_req[i].ifr_name));
data/pptpd-1.4.0/bcrelay.c:895:13: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(iflist[cntr].ifname, ifs.ifc_req[i].ifr_ifrn.ifrn_name,
data/pptpd-1.4.0/bcrelay.c:904:19: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void)strncpy(ifr.ifr_name, iflist[cntr].ifname, strlen(iflist[cntr].ifname)+1);
data/pptpd-1.4.0/bcrelay.c:904:62: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(void)strncpy(ifr.ifr_name, iflist[cntr].ifname, strlen(iflist[cntr].ifname)+1);
data/pptpd-1.4.0/bcrelay.c:920:21: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
(void)strncpy(ifr.ifr_name, iflist[cntr].ifname, strlen(iflist[cntr].ifname)+1);
data/pptpd-1.4.0/bcrelay.c:920:64: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(void)strncpy(ifr.ifr_name, iflist[cntr].ifname, strlen(iflist[cntr].ifname)+1);
data/pptpd-1.4.0/compat.c:20:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dst, src, size - 1);
data/pptpd-1.4.0/compat.c:193:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read(sigpipe[0], &signum, sizeof(signum)) == -1) {
data/pptpd-1.4.0/configfile.c:48:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
keyword_len = strlen(keyword);
data/pptpd-1.4.0/configfile.c:57:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (buffer[(len = strlen(buffer)) - 1] != '\n') {
data/pptpd-1.4.0/configfile.c:63:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
while (p && buffer[strlen(buffer) - 1] != '\n');
data/pptpd-1.4.0/ctrlpacket.c:226:30: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
bytes_this = read(clientFd, packet + bytes_ttl, 2 - bytes_ttl);
data/pptpd-1.4.0/ctrlpacket.c:280:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
bytes_this = read(clientFd, packet + bytes_ttl, length - bytes_ttl);
data/pptpd-1.4.0/ctrlpacket.c:376:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char *)start_ctrl_conn_rply.hostname, PPTP_HOSTNAME, MAX_HOSTNAME_SIZE);
data/pptpd-1.4.0/ctrlpacket.c:378:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char *)start_ctrl_conn_rply.vendor, PPTP_VENDOR, MAX_VENDOR_SIZE);
data/pptpd-1.4.0/getopt.c:244:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
# if (!defined __STDC__ || !__STDC__) && !defined strlen
data/pptpd-1.4.0/getopt.c:247:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
extern int strlen (const char *);
data/pptpd-1.4.0/getopt.c:445:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = nonoption_flags_max_len = strlen (orig_str);
data/pptpd-1.4.0/getopt.c:666:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
== (unsigned int) strlen (p->name))
data/pptpd-1.4.0/getopt.c:690:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/pptpd-1.4.0/getopt.c:722:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/pptpd-1.4.0/getopt.c:738:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/pptpd-1.4.0/getopt.c:743:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/pptpd-1.4.0/getopt.c:854:58: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((unsigned int) (nameend - nextchar) == strlen (p->name))
data/pptpd-1.4.0/getopt.c:877:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/pptpd-1.4.0/getopt.c:897:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/pptpd-1.4.0/getopt.c:911:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/pptpd-1.4.0/getopt.c:915:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nextchar += strlen (nextchar);
data/pptpd-1.4.0/inststr.c:20:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(src) <= strlen(argv[0])) {
data/pptpd-1.4.0/inststr.c:20:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(src) <= strlen(argv[0])) {
data/pptpd-1.4.0/inststr.c:34:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr = argv[0] + strlen(argv[0]);
data/pptpd-1.4.0/inststr.c:38:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr += strlen(ptr);
data/pptpd-1.4.0/pptpd.c:508:17: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(0);
data/pptpd-1.4.0/pptpd.c:534:9: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(0);
data/pptpd-1.4.0/pptpd.c:690:25: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
sscanf(tmpstr2, "%7s %7s %7s %7s", ipa, ipb, ipc, ipd);
data/pptpd-1.4.0/pptpd.c:695:33: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
sscanf(ipd, "%3s %3s", ipl, ipu);
data/pptpd-1.4.0/pptpd.c:712:33: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
sscanf(ipc, "%3s %3s", ipl, ipu);
data/pptpd-1.4.0/pptpd.c:729:33: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
sscanf(ipb, "%3s %3s", ipl, ipu);
data/pptpd-1.4.0/pptpd.c:746:33: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
sscanf(ipa, "%3s %3s", ipl, ipu);
data/pptpd-1.4.0/pptpgre.c:140:31: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((status = read(fd, buffer, sizeof(buffer))) <= 0) {
data/pptpd-1.4.0/pptpgre.c:349:23: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((status = read(fd, buffer, sizeof(buffer))) <= 0) {
ANALYSIS SUMMARY:
Hits = 165
Lines analyzed = 7543 in approximately 0.28 seconds (26871 lines/second)
Physical Source Lines of Code (SLOC) = 4938
Hits@level = [0] 309 [1] 44 [2] 90 [3] 14 [4] 17 [5] 0
Hits@level+ = [0+] 474 [1+] 165 [2+] 121 [3+] 31 [4+] 17 [5+] 0
Hits/KSLOC@level+ = [0+] 95.9903 [1+] 33.4143 [2+] 24.5038 [3+] 6.27785 [4+] 3.44269 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.