Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/qcomicbook-0.9.1/src/AboutDialog.cpp
Examining data/qcomicbook-0.9.1/src/AboutDialog.h
Examining data/qcomicbook-0.9.1/src/Archivers/AceArchiverStrategy.cpp
Examining data/qcomicbook-0.9.1/src/Archivers/AceArchiverStrategy.h
Examining data/qcomicbook-0.9.1/src/Archivers/ArchiverHint.cpp
Examining data/qcomicbook-0.9.1/src/Archivers/ArchiverHint.h
Examining data/qcomicbook-0.9.1/src/Archivers/ArchiverStatus.cpp
Examining data/qcomicbook-0.9.1/src/Archivers/ArchiverStatus.h
Examining data/qcomicbook-0.9.1/src/Archivers/ArchiverStrategy.cpp
Examining data/qcomicbook-0.9.1/src/Archivers/ArchiverStrategy.h
Examining data/qcomicbook-0.9.1/src/Archivers/ArchiversConfiguration.cpp
Examining data/qcomicbook-0.9.1/src/Archivers/ArchiversConfiguration.h
Examining data/qcomicbook-0.9.1/src/Archivers/P7zipArchiverStrategy.cpp
Examining data/qcomicbook-0.9.1/src/Archivers/P7zipArchiverStrategy.h
Examining data/qcomicbook-0.9.1/src/Archivers/RarArchiverStrategy.cpp
Examining data/qcomicbook-0.9.1/src/Archivers/RarArchiverStrategy.h
Examining data/qcomicbook-0.9.1/src/Archivers/Tarbz2ArchiverStrategy.cpp
Examining data/qcomicbook-0.9.1/src/Archivers/Tarbz2ArchiverStrategy.h
Examining data/qcomicbook-0.9.1/src/Archivers/TargzArchiverStrategy.cpp
Examining data/qcomicbook-0.9.1/src/Archivers/TargzArchiverStrategy.h
Examining data/qcomicbook-0.9.1/src/Archivers/ZipArchiverStrategy.cpp
Examining data/qcomicbook-0.9.1/src/Archivers/ZipArchiverStrategy.h
Examining data/qcomicbook-0.9.1/src/Bookmark.cpp
Examining data/qcomicbook-0.9.1/src/Bookmark.h
Examining data/qcomicbook-0.9.1/src/BookmarkManager.cpp
Examining data/qcomicbook-0.9.1/src/BookmarkManager.h
Examining data/qcomicbook-0.9.1/src/Bookmarks.cpp
Examining data/qcomicbook-0.9.1/src/Bookmarks.h
Examining data/qcomicbook-0.9.1/src/ColorPushButton.cpp
Examining data/qcomicbook-0.9.1/src/ColorPushButton.h
Examining data/qcomicbook-0.9.1/src/ComicBookCfgDialog.cpp
Examining data/qcomicbook-0.9.1/src/ComicBookCfgDialog.h
Examining data/qcomicbook-0.9.1/src/ComicBookDebug.h
Examining data/qcomicbook-0.9.1/src/ComicBookInfo.cpp
Examining data/qcomicbook-0.9.1/src/ComicBookInfo.h
Examining data/qcomicbook-0.9.1/src/ComicBookSettings.cpp
Examining data/qcomicbook-0.9.1/src/ComicBookSettings.h
Examining data/qcomicbook-0.9.1/src/ComicFrameImage.cpp
Examining data/qcomicbook-0.9.1/src/ComicFrameImage.h
Examining data/qcomicbook-0.9.1/src/ComicImage.cpp
Examining data/qcomicbook-0.9.1/src/ComicImage.h
Examining data/qcomicbook-0.9.1/src/ComicMainWindow.cpp
Examining data/qcomicbook-0.9.1/src/ComicMainWindow.h
Examining data/qcomicbook-0.9.1/src/ComicPageImage.cpp
Examining data/qcomicbook-0.9.1/src/ComicPageImage.h
Examining data/qcomicbook-0.9.1/src/Counted.h
Examining data/qcomicbook-0.9.1/src/Debug/ContinuousPageViewDebug.cpp
Examining data/qcomicbook-0.9.1/src/Debug/ContinuousPageViewDebug.h
Examining data/qcomicbook-0.9.1/src/Debug/DebugController.cpp
Examining data/qcomicbook-0.9.1/src/Debug/DebugController.h
Examining data/qcomicbook-0.9.1/src/Debug/MemoryDebug.cpp
Examining data/qcomicbook-0.9.1/src/Debug/MemoryDebug.h
Examining data/qcomicbook-0.9.1/src/DirReader.cpp
Examining data/qcomicbook-0.9.1/src/DirReader.h
Examining data/qcomicbook-0.9.1/src/EnumMap.h
Examining data/qcomicbook-0.9.1/src/FileSignature.cpp
Examining data/qcomicbook-0.9.1/src/FileSignature.h
Examining data/qcomicbook-0.9.1/src/FrameDetect/AbstractImage.h
Examining data/qcomicbook-0.9.1/src/FrameDetect/BinarizedImage.cpp
Examining data/qcomicbook-0.9.1/src/FrameDetect/BinarizedImage.h
Examining data/qcomicbook-0.9.1/src/FrameDetect/ComicFrame.h
Examining data/qcomicbook-0.9.1/src/FrameDetect/ComicFrameList.cpp
Examining data/qcomicbook-0.9.1/src/FrameDetect/ComicFrameList.h
Examining data/qcomicbook-0.9.1/src/FrameDetect/CompareFrames.h
Examining data/qcomicbook-0.9.1/src/FrameDetect/FrameCache.cpp
Examining data/qcomicbook-0.9.1/src/FrameDetect/FrameCache.h
Examining data/qcomicbook-0.9.1/src/FrameDetect/FrameDetect.cpp
Examining data/qcomicbook-0.9.1/src/FrameDetect/FrameDetect.h
Examining data/qcomicbook-0.9.1/src/FrameDetect/FrameDetectThread.cpp
Examining data/qcomicbook-0.9.1/src/FrameDetect/FrameDetectThread.h
Examining data/qcomicbook-0.9.1/src/GoToPageWidget.cpp
Examining data/qcomicbook-0.9.1/src/GoToPageWidget.h
Examining data/qcomicbook-0.9.1/src/History.cpp
Examining data/qcomicbook-0.9.1/src/History.h
Examining data/qcomicbook-0.9.1/src/IconViewThumbnail.cpp
Examining data/qcomicbook-0.9.1/src/IconViewThumbnail.h
Examining data/qcomicbook-0.9.1/src/ImageFormatsInfo.cpp
Examining data/qcomicbook-0.9.1/src/ImageFormatsInfo.h
Examining data/qcomicbook-0.9.1/src/ImgCache.cpp
Examining data/qcomicbook-0.9.1/src/ImgCache.h
Examining data/qcomicbook-0.9.1/src/Job/FrameRedrawJob.cpp
Examining data/qcomicbook-0.9.1/src/Job/FrameRedrawJob.h
Examining data/qcomicbook-0.9.1/src/Job/ImageJobResult.h
Examining data/qcomicbook-0.9.1/src/Job/ImageTransformJob.cpp
Examining data/qcomicbook-0.9.1/src/Job/ImageTransformJob.h
Examining data/qcomicbook-0.9.1/src/Job/ImageTransformThread.cpp
Examining data/qcomicbook-0.9.1/src/Job/ImageTransformThread.h
Examining data/qcomicbook-0.9.1/src/Job/JobKey.cpp
Examining data/qcomicbook-0.9.1/src/Job/JobKey.h
Examining data/qcomicbook-0.9.1/src/Job/JobSource.h
Examining data/qcomicbook-0.9.1/src/Job/JobType.h
Examining data/qcomicbook-0.9.1/src/Job/PageRedrawJob.cpp
Examining data/qcomicbook-0.9.1/src/Job/PageRedrawJob.h
Examining data/qcomicbook-0.9.1/src/Lens.cpp
Examining data/qcomicbook-0.9.1/src/Lens.h
Examining data/qcomicbook-0.9.1/src/ListViewThumbnail.cpp
Examining data/qcomicbook-0.9.1/src/ListViewThumbnail.h
Examining data/qcomicbook-0.9.1/src/LoaderThreadBase.cpp
Examining data/qcomicbook-0.9.1/src/LoaderThreadBase.h
Examining data/qcomicbook-0.9.1/src/NaturalComparator.cpp
Examining data/qcomicbook-0.9.1/src/NaturalComparator.h
Examining data/qcomicbook-0.9.1/src/Page.cpp
Examining data/qcomicbook-0.9.1/src/Page.h
Examining data/qcomicbook-0.9.1/src/PageLoaderThread.cpp
Examining data/qcomicbook-0.9.1/src/PageLoaderThread.h
Examining data/qcomicbook-0.9.1/src/PrintProgressDialog.cpp
Examining data/qcomicbook-0.9.1/src/PrintProgressDialog.h
Examining data/qcomicbook-0.9.1/src/PrinterThread.cpp
Examining data/qcomicbook-0.9.1/src/PrinterThread.h
Examining data/qcomicbook-0.9.1/src/RecentFilesMenu.cpp
Examining data/qcomicbook-0.9.1/src/RecentFilesMenu.h
Examining data/qcomicbook-0.9.1/src/Sink/ImgArchiveSink.cpp
Examining data/qcomicbook-0.9.1/src/Sink/ImgArchiveSink.h
Examining data/qcomicbook-0.9.1/src/Sink/ImgDirSink.cpp
Examining data/qcomicbook-0.9.1/src/Sink/ImgDirSink.h
Examining data/qcomicbook-0.9.1/src/Sink/ImgPdfSink.cpp
Examining data/qcomicbook-0.9.1/src/Sink/ImgPdfSink.h
Examining data/qcomicbook-0.9.1/src/Sink/ImgSink.cpp
Examining data/qcomicbook-0.9.1/src/Sink/ImgSink.h
Examining data/qcomicbook-0.9.1/src/Sink/ImgSinkFactory.cpp
Examining data/qcomicbook-0.9.1/src/Sink/ImgSinkFactory.h
Examining data/qcomicbook-0.9.1/src/StatusBar.cpp
Examining data/qcomicbook-0.9.1/src/StatusBar.h
Examining data/qcomicbook-0.9.1/src/SystemInfoDialog.cpp
Examining data/qcomicbook-0.9.1/src/SystemInfoDialog.h
Examining data/qcomicbook-0.9.1/src/Thumbnail.cpp
Examining data/qcomicbook-0.9.1/src/Thumbnail.h
Examining data/qcomicbook-0.9.1/src/ThumbnailItem.cpp
Examining data/qcomicbook-0.9.1/src/ThumbnailItem.h
Examining data/qcomicbook-0.9.1/src/ThumbnailLoaderThread.cpp
Examining data/qcomicbook-0.9.1/src/ThumbnailLoaderThread.h
Examining data/qcomicbook-0.9.1/src/ThumbnailsView.cpp
Examining data/qcomicbook-0.9.1/src/ThumbnailsView.h
Examining data/qcomicbook-0.9.1/src/ThumbnailsWindow.cpp
Examining data/qcomicbook-0.9.1/src/ThumbnailsWindow.h
Examining data/qcomicbook-0.9.1/src/Utility.cpp
Examining data/qcomicbook-0.9.1/src/Utility.h
Examining data/qcomicbook-0.9.1/src/View/ContinuousPageView.cpp
Examining data/qcomicbook-0.9.1/src/View/ContinuousPageView.h
Examining data/qcomicbook-0.9.1/src/View/CoordinateRangeList.h
Examining data/qcomicbook-0.9.1/src/View/FrameView.cpp
Examining data/qcomicbook-0.9.1/src/View/FrameView.h
Examining data/qcomicbook-0.9.1/src/View/PageViewBase.cpp
Examining data/qcomicbook-0.9.1/src/View/PageViewBase.h
Examining data/qcomicbook-0.9.1/src/View/SimplePageView.cpp
Examining data/qcomicbook-0.9.1/src/View/SimplePageView.h
Examining data/qcomicbook-0.9.1/src/ViewProperties.cpp
Examining data/qcomicbook-0.9.1/src/ViewProperties.h
Examining data/qcomicbook-0.9.1/src/ViewPropertiesData.h
Examining data/qcomicbook-0.9.1/src/main.cpp
FINAL RESULTS:
data/qcomicbook-0.9.1/src/Sink/ImgArchiveSink.cpp:218:4: [5] (race) chmod:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchmod( ) instead.
chmod(f.toLocal8Bit(), S_IRUSR|S_IWUSR);
data/qcomicbook-0.9.1/src/Archivers/RarArchiverStrategy.cpp:48:18: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if ((f = popen("unrar", "r")) != NULL)
data/qcomicbook-0.9.1/src/main.cpp:40:39: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
qtTrans.load("qt_" + QLocale::system().name(), QLibraryInfo::location(QLibraryInfo::TranslationsPath));
data/qcomicbook-0.9.1/src/main.cpp:44:55: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
qcomicbookTrans.load("qcomicbook_" + QLocale::system().name(), DATADIR "/i18n");
data/qcomicbook-0.9.1/src/Sink/ImgArchiveSink.cpp:248:9: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(time(NULL));
data/qcomicbook-0.9.1/src/Utility.cpp:22:32: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const QString paths = QString(getenv("PATH"));
data/qcomicbook-0.9.1/src/Archivers/ArchiverStrategy.cpp:117:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (file.open(QIODevice::ReadOnly))
data/qcomicbook-0.9.1/src/Archivers/ArchiversConfiguration.cpp:56:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (file.open(QIODevice::ReadOnly))
data/qcomicbook-0.9.1/src/Bookmarks.cpp:36:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (f.open(QIODevice::ReadOnly))
data/qcomicbook-0.9.1/src/Bookmarks.cpp:60:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (f.open(QIODevice::WriteOnly))
data/qcomicbook-0.9.1/src/ComicMainWindow.cpp:531:3: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(urls.at(0).toLocalFile(), 0);
data/qcomicbook-0.9.1/src/ComicMainWindow.cpp:665:5: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(fname, 0);
data/qcomicbook-0.9.1/src/ComicMainWindow.cpp:742:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(dir, 0);
data/qcomicbook-0.9.1/src/ComicMainWindow.cpp:749:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(file, 0);
data/qcomicbook-0.9.1/src/ComicMainWindow.cpp:752:23: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void ComicMainWindow::open(const QString &path, int page)
data/qcomicbook-0.9.1/src/ComicMainWindow.cpp:776:28: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int status = sink->open(fullname);
data/qcomicbook-0.9.1/src/ComicMainWindow.cpp:789:4: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(fname, 0);
data/qcomicbook-0.9.1/src/ComicMainWindow.cpp:799:25: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(fname, 0);
data/qcomicbook-0.9.1/src/ComicMainWindow.cpp:1144:25: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(fname, b.getPage());
data/qcomicbook-0.9.1/src/ComicMainWindow.h:124:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open(const QString &path, int page=0);
data/qcomicbook-0.9.1/src/Sink/ImgArchiveSink.cpp:42:2: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(path);
data/qcomicbook-0.9.1/src/Sink/ImgArchiveSink.cpp:161:21: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int ImgArchiveSink::open(const QString &path) //TODO: cleanup if already opened?
data/qcomicbook-0.9.1/src/Sink/ImgArchiveSink.h:65:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
virtual int open(const QString &path);
data/qcomicbook-0.9.1/src/Sink/ImgDirSink.cpp:35:2: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(path);
data/qcomicbook-0.9.1/src/Sink/ImgDirSink.cpp:91:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int ImgDirSink::open(const QString &path)
data/qcomicbook-0.9.1/src/Sink/ImgDirSink.cpp:143:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (f.open(QIODevice::ReadOnly) && (f.size() < MAX_TEXTFILE_SIZE))
data/qcomicbook-0.9.1/src/Sink/ImgDirSink.h:81:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
virtual int open(const QString &path);
data/qcomicbook-0.9.1/src/Sink/ImgPdfSink.cpp:30:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int ImgPdfSink::open(const QString &path)
data/qcomicbook-0.9.1/src/Sink/ImgPdfSink.h:29:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int open(const QString &path);
data/qcomicbook-0.9.1/src/Sink/ImgSink.h:62:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
virtual int open(const QString &path) = 0;
data/qcomicbook-0.9.1/src/View/PageViewBase.cpp:349:25: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char bmp_bits[4*32];
data/qcomicbook-0.9.1/src/View/PageViewBase.cpp:350:25: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char msk_bits[4*32];
data/qcomicbook-0.9.1/src/main.cpp:90:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
win->open(app.arguments().at(1));
ANALYSIS SUMMARY:
Hits = 33
Lines analyzed = 13635 in approximately 0.29 seconds (46773 lines/second)
Physical Source Lines of Code (SLOC) = 9669
Hits@level = [0] 0 [1] 0 [2] 27 [3] 2 [4] 3 [5] 1
Hits@level+ = [0+] 33 [1+] 33 [2+] 33 [3+] 6 [4+] 4 [5+] 1
Hits/KSLOC@level+ = [0+] 3.41297 [1+] 3.41297 [2+] 3.41297 [3+] 0.62054 [4+] 0.413693 [5+] 0.103423
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.