Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/qdirstat-1.7/src/ActionManager.cpp
Examining data/qdirstat-1.7/src/ActionManager.h
Examining data/qdirstat-1.7/src/AdaptiveTimer.cpp
Examining data/qdirstat-1.7/src/AdaptiveTimer.h
Examining data/qdirstat-1.7/src/Attic.cpp
Examining data/qdirstat-1.7/src/Attic.h
Examining data/qdirstat-1.7/src/BreadcrumbNavigator.cpp
Examining data/qdirstat-1.7/src/BreadcrumbNavigator.h
Examining data/qdirstat-1.7/src/BucketsTableModel.cpp
Examining data/qdirstat-1.7/src/BucketsTableModel.h
Examining data/qdirstat-1.7/src/BusyPopup.cpp
Examining data/qdirstat-1.7/src/BusyPopup.h
Examining data/qdirstat-1.7/src/Cleanup.cpp
Examining data/qdirstat-1.7/src/Cleanup.h
Examining data/qdirstat-1.7/src/CleanupCollection.cpp
Examining data/qdirstat-1.7/src/CleanupCollection.h
Examining data/qdirstat-1.7/src/CleanupConfigPage.cpp
Examining data/qdirstat-1.7/src/CleanupConfigPage.h
Examining data/qdirstat-1.7/src/ConfigDialog.cpp
Examining data/qdirstat-1.7/src/ConfigDialog.h
Examining data/qdirstat-1.7/src/DataColumns.cpp
Examining data/qdirstat-1.7/src/DataColumns.h
Examining data/qdirstat-1.7/src/DebugHelpers.cpp
Examining data/qdirstat-1.7/src/DebugHelpers.h
Examining data/qdirstat-1.7/src/DelayedRebuilder.cpp
Examining data/qdirstat-1.7/src/DelayedRebuilder.h
Examining data/qdirstat-1.7/src/DirInfo.cpp
Examining data/qdirstat-1.7/src/DirInfo.h
Examining data/qdirstat-1.7/src/DirReadJob.cpp
Examining data/qdirstat-1.7/src/DirReadJob.h
Examining data/qdirstat-1.7/src/DirSaver.cpp
Examining data/qdirstat-1.7/src/DirSaver.h
Examining data/qdirstat-1.7/src/DirTree.cpp
Examining data/qdirstat-1.7/src/DirTree.h
Examining data/qdirstat-1.7/src/DirTreeCache.cpp
Examining data/qdirstat-1.7/src/DirTreeCache.h
Examining data/qdirstat-1.7/src/DirTreeFilter.h
Examining data/qdirstat-1.7/src/DirTreeModel.cpp
Examining data/qdirstat-1.7/src/DirTreeModel.h
Examining data/qdirstat-1.7/src/DirTreePatternFilter.cpp
Examining data/qdirstat-1.7/src/DirTreePatternFilter.h
Examining data/qdirstat-1.7/src/DirTreePkgFilter.cpp
Examining data/qdirstat-1.7/src/DirTreePkgFilter.h
Examining data/qdirstat-1.7/src/DirTreeView.cpp
Examining data/qdirstat-1.7/src/DirTreeView.h
Examining data/qdirstat-1.7/src/DotEntry.cpp
Examining data/qdirstat-1.7/src/DotEntry.h
Examining data/qdirstat-1.7/src/DpkgPkgManager.cpp
Examining data/qdirstat-1.7/src/DpkgPkgManager.h
Examining data/qdirstat-1.7/src/Exception.cpp
Examining data/qdirstat-1.7/src/Exception.h
Examining data/qdirstat-1.7/src/ExcludeRules.cpp
Examining data/qdirstat-1.7/src/ExcludeRules.h
Examining data/qdirstat-1.7/src/ExcludeRulesConfigPage.cpp
Examining data/qdirstat-1.7/src/ExcludeRulesConfigPage.h
Examining data/qdirstat-1.7/src/ExistingDirCompleter.cpp
Examining data/qdirstat-1.7/src/ExistingDirCompleter.h
Examining data/qdirstat-1.7/src/ExistingDirValidator.cpp
Examining data/qdirstat-1.7/src/ExistingDirValidator.h
Examining data/qdirstat-1.7/src/FileDetailsView.cpp
Examining data/qdirstat-1.7/src/FileDetailsView.h
Examining data/qdirstat-1.7/src/FileInfo.cpp
Examining data/qdirstat-1.7/src/FileInfo.h
Examining data/qdirstat-1.7/src/FileInfoIterator.cpp
Examining data/qdirstat-1.7/src/FileInfoIterator.h
Examining data/qdirstat-1.7/src/FileInfoSet.cpp
Examining data/qdirstat-1.7/src/FileInfoSet.h
Examining data/qdirstat-1.7/src/FileInfoSorter.cpp
Examining data/qdirstat-1.7/src/FileInfoSorter.h
Examining data/qdirstat-1.7/src/FileSizeLabel.cpp
Examining data/qdirstat-1.7/src/FileSizeLabel.h
Examining data/qdirstat-1.7/src/FileSizeStats.cpp
Examining data/qdirstat-1.7/src/FileSizeStats.h
Examining data/qdirstat-1.7/src/FileSizeStatsWindow.cpp
Examining data/qdirstat-1.7/src/FileSizeStatsWindow.h
Examining data/qdirstat-1.7/src/FileTypeStats.cpp
Examining data/qdirstat-1.7/src/FileTypeStats.h
Examining data/qdirstat-1.7/src/FileTypeStatsWindow.cpp
Examining data/qdirstat-1.7/src/FileTypeStatsWindow.h
Examining data/qdirstat-1.7/src/FilesystemsWindow.cpp
Examining data/qdirstat-1.7/src/FilesystemsWindow.h
Examining data/qdirstat-1.7/src/GeneralConfigPage.cpp
Examining data/qdirstat-1.7/src/GeneralConfigPage.h
Examining data/qdirstat-1.7/src/HeaderTweaker.cpp
Examining data/qdirstat-1.7/src/HeaderTweaker.h
Examining data/qdirstat-1.7/src/HistogramDraw.cpp
Examining data/qdirstat-1.7/src/HistogramItems.cpp
Examining data/qdirstat-1.7/src/HistogramItems.h
Examining data/qdirstat-1.7/src/HistogramOverflowPanel.cpp
Examining data/qdirstat-1.7/src/HistogramView.cpp
Examining data/qdirstat-1.7/src/HistogramView.h
Examining data/qdirstat-1.7/src/ListEditor.cpp
Examining data/qdirstat-1.7/src/ListEditor.h
Examining data/qdirstat-1.7/src/ListMover.h
Examining data/qdirstat-1.7/src/LocateFilesWindow.cpp
Examining data/qdirstat-1.7/src/LocateFilesWindow.h
Examining data/qdirstat-1.7/src/Logger.cpp
Examining data/qdirstat-1.7/src/Logger.h
Examining data/qdirstat-1.7/src/MainWindow.cpp
Examining data/qdirstat-1.7/src/MainWindow.h
Examining data/qdirstat-1.7/src/MessagePanel.cpp
Examining data/qdirstat-1.7/src/MessagePanel.h
Examining data/qdirstat-1.7/src/MimeCategorizer.cpp
Examining data/qdirstat-1.7/src/MimeCategorizer.h
Examining data/qdirstat-1.7/src/MimeCategory.cpp
Examining data/qdirstat-1.7/src/MimeCategory.h
Examining data/qdirstat-1.7/src/MimeCategoryConfigPage.cpp
Examining data/qdirstat-1.7/src/MimeCategoryConfigPage.h
Examining data/qdirstat-1.7/src/MountPoints.cpp
Examining data/qdirstat-1.7/src/MountPoints.h
Examining data/qdirstat-1.7/src/OpenDirDialog.cpp
Examining data/qdirstat-1.7/src/OpenDirDialog.h
Examining data/qdirstat-1.7/src/OpenPkgDialog.cpp
Examining data/qdirstat-1.7/src/OpenPkgDialog.h
Examining data/qdirstat-1.7/src/OutputWindow.cpp
Examining data/qdirstat-1.7/src/OutputWindow.h
Examining data/qdirstat-1.7/src/PacManPkgManager.cpp
Examining data/qdirstat-1.7/src/PacManPkgManager.h
Examining data/qdirstat-1.7/src/PanelMessage.cpp
Examining data/qdirstat-1.7/src/PanelMessage.h
Examining data/qdirstat-1.7/src/PathSelector.cpp
Examining data/qdirstat-1.7/src/PathSelector.h
Examining data/qdirstat-1.7/src/PercentBar.cpp
Examining data/qdirstat-1.7/src/PercentBar.h
Examining data/qdirstat-1.7/src/PercentileStats.cpp
Examining data/qdirstat-1.7/src/PercentileStats.h
Examining data/qdirstat-1.7/src/PkgFileListCache.cpp
Examining data/qdirstat-1.7/src/PkgFileListCache.h
Examining data/qdirstat-1.7/src/PkgFilter.cpp
Examining data/qdirstat-1.7/src/PkgFilter.h
Examining data/qdirstat-1.7/src/PkgInfo.cpp
Examining data/qdirstat-1.7/src/PkgInfo.h
Examining data/qdirstat-1.7/src/PkgManager.cpp
Examining data/qdirstat-1.7/src/PkgManager.h
Examining data/qdirstat-1.7/src/PkgQuery.cpp
Examining data/qdirstat-1.7/src/PkgQuery.h
Examining data/qdirstat-1.7/src/PkgReader.cpp
Examining data/qdirstat-1.7/src/PkgReader.h
Examining data/qdirstat-1.7/src/Process.cpp
Examining data/qdirstat-1.7/src/Process.h
Examining data/qdirstat-1.7/src/ProcessStarter.cpp
Examining data/qdirstat-1.7/src/ProcessStarter.h
Examining data/qdirstat-1.7/src/Qt4Compat.h
Examining data/qdirstat-1.7/src/Refresher.cpp
Examining data/qdirstat-1.7/src/Refresher.h
Examining data/qdirstat-1.7/src/RpmPkgManager.cpp
Examining data/qdirstat-1.7/src/RpmPkgManager.h
Examining data/qdirstat-1.7/src/SelectionModel.cpp
Examining data/qdirstat-1.7/src/SelectionModel.h
Examining data/qdirstat-1.7/src/Settings.cpp
Examining data/qdirstat-1.7/src/Settings.h
Examining data/qdirstat-1.7/src/SettingsHelpers.cpp
Examining data/qdirstat-1.7/src/SettingsHelpers.h
Examining data/qdirstat-1.7/src/ShowUnpkgFilesDialog.cpp
Examining data/qdirstat-1.7/src/ShowUnpkgFilesDialog.h
Examining data/qdirstat-1.7/src/SignalBlocker.h
Examining data/qdirstat-1.7/src/SizeColDelegate.cpp
Examining data/qdirstat-1.7/src/SizeColDelegate.h
Examining data/qdirstat-1.7/src/StdCleanup.cpp
Examining data/qdirstat-1.7/src/StdCleanup.h
Examining data/qdirstat-1.7/src/Subtree.cpp
Examining data/qdirstat-1.7/src/Subtree.h
Examining data/qdirstat-1.7/src/SysUtil.cpp
Examining data/qdirstat-1.7/src/SysUtil.h
Examining data/qdirstat-1.7/src/SystemFileChecker.cpp
Examining data/qdirstat-1.7/src/SystemFileChecker.h
Examining data/qdirstat-1.7/src/Trash.cpp
Examining data/qdirstat-1.7/src/Trash.h
Examining data/qdirstat-1.7/src/TreemapTile.cpp
Examining data/qdirstat-1.7/src/TreemapTile.h
Examining data/qdirstat-1.7/src/TreemapView.cpp
Examining data/qdirstat-1.7/src/TreemapView.h
Examining data/qdirstat-1.7/src/UnpkgSettings.cpp
Examining data/qdirstat-1.7/src/UnpkgSettings.h
Examining data/qdirstat-1.7/src/UnreadableDirsWindow.cpp
Examining data/qdirstat-1.7/src/UnreadableDirsWindow.h
Examining data/qdirstat-1.7/src/Version.h
Examining data/qdirstat-1.7/src/main.cpp
FINAL RESULTS:
data/qdirstat-1.7/src/Settings.cpp:112:28: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
int result = ::chown( filename.toUtf8(), uid, gid );
data/qdirstat-1.7/src/DirReadJob.cpp:221:10: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if ( access( _dirName.toUtf8(), X_OK | R_OK ) != 0 )
data/qdirstat-1.7/src/SysUtil.cpp:154:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
return access( command.toUtf8(), X_OK ) == 0;
data/qdirstat-1.7/src/MimeCategoryConfigPage.cpp:294:5: [3] (random) srandom:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srandom( (unsigned) time(0) ); // Seed random number generator
data/qdirstat-1.7/src/MimeCategoryConfigPage.cpp:295:26: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
int fileCount = random() % 30 + 12;
data/qdirstat-1.7/src/MimeCategoryConfigPage.cpp:305:14: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
int dirNo = random() % dirs.size();
data/qdirstat-1.7/src/MimeCategoryConfigPage.cpp:309:22: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
FileSize fileSize = random() % maxSize;
data/qdirstat-1.7/src/DirTreeCache.cpp:369:29: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int links = links_str ? atoi( links_str ) : 1;
data/qdirstat-1.7/src/DirTreeCache.h:279:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char _buffer[ MAX_CACHE_LINE_LEN ];
data/qdirstat-1.7/src/DirTreeCache.h:283:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char * _fields[ MAX_FIELDS_PER_LINE ];
data/qdirstat-1.7/src/Logger.cpp:116:22: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ( _nullDevice.open( QIODevice::WriteOnly | QIODevice::Text ) )
data/qdirstat-1.7/src/Logger.cpp:133:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ( _logFile.open( QIODevice::WriteOnly |
data/qdirstat-1.7/src/MountPoints.cpp:288:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ( ! file.open( QIODevice::ReadOnly | QIODevice::Text ) )
data/qdirstat-1.7/src/Trash.cpp:294:22: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ( ! trashInfo.open( QIODevice::WriteOnly | QIODevice::Text ) )
data/qdirstat-1.7/src/DirReadJob.cpp:69:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
void DirReadJob::read()
data/qdirstat-1.7/src/DirReadJob.cpp:688:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
CacheReadJob::read()
data/qdirstat-1.7/src/DirReadJob.cpp:699:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
_reader->read( 1000 );
data/qdirstat-1.7/src/DirReadJob.cpp:836:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
_queue.first()->read();
data/qdirstat-1.7/src/DirReadJob.h:75:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
virtual void read();
data/qdirstat-1.7/src/DirReadJob.h:379:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
virtual void read();
data/qdirstat-1.7/src/DirTree.cpp:469:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
reader.read( pkgFilter );
data/qdirstat-1.7/src/DirTreeCache.cpp:265:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
bool CacheReader::read( int maxLines )
data/qdirstat-1.7/src/DirTreeCache.cpp:638:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char * end = _line + strlen( _line );
data/qdirstat-1.7/src/DirTreeCache.cpp:697:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cptr = start + strlen( start ) -1;
data/qdirstat-1.7/src/DirTreeCache.h:115:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
bool read( int maxLines = 0 );
data/qdirstat-1.7/src/MountPoints.cpp:274:5: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read( "/proc/mounts" ) || read( "/etc/mtab" );
data/qdirstat-1.7/src/MountPoints.cpp:274:31: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read( "/proc/mounts" ) || read( "/etc/mtab" );
data/qdirstat-1.7/src/MountPoints.cpp:284:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
bool MountPoints::read( const QString & filename )
data/qdirstat-1.7/src/MountPoints.h:278:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
bool read( const QString & filename );
data/qdirstat-1.7/src/PkgReader.cpp:46:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
void PkgReader::read( const PkgFilter & filter )
data/qdirstat-1.7/src/PkgReader.h:61:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
void read( const PkgFilter & filter );
data/qdirstat-1.7/src/UnpkgSettings.cpp:24:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read();
data/qdirstat-1.7/src/UnpkgSettings.cpp:39:21: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
void UnpkgSettings::read()
data/qdirstat-1.7/src/UnpkgSettings.h:51:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
void read();
ANALYSIS SUMMARY:
Hits = 34
Lines analyzed = 44466 in approximately 0.82 seconds (54486 lines/second)
Physical Source Lines of Code (SLOC) = 22970
Hits@level = [0] 8 [1] 20 [2] 7 [3] 4 [4] 2 [5] 1
Hits@level+ = [0+] 42 [1+] 34 [2+] 14 [3+] 7 [4+] 3 [5+] 1
Hits/KSLOC@level+ = [0+] 1.82847 [1+] 1.48019 [2+] 0.609491 [3+] 0.304745 [4+] 0.130605 [5+] 0.043535
Dot directories skipped = 2 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.