Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/qterm-0.7.4/cmake/bindingstest/QtScriptBindingsTest.cpp
Examining data/qterm-0.7.4/src/aboutdialog.cpp
Examining data/qterm-0.7.4/src/aboutdialog.h
Examining data/qterm-0.7.4/src/addrdialog.cpp
Examining data/qterm-0.7.4/src/addrdialog.h
Examining data/qterm-0.7.4/src/articledialog.cpp
Examining data/qterm-0.7.4/src/articledialog.h
Examining data/qterm-0.7.4/src/assistantclient.cpp
Examining data/qterm-0.7.4/src/assistantclient.h
Examining data/qterm-0.7.4/src/blur.cpp
Examining data/qterm-0.7.4/src/blur.h
Examining data/qterm-0.7.4/src/charpane.cpp
Examining data/qterm-0.7.4/src/charpane.h
Examining data/qterm-0.7.4/src/chartable.cpp
Examining data/qterm-0.7.4/src/chartable.h
Examining data/qterm-0.7.4/src/closedialog.cpp
Examining data/qterm-0.7.4/src/closedialog.h
Examining data/qterm-0.7.4/src/dbus.cpp
Examining data/qterm-0.7.4/src/dbus.h
Examining data/qterm-0.7.4/src/dommodel.cpp
Examining data/qterm-0.7.4/src/dommodel.h
Examining data/qterm-0.7.4/src/hostinfo.cpp
Examining data/qterm-0.7.4/src/hostinfo.h
Examining data/qterm-0.7.4/src/imageconverter.cpp
Examining data/qterm-0.7.4/src/imageconverter.h
Examining data/qterm-0.7.4/src/imagelistviewer.cpp
Examining data/qterm-0.7.4/src/imagelistviewer.h
Examining data/qterm-0.7.4/src/imageviewer.cpp
Examining data/qterm-0.7.4/src/imageviewer.h
Examining data/qterm-0.7.4/src/keyboardtranslator.cpp
Examining data/qterm-0.7.4/src/keyboardtranslator.h
Examining data/qterm-0.7.4/src/keydialog.cpp
Examining data/qterm-0.7.4/src/keydialog.h
Examining data/qterm-0.7.4/src/main.cpp
Examining data/qterm-0.7.4/src/msgdialog.cpp
Examining data/qterm-0.7.4/src/msgdialog.h
Examining data/qterm-0.7.4/src/osdmessage.cpp
Examining data/qterm-0.7.4/src/osdmessage.h
Examining data/qterm-0.7.4/src/overlayWidget.cpp
Examining data/qterm-0.7.4/src/overlayWidget.h
Examining data/qterm-0.7.4/src/pallete.cpp
Examining data/qterm-0.7.4/src/pallete.h
Examining data/qterm-0.7.4/src/popupMessage.cpp
Examining data/qterm-0.7.4/src/popupMessage.h
Examining data/qterm-0.7.4/src/popwidget.cpp
Examining data/qterm-0.7.4/src/popwidget.h
Examining data/qterm-0.7.4/src/prefdialog.cpp
Examining data/qterm-0.7.4/src/prefdialog.h
Examining data/qterm-0.7.4/src/progressBar.cpp
Examining data/qterm-0.7.4/src/progressBar.h
Examining data/qterm-0.7.4/src/qterm.h
Examining data/qterm-0.7.4/src/qtermbbs.cpp
Examining data/qterm-0.7.4/src/qtermbbs.h
Examining data/qterm-0.7.4/src/qtermbuffer.cpp
Examining data/qterm-0.7.4/src/qtermbuffer.h
Examining data/qterm-0.7.4/src/qtermcanvas.h
Examining data/qterm-0.7.4/src/qtermconfig.cpp
Examining data/qterm-0.7.4/src/qtermconfig.h
Examining data/qterm-0.7.4/src/qtermconvert.cpp
Examining data/qterm-0.7.4/src/qtermconvert.h
Examining data/qterm-0.7.4/src/qtermdecode.cpp
Examining data/qterm-0.7.4/src/qtermdecode.h
Examining data/qterm-0.7.4/src/qtermframe.cpp
Examining data/qterm-0.7.4/src/qtermframe.h
Examining data/qterm-0.7.4/src/qtermglobal.cpp
Examining data/qterm-0.7.4/src/qtermglobal.h
Examining data/qterm-0.7.4/src/qtermhttp.cpp
Examining data/qterm-0.7.4/src/qtermhttp.h
Examining data/qterm-0.7.4/src/qtermiplocation.h
Examining data/qterm-0.7.4/src/qtermparam.cpp
Examining data/qterm-0.7.4/src/qtermparam.h
Examining data/qterm-0.7.4/src/qtermpython.cpp
Examining data/qterm-0.7.4/src/qtermpython.h
Examining data/qterm-0.7.4/src/qtermscreen.cpp
Examining data/qterm-0.7.4/src/qtermscreen.h
Examining data/qterm-0.7.4/src/qtermsocket.cpp
Examining data/qterm-0.7.4/src/qtermsound.cpp
Examining data/qterm-0.7.4/src/qtermsound.h
Examining data/qterm-0.7.4/src/qtermtelnet.cpp
Examining data/qterm-0.7.4/src/qtermtelnet.h
Examining data/qterm-0.7.4/src/qtermtextline.cpp
Examining data/qterm-0.7.4/src/qtermtextline.h
Examining data/qterm-0.7.4/src/qtermtimelabel.cpp
Examining data/qterm-0.7.4/src/qtermtimelabel.h
Examining data/qterm-0.7.4/src/qtermtoolbutton.cpp
Examining data/qterm-0.7.4/src/qtermtoolbutton.h
Examining data/qterm-0.7.4/src/qtermwindow.cpp
Examining data/qterm-0.7.4/src/qtermwindow.h
Examining data/qterm-0.7.4/src/qtermwindowbase.cpp
Examining data/qterm-0.7.4/src/qtermwindowbase.h
Examining data/qterm-0.7.4/src/quickdialog.cpp
Examining data/qterm-0.7.4/src/quickdialog.h
Examining data/qterm-0.7.4/src/schemedialog.cpp
Examining data/qterm-0.7.4/src/schemedialog.h
Examining data/qterm-0.7.4/src/scripthelper.cpp
Examining data/qterm-0.7.4/src/scripthelper.h
Examining data/qterm-0.7.4/src/shortcutsdialog.h
Examining data/qterm-0.7.4/src/soundconf.cpp
Examining data/qterm-0.7.4/src/soundconf.h
Examining data/qterm-0.7.4/src/ssh/auth.h
Examining data/qterm-0.7.4/src/ssh/channel.cpp
Examining data/qterm-0.7.4/src/ssh/channel.h
Examining data/qterm-0.7.4/src/ssh/crc32.cpp
Examining data/qterm-0.7.4/src/ssh/crc32.h
Examining data/qterm-0.7.4/src/ssh/kex.cpp
Examining data/qterm-0.7.4/src/ssh/kex.h
Examining data/qterm-0.7.4/src/ssh/key.cpp
Examining data/qterm-0.7.4/src/ssh/key.h
Examining data/qterm-0.7.4/src/ssh/libcrypto-compat.c
Examining data/qterm-0.7.4/src/ssh/libcrypto-compat.h
Examining data/qterm-0.7.4/src/ssh/packet.cpp
Examining data/qterm-0.7.4/src/ssh/packet.h
Examining data/qterm-0.7.4/src/ssh/socket.cpp
Examining data/qterm-0.7.4/src/ssh/socket.h
Examining data/qterm-0.7.4/src/ssh/ssh1.h
Examining data/qterm-0.7.4/src/ssh/ssh2.h
Examining data/qterm-0.7.4/src/ssh/transport.cpp
Examining data/qterm-0.7.4/src/ssh/transport.h
Examining data/qterm-0.7.4/src/ssh/auth.cpp
Examining data/qterm-0.7.4/src/statusBar.cpp
Examining data/qterm-0.7.4/src/statusBar.h
Examining data/qterm-0.7.4/src/termstring.cpp
Examining data/qterm-0.7.4/src/termstring.h
Examining data/qterm-0.7.4/src/test/config/testconfig.cpp
Examining data/qterm-0.7.4/src/test/config/testconfig.h
Examining data/qterm-0.7.4/src/test/global/testglobal.cpp
Examining data/qterm-0.7.4/src/test/global/testglobal.h
Examining data/qterm-0.7.4/src/test/hostinfo/testhostinfo.cpp
Examining data/qterm-0.7.4/src/test/hostinfo/testhostinfo.h
Examining data/qterm-0.7.4/src/test/http/main.cpp
Examining data/qterm-0.7.4/src/test/http/qnamredirect.cpp
Examining data/qterm-0.7.4/src/test/http/qnamredirect.h
Examining data/qterm-0.7.4/src/test/ssh/testssh.cpp
Examining data/qterm-0.7.4/src/test/ssh/testssh.h
Examining data/qterm-0.7.4/src/toolbardialog.cpp
Examining data/qterm-0.7.4/src/toolbardialog.h
Examining data/qterm-0.7.4/src/uaocodec.cpp
Examining data/qterm-0.7.4/src/uaocodec.h
Examining data/qterm-0.7.4/src/wallet.cpp
Examining data/qterm-0.7.4/src/wallet.h
Examining data/qterm-0.7.4/src/zmodemdialog.h
Examining data/qterm-0.7.4/src/qtermcanvas.cpp
Examining data/qterm-0.7.4/src/qtermiplocation.cpp
Examining data/qterm-0.7.4/src/qtermsocket.h
Examining data/qterm-0.7.4/src/qtermzmodem.cpp
Examining data/qterm-0.7.4/src/qtermzmodem.h
Examining data/qterm-0.7.4/src/shortcutsdialog.cpp
Examining data/qterm-0.7.4/src/zmodemdialog.cpp
FINAL RESULTS:
data/qterm-0.7.4/src/main.cpp:94:9: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access (QTERM_SIG_LOG_DIR, F_OK))
data/qterm-0.7.4/src/qtermframe.cpp:815:9: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system((strTmp.mid(1) + " &").toLocal8Bit());
data/qterm-0.7.4/src/qtermglobal.cpp:183:20: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
strSection.sprintf("bbs %d", n);
data/qterm-0.7.4/src/qtermglobal.cpp:416:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ExeNamePath, DefaultModuleName);
data/qterm-0.7.4/src/qtermglobal.cpp:841:5: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(command.toUtf8().data());
data/qterm-0.7.4/src/qtermsocket.cpp:140:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(request,
data/qterm-0.7.4/src/qtermsocket.cpp:332:2: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf((char *)command.data()," %s %s",proxy_usr.toLocal8Bit().data(),
data/qterm-0.7.4/src/qtermsocket.cpp:474:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (t1, "%s:%s", user, passwd);
data/qterm-0.7.4/src/qtermsocket.cpp:478:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (res, "%s: Basic %s\r\n", header, t2);
data/qterm-0.7.4/src/qtermzmodem.cpp:890:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(xmDefPath, file) ;
data/qterm-0.7.4/src/qtermzmodem.cpp:892:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(xmFilename, file) ;
data/qterm-0.7.4/src/qtermzmodem.cpp:2358:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(rval, str) ;
data/qterm-0.7.4/src/qtermzmodem.cpp:2835:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(zmodemlogfile, fmt, ap) ;
data/qterm-0.7.4/src/ssh/packet.cpp:117:43: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
firstBlock = m_transport->crypt(m_in.left(blockSize));
data/qterm-0.7.4/src/ssh/packet.cpp:148:39: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
source = m_transport->crypt(m_in.mid(blockSize, length + 4 - blockSize));
data/qterm-0.7.4/src/ssh/packet.cpp:371:39: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
plain = m_encryption->crypt(m_in.mid(4, totalLen));
data/qterm-0.7.4/src/ssh/packet.cpp:509:31: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
packet = m_transport->crypt(plain);
data/qterm-0.7.4/src/ssh/packet.cpp:617:32: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
packet = m_encryption->crypt(plain + tmp);
data/qterm-0.7.4/src/ssh/transport.cpp:72:27: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
QByteArray SSH2Transport::crypt(const QByteArray & src)
data/qterm-0.7.4/src/ssh/transport.cpp:74:19: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
return m_enc->crypt(src);
data/qterm-0.7.4/src/ssh/transport.cpp:110:28: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
QByteArray SSH2Encryption::crypt(const QByteArray & src)
data/qterm-0.7.4/src/ssh/transport.cpp:176:28: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
QByteArray SSH1Encryption::crypt(const QByteArray & src)
data/qterm-0.7.4/src/ssh/transport.h:39:16: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
QByteArray crypt(const QByteArray & src);
data/qterm-0.7.4/src/ssh/transport.h:151:16: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
QByteArray crypt(const QByteArray & src);
data/qterm-0.7.4/src/ssh/transport.h:173:16: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
QByteArray crypt(const QByteArray & src);
data/qterm-0.7.4/src/aboutdialog.cpp:36:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ( file.open( QIODevice::ReadOnly ) )
data/qterm-0.7.4/src/articledialog.cpp:48:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f.open(QIODevice::WriteOnly))) {
data/qterm-0.7.4/src/charpane.h:20:23: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void toggled(bool open);
data/qterm-0.7.4/src/hostinfo.cpp:165:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, passphrase.toUtf8().data(), len);
data/qterm-0.7.4/src/keyboardtranslator.cpp:320:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
buffer.open(QIODevice::ReadOnly);
data/qterm-0.7.4/src/keyboardtranslator.cpp:509:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char replacement[2] = {0,0};
data/qterm-0.7.4/src/keyboardtranslator.cpp:526:21: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hexDigits[3] = {0};
data/qterm-0.7.4/src/main.cpp:51:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char _sig_fname[PATH_MAX+1];
data/qterm-0.7.4/src/main.cpp:52:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char _buf[256];
data/qterm-0.7.4/src/main.cpp:74:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (_buf, "Hit with signal %d! Stack trace of last %d functions:\n",
data/qterm-0.7.4/src/qtermcanvas.cpp:193:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (file.open(QIODevice::ReadOnly)) {
data/qterm-0.7.4/src/qtermcanvas.cpp:195:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (save.open(QIODevice::WriteOnly)) {
data/qterm-0.7.4/src/qtermcanvas.cpp:228:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (file.open(QIODevice::ReadOnly)) {
data/qterm-0.7.4/src/qtermcanvas.cpp:230:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (save.open(QIODevice::WriteOnly)) {
data/qterm-0.7.4/src/qtermglobal.cpp:110:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (file.open(QIODevice::ReadOnly)) {
data/qterm-0.7.4/src/qtermglobal.cpp:164:31: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
m_wallet->open();
data/qterm-0.7.4/src/qtermglobal.cpp:194:23: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
m_wallet->open();
data/qterm-0.7.4/src/qtermglobal.cpp:216:27: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
m_wallet->open();
data/qterm-0.7.4/src/qtermglobal.cpp:274:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (file.open(QIODevice::ReadOnly) && doc.setContent(&file)) {
data/qterm-0.7.4/src/qtermglobal.cpp:321:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (ofile.open(QIODevice::WriteOnly)) {
data/qterm-0.7.4/src/qtermglobal.cpp:411:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ExeNamePath[MAX_PATH];
data/qterm-0.7.4/src/qtermhttp.cpp:158:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (file.open(QIODevice::ReadWrite | QIODevice::Append)) {
data/qterm-0.7.4/src/qtermiplocation.cpp:37:24: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f->ipfp = fopen((pathCfg + (files.at(0))).toLocal8Bit(), "r")) == NULL) {
data/qterm-0.7.4/src/qtermiplocation.cpp:89:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[512];
data/qterm-0.7.4/src/qtermpython.cpp:262:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
file.open(QIODevice::ReadOnly);
data/qterm-0.7.4/src/qtermscreen.cpp:1189:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char tbl[256];
data/qterm-0.7.4/src/qtermsocket.cpp:103:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(command.data()+2,&addr_host.sin_port,2);
data/qterm-0.7.4/src/qtermsocket.cpp:104:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(command.data()+4,&addr_host.sin_addr,4);
data/qterm-0.7.4/src/qtermsocket.cpp:282:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&addr_host.sin_addr,hostent->h_addr,4);
data/qterm-0.7.4/src/qtermsocket.cpp:319:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy( command.data()+4, &addr_host.sin_addr,4 );
data/qterm-0.7.4/src/qtermsocket.cpp:320:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy( command.data()+8, &addr_host.sin_port,2 );
data/qterm-0.7.4/src/qtermsocket.cpp:431:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char tbl[64] = {
data/qterm-0.7.4/src/qtermtelnet.cpp:413:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data, from_socket.data(), raw_size);
data/qterm-0.7.4/src/qtermtelnet.cpp:436:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data, to_ansi.data(), rsize);
data/qterm-0.7.4/src/qtermtelnet.cpp:455:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(from_ansi.data(), data, len);
data/qterm-0.7.4/src/qtermwindow.cpp:1893:35: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (name.isEmpty() || !source.open(QIODevice::ReadOnly | QIODevice::Text))
data/qterm-0.7.4/src/qtermzmodem.cpp:455:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
zmodemlogfile = fopen("zmodem.log", "w+");
data/qterm-0.7.4/src/qtermzmodem.cpp:549:39: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (file == NULL || (info->file = fopen(file, "rb")) == NULL)
data/qterm-0.7.4/src/qtermzmodem.cpp:912:19: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *ifile = fopen(name, "rb") ;
data/qterm-0.7.4/src/qtermzmodem.cpp:1039:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
rval = fopen(str.toLocal8Bit(), apnd ? "ab" : "wb") ;
data/qterm-0.7.4/src/qtermzmodem.cpp:2445:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, info->rfilename, i + 1) ; ptr += i + 1 ;
data/qterm-0.7.4/src/qtermzmodem.cpp:2446:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf((char *)ptr, "%d %lo %o 0", info->len, info->date, info->mode);
data/qterm-0.7.4/src/qtermzmodem.cpp:2517:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, info->rfilename, i + 1) ; ptr += i + 1 ;
data/qterm-0.7.4/src/qtermzmodem.cpp:2518:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf((char *)ptr, "%d %lo %o 0 %d %d 0", info->len, info->date,
data/qterm-0.7.4/src/qtermzmodem.cpp:2820:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
zmodemlogfile = fopen("zmodem.log", "a");
data/qterm-0.7.4/src/scripthelper.cpp:302:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
file.open(QIODevice::ReadOnly);
data/qterm-0.7.4/src/ssh/auth.cpp:64:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file.open(QIODevice::ReadOnly | QIODevice::Text)) {
data/qterm-0.7.4/src/ssh/kex.cpp:146:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char p_value[128] = {
data/qterm-0.7.4/src/ssh/kex.cpp:174:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char p_value[256] = {
data/qterm-0.7.4/src/ssh/packet.cpp:81:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
m_buf.open(QBuffer::ReadWrite);
data/qterm-0.7.4/src/ssh/packet.cpp:184:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[4];
data/qterm-0.7.4/src/ssh/packet.cpp:250:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
m_buf.open(QBuffer::ReadWrite);
data/qterm-0.7.4/src/ssh/packet.cpp:262:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[4];
data/qterm-0.7.4/src/ssh/packet.cpp:289:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[2];
data/qterm-0.7.4/src/ssh/packet.cpp:397:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
m_buf.open(QBuffer::ReadWrite);
data/qterm-0.7.4/src/ssh/packet.cpp:419:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[4];
data/qterm-0.7.4/src/ssh/packet.cpp:529:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
m_buf.open(QBuffer::ReadWrite);
data/qterm-0.7.4/src/ssh/packet.cpp:551:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[4];
data/qterm-0.7.4/src/ssh/packet.cpp:581:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg[2];
data/qterm-0.7.4/src/wallet.cpp:36:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void Wallet::open()
data/qterm-0.7.4/src/wallet.cpp:50:26: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
m_handle = m_wallet->open(m_walletName, 0, "QTerm");
data/qterm-0.7.4/src/wallet.h:42:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open();
data/qterm-0.7.4/src/hostinfo.cpp:161:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(passphrase.toUtf8().data());
data/qterm-0.7.4/src/keyboardtranslator.cpp:537:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
charsToRemove = 2 + strlen(hexDigits);
data/qterm-0.7.4/src/main.cpp:76:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write (fd, _buf, strlen (_buf));
data/qterm-0.7.4/src/qtermglobal.cpp:418:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (size_t i = 0, ModuleNameLen = strlen(ExeNamePath) ;
data/qterm-0.7.4/src/qtermiplocation.cpp:101:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return strlen(str);
data/qterm-0.7.4/src/qtermpython.cpp:350:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(pstr);
data/qterm-0.7.4/src/qtermpython.cpp:367:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(pstr);
data/qterm-0.7.4/src/qtermsocket.cpp:136:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = proxyauth!=NULL?strlen(proxyauth):0;
data/qterm-0.7.4/src/qtermsocket.cpp:295:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
return m_socket->read(maxlen);
data/qterm-0.7.4/src/qtermsocket.cpp:470:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len1 = strlen (user) + 1 + strlen (passwd);
data/qterm-0.7.4/src/qtermsocket.cpp:470:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len1 = strlen (user) + 1 + strlen (passwd);
data/qterm-0.7.4/src/qtermsocket.cpp:477:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
res = (char *)malloc (len2 + 11 + strlen (header));
data/qterm-0.7.4/src/qtermtelnet.cpp:422:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int Telnet::read(char * data, uint maxlen)
data/qterm-0.7.4/src/qtermtelnet.h:120:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int read(char * data, uint maxlen);
data/qterm-0.7.4/src/qtermwindow.cpp:931:16: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
m_pTelnet->read(str, size);
data/qterm-0.7.4/src/qtermzmodem.cpp:920:17: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((i = fgetc(ifile)) != EOF)
data/qterm-0.7.4/src/qtermzmodem.cpp:1976:33: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while (len > 0 && (c = getc(info->file)) != EOF) {
data/qterm-0.7.4/src/qtermzmodem.cpp:2242:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr = fileinfo + strlen(fileinfo) + 1 ;
data/qterm-0.7.4/src/qtermzmodem.cpp:2356:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(str) + 1 ;
data/qterm-0.7.4/src/qtermzmodem.cpp:2444:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = strlen(info->rfilename) ;
data/qterm-0.7.4/src/qtermzmodem.cpp:2447:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr += strlen((char *)ptr) ;
data/qterm-0.7.4/src/qtermzmodem.cpp:2516:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = strlen(info->rfilename) ;
data/qterm-0.7.4/src/qtermzmodem.cpp:2520:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr += strlen((char *)ptr) ;
data/qterm-0.7.4/src/qtermzmodem.cpp:2644:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(err = ZXmitData(ZBIN, strlen(at) + 1, ZCRCW, (uchar *)at, info))) {
data/qterm-0.7.4/src/ssh/packet.cpp:185:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
m_buf.read(tmp, 4);
data/qterm-0.7.4/src/ssh/packet.cpp:199:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
m_buf.read(data.data(), size);
data/qterm-0.7.4/src/ssh/packet.cpp:263:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
m_buf.read(tmp, 4);
data/qterm-0.7.4/src/ssh/packet.cpp:277:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
m_buf.read(data.data(), size);
data/qterm-0.7.4/src/ssh/packet.cpp:290:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
m_buf.read(tmp, 2);
ANALYSIS SUMMARY:
Hits = 116
Lines analyzed = 50549 in approximately 2.58 seconds (19575 lines/second)
Physical Source Lines of Code (SLOC) = 42217
Hits@level = [0] 12 [1] 29 [2] 62 [3] 0 [4] 25 [5] 0
Hits@level+ = [0+] 128 [1+] 116 [2+] 87 [3+] 25 [4+] 25 [5+] 0
Hits/KSLOC@level+ = [0+] 3.03195 [1+] 2.74771 [2+] 2.06078 [3+] 0.592179 [4+] 0.592179 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.