Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/rabbitsign-2.1+dmca1/test/randapp.c Examining data/rabbitsign-2.1+dmca1/src/input.c Examining data/rabbitsign-2.1+dmca1/src/os8x.c Examining data/rabbitsign-2.1+dmca1/src/md5.c Examining data/rabbitsign-2.1+dmca1/src/typestr.c Examining data/rabbitsign-2.1+dmca1/src/mem.c Examining data/rabbitsign-2.1+dmca1/src/mpz.c Examining data/rabbitsign-2.1+dmca1/src/error.c Examining data/rabbitsign-2.1+dmca1/src/mpz.h Examining data/rabbitsign-2.1+dmca1/src/rskeygen.c Examining data/rabbitsign-2.1+dmca1/src/cmdline.c Examining data/rabbitsign-2.1+dmca1/src/packxxk.c Examining data/rabbitsign-2.1+dmca1/src/rabbitsign.h Examining data/rabbitsign-2.1+dmca1/src/graphlink.c Examining data/rabbitsign-2.1+dmca1/src/app9x.c Examining data/rabbitsign-2.1+dmca1/src/rabin.c Examining data/rabbitsign-2.1+dmca1/src/output.c Examining data/rabbitsign-2.1+dmca1/src/md5.h Examining data/rabbitsign-2.1+dmca1/src/internal.h Examining data/rabbitsign-2.1+dmca1/src/program.c Examining data/rabbitsign-2.1+dmca1/src/output9x.c Examining data/rabbitsign-2.1+dmca1/src/header.c Examining data/rabbitsign-2.1+dmca1/src/rsa.c Examining data/rabbitsign-2.1+dmca1/src/apps.c Examining data/rabbitsign-2.1+dmca1/src/rabbitsign.c Examining data/rabbitsign-2.1+dmca1/src/autokeys.h Examining data/rabbitsign-2.1+dmca1/src/keys.c Examining data/rabbitsign-2.1+dmca1/src/autokey.c Examining data/rabbitsign-2.1+dmca1/src/output8x.c Examining data/rabbitsign-2.1+dmca1/src/app8x.c FINAL RESULTS: data/rabbitsign-2.1+dmca1/src/autokey.c:86:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(s, a); data/rabbitsign-2.1+dmca1/src/autokey.c:87:3: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(s, b); data/rabbitsign-2.1+dmca1/src/autokey.c:88:3: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(s, c); data/rabbitsign-2.1+dmca1/src/autokey.c:218:5: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. sprintf(buf, fmts[i], keyid, "key"); data/rabbitsign-2.1+dmca1/src/autokey.c:229:7: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. sprintf(buf, fmts[i], keyid, "pub"); data/rabbitsign-2.1+dmca1/src/packxxk.c:90:5: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. fprintf(stderr, usage[0], progname); data/rabbitsign-2.1+dmca1/src/packxxk.c:101:7: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf(usage[0], progname); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:144:5: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. fprintf(stderr, usage[0], progname); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:155:7: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf(usage[0], progname); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:417:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(tempname, infilename); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:422:4: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(tempname, ext); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:425:4: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(ptr + 1, ext); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:429:4: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(ptr, ext); data/rabbitsign-2.1+dmca1/src/rabbitsign.h:34:52: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. # define RS_ATTR_PRINTF(f,i) __attribute__((format(printf,f,i))) data/rabbitsign-2.1+dmca1/src/autokey.c:122:12: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if ((p = getenv("RABBITSIGN_KEY_DIR"))) { data/rabbitsign-2.1+dmca1/src/autokey.c:133:12: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if ((p = getenv("TI83PLUSDIR"))) { data/rabbitsign-2.1+dmca1/test/randapp.c:48:10: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. # undef random data/rabbitsign-2.1+dmca1/test/randapp.c:49:10: [3] (random) srandom: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. # undef srandom data/rabbitsign-2.1+dmca1/test/randapp.c:50:11: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. # define random rand data/rabbitsign-2.1+dmca1/test/randapp.c:51:11: [3] (random) srandom: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. # define srandom srand data/rabbitsign-2.1+dmca1/test/randapp.c:51:19: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. # define srandom srand data/rabbitsign-2.1+dmca1/test/randapp.c:84:3: [3] (random) srandom: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srandom(time(NULL) + (100 * getpid())); data/rabbitsign-2.1+dmca1/test/randapp.c:86:30: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. size = sizeof(appstart) + (random() % 1000); data/rabbitsign-2.1+dmca1/test/randapp.c:103:15: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. data[i] = random() & 0xff; data/rabbitsign-2.1+dmca1/test/randapp.c:110:15: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. data[i] = random() & 0xff; data/rabbitsign-2.1+dmca1/test/randapp.c:113:15: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. data[i++] = random() % 4; data/rabbitsign-2.1+dmca1/src/app8x.c:289:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char sigdata[512]; data/rabbitsign-2.1+dmca1/src/app9x.c:204:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char sigdata[512]; data/rabbitsign-2.1+dmca1/src/autokey.c:90:7: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(s, "rt"); data/rabbitsign-2.1+dmca1/src/autokey.c:160:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[16]; data/rabbitsign-2.1+dmca1/src/autokey.c:169:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%04lX", keyid); data/rabbitsign-2.1+dmca1/src/autokey.c:171:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%02lX", keyid); data/rabbitsign-2.1+dmca1/src/error.c:82:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char msg[512]; data/rabbitsign-2.1+dmca1/src/error.c:86:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(msg, "error: "); data/rabbitsign-2.1+dmca1/src/error.c:99:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char msg[512]; data/rabbitsign-2.1+dmca1/src/error.c:103:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(msg, "warning: "); data/rabbitsign-2.1+dmca1/src/error.c:117:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char msg[512]; data/rabbitsign-2.1+dmca1/src/graphlink.c:64:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[78]; data/rabbitsign-2.1+dmca1/src/graphlink.c:70:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy((char*) buf, "**TIFL**"); data/rabbitsign-2.1+dmca1/src/input.c:165:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[1024]; data/rabbitsign-2.1+dmca1/src/input.c:232:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char data[256]; data/rabbitsign-2.1+dmca1/src/input.c:325:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(prgm->signature + addr, data, nbytes); data/rabbitsign-2.1+dmca1/src/input.c:331:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(prgm->data + offset, data, nbytes); data/rabbitsign-2.1+dmca1/src/input.c:385:7: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(prgm->header, prgm->data, prgm->length); data/rabbitsign-2.1+dmca1/src/input.c:447:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char tiflbuf[78]; data/rabbitsign-2.1+dmca1/src/keys.c:82:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[256]; data/rabbitsign-2.1+dmca1/src/keys.c:122:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/rabbitsign-2.1+dmca1/src/md5.c:34:11: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. # define memcpy(d, s, n) bcopy ((s), (d), (n)) data/rabbitsign-2.1+dmca1/src/md5.c:34:27: [2] (buffer) bcopy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. # define memcpy(d, s, n) bcopy ((s), (d), (n)) data/rabbitsign-2.1+dmca1/src/md5.c:57:23: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const unsigned char fillbuf[64] = { 0x80, 0 /* , 0, 0, ... */ }; data/rabbitsign-2.1+dmca1/src/md5.c:113:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (&ctx->buffer[bytes], fillbuf, pad); data/rabbitsign-2.1+dmca1/src/md5.c:137:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[BLOCKSIZE + 72]; data/rabbitsign-2.1+dmca1/src/md5.c:218:7: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (&ctx->buffer[left_over], buffer, add); data/rabbitsign-2.1+dmca1/src/md5.c:225:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (ctx->buffer, &ctx->buffer[(left_over + add) & ~63], data/rabbitsign-2.1+dmca1/src/md5.c:245:7: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (ctx->buffer, buffer, len); data/rabbitsign-2.1+dmca1/src/md5.h:90:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[128]; data/rabbitsign-2.1+dmca1/src/mem.c:71:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p, str, n + 1); data/rabbitsign-2.1+dmca1/src/os8x.c:79:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(os->header, os->data + ((unsigned long) i << 14), 256); data/rabbitsign-2.1+dmca1/src/os8x.c:213:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char sigdata[512]; data/rabbitsign-2.1+dmca1/src/os8x.c:249:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(os->signature, sigdata, siglength); data/rabbitsign-2.1+dmca1/src/output8x.c:47:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/rabbitsign-2.1+dmca1/src/output8x.c:52:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, ":%02X%04X%02X", nbytes, addr, type); data/rabbitsign-2.1+dmca1/src/output8x.c:55:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf + 9 + 2 * i, "%02X", data[i]); data/rabbitsign-2.1+dmca1/src/output8x.c:61:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf + 9 + 2 * i, "%02X", sum); data/rabbitsign-2.1+dmca1/src/output8x.c:67:7: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(buf + 11 + 2 * i, "\r\n"); data/rabbitsign-2.1+dmca1/src/output8x.c:126:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[9]; data/rabbitsign-2.1+dmca1/src/output8x.c:129:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char pnbuf[2]; data/rabbitsign-2.1+dmca1/src/output8x.c:154:4: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(name, "BASECODE"); data/rabbitsign-2.1+dmca1/src/output8x.c:156:4: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(name, "basecode"); data/rabbitsign-2.1+dmca1/src/output9x.c:53:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[9]; data/rabbitsign-2.1+dmca1/src/output9x.c:63:7: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(name, "basecode"); data/rabbitsign-2.1+dmca1/src/packxxk.c:170:21: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!(outfile = fopen(outfilename, "wb"))) { data/rabbitsign-2.1+dmca1/src/packxxk.c:189:22: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!(infile = fopen(infilename, "rb"))) { data/rabbitsign-2.1+dmca1/src/program.c:184:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(prgm->data + prgm->length, data, length); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:270:14: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). infile = fopen(keyfilename, "rb"); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:301:16: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). infile = fopen(arg, "rb"); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:392:14: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). outfile = fopen(outfilename, "wb"); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:428:4: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(ptr, "-signed."); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:432:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). outfile = fopen(tempname, "wb"); data/rabbitsign-2.1+dmca1/src/rskeygen.c:66:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buffer[256]; data/rabbitsign-2.1+dmca1/src/rskeygen.c:85:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buffer[256]; data/rabbitsign-2.1+dmca1/src/rskeygen.c:88:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). krandom = fopen(RANDOM_FILE, "rb"); data/rabbitsign-2.1+dmca1/test/randapp.c:58:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char currec[256]; data/rabbitsign-2.1+dmca1/test/randapp.c:80:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char data[2000]; data/rabbitsign-2.1+dmca1/src/autokey.c:83:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). s = rs_malloc(strlen(a) + strlen(b) + strlen(c) + 1); data/rabbitsign-2.1+dmca1/src/autokey.c:83:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). s = rs_malloc(strlen(a) + strlen(b) + strlen(c) + 1); data/rabbitsign-2.1+dmca1/src/autokey.c:83:41: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). s = rs_malloc(strlen(a) + strlen(b) + strlen(c) + 1); data/rabbitsign-2.1+dmca1/src/graphlink.c:97:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buf[16] = strlen(name); data/rabbitsign-2.1+dmca1/src/graphlink.c:101:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy((char*) buf + 17, name, 8); data/rabbitsign-2.1+dmca1/src/input.c:267:9: [1] (buffer) fgetc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). c = fgetc(f); data/rabbitsign-2.1+dmca1/src/input.c:269:11: [1] (buffer) fgetc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). c = fgetc(f); data/rabbitsign-2.1+dmca1/src/input.c:360:11: [1] (buffer) fgetc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). c = fgetc(f); data/rabbitsign-2.1+dmca1/src/input.c:464:7: [1] (buffer) fgetc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). c = fgetc(f); data/rabbitsign-2.1+dmca1/src/input.c:505:10: [1] (buffer) fgetc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if (fgetc(f) == EOF) { data/rabbitsign-2.1+dmca1/src/input.c:514:9: [1] (buffer) fgetc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). c = fgetc(f); data/rabbitsign-2.1+dmca1/src/keys.c:85:28: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). || (count * 2 + 2) > strlen(str)) data/rabbitsign-2.1+dmca1/src/keys.c:135:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(buf) < 11) { data/rabbitsign-2.1+dmca1/src/mem.c:68:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). n = strlen(str); data/rabbitsign-2.1+dmca1/src/output8x.c:65:7: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(buf + 11 + 2 * i, "\n"); data/rabbitsign-2.1+dmca1/src/output8x.c:162:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(name, (char*) hdr + fieldstart, fieldsize); data/rabbitsign-2.1+dmca1/src/output9x.c:69:7: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(name, (char*) hdr + fieldstart, fieldsize); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:411:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tempname = rs_malloc(strlen(infilename) + 32); data/rabbitsign-2.1+dmca1/src/rabbitsign.c:421:4: [1] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant character. strcat(tempname, "."); data/rabbitsign-2.1+dmca1/src/typestr.c:90:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(suff) != 3) ANALYSIS SUMMARY: Hits = 104 Lines analyzed = 7298 in approximately 0.20 seconds (36448 lines/second) Physical Source Lines of Code (SLOC) = 4798 Hits@level = [0] 54 [1] 20 [2] 58 [3] 12 [4] 14 [5] 0 Hits@level+ = [0+] 158 [1+] 104 [2+] 84 [3+] 26 [4+] 14 [5+] 0 Hits/KSLOC@level+ = [0+] 32.9304 [1+] 21.6757 [2+] 17.5073 [3+] 5.41892 [4+] 2.91788 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.