Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/remmina-1.4.8+dfsg/plugins/common/remmina_plugin.h
Examining data/remmina-1.4.8+dfsg/plugins/exec/exec_plugin.c
Examining data/remmina-1.4.8+dfsg/plugins/exec/exec_plugin_config.h
Examining data/remmina-1.4.8+dfsg/plugins/kwallet/src/kwallet_plugin.cpp
Examining data/remmina-1.4.8+dfsg/plugins/kwallet/src/kwallet_plugin.h
Examining data/remmina-1.4.8+dfsg/plugins/kwallet/src/kwallet_plugin_main.c
Examining data/remmina-1.4.8+dfsg/plugins/nx/nx_plugin.c
Examining data/remmina-1.4.8+dfsg/plugins/nx/nx_plugin.h
Examining data/remmina-1.4.8+dfsg/plugins/nx/nx_session.c
Examining data/remmina-1.4.8+dfsg/plugins/nx/nx_session.h
Examining data/remmina-1.4.8+dfsg/plugins/nx/nx_session_manager.c
Examining data/remmina-1.4.8+dfsg/plugins/nx/nx_session_manager.h
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_channels.c
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_channels.h
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_cliprdr.c
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_cliprdr.h
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_event.c
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_event.h
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_file.c
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_file.h
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_graphics.c
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_graphics.h
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.h
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_settings.c
Examining data/remmina-1.4.8+dfsg/plugins/rdp/rdp_settings.h
Examining data/remmina-1.4.8+dfsg/plugins/secret/src/glibsecret_plugin.c
Examining data/remmina-1.4.8+dfsg/plugins/secret/src/glibsecret_plugin.h
Examining data/remmina-1.4.8+dfsg/plugins/spice/spice_plugin.c
Examining data/remmina-1.4.8+dfsg/plugins/spice/spice_plugin.h
Examining data/remmina-1.4.8+dfsg/plugins/spice/spice_plugin_file_transfer.c
Examining data/remmina-1.4.8+dfsg/plugins/spice/spice_plugin_usb.c
Examining data/remmina-1.4.8+dfsg/plugins/st/st_plugin.c
Examining data/remmina-1.4.8+dfsg/plugins/st/st_plugin_config.h
Examining data/remmina-1.4.8+dfsg/plugins/telepathy/telepathy_channel_handler.c
Examining data/remmina-1.4.8+dfsg/plugins/telepathy/telepathy_channel_handler.h
Examining data/remmina-1.4.8+dfsg/plugins/telepathy/telepathy_handler.c
Examining data/remmina-1.4.8+dfsg/plugins/telepathy/telepathy_handler.h
Examining data/remmina-1.4.8+dfsg/plugins/telepathy/telepathy_plugin.c
Examining data/remmina-1.4.8+dfsg/plugins/tool_hello_world/plugin.c
Examining data/remmina-1.4.8+dfsg/plugins/tool_hello_world/plugin_config.h
Examining data/remmina-1.4.8+dfsg/plugins/vnc/vnc_plugin.c
Examining data/remmina-1.4.8+dfsg/plugins/vnc/vnc_plugin.h
Examining data/remmina-1.4.8+dfsg/plugins/www/www_config.h
Examining data/remmina-1.4.8+dfsg/plugins/www/www_plugin.c
Examining data/remmina-1.4.8+dfsg/plugins/www/www_plugin.h
Examining data/remmina-1.4.8+dfsg/plugins/www/www_utils.c
Examining data/remmina-1.4.8+dfsg/plugins/www/www_utils.h
Examining data/remmina-1.4.8+dfsg/plugins/xdmcp/xdmcp_plugin.c
Examining data/remmina-1.4.8+dfsg/src/include/remmina/plugin.h
Examining data/remmina-1.4.8+dfsg/src/include/remmina/remmina_trace_calls.h
Examining data/remmina-1.4.8+dfsg/src/include/remmina/types.h
Examining data/remmina-1.4.8+dfsg/src/rcw.c
Examining data/remmina-1.4.8+dfsg/src/rcw.h
Examining data/remmina-1.4.8+dfsg/src/remmina.c
Examining data/remmina-1.4.8+dfsg/src/remmina.h
Examining data/remmina-1.4.8+dfsg/src/remmina_about.c
Examining data/remmina-1.4.8+dfsg/src/remmina_about.h
Examining data/remmina-1.4.8+dfsg/src/remmina_applet_menu.c
Examining data/remmina-1.4.8+dfsg/src/remmina_applet_menu.h
Examining data/remmina-1.4.8+dfsg/src/remmina_applet_menu_item.c
Examining data/remmina-1.4.8+dfsg/src/remmina_applet_menu_item.h
Examining data/remmina-1.4.8+dfsg/src/remmina_avahi.c
Examining data/remmina-1.4.8+dfsg/src/remmina_avahi.h
Examining data/remmina-1.4.8+dfsg/src/remmina_chat_window.c
Examining data/remmina-1.4.8+dfsg/src/remmina_chat_window.h
Examining data/remmina-1.4.8+dfsg/src/remmina_crypt.c
Examining data/remmina-1.4.8+dfsg/src/remmina_crypt.h
Examining data/remmina-1.4.8+dfsg/src/remmina_exec.c
Examining data/remmina-1.4.8+dfsg/src/remmina_exec.h
Examining data/remmina-1.4.8+dfsg/src/remmina_ext_exec.c
Examining data/remmina-1.4.8+dfsg/src/remmina_ext_exec.h
Examining data/remmina-1.4.8+dfsg/src/remmina_external_tools.c
Examining data/remmina-1.4.8+dfsg/src/remmina_external_tools.h
Examining data/remmina-1.4.8+dfsg/src/remmina_file.c
Examining data/remmina-1.4.8+dfsg/src/remmina_file.h
Examining data/remmina-1.4.8+dfsg/src/remmina_file_editor.c
Examining data/remmina-1.4.8+dfsg/src/remmina_file_editor.h
Examining data/remmina-1.4.8+dfsg/src/remmina_file_manager.c
Examining data/remmina-1.4.8+dfsg/src/remmina_file_manager.h
Examining data/remmina-1.4.8+dfsg/src/remmina_ftp_client.c
Examining data/remmina-1.4.8+dfsg/src/remmina_ftp_client.h
Examining data/remmina-1.4.8+dfsg/src/remmina_icon.c
Examining data/remmina-1.4.8+dfsg/src/remmina_icon.h
Examining data/remmina-1.4.8+dfsg/src/remmina_key_chooser.c
Examining data/remmina-1.4.8+dfsg/src/remmina_key_chooser.h
Examining data/remmina-1.4.8+dfsg/src/remmina_log.c
Examining data/remmina-1.4.8+dfsg/src/remmina_log.h
Examining data/remmina-1.4.8+dfsg/src/remmina_main.c
Examining data/remmina-1.4.8+dfsg/src/remmina_main.h
Examining data/remmina-1.4.8+dfsg/src/remmina_marshals.c
Examining data/remmina-1.4.8+dfsg/src/remmina_marshals.h
Examining data/remmina-1.4.8+dfsg/src/remmina_masterthread_exec.c
Examining data/remmina-1.4.8+dfsg/src/remmina_masterthread_exec.h
Examining data/remmina-1.4.8+dfsg/src/remmina_message_panel.c
Examining data/remmina-1.4.8+dfsg/src/remmina_message_panel.h
Examining data/remmina-1.4.8+dfsg/src/remmina_mpchange.c
Examining data/remmina-1.4.8+dfsg/src/remmina_mpchange.h
Examining data/remmina-1.4.8+dfsg/src/remmina_plugin_manager.c
Examining data/remmina-1.4.8+dfsg/src/remmina_plugin_manager.h
Examining data/remmina-1.4.8+dfsg/src/remmina_pref.c
Examining data/remmina-1.4.8+dfsg/src/remmina_pref.h
Examining data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.c
Examining data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.h
Examining data/remmina-1.4.8+dfsg/src/remmina_protocol_widget.c
Examining data/remmina-1.4.8+dfsg/src/remmina_protocol_widget.h
Examining data/remmina-1.4.8+dfsg/src/remmina_public.c
Examining data/remmina-1.4.8+dfsg/src/remmina_public.h
Examining data/remmina-1.4.8+dfsg/src/remmina_scheduler.c
Examining data/remmina-1.4.8+dfsg/src/remmina_scheduler.h
Examining data/remmina-1.4.8+dfsg/src/remmina_scrolled_viewport.c
Examining data/remmina-1.4.8+dfsg/src/remmina_scrolled_viewport.h
Examining data/remmina-1.4.8+dfsg/src/remmina_sftp_client.c
Examining data/remmina-1.4.8+dfsg/src/remmina_sftp_client.h
Examining data/remmina-1.4.8+dfsg/src/remmina_sftp_plugin.c
Examining data/remmina-1.4.8+dfsg/src/remmina_sftp_plugin.h
Examining data/remmina-1.4.8+dfsg/src/remmina_sodium.c
Examining data/remmina-1.4.8+dfsg/src/remmina_sodium.h
Examining data/remmina-1.4.8+dfsg/src/remmina_ssh.c
Examining data/remmina-1.4.8+dfsg/src/remmina_ssh.h
Examining data/remmina-1.4.8+dfsg/src/remmina_ssh_plugin.c
Examining data/remmina-1.4.8+dfsg/src/remmina_ssh_plugin.h
Examining data/remmina-1.4.8+dfsg/src/remmina_stats.c
Examining data/remmina-1.4.8+dfsg/src/remmina_stats.h
Examining data/remmina-1.4.8+dfsg/src/remmina_stats_sender.c
Examining data/remmina-1.4.8+dfsg/src/remmina_stats_sender.h
Examining data/remmina-1.4.8+dfsg/src/remmina_string_array.c
Examining data/remmina-1.4.8+dfsg/src/remmina_string_array.h
Examining data/remmina-1.4.8+dfsg/src/remmina_string_list.c
Examining data/remmina-1.4.8+dfsg/src/remmina_string_list.h
Examining data/remmina-1.4.8+dfsg/src/remmina_sysinfo.c
Examining data/remmina-1.4.8+dfsg/src/remmina_sysinfo.h
Examining data/remmina-1.4.8+dfsg/src/remmina_unlock.c
Examining data/remmina-1.4.8+dfsg/src/remmina_unlock.h
Examining data/remmina-1.4.8+dfsg/src/remmina_utils.c
Examining data/remmina-1.4.8+dfsg/src/remmina_utils.h
Examining data/remmina-1.4.8+dfsg/src/remmina_widget_pool.c
Examining data/remmina-1.4.8+dfsg/src/remmina_widget_pool.h
Examining data/remmina-1.4.8+dfsg/src/rmnews.c
Examining data/remmina-1.4.8+dfsg/src/rmnews.h
FINAL RESULTS:
data/remmina-1.4.8+dfsg/plugins/kwallet/src/kwallet_plugin.cpp:82:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(cpassword, pba.data());
data/remmina-1.4.8+dfsg/plugins/kwallet/src/kwallet_plugin_main.c:64:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(kwkey, key);
data/remmina-1.4.8+dfsg/plugins/kwallet/src/kwallet_plugin_main.c:66:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(kwkey, path);
data/remmina-1.4.8+dfsg/plugins/nx/nx_plugin.c:316:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buffer, sizeof(buffer), fmt, args);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.h:91:16: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
wClipboard * system;
data/remmina-1.4.8+dfsg/src/remmina_external_tools.c:65:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(dirname, REMMINA_RUNTIME_EXTERNAL_TOOLS_DIR);
data/remmina-1.4.8+dfsg/src/remmina_external_tools.c:125:16: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int retval = snprintf(env, envstrlen, env_format, key, value);
data/remmina-1.4.8+dfsg/src/remmina_external_tools.c:150:2: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(cmd);
data/remmina-1.4.8+dfsg/src/remmina_pref.c:720:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(remmina_pref_file, W_OK) == 0)
data/remmina-1.4.8+dfsg/src/remmina_public.c:430:5: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(addr.sun_path, sizeof(addr.sun_path), X_UNIX_SOCKET, port);
data/remmina-1.4.8+dfsg/src/remmina_ssh_plugin.c:1213:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(menu_str, filename);
data/remmina-1.4.8+dfsg/src/remmina_file_editor.c:380:33: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
s = g_strdup_printf("%s/.ssh", g_get_home_dir());
data/remmina-1.4.8+dfsg/src/remmina_file_manager.c:66:33: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
remminadir = g_build_path("/", g_get_home_dir(), dir, NULL);
data/remmina-1.4.8+dfsg/src/remmina_file_manager.c:119:33: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
remminadir = g_build_path("/", g_get_home_dir(), legacy, NULL);
data/remmina-1.4.8+dfsg/src/remmina_icon.c:501:96: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
remmina_icon.autostart_file = g_strdup_printf("%s/.config/autostart/remmina-applet.desktop", g_get_home_dir());
data/remmina-1.4.8+dfsg/src/remmina_pref.c:82:2: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(g_date_time_to_unix(gtime));
data/remmina-1.4.8+dfsg/src/remmina_pref.c:238:34: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
remmina_dir = g_build_path("/", g_get_home_dir(), legacy, NULL);
data/remmina-1.4.8+dfsg/src/remmina_pref.c:438:35: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
remmina_pref.screenshot_path = g_get_home_dir();
data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.c:598:98: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
gtk_file_chooser_set_filename(remmina_pref_dialog->filechooserbutton_options_screenshots_path, g_get_home_dir());
data/remmina-1.4.8+dfsg/src/remmina_ssh.c:125:34: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
return g_strdup_printf("%s/%s", g_get_home_dir(), id);
data/remmina-1.4.8+dfsg/src/remmina_utils.c:524:21: [3] (random) g_rand_int_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
result[i] = alpha[g_rand_int_range(rand, 0, sizeof(alpha) - 1)];
data/remmina-1.4.8+dfsg/src/remmina_utils.c:528:25: [3] (random) g_rand_int_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
result[i + 7] = alpha[g_rand_int_range(rand, 0, sizeof(alpha) - 1)];
data/remmina-1.4.8+dfsg/src/rmnews.c:525:2: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(time(NULL));
data/remmina-1.4.8+dfsg/plugins/nx/nx_plugin.c:313:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[256];
data/remmina-1.4.8+dfsg/plugins/nx/nx_session.c:466:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
nx->session_display = atoi(p);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_cliprdr.c:380:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(output, data, size);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_cliprdr.c:604:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(retp->formats, formats, sizeof(CLIPRDR_FORMAT) * srvcount);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_cliprdr.c:689:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(outbuf, data, buffersize);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_cliprdr.c:700:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(outbuf, data, buffersize);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_cliprdr.c:713:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(outbuf, data + 14, size);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_file.c:72:71: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_plugin_service->file_set_int(remminafile, "keyboard_grab", (atoi(value) == 1));
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_file.c:76:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
switch (atoi(value)) {
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_file.c:85:68: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_plugin_service->file_set_int(remminafile, "microphone", (atoi(value) == 1));
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_file.c:87:70: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_plugin_service->file_set_int(remminafile, "shareprinter", (atoi(value) == 1));
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_file.c:89:72: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_plugin_service->file_set_int(remminafile, "sharesmartcard", (atoi(value) == 1));
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_file.c:91:74: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_plugin_service->file_set_int(remminafile, "disableclipboard", (atoi(value) != 1));
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_file.c:101:71: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_plugin_service->file_set_int(remminafile, "gateway_usage", (atoi(value) == TSC_PROXY_MODE_DETECT));
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_file.c:105:77: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_plugin_service->file_set_int(remminafile, "authentication level", atoi(value));
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:160:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, list, len);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:1023:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, dr, sz);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:1128:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *rdpsnd_params[3];
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:1130:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rdpsnd_param1[16];
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:1131:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rdpsnd_param2[16];
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:1476:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
rdpsnd_rate = atoi(cs + 1);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:1482:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
rdpsnd_channel = atoi(cs + 1);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:1992:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(thname, "RemmRDP:");
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:2001:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(thname, "<NONAM>");
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:2138:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(rpsd->buffer, gdi->primary_buffer, szmem);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:2341:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char remmina_plugin_rdp_version[256];
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_settings.c:620:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
orientation = s ? atoi(s) : 0;
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_settings.c:627:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dpsf = s ? atoi(s) : 0;
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_settings.c:633:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
desf = s ? atoi(s) : 0;
data/remmina-1.4.8+dfsg/plugins/vnc/vnc_plugin.c:727:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(param->text, text, textlen);
data/remmina-1.4.8+dfsg/src/remmina_crypt.c:114:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, str, strlen(str));
data/remmina-1.4.8+dfsg/src/remmina_exec.c:393:48: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
widget = GTK_WIDGET(remmina_pref_dialog_new(atoi(data), NULL));
data/remmina-1.4.8+dfsg/src/remmina_ext_exec.c:78:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(pre, "precommand");
data/remmina-1.4.8+dfsg/src/remmina_ext_exec.c:79:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(post, "postcommand");
data/remmina-1.4.8+dfsg/src/remmina_file.c:531:67: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
return value == NULL ? default_value : (value[0] == 't' ? TRUE : atoi(value));
data/remmina-1.4.8+dfsg/src/remmina_file.c:799:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char time_string[256];
data/remmina-1.4.8+dfsg/src/remmina_file.c:858:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(remminafile->filename, O_CREAT | O_EXCL, 0644)) < 0)
data/remmina-1.4.8+dfsg/src/remmina_icon.c:429:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg[200];
data/remmina-1.4.8+dfsg/src/remmina_icon.c:440:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(msg, "StatusNotifier/Appindicator support: ");
data/remmina-1.4.8+dfsg/src/remmina_icon.c:442:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(msg, "your desktop does support it");
data/remmina-1.4.8+dfsg/src/remmina_icon.c:444:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(msg, " and libappindicator is compiled in Remmina. Good.");
data/remmina-1.4.8+dfsg/src/remmina_icon.c:446:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(msg, ", but you did not compile Remmina with CMake’s -DWITH_APPINDICATOR=on");
data/remmina-1.4.8+dfsg/src/remmina_icon.c:450:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(msg, "not supported by desktop. libappindicator will try to fallback to GtkStatusIcon/xembed");
data/remmina-1.4.8+dfsg/src/remmina_icon.c:452:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(msg, "not supported by desktop. Remmina will try to fallback to GtkStatusIcon/xembed");
data/remmina-1.4.8+dfsg/src/remmina_main.c:459:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(iter, &child, sizeof(GtkTreeIter));
data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.c:232:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_pref.sshtunnel_port = atoi(gtk_entry_get_text(remmina_pref_dialog->entry_options_ssh_port));
data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.c:235:34: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_pref.ssh_tcp_keepidle = atoi(gtk_entry_get_text(remmina_pref_dialog->entry_options_ssh_tcp_keepidle));
data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.c:238:35: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_pref.ssh_tcp_keepintvl = atoi(gtk_entry_get_text(remmina_pref_dialog->entry_options_ssh_tcp_keepintvl));
data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.c:241:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_pref.ssh_tcp_keepcnt = atoi(gtk_entry_get_text(remmina_pref_dialog->entry_options_ssh_tcp_keepcnt));
data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.c:244:36: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_pref.ssh_tcp_usrtimeout = atoi(gtk_entry_get_text(remmina_pref_dialog->entry_options_ssh_tcp_usrtimeout));
data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.c:249:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_pref.unlock_timeout = atoi(gtk_entry_get_text(remmina_pref_dialog->unlock_timeout));
data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.c:254:34: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_pref.auto_scroll_step = atoi(gtk_entry_get_text(remmina_pref_dialog->entry_options_scroll));
data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.c:260:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_pref.recent_maximum = atoi(gtk_entry_get_text(remmina_pref_dialog->entry_options_recent_items));
data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.c:347:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remmina_pref.vte_lines = atoi(gtk_entry_get_text(remmina_pref_dialog->entry_scrollback_lines));
data/remmina-1.4.8+dfsg/src/remmina_protocol_widget.c:268:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(feature, plugin->features, sizeof(RemminaProtocolFeature) * num_plugin);
data/remmina-1.4.8+dfsg/src/remmina_public.c:349:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
defaultport = atoi(ptr2 + 1);
data/remmina-1.4.8+dfsg/src/remmina_public.c:365:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
defaultport = atoi(ptr);
data/remmina-1.4.8+dfsg/src/remmina_public.c:425:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(ptr);
data/remmina-1.4.8+dfsg/src/remmina_sodium.c:78:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char salt[crypto_pwhash_SALTBYTES] = { 0 };
data/remmina-1.4.8+dfsg/src/remmina_sodium.c:82:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char key[crypto_secretbox_KEYBYTES];
data/remmina-1.4.8+dfsg/src/remmina_sodium.c:100:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char salt[crypto_pwhash_SALTBYTES] = { 0 };
data/remmina-1.4.8+dfsg/src/remmina_sodium.c:104:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char key[crypto_pwhash_STRBYTES];
data/remmina-1.4.8+dfsg/src/remmina_sodium.c:134:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open("/dev/random", O_RDONLY)) != -1) {
data/remmina-1.4.8+dfsg/src/remmina_ssh.c:2024:22: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
(shell->slave = open(slavedevice, O_RDWR | O_NOCTTY)) < 0) {
data/remmina-1.4.8+dfsg/src/remmina_stats.c:578:5: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(pyear),
data/remmina-1.4.8+dfsg/src/remmina_stats.c:579:5: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(pmonth),
data/remmina-1.4.8+dfsg/src/remmina_stats.c:580:5: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(pday), 0, 0, 0);
data/remmina-1.4.8+dfsg/src/remmina_stats.c:605:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(hyear),
data/remmina-1.4.8+dfsg/src/remmina_stats.c:606:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(hmonth),
data/remmina-1.4.8+dfsg/src/remmina_stats.c:607:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(hday), 0, 0, 0);
data/remmina-1.4.8+dfsg/src/remmina_utils.c:468:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char block[BLOCK_SIZE];
data/remmina-1.4.8+dfsg/src/remmina_utils.c:473:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
file = fopen (filename, "r");
data/remmina-1.4.8+dfsg/src/rmnews.c:331:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
output_file = fopen(output_file_path, "w");
data/remmina-1.4.8+dfsg/src/rmnews.c:493:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(mage, "%ld", (long)(time(NULL) - sb.st_mtim.tv_sec));
data/remmina-1.4.8+dfsg/src/rmnews.c:497:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(gcount, "%ld", remmina_pref.periodic_rmnews_get_count);
data/remmina-1.4.8+dfsg/plugins/kwallet/src/kwallet_plugin_main.c:61:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
kwkey_sz = strlen(key) + 1 + strlen(path) + 1;
data/remmina-1.4.8+dfsg/plugins/kwallet/src/kwallet_plugin_main.c:61:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
kwkey_sz = strlen(key) + 1 + strlen(path) + 1;
data/remmina-1.4.8+dfsg/plugins/kwallet/src/kwallet_plugin_main.c:65:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(kwkey, ";");
data/remmina-1.4.8+dfsg/plugins/nx/nx_plugin.c:306:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read(gpdata->event_pipe[0], &dummy, 1)) {
data/remmina-1.4.8+dfsg/plugins/nx/nx_session.c:343:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = strlen(p1);
data/remmina-1.4.8+dfsg/plugins/nx/nx_session.c:371:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nx->version = g_strdup(ptr + strlen(nx_hello_server_msg));
data/remmina-1.4.8+dfsg/plugins/nx/nx_session.c:424:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = strlen(line);
data/remmina-1.4.8+dfsg/plugins/nx/nx_session.c:521:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ssh_channel_write(nx->channel, cmd, strlen(cmd));
data/remmina-1.4.8+dfsg/plugins/nx/nx_session.c:823:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
len = read(sock, buffer, sizeof(buffer));
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_cliprdr.c:671:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size = strlen((char *)inbuf);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_cliprdr.c:677:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size = strlen((char *)inbuf);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_cliprdr.c:820:3: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(100000);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:121:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(name);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:153:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(list);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:370:2: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(500000);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:909:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read(rfi->event_pipe[0], buf, sizeof(buf))) {
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:1349:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(rfi->settings->ClientHostname, cs, FREERDP_CLIENTHOSTNAME_LEN - 1);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:1351:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(rfi->settings->ClientHostname, g_get_host_name(), FREERDP_CLIENTHOSTNAME_LEN - 1);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:1362:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
rfi->settings->LoadBalanceInfoLength = (UINT32)strlen((char *)rfi->settings->LoadBalanceInfo);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:1994:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nthname = strlen(thname);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:2039:3: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(100000);
data/remmina-1.4.8+dfsg/plugins/rdp/rdp_plugin.c:2406:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n = p + strlen(option);
data/remmina-1.4.8+dfsg/plugins/vnc/vnc_plugin.c:341:57: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
SendClientCutText(cl, event->event_data.text.text, strlen(event->event_data.text.text));
data/remmina-1.4.8+dfsg/plugins/vnc/vnc_plugin.c:361:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read(gpdata->vnc_event_pipe[0], buf, sizeof(buf))) {
data/remmina-1.4.8+dfsg/plugins/vnc/vnc_plugin.c:930:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (f[strlen(f) - 1] == '\n') f[strlen(f) - 1] = '\0';
data/remmina-1.4.8+dfsg/plugins/vnc/vnc_plugin.c:930:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (f[strlen(f) - 1] == '\n') f[strlen(f) - 1] = '\0';
data/remmina-1.4.8+dfsg/plugins/www/www_utils.c:123:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pos += strlen(replace);
data/remmina-1.4.8+dfsg/plugins/www/www_utils.c:142:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gsize needle_length = strlen(needle);
data/remmina-1.4.8+dfsg/src/rcw.c:1907:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_strdup(keystroke_values[strlen(keystroke_values[0]) ? 0 : 1]));
data/remmina-1.4.8+dfsg/src/remmina_chat_window.c:113:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (text[strlen(text) - 1] == '\n') {
data/remmina-1.4.8+dfsg/src/remmina_crypt.c:109:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf_len = strlen(str);
data/remmina-1.4.8+dfsg/src/remmina_crypt.c:114:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memcpy(buf, str, strlen(str));
data/remmina-1.4.8+dfsg/src/remmina_exec.c:171:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t read;
data/remmina-1.4.8+dfsg/src/remmina_exec.c:182:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(settings[i]) > 0) {
data/remmina-1.4.8+dfsg/src/remmina_exec.c:186:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read > 0) {
data/remmina-1.4.8+dfsg/src/remmina_exec.c:475:16: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((ch = getchar()) != EOF && ch != '\n') {
data/remmina-1.4.8+dfsg/src/remmina_external_tools.c:119:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
envstrlen = strlen(key) + strlen(value) + strlen(env_format) + 1;
data/remmina-1.4.8+dfsg/src/remmina_external_tools.c:119:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
envstrlen = strlen(key) + strlen(value) + strlen(env_format) + 1;
data/remmina-1.4.8+dfsg/src/remmina_external_tools.c:119:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
envstrlen = strlen(key) + strlen(value) + strlen(env_format) + 1;
data/remmina-1.4.8+dfsg/src/remmina_external_tools.c:136:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
envstrlen = strlen(term_title_key) + strlen(term_title_val_prefix) + strlen(shortname) + 7;
data/remmina-1.4.8+dfsg/src/remmina_external_tools.c:136:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
envstrlen = strlen(term_title_key) + strlen(term_title_val_prefix) + strlen(shortname) + 7;
data/remmina-1.4.8+dfsg/src/remmina_external_tools.c:136:71: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
envstrlen = strlen(term_title_key) + strlen(term_title_val_prefix) + strlen(shortname) + 7;
data/remmina-1.4.8+dfsg/src/remmina_external_tools.c:147:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t cmdlen = strlen(launcher) + strlen(scriptname) + 2;
data/remmina-1.4.8+dfsg/src/remmina_external_tools.c:147:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t cmdlen = strlen(launcher) + strlen(scriptname) + 2;
data/remmina-1.4.8+dfsg/src/remmina_file_manager.c:61:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (remminadir != NULL && strlen(remminadir) > 0)
data/remmina-1.4.8+dfsg/src/remmina_icon.c:455:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(msg, "\n");
data/remmina-1.4.8+dfsg/src/remmina_pref.c:133:65: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!g_key_file_load_from_data(gkeyfile, default_keymap_data, strlen(default_keymap_data), G_KEY_FILE_NONE,
data/remmina-1.4.8+dfsg/src/remmina_pref_dialog.c:587:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (remmina_pref.datadir_path != NULL && strlen(remmina_pref.datadir_path) > 0) {
data/remmina-1.4.8+dfsg/src/remmina_protocol_widget.c:512:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
keyvals = (guint *)g_malloc(strlen(keystrokes));
data/remmina-1.4.8+dfsg/src/remmina_public.c:328:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (path1[strlen(path1) - 1] == '/')
data/remmina-1.4.8+dfsg/src/remmina_sodium.c:83:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (crypto_pwhash(key, sizeof key, pass, strlen(pass), salt,
data/remmina-1.4.8+dfsg/src/remmina_sodium.c:105:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (crypto_pwhash_str(key, pass, strlen(pass),
data/remmina-1.4.8+dfsg/src/remmina_sodium.c:122:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
rc = crypto_pwhash_str_verify(key, pass, strlen(pass));
data/remmina-1.4.8+dfsg/src/remmina_ssh.c:1473:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
(len = read(tunnel->sockets[i], tunnel->buffer, tunnel->buffer_len)) > 0) {
data/remmina-1.4.8+dfsg/src/remmina_ssh.c:1962:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
len = read(shell->slave, buf, buf_len);
data/remmina-1.4.8+dfsg/src/remmina_ssh_plugin.c:1212:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *menu_str = g_malloc(strlen(filename) + 1);
data/remmina-1.4.8+dfsg/src/remmina_stats.c:197:47: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_checksum_update(chs, (const guchar*)uname, strlen(uname));
data/remmina-1.4.8+dfsg/src/remmina_stats.c:198:47: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_checksum_update(chs, (const guchar*)hname, strlen(hname));
data/remmina-1.4.8+dfsg/src/remmina_stats.c:573:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (last_success && last_success[0] != '\0' && strlen(last_success) >= 6) {
data/remmina-1.4.8+dfsg/src/remmina_stats.c:599:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (pdate && strlen(pdate) >= 6) {
data/remmina-1.4.8+dfsg/src/remmina_stats_sender.c:125:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int inLen = strlen(instr);
data/remmina-1.4.8+dfsg/src/remmina_stats_sender.c:136:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
remaining = strlen(instr);
data/remmina-1.4.8+dfsg/src/remmina_stats_sender.c:256:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
SOUP_MEMORY_COPY, enc_s, strlen(enc_s));
data/remmina-1.4.8+dfsg/src/remmina_string_list.c:227:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (item_value && strlen(item_value) > 0) {
data/remmina-1.4.8+dfsg/src/remmina_string_list.c:259:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(title1 && strlen(title1) > 0) ? title1 : "");
data/remmina-1.4.8+dfsg/src/remmina_string_list.c:261:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (title2 && strlen(title2) > 0) {
data/remmina-1.4.8+dfsg/src/remmina_utils.c:179:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pos += strlen(replace);
data/remmina-1.4.8+dfsg/src/remmina_utils.c:198:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gsize needle_length = strlen(needle);
data/remmina-1.4.8+dfsg/src/remmina_utils.c:222:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gchar *p = g_malloc(strlen(s) + 1);
data/remmina-1.4.8+dfsg/src/rmnews.c:401:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_checksum_update(chs, (const guchar *)uname, strlen(uname));
data/remmina-1.4.8+dfsg/src/rmnews.c:402:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_checksum_update(chs, (const guchar *)hname, strlen(hname));
data/remmina-1.4.8+dfsg/src/rmnews.c:495:3: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(mage, "0");
ANALYSIS SUMMARY:
Hits = 170
Lines analyzed = 48130 in approximately 1.23 seconds (39221 lines/second)
Physical Source Lines of Code (SLOC) = 33857
Hits@level = [0] 142 [1] 72 [2] 75 [3] 12 [4] 11 [5] 0
Hits@level+ = [0+] 312 [1+] 170 [2+] 98 [3+] 23 [4+] 11 [5+] 0
Hits/KSLOC@level+ = [0+] 9.21523 [1+] 5.02112 [2+] 2.89453 [3+] 0.679328 [4+] 0.324896 [5+] 0
Dot directories skipped = 2 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.