Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/rolo-014/src/add.c Examining data/rolo-014/src/add.h Examining data/rolo-014/src/delete.c Examining data/rolo-014/src/delete.h Examining data/rolo-014/src/edit.c Examining data/rolo-014/src/edit.h Examining data/rolo-014/src/entry.c Examining data/rolo-014/src/entry.h Examining data/rolo-014/src/help.c Examining data/rolo-014/src/help.h Examining data/rolo-014/src/index.c Examining data/rolo-014/src/index.h Examining data/rolo-014/src/main.c Examining data/rolo-014/src/search.c Examining data/rolo-014/src/search.h Examining data/rolo-014/src/view.c Examining data/rolo-014/src/view.h FINAL RESULTS: data/rolo-014/src/add.c:54:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (tmp_datafile, datafile); data/rolo-014/src/add.c:130:7: [4] (shell) execlp: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execlp (editor, editor_basename, filename, NULL); data/rolo-014/src/delete.c:57:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (tmp_datafile, datafile); data/rolo-014/src/edit.c:62:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (tmp_datafile, datafile); data/rolo-014/src/edit.c:263:7: [4] (shell) execlp: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execlp (editor, editor_basename, filename, NULL); data/rolo-014/src/entry.c:519:3: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. sprintf (menu_name, menu_print_format, data/rolo-014/src/help.c:201:7: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf (help_block, "---[ %s ]---", text); data/rolo-014/src/index.c:298:7: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf (rolo_block, "---[ rolo: %s ]---", filename); data/rolo-014/src/main.c:151:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (default_datafile, home); data/rolo-014/src/main.c:203:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (data_path, default_datafile); data/rolo-014/src/view.c:362:7: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. snprintf (tmp, 79, type ? "(%s)" : "", type); data/rolo-014/src/view.c:387:7: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. snprintf (tmp, 79, type ? "(%s)" : "", type); data/rolo-014/src/view.c:627:11: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf (entry_block, "---[ entry %i: %s ]---", entry_number % 1000, data/rolo-014/src/add.c:104:3: [3] (tmpfile) tmpnam: Temporary file race condition (CWE-377). tmpnam (filename); data/rolo-014/src/edit.c:239:3: [3] (tmpfile) tmpnam: Temporary file race condition (CWE-377). tmpnam (filename); data/rolo-014/src/main.c:84:12: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. editor = getenv ("ROLO_EDITOR"); data/rolo-014/src/main.c:88:16: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. editor = getenv ("EDITOR"); data/rolo-014/src/main.c:145:12: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. home = getenv ("HOME"); data/rolo-014/src/main.c:298:22: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while (-1 != (ch = getopt (argc, argv, "rf:vVh"))) data/rolo-014/src/add.c:49:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmp_datafile[PATH_MAX]; data/rolo-014/src/add.c:55:3: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. strcat (tmp_datafile, ".tmp"); data/rolo-014/src/add.c:56:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). dfp = fopen (datafile, "r"); data/rolo-014/src/add.c:57:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). tfp = fopen (tmp_datafile, "w"); data/rolo-014/src/add.c:59:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). efp = fopen (new_entry_filename, "r"); data/rolo-014/src/add.c:96:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename[PATH_MAX]; data/rolo-014/src/add.c:105:8: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen (filename, "w"); data/rolo-014/src/delete.c:37:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmp_datafile[PATH_MAX]; data/rolo-014/src/delete.c:58:3: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. strcat (tmp_datafile, ".tmp"); data/rolo-014/src/delete.c:59:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). dfp = fopen (datafile, "r"); data/rolo-014/src/delete.c:60:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). tfp = fopen (tmp_datafile, "w"); data/rolo-014/src/edit.c:57:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmp_datafile[PATH_MAX]; data/rolo-014/src/edit.c:63:3: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. strcat (tmp_datafile, ".tmp"); data/rolo-014/src/edit.c:64:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). dfp = fopen (datafile, "r"); data/rolo-014/src/edit.c:65:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). tfp = fopen (tmp_datafile, "w"); data/rolo-014/src/edit.c:77:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). efp = fopen (new_entry_filename, "r"); data/rolo-014/src/edit.c:223:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename[PATH_MAX]; data/rolo-014/src/edit.c:232:8: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen (datafile, "r"); data/rolo-014/src/edit.c:240:8: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen (filename, "w"); data/rolo-014/src/entry.c:508:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char menu_print_format[MENU_PRINT_FORMAT_SIZE]; data/rolo-014/src/index.c:102:8: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen (datafile, "r"); data/rolo-014/src/index.c:170:7: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf (line_number, "%3i", (i + 1) % 1000); data/rolo-014/src/index.c:194:15: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. name = (char *) item_name (items[i]); data/rolo-014/src/index.c:197:22: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. description = (char *) item_description (items[i]); data/rolo-014/src/index.c:316:7: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf (entries_block, "---[ entries: %i ]---", entries % 1000); data/rolo-014/src/index.c:647:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char f_string[80]; data/rolo-014/src/index.c:683:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char search_string[80]; data/rolo-014/src/main.c:58:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char data_path[PATH_MAX]; data/rolo-014/src/main.c:140:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char default_datafile[PATH_MAX]; data/rolo-014/src/main.c:184:22: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen (default_datafile, "w"); data/rolo-014/src/main.c:424:20: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen (data_path, "r"); data/rolo-014/src/main.c:458:20: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen (data_path, "r"); data/rolo-014/src/main.c:513:20: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen (data_path, "r"); data/rolo-014/src/main.c:545:20: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen (data_path, "r"); data/rolo-014/src/search.c:42:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmp_haystack[80]; data/rolo-014/src/search.c:43:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmp_needle[80]; data/rolo-014/src/view.c:324:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char fmt [80]; data/rolo-014/src/view.c:325:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmp [80]; data/rolo-014/src/view.c:632:11: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf (entry_block, "---[ entry %i ]---", entry_number % 1000); data/rolo-014/src/add.c:64:8: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ch = getc (dfp); data/rolo-014/src/add.c:68:12: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ch = getc (dfp); data/rolo-014/src/delete.c:64:8: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ch = getc (dfp); data/rolo-014/src/delete.c:68:12: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ch = getc (dfp); data/rolo-014/src/delete.c:76:8: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ch = getc (dfp); data/rolo-014/src/delete.c:80:12: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ch = getc (dfp); data/rolo-014/src/edit.c:69:8: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ch = getc (dfp); data/rolo-014/src/edit.c:73:12: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ch = getc (dfp); data/rolo-014/src/edit.c:81:8: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ch = getc (efp); data/rolo-014/src/edit.c:85:12: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ch = getc (efp); data/rolo-014/src/edit.c:95:8: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ch = getc (dfp); data/rolo-014/src/edit.c:99:12: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ch = getc (dfp); data/rolo-014/src/edit.c:139:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy (header_str, MENU_BAR_STRING, COLS); data/rolo-014/src/edit.c:141:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (i = strlen (MENU_BAR_STRING); i < COLS; i++) data/rolo-014/src/entry.c:196:39: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (unac_string ("UTF-8", ena_desc, strlen (ena_desc), &pure_a, length)) { data/rolo-014/src/entry.c:201:39: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (unac_string ("UTF-8", enb_desc, strlen (enb_desc), &pure_b, length)) { data/rolo-014/src/entry.c:246:39: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (unac_string ("UTF-8", ena_desc, strlen (ena_desc), &pure_a, length)) { data/rolo-014/src/entry.c:251:39: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (unac_string ("UTF-8", enb_desc, strlen (enb_desc), &pure_b, length)) { data/rolo-014/src/entry.c:538:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). fn_len += strlen (fn) - g_utf8_strlen (fn, -1); data/rolo-014/src/entry.c:540:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). gn_len += strlen (gn) - g_utf8_strlen (gn, -1); data/rolo-014/src/entry.c:542:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). em_len += strlen (em) - g_utf8_strlen (em, -1); data/rolo-014/src/help.c:161:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy (header_str, MENU_BAR_STRING, COLS); data/rolo-014/src/help.c:163:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (i = strlen (MENU_BAR_STRING); i < COLS; i++) data/rolo-014/src/help.c:198:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). help_block_len = strlen (text) + 10; data/rolo-014/src/index.c:243:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy (header_str, MENU_BAR_STRING, x); data/rolo-014/src/index.c:245:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (i = strlen (MENU_BAR_STRING); i < x; i++) data/rolo-014/src/index.c:288:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). rolo_block_len = strlen (filename) + 16; data/rolo-014/src/index.c:318:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). entries_block_len = strlen (entries_block); data/rolo-014/src/main.c:144:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen (data_path) == 0) { data/rolo-014/src/main.c:159:9: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. Risk is low because the source is a constant character. strncat (default_datafile, "/", 1); data/rolo-014/src/main.c:160:9: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. strncat (default_datafile, DEFAULT_HOME_ROLO_DIR, data/rolo-014/src/main.c:161:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen (DEFAULT_HOME_ROLO_DIR)); data/rolo-014/src/main.c:175:9: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. Risk is low because the source is a constant character. strncat (default_datafile, "/", 1); data/rolo-014/src/main.c:176:9: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. strncat (default_datafile, DEFAULT_FILENAME, strlen (DEFAULT_FILENAME)); data/rolo-014/src/main.c:176:54: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strncat (default_datafile, DEFAULT_FILENAME, strlen (DEFAULT_FILENAME)); data/rolo-014/src/main.c:283:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy (data_path, optarg, PATH_MAX); data/rolo-014/src/search.c:47:7: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy (tmp_haystack, haystack, sizeof (tmp_haystack) - 1); data/rolo-014/src/search.c:49:7: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy (tmp_needle, needle, sizeof (tmp_needle) - 1); data/rolo-014/src/search.c:52:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen (tmp_haystack); data/rolo-014/src/search.c:58:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen (tmp_needle); data/rolo-014/src/view.c:169:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). x = (COLS - strlen (HEADING_IDENT_STRING)) / 2; data/rolo-014/src/view.c:243:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). x = (COLS - strlen (HEADING_GEO_STRING)) / 2; data/rolo-014/src/view.c:334:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). x = (COLS - strlen (HEADING_TEL_STRING)) / 2; data/rolo-014/src/view.c:350:35: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((len < 0) | (len < strlen (type))) data/rolo-014/src/view.c:351:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen (type) + 2; /* take parentheses into account */ data/rolo-014/src/view.c:375:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((len < 0) | (len < strlen (type))) data/rolo-014/src/view.c:376:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen (type) + 2; /* take parentheses into account */ data/rolo-014/src/view.c:418:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). x = (COLS - strlen (HEADING_ORG_STRING)) / 2; data/rolo-014/src/view.c:490:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). x = (COLS - strlen (HEADING_MISC_STRING)) / 2; data/rolo-014/src/view.c:567:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy (header_str, MENU_BAR_STRING, COLS); data/rolo-014/src/view.c:569:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (i = strlen (MENU_BAR_STRING); i < COLS; i++) data/rolo-014/src/view.c:610:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). entry_block_len = strlen (fn) + 18 + 3; /* 3 for entry_number */ data/rolo-014/src/view.c:635:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). entry_block_len = strlen (entry_block); ANALYSIS SUMMARY: Hits = 111 Lines analyzed = 4033 in approximately 0.12 seconds (33565 lines/second) Physical Source Lines of Code (SLOC) = 2643 Hits@level = [0] 53 [1] 53 [2] 39 [3] 6 [4] 13 [5] 0 Hits@level+ = [0+] 164 [1+] 111 [2+] 58 [3+] 19 [4+] 13 [5+] 0 Hits/KSLOC@level+ = [0+] 62.0507 [1+] 41.9977 [2+] 21.9448 [3+] 7.1888 [4+] 4.91865 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.