Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/amf.c
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/amf.h
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/bytes.h
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/dh.h
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/dhgroups.h
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/http.h
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/log.c
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/log.h
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/parseurl.c
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.h
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp_sys.h
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/thread.c
Examining data/rtmpdump-2.4+20151223.gitfa8646d.1/thread.h
FINAL RESULTS:
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:143:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(sb.sb_buf,
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:147:10: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
i += sprintf(sb.sb_buf + i, "If-Modified-Since: %s\r\n", http->date);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:251:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(http->date, sb.sb_start + sizeof("Last-Modified: ") - 1);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:444:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(s, "%s, %02d %s %d %02d:%02d:%02d GMT",
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:501:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(path, "%s%s" DIRSEP ".swfinfo", hpre.av_val, home.av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/log.c:52:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(str, MAX_PRINT_LEN-1, format, vl);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/log.c:188:8: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
len = vsnprintf(str, MAX_PRINT_LEN-1, format, args);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/log.c:213:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(str, MAX_PRINT_LEN-1, format, args);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2549:33: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
pubToken.av_len = sprintf(pubToken.av_val, "?%s&user=%s",
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2637:31: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
pubToken.av_len = sprintf(pubToken.av_val,
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2697:33: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
pubToken.av_len = sprintf(pubToken.av_val, "?%s&user=%s",
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2821:11: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(pubToken.av_val,
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp_sys.h:31:9: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define snprintf _snprintf
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp_sys.h:31:18: [4] (format) _snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define snprintf _snprintf
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp_sys.h:34:9: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define vsnprintf _vsnprintf
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:382:10: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
len = sprintf(buf, "HTTP/1.0 416 Requested Range Not Satisfiable%s\r\n",
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:517:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(req.tcUrl.av_val, str);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:532:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
len = sprintf(buf, "HTTP/1.0 200 OK%sContent-Type: video/flv\r\n\r\n", srvhead);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:659:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
len = sprintf(buf, "HTTP/1.0 %s%s\r\n", status, srvhead);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:359:14: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if ((i = execvp(argv[0], argv)))
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:622:11: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
ptr += sprintf(ptr," -r \"%s\"", r->Link.tcUrl.av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:630:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
ptr += sprintf(ptr, " -a \"%s\"", r->Link.app.av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:638:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
ptr += sprintf(ptr, " -f \"%s\"", r->Link.flashVer.av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:646:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
ptr += sprintf(ptr, " -W \"%s\"", r->Link.swfUrl.av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:654:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
ptr += sprintf(ptr, " -p \"%s\"", r->Link.pageUrl.av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:662:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
ptr += sprintf(ptr, " -j \"%s\"", r->Link.usherToken.av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:731:11: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
ptr += sprintf(ptr, " -o %s", file);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:968:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(destch, inet_ntoa(dest.sin_addr));
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:1033:11: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(destch, inet_ntoa(dest.sin_addr));
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:474:17: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
hpre.av_val = getenv("HOMEDRIVE");
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:476:17: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
home.av_val = getenv("HOMEPATH");
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:483:17: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
home.av_val = getenv("HOME");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:865:4: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
getopt_long(argc, argv,
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:1058:4: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
getopt_long(argc, argv,
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:340:7: [3] (shell) CreateProcess:
This causes a new process to execute and is difficult to use safely
(CWE-78). Specify the application path in the first argument, NOT as part
of the second, or embedded spaces could allow an attacker to force a
different program to run.
if (CreateProcess(NULL, cmd, NULL, NULL, FALSE, 0, NULL, NULL,
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:340:7: [3] (shell) CreateProcess:
This causes a new process to execute and is difficult to use safely
(CWE-78). Specify the application path in the first argument, NOT as part
of the second, or embedded spaces could allow an attacker to force a
different program to run.
if (CreateProcess(NULL, cmd, NULL, NULL, FALSE, 0, NULL, NULL,
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/amf.c:87:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&dVal, data, 8);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/amf.c:192:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(output, bv->av_val, bv->av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/amf.c:208:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(output, &dVal, 8);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/amf.c:279:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(output, strName->av_val, strName->av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/amf.c:292:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(output, strName->av_val, strName->av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/amf.c:305:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(output, strName->av_val, strName->av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/amf.c:378:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(pBuffer, prop->p_name.av_val, prop->p_name.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/amf.c:801:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strRes[256];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/amf.c:802:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[256];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/amf.c:1239:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&obj->o_props[obj->o_num++], prop, sizeof(AMFObjectProperty));
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/dh.h:60:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char out[2];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:285:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(message, handshakeMessage, digestPos);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:286:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(message + digestPos,
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:565:23: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const unsigned char rtmpe9_keys[16][KEYBYTES] = {
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:730:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(clientsig, &uptime, 4);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:830:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&uptime, serversig, 4);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:874:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(r->Link.SWFVerificationResponse, swfVerify, 2);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:959:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(reply+4, &uptime, 4);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:1040:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[RTMP_SIG_SIZE];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:1127:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(serversig, &uptime, 4);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:1205:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&uptime, clientsig, 4);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:1242:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(r->Link.SWFVerificationResponse, swfVerify, 2);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:1320:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(clientsig+4, &uptime, 4);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/handshake.h:1391:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[RTMP_SIG_SIZE];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:80:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hbuf[256];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:127:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(p1);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:148:8: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
i += sprintf(sb.sb_buf + i, "\r\n");
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:203:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
rc = atoi(p1 + 1);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:244:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
flen = atoi(sb.sb_start + sizeof("Content-Length: ") - 1);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:322:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char out[CHUNK];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:349:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char *monthtab[12] = { "Jan", "Feb", "Mar",
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:456:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *path, date[64], cctim[64];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:503:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen(path, "r+");
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:506:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096], *file, *p;
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:616:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen(path, "w");
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/log.c:50:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[MAX_PRINT_LEN]="";
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/log.c:109:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[50], *ptr;
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/log.c:138:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BP_LEN];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/log.c:184:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[MAX_PRINT_LEN]="";
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/log.c:210:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[MAX_PRINT_LEN]="";
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/parseurl.c:119:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p2 = atoi(p);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/parseurl.c:253:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(destptr, "mp4:");
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/parseurl.c:260:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(destptr, "mp3:");
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:422:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
r->Link.socksport = socksport ? atoi(socksport + 1) : 1080;
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:634:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
prop.p_vu.p_number = atoi(p);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:649:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(p);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:677:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
prop.p_vu.p_number = atoi(p);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:877:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(hostname, host->av_val, host->av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1461:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, r->m_sb.sb_start, nRead);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1507:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[RTMP_BUFFER_CACHE_SIZE];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1582:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[4096], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1696:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[1024], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1728:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[256], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1755:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[512], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1787:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[1024], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1819:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[1024], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1849:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[1024], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1879:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[1024], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1911:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[1024], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1946:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[256], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:1975:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[256], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2013:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[256], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2042:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[256], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2062:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[256], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2083:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[256], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2108:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[256], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2136:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[256], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2165:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[256], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2192:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[1024], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2260:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[1024], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2298:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[1024], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2342:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[256], *pend = pbuf + sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2371:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, r->Link.SWFVerificationResponse, 42);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2420:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tmp, av->av_val, av->av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2472:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(output, bptr->data, bptr->length-1);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2505:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ptr, "%02x", *inbuf++);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2526:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char md5sum_val[MD5_DIGEST_LENGTH+1];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2535:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char response[RESPONSE_LEN];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2536:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char challenge2[CHALLENGE2_LEN];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2537:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char salted2[SALTED2_LEN];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2710:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hash1[HEXHASH_LEN+1], hash2[HEXHASH_LEN+1], hash3[HEXHASH_LEN+1];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2727:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char nchex[9];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2729:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cnonce[9];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2763:11: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(nchex, "%08x", nc);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2764:11: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(cnonce, "%08x", rand());
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3211:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, prop, sizeof(*prop));
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3237:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, prop, sizeof(*prop));
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3257:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[256] = "";
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3624:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(packet, r->m_vecChannelsIn[packet->m_nChannel],
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3695:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(packet->m_chunk->c_header, hbuf, hSize);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3714:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(r->m_vecChannelsIn[packet->m_nChannel], packet, sizeof(RTMPPacket));
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3750:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char clientbuf[RTMP_SIG_SIZE + 1], *clientsig = clientbuf + 1;
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3751:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char serversig[RTMP_SIG_SIZE];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3756:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(clientsig, &uptime, 4);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3785:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&suptime, serversig, 4);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3811:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char serverbuf[RTMP_SIG_SIZE + 1], *serversig = serverbuf + 1;
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3812:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char clientsig[RTMP_SIG_SIZE];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3829:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(serversig, &uptime, 4);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3848:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&uptime, clientsig, 4);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3875:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hbuf[RTMP_MAX_HEADER_SIZE];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3885:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(hbuf, ptr, chunk->c_headerSize);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3886:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, chunk->c_header, chunk->c_headerSize);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3888:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, hbuf, chunk->c_headerSize);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:3902:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *header, *hptr, *hend, hbuf[RTMP_MAX_HEADER_SIZE], c;
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:4045:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(toff, header, nChunkSize + hSize);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:4115:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(r->m_vecChannelsOut[packet->m_nChannel], packet, sizeof(RTMPPacket));
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:4401:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(text->av_val, out, text->av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:4408:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hbuf[512];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:4457:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
hlen = atoi(ptr+16);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:4479:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(r->m_clientID.av_val+1, ptr, hlen-1);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:4858:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, packetBody, nPacketLen);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:4963:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, r->m_read.buf, len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:5005:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(mybuf, flvHeader, sizeof(flvHeader));
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:5024:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(mybuf+cnt, r->m_read.buf, nRead);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:5058:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, r->m_read.bufpos, nRead);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:5160:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(enc, buf, num);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.h:110:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char c_header[RTMP_MAX_HEADER_SIZE];
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.h:132:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sb_buf[RTMP_BUFFER_CACHE_SIZE]; /* data read from socket */
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.h:195:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char SWFVerificationResponse[RTMP_SWF_HASHLEN+10];
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:142:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hbuf[16], *buffer = NULL;
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:147:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
*file = fopen(flvFile, "r+b");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:245:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(*metaHeader, buffer, *nMetaHeaderSize);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:282:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[bufferSize];
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:781:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char hash[RTMP_SWF_HASHLEN];
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:889:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int size = atoi(optarg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:906:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int num = atoi(optarg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:919:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
nSkipKeyFrames = atoi(optarg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:934:19: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int32_t bt = atol(optarg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:961:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(optarg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:964:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
protocol = atoi(optarg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:1050:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
timeout = atoi(optarg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:1261:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
file = fopen(flvFile, "w+b");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:1271:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
netstackdump = fopen("netstackdump", "wb");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:1272:23: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
netstackdump_read = fopen("netstackdump_read", "wb");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:111:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char hash[RTMP_SWF_HASHLEN];
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:131:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
prop.p_vu.p_number = atoi(p);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:145:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(p);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:173:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
prop.p_vu.p_number = atoi(p);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:228:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hex[3];
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:332:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[512] = { 0 }; // answer buffer
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:333:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char header[2048] = { 0 }; // request header
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:352:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&req, &defaultRTMPRequest, sizeof(RTMP_REQUEST));
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:441:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(arg, ptr, nArgLen * sizeof(char));
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:512:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[512] = { 0 };
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:814:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int size = atoi(arg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:833:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int num = atoi(arg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:847:15: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int32_t bt = atol(arg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:870:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
req->rtmpport = atoi(arg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:874:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int protocol = atoi(arg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:948:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
req->timeout = atoi(arg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:1157:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int port = atoi(optarg);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:1179:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
netstackdump = fopen("netstackdump", "wb");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:1180:23: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
netstackdump_read = fopen("netstackdump_read", "wb");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:176:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[384], *pend = pbuf+sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:237:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[256], *pend = pbuf+sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:272:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[512], *pend = pbuf+sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:304:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pbuf[512], *pend = pbuf+sizeof(pbuf);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:415:14: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
ptr += sprintf(ptr, " -C ");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:422:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
ptr += sprintf(ptr, "%.*s:", p->p_name.av_len, p->p_name.av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:430:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, p->p_vu.p_aval.av_val, p->p_vu.p_aval.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:435:11: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
ptr += sprintf(ptr, "%f", p->p_vu.p_number);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:449:11: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
ptr += sprintf(ptr, " -C O:0");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:567:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(r->Link.extras.o_props, obj.o_props+3, i*sizeof(AMFObjectProperty));
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:616:11: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
ptr += sprintf(ptr, "rtmpdump");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:675:11: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
ptr += sprintf(ptr, " -y \"%.*s\"",
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:711:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(file, av.av_val, av.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:725:8: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(file+av.av_len-4, ".flv");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:965:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char destch[16];
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:1116:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
netstackdump = fopen("netstackdump", "wb");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:1117:23: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
netstackdump_read = fopen("netstackdump_read", "wb");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:1180:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dptr, srcbeg, n);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:1182:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dptr, repl->av_val, repl->av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:1188:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dptr, srcbeg, n);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:250:19: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(r2, r1, len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:258:46: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
server->rc.Link.port = atoi(r1);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:367:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(file, av.av_val, av.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:369:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(file+av.av_len, "%02x", count);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:378:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
out = fopen(file, "wb");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:390:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(fl->f_path.av_val, av.av_val, av.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:627:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, packetBody, nPacketLen);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:1030:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char destch[16];
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:1162:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
netstackdump = fopen("netstackdump", "wb");
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:1163:23: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
netstackdump_read = fopen("netstackdump_read", "wb");
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:120:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(hbuf, host, hlen);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:475:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
hpre.av_len = strlen(hpre.av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:488:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
home.av_len = strlen(home.av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:534:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = strlen(r1);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:549:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int l = strlen((char *)in) - 1;
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:556:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf[strlen(buf) - 1] = '\0';
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:557:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(date, buf + 6, sizeof(date));
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:562:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf[strlen(buf) - 1] = '\0';
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/hashswf.c:631:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = strlen(url);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/parseurl.c:90:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
end = p + strlen(p);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/parseurl.c:218:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pplen = strlen(ppstart);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:420:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
r->Link.sockshost.av_len = strlen(hostname);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:767:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(url);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:793:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
arg.av_len = strlen(p2);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:845:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
r->Link.tcUrl.av_len = strlen(url);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2598:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
aptr->av_len = strlen(aptr->av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2663:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ptr, r->Link.app.av_val, r->Link.app.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2664:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ptr + r->Link.app.av_len, pubToken.av_val, pubToken.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2671:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ptr, r->Link.tcUrl.av_val, r->Link.tcUrl.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2672:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ptr + r->Link.tcUrl.av_len, pubToken.av_val, pubToken.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2759:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
aptr->av_len = strlen(aptr->av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2824:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pubToken.av_len = strlen(pubToken.av_val);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2847:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ptr, r->Link.app.av_val, r->Link.app.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2848:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ptr + r->Link.app.av_len, pubToken.av_val, pubToken.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2855:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ptr, r->Link.tcUrl.av_val, r->Link.tcUrl.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp.c:2856:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ptr + r->Link.tcUrl.av_len, pubToken.av_val, pubToken.av_len);
data/rtmpdump-2.4+20151223.gitfa8646d.1/librtmp/rtmp_sys.h:57:19: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
#define msleep(n) usleep(n*1000)
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:111:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int i, l = strlen(str);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:637:55: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
#define STR2AVAL(av,str) av.av_val = str; av.av_len = strlen(av.av_val)
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpdump.c:1173:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tcUrl.av_len = strlen(RTMPProtocolStringsLower[protocol]) +
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:115:55: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
#define STR2AVAL(av,str) av.av_val = str; av.av_len = strlen(av.av_val)
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:233:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int length = (int) strlen(data);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:277:13: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ich = getchar();
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:419:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(ptr);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpgw.c:774:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int i, l = strlen(str);
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:131:55: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
#define STR2AVAL(av,str) av.av_val = str; av.av_len = strlen(av.av_val)
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsrv.c:859:13: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ich = getchar();
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:106:55: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
#define STR2AVAL(av,str) av.av_val = str; av.av_len = strlen(av.av_val)
data/rtmpdump-2.4+20151223.gitfa8646d.1/rtmpsuck.c:717:13: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ich = getchar();
ANALYSIS SUMMARY:
Hits = 258
Lines analyzed = 15668 in approximately 0.39 seconds (39956 lines/second)
Physical Source Lines of Code (SLOC) = 12658
Hits@level = [0] 39 [1] 39 [2] 183 [3] 7 [4] 29 [5] 0
Hits@level+ = [0+] 297 [1+] 258 [2+] 219 [3+] 36 [4+] 29 [5+] 0
Hits/KSLOC@level+ = [0+] 23.4634 [1+] 20.3824 [2+] 17.3013 [3+] 2.84405 [4+] 2.29104 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.