Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/rumur-2020.09.06/common/escape.cc Examining data/rumur-2020.09.06/common/escape.h Examining data/rumur-2020.09.06/common/help.cc Examining data/rumur-2020.09.06/common/help.h Examining data/rumur-2020.09.06/librumur/include/rumur/Boolean.h Examining data/rumur-2020.09.06/librumur/include/rumur/Decl.h Examining data/rumur-2020.09.06/librumur/include/rumur/Expr.h Examining data/rumur-2020.09.06/librumur/include/rumur/Function.h Examining data/rumur-2020.09.06/librumur/include/rumur/Model.h Examining data/rumur-2020.09.06/librumur/include/rumur/Node.h Examining data/rumur-2020.09.06/librumur/include/rumur/Number.h Examining data/rumur-2020.09.06/librumur/include/rumur/Property.h Examining data/rumur-2020.09.06/librumur/include/rumur/Ptr.h Examining data/rumur-2020.09.06/librumur/include/rumur/Rule.h Examining data/rumur-2020.09.06/librumur/include/rumur/Stmt.h Examining data/rumur-2020.09.06/librumur/include/rumur/Symtab.h Examining data/rumur-2020.09.06/librumur/include/rumur/TypeExpr.h Examining data/rumur-2020.09.06/librumur/include/rumur/except.h Examining data/rumur-2020.09.06/librumur/include/rumur/indexer.h Examining data/rumur-2020.09.06/librumur/include/rumur/parse.h Examining data/rumur-2020.09.06/librumur/include/rumur/resolve-symbols.h Examining data/rumur-2020.09.06/librumur/include/rumur/rumur.h Examining data/rumur-2020.09.06/librumur/include/rumur/scanner.h Examining data/rumur-2020.09.06/librumur/include/rumur/traverse.h Examining data/rumur-2020.09.06/librumur/include/rumur/validate.h Examining data/rumur-2020.09.06/librumur/src/Boolean.cc Examining data/rumur-2020.09.06/librumur/src/Decl.cc Examining data/rumur-2020.09.06/librumur/src/Expr.cc Examining data/rumur-2020.09.06/librumur/src/Function.cc Examining data/rumur-2020.09.06/librumur/src/Model.cc Examining data/rumur-2020.09.06/librumur/src/Node.cc Examining data/rumur-2020.09.06/librumur/src/Number.cc Examining data/rumur-2020.09.06/librumur/src/Property.cc Examining data/rumur-2020.09.06/librumur/src/Rule.cc Examining data/rumur-2020.09.06/librumur/src/Stmt.cc Examining data/rumur-2020.09.06/librumur/src/TypeExpr.cc Examining data/rumur-2020.09.06/librumur/src/except.cc Examining data/rumur-2020.09.06/librumur/src/indexer.cc Examining data/rumur-2020.09.06/librumur/src/parse.cc Examining data/rumur-2020.09.06/librumur/src/resolve-symbols.cc Examining data/rumur-2020.09.06/librumur/src/traverse.cc Examining data/rumur-2020.09.06/librumur/src/utils.h Examining data/rumur-2020.09.06/librumur/src/validate.cc Examining data/rumur-2020.09.06/murphi2c/resources/c_prefix.c Examining data/rumur-2020.09.06/murphi2c/resources/h_prefix.h Examining data/rumur-2020.09.06/murphi2c/src/CLikeGenerator.cc Examining data/rumur-2020.09.06/murphi2c/src/CLikeGenerator.h Examining data/rumur-2020.09.06/murphi2c/src/CodeGenerator.cc Examining data/rumur-2020.09.06/murphi2c/src/CodeGenerator.h Examining data/rumur-2020.09.06/murphi2c/src/check.cc Examining data/rumur-2020.09.06/murphi2c/src/check.h Examining data/rumur-2020.09.06/murphi2c/src/compares_complex_values.cc Examining data/rumur-2020.09.06/murphi2c/src/compares_complex_values.h Examining data/rumur-2020.09.06/murphi2c/src/generate_c.cc Examining data/rumur-2020.09.06/murphi2c/src/generate_c.h Examining data/rumur-2020.09.06/murphi2c/src/generate_h.cc Examining data/rumur-2020.09.06/murphi2c/src/generate_h.h Examining data/rumur-2020.09.06/murphi2c/src/main.cc Examining data/rumur-2020.09.06/murphi2c/src/name_rules.cc Examining data/rumur-2020.09.06/murphi2c/src/name_rules.h Examining data/rumur-2020.09.06/murphi2c/src/options.cc Examining data/rumur-2020.09.06/murphi2c/src/options.h Examining data/rumur-2020.09.06/murphi2c/src/resources.h Examining data/rumur-2020.09.06/murphi2murphi/src/DecomposeComplexComparisons.cc Examining data/rumur-2020.09.06/murphi2murphi/src/DecomposeComplexComparisons.h Examining data/rumur-2020.09.06/murphi2murphi/src/ExplicitSemicolons.cc Examining data/rumur-2020.09.06/murphi2murphi/src/ExplicitSemicolons.h Examining data/rumur-2020.09.06/murphi2murphi/src/Pipeline.cc Examining data/rumur-2020.09.06/murphi2murphi/src/Pipeline.h Examining data/rumur-2020.09.06/murphi2murphi/src/Printer.cc Examining data/rumur-2020.09.06/murphi2murphi/src/Printer.h Examining data/rumur-2020.09.06/murphi2murphi/src/RemoveLiveness.cc Examining data/rumur-2020.09.06/murphi2murphi/src/RemoveLiveness.h Examining data/rumur-2020.09.06/murphi2murphi/src/Stage.cc Examining data/rumur-2020.09.06/murphi2murphi/src/Stage.h Examining data/rumur-2020.09.06/murphi2murphi/src/SwitchToIf.cc Examining data/rumur-2020.09.06/murphi2murphi/src/SwitchToIf.h Examining data/rumur-2020.09.06/murphi2murphi/src/ToAscii.cc Examining data/rumur-2020.09.06/murphi2murphi/src/ToAscii.h Examining data/rumur-2020.09.06/murphi2murphi/src/main.cc Examining data/rumur-2020.09.06/murphi2murphi/src/options.cc Examining data/rumur-2020.09.06/murphi2murphi/src/options.h Examining data/rumur-2020.09.06/murphi2murphi/src/resources.h Examining data/rumur-2020.09.06/murphi2xml/src/XMLPrinter.cc Examining data/rumur-2020.09.06/murphi2xml/src/XMLPrinter.h Examining data/rumur-2020.09.06/murphi2xml/src/main.cc Examining data/rumur-2020.09.06/murphi2xml/src/resources.h Examining data/rumur-2020.09.06/rumur/resources/header.c Examining data/rumur-2020.09.06/rumur/resources/includes.c Examining data/rumur-2020.09.06/rumur/src/ValueType.cc Examining data/rumur-2020.09.06/rumur/src/ValueType.h Examining data/rumur-2020.09.06/rumur/src/assume-statements-count.cc Examining data/rumur-2020.09.06/rumur/src/assume-statements-count.h Examining data/rumur-2020.09.06/rumur/src/environ.cc Examining data/rumur-2020.09.06/rumur/src/environ.h Examining data/rumur-2020.09.06/rumur/src/generate-allocations.cc Examining data/rumur-2020.09.06/rumur/src/generate-cover-array.cc Examining data/rumur-2020.09.06/rumur/src/generate-decl.cc Examining data/rumur-2020.09.06/rumur/src/generate-expr.cc Examining data/rumur-2020.09.06/rumur/src/generate-function.cc Examining data/rumur-2020.09.06/rumur/src/generate-model.cc Examining data/rumur-2020.09.06/rumur/src/generate-print.cc Examining data/rumur-2020.09.06/rumur/src/generate-property.cc Examining data/rumur-2020.09.06/rumur/src/generate-quantifier.cc Examining data/rumur-2020.09.06/rumur/src/generate-stmt.cc Examining data/rumur-2020.09.06/rumur/src/generate.h Examining data/rumur-2020.09.06/rumur/src/has-start-state.cc Examining data/rumur-2020.09.06/rumur/src/has-start-state.h Examining data/rumur-2020.09.06/rumur/src/log.cc Examining data/rumur-2020.09.06/rumur/src/log.h Examining data/rumur-2020.09.06/rumur/src/main.cc Examining data/rumur-2020.09.06/rumur/src/max-simple-width.cc Examining data/rumur-2020.09.06/rumur/src/max-simple-width.h Examining data/rumur-2020.09.06/rumur/src/optimise-field-ordering.cc Examining data/rumur-2020.09.06/rumur/src/optimise-field-ordering.h Examining data/rumur-2020.09.06/rumur/src/options.cc Examining data/rumur-2020.09.06/rumur/src/options.h Examining data/rumur-2020.09.06/rumur/src/output.cc Examining data/rumur-2020.09.06/rumur/src/prints-scalarsets.cc Examining data/rumur-2020.09.06/rumur/src/prints-scalarsets.h Examining data/rumur-2020.09.06/rumur/src/process.cc Examining data/rumur-2020.09.06/rumur/src/process.h Examining data/rumur-2020.09.06/rumur/src/resources.h Examining data/rumur-2020.09.06/rumur/src/smt/define-enum-members.cc Examining data/rumur-2020.09.06/rumur/src/smt/define-enum-members.h Examining data/rumur-2020.09.06/rumur/src/smt/define-records.cc Examining data/rumur-2020.09.06/rumur/src/smt/define-records.h Examining data/rumur-2020.09.06/rumur/src/smt/except.h Examining data/rumur-2020.09.06/rumur/src/smt/logic.cc Examining data/rumur-2020.09.06/rumur/src/smt/logic.h Examining data/rumur-2020.09.06/rumur/src/smt/simplify.cc Examining data/rumur-2020.09.06/rumur/src/smt/simplify.h Examining data/rumur-2020.09.06/rumur/src/smt/solver.cc Examining data/rumur-2020.09.06/rumur/src/smt/solver.h Examining data/rumur-2020.09.06/rumur/src/smt/translate.cc Examining data/rumur-2020.09.06/rumur/src/smt/translate.h Examining data/rumur-2020.09.06/rumur/src/smt/typeexpr-to-smt.cc Examining data/rumur-2020.09.06/rumur/src/smt/typeexpr-to-smt.h Examining data/rumur-2020.09.06/rumur/src/symmetry-reduction.cc Examining data/rumur-2020.09.06/rumur/src/symmetry-reduction.h Examining data/rumur-2020.09.06/rumur/src/utils.cc Examining data/rumur-2020.09.06/rumur/src/utils.h FINAL RESULTS: data/rumur-2020.09.06/common/help.cc:61:11: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. ret = system(args.c_str()); data/rumur-2020.09.06/common/help.cc:68:7: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(path, F_OK) == 0) data/rumur-2020.09.06/rumur/resources/header.c:550:3: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. snprintf(buffer, sizeof(buffer), "%" PRIdMAX, u); data/rumur-2020.09.06/rumur/resources/header.c:556:3: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. snprintf(buffer, sizeof(buffer), "%" PRIuMAX, u); data/rumur-2020.09.06/rumur/resources/header.c:584:30: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. static __attribute__((format(printf, 1, 2))) void trace(const char *NONNULL fmt, data/rumur-2020.09.06/rumur/resources/header.c:593:9: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. (void)vfprintf(stderr, fmt, ap); data/rumur-2020.09.06/rumur/resources/header.c:1355:30: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. static __attribute__((format(printf, 2, 3))) _Noreturn void error( data/rumur-2020.09.06/rumur/resources/header.c:1378:20: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. int size = vsnprintf(NULL, 0, fmt, ap2); data/rumur-2020.09.06/rumur/resources/header.c:1386:30: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. if (__builtin_expect(vsnprintf(buffer, size + 1, fmt, ap) != size, 0)) { data/rumur-2020.09.06/rumur/resources/header.c:1414:20: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. int size = vsnprintf(NULL, 0, fmt, ap2); data/rumur-2020.09.06/rumur/resources/header.c:1422:30: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. if (__builtin_expect(vsnprintf(buffer, size + 1, fmt, ap) != size, 0)) { data/rumur-2020.09.06/common/help.cc:22:24: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const char *TMPDIR = getenv("TMPDIR"); data/rumur-2020.09.06/murphi2c/src/main.cc:43:13: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. int c = getopt_long(argc, argv, "ho:", options, &option_index); data/rumur-2020.09.06/murphi2murphi/src/main.cc:65:13: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. int c = getopt_long(argc, argv, "ho:", opts, &option_index); data/rumur-2020.09.06/murphi2xml/src/main.cc:45:13: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. int c = getopt_long(argc, argv, "o:", options, &option_index); data/rumur-2020.09.06/rumur/src/main.cc:116:13: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. int c = getopt_long(argc, argv, "de:ho:qs:t:v", opts, &option_index); data/rumur-2020.09.06/rumur/src/main.cc:723:22: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const char *cc = getenv("CC"); data/rumur-2020.09.06/common/escape.cc:8:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[sizeof("\\000")]; data/rumur-2020.09.06/common/help.cc:33:12: [2] (tmpfile) mkstemp: Potential for temporary file vulnerability in some circumstances. Some older Unix-like systems create temp files with permission to write by all by default, so be sure to set the umask to override this. Also, some older Unix systems might fail to use O_EXCL when opening the file, so make sure that O_EXCL is used by the library (CWE-377). int fd = mkstemp(path); data/rumur-2020.09.06/rumur/resources/header.c:396:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char data[41]; data/rumur-2020.09.06/rumur/resources/header.c:426:7: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(buffer.data, "-170141183460469231731687303715884105728"); data/rumur-2020.09.06/rumur/resources/header.c:549:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[128] = { 0 }; data/rumur-2020.09.06/rumur/resources/header.c:555:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[128] = { 0 }; data/rumur-2020.09.06/rumur/resources/header.c:711:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&x, p, extent); data/rumur-2020.09.06/rumur/resources/header.c:740:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&x, p, extent); data/rumur-2020.09.06/rumur/resources/header.c:883:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p, &v, extent); data/rumur-2020.09.06/rumur/resources/header.c:894:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p, &v, extent); data/rumur-2020.09.06/rumur/resources/header.c:2541:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&p, &q1, sizeof(q1)); data/rumur-2020.09.06/rumur/resources/header.c:2542:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((unsigned char*)&p + sizeof(q1), &q2, sizeof(q2)); data/rumur-2020.09.06/rumur/resources/header.c:2874:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&p2, &old, sizeof(old)); data/rumur-2020.09.06/rumur/resources/header.c:2886:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&new, &p3, sizeof(p3)); data/rumur-2020.09.06/rumur/resources/header.c:2901:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&p2, &old, sizeof(old)); data/rumur-2020.09.06/rumur/resources/header.c:2926:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&p2, &old, sizeof(old)); data/rumur-2020.09.06/rumur/resources/header.c:2964:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&p, current, sizeof(*current)); data/rumur-2020.09.06/rumur/src/process.cc:193:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char ignored[BUFSIZ]; data/rumur-2020.09.06/rumur/src/process.cc:203:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[BUFSIZ]; data/rumur-2020.09.06/librumur/src/TypeExpr.cc:69:13: [1] (buffer) equal: Function does not check the second iterator for over-read conditions (CWE-126). This function is often discouraged by most C++ coding standards in favor of its safer alternatives provided since C++14. Consider using a form of this function that checks the second iterator before potentially overflowing it. static bool equal(const TypeExpr &t1, const TypeExpr &t2) { data/rumur-2020.09.06/librumur/src/TypeExpr.cc:83:19: [1] (buffer) equal: Function does not check the second iterator for over-read conditions (CWE-126). This function is often discouraged by most C++ coding standards in favor of its safer alternatives provided since C++14. Consider using a form of this function that checks the second iterator before potentially overflowing it. result &= equal(*a->index_type, *n.index_type); data/rumur-2020.09.06/librumur/src/TypeExpr.cc:84:19: [1] (buffer) equal: Function does not check the second iterator for over-read conditions (CWE-126). This function is often discouraged by most C++ coding standards in favor of its safer alternatives provided since C++14. Consider using a form of this function that checks the second iterator before potentially overflowing it. result &= equal(*a->element_type, *n.element_type); data/rumur-2020.09.06/librumur/src/TypeExpr.cc:129:21: [1] (buffer) equal: Function does not check the second iterator for over-read conditions (CWE-126). This function is often discouraged by most C++ coding standards in favor of its safer alternatives provided since C++14. Consider using a form of this function that checks the second iterator before potentially overflowing it. && equal(*(*it)->get_type(), *(*it2)->get_type()); data/rumur-2020.09.06/librumur/src/TypeExpr.cc:162:10: [1] (buffer) equal: Function does not check the second iterator for over-read conditions (CWE-126). This function is often discouraged by most C++ coding standards in favor of its safer alternatives provided since C++14. Consider using a form of this function that checks the second iterator before potentially overflowing it. return equal(*t1, *t2); data/rumur-2020.09.06/rumur/resources/header.c:438:45: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). memmove(&buffer.data[1], buffer.data, strlen(buffer.data) + 1); data/rumur-2020.09.06/rumur/src/process.cc:194:43: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ssize_t r __attribute__((unused)) = read(sigchld_pipe[READ_FD], ignored, data/rumur-2020.09.06/rumur/src/process.cc:205:15: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). r = read(out[READ_FD], buffer, sizeof(buffer)); ANALYSIS SUMMARY: Hits = 44 Lines analyzed = 26114 in approximately 0.68 seconds (38449 lines/second) Physical Source Lines of Code (SLOC) = 19208 Hits@level = [0] 26 [1] 8 [2] 19 [3] 6 [4] 11 [5] 0 Hits@level+ = [0+] 70 [1+] 44 [2+] 36 [3+] 17 [4+] 11 [5+] 0 Hits/KSLOC@level+ = [0+] 3.64431 [1+] 2.29071 [2+] 1.87422 [3+] 0.885048 [4+] 0.572678 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.