Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c Examining data/s3ql-3.3.2+dfsg/src/s3ql/endian_indep.h FINAL RESULTS: data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:794:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(__PYX_DEFAULT_STRING_ENCODING, default_encoding_c); data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:747:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char ascii_chars[128]; data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:10054:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((char *)result_udata + char_pos * result_ukind, udata, (size_t) (ulength * result_ukind)); data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:11008:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const char DIGIT_PAIRS_10[2*10*10+1] = { data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:11020:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const char DIGIT_PAIRS_8[2*8*8+1] = { data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:11030:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const char DIGITS_HEX[2*16+1] = { data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:11122:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char digits[sizeof(size_t)*3+2]; data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:11201:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char digits[sizeof(int)*3+2]; data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:11553:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char warning[200]; data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:12866:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char ctversion[4], rtversion[4]; data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:12870:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char message[200]; data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:671:87: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). #define __Pyx_PyByteArray_FromString(s) PyByteArray_FromStringAndSize((const char*)s, strlen((const char*)s)) data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:792:52: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). __PYX_DEFAULT_STRING_ENCODING = (char*) malloc(strlen(default_encoding_c) + 1); data/s3ql-3.3.2+dfsg/src/s3ql/deltadump.c:12914:65: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return __Pyx_PyUnicode_FromStringAndSize(c_str, (Py_ssize_t)strlen(c_str)); ANALYSIS SUMMARY: Hits = 14 Lines analyzed = 13173 in approximately 0.35 seconds (37776 lines/second) Physical Source Lines of Code (SLOC) = 9517 Hits@level = [0] 1 [1] 3 [2] 10 [3] 0 [4] 1 [5] 0 Hits@level+ = [0+] 15 [1+] 14 [2+] 11 [3+] 1 [4+] 1 [5+] 0 Hits/KSLOC@level+ = [0+] 1.57613 [1+] 1.47105 [2+] 1.15583 [3+] 0.105075 [4+] 0.105075 [5+] 0 Dot directories skipped = 2 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.