Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/samplv1-0.9.18/src/samplv1_sample.cpp
Examining data/samplv1-0.9.18/src/samplv1_pshifter.cpp
Examining data/samplv1-0.9.18/src/samplv1widget_config.h
Examining data/samplv1-0.9.18/src/samplv1widget_config.cpp
Examining data/samplv1-0.9.18/src/samplv1_fx.h
Examining data/samplv1-0.9.18/src/samplv1widget_keybd.cpp
Examining data/samplv1-0.9.18/src/samplv1_sample.h
Examining data/samplv1-0.9.18/src/samplv1widget_controls.h
Examining data/samplv1-0.9.18/src/samplv1widget_control.h
Examining data/samplv1-0.9.18/src/samplv1widget_jack.h
Examining data/samplv1-0.9.18/src/samplv1widget.cpp
Examining data/samplv1-0.9.18/src/samplv1_lv2.cpp
Examining data/samplv1-0.9.18/src/samplv1widget_wave.cpp
Examining data/samplv1-0.9.18/src/samplv1_controls.h
Examining data/samplv1-0.9.18/src/samplv1widget_filt.cpp
Examining data/samplv1-0.9.18/src/samplv1_wave.h
Examining data/samplv1-0.9.18/src/samplv1widget_preset.cpp
Examining data/samplv1-0.9.18/src/samplv1_nsm.cpp
Examining data/samplv1-0.9.18/src/samplv1.h
Examining data/samplv1-0.9.18/src/samplv1_nsm.h
Examining data/samplv1-0.9.18/src/samplv1widget_palette.cpp
Examining data/samplv1-0.9.18/src/samplv1_formant.h
Examining data/samplv1-0.9.18/src/samplv1widget_sample.cpp
Examining data/samplv1-0.9.18/src/samplv1widget_lv2.h
Examining data/samplv1-0.9.18/src/samplv1widget_keybd.h
Examining data/samplv1-0.9.18/src/samplv1_formant.cpp
Examining data/samplv1-0.9.18/src/samplv1widget_param.h
Examining data/samplv1-0.9.18/src/samplv1widget_env.h
Examining data/samplv1-0.9.18/src/samplv1widget.h
Examining data/samplv1-0.9.18/src/samplv1widget_lv2.cpp
Examining data/samplv1-0.9.18/src/lv2/lv2_programs.h
Examining data/samplv1-0.9.18/src/lv2/lv2_external_ui.h
Examining data/samplv1-0.9.18/src/samplv1_lv2ui.cpp
Examining data/samplv1-0.9.18/src/samplv1widget_status.h
Examining data/samplv1-0.9.18/src/samplv1widget_param.cpp
Examining data/samplv1-0.9.18/src/samplv1_pshifter.h
Examining data/samplv1-0.9.18/src/samplv1_ui.h
Examining data/samplv1-0.9.18/src/samplv1_resampler.cpp
Examining data/samplv1-0.9.18/src/samplv1widget_programs.cpp
Examining data/samplv1-0.9.18/src/samplv1_sched.cpp
Examining data/samplv1-0.9.18/src/samplv1_sched.h
Examining data/samplv1-0.9.18/src/samplv1_filter.h
Examining data/samplv1-0.9.18/src/samplv1widget_preset.h
Examining data/samplv1-0.9.18/src/samplv1widget_filt.h
Examining data/samplv1-0.9.18/src/samplv1.cpp
Examining data/samplv1-0.9.18/src/samplv1widget_wave.h
Examining data/samplv1-0.9.18/src/samplv1_jack.cpp
Examining data/samplv1-0.9.18/src/samplv1widget_palette.h
Examining data/samplv1-0.9.18/src/samplv1_param.cpp
Examining data/samplv1-0.9.18/src/samplv1_config.cpp
Examining data/samplv1-0.9.18/src/samplv1widget_controls.cpp
Examining data/samplv1-0.9.18/src/samplv1_list.h
Examining data/samplv1-0.9.18/src/samplv1_resampler.h
Examining data/samplv1-0.9.18/src/samplv1_config.h
Examining data/samplv1-0.9.18/src/samplv1widget_programs.h
Examining data/samplv1-0.9.18/src/samplv1_lv2.h
Examining data/samplv1-0.9.18/src/samplv1widget_spinbox.h
Examining data/samplv1-0.9.18/src/samplv1widget_spinbox.cpp
Examining data/samplv1-0.9.18/src/samplv1widget_sample.h
Examining data/samplv1-0.9.18/src/samplv1_ui.cpp
Examining data/samplv1-0.9.18/src/samplv1_jack.h
Examining data/samplv1-0.9.18/src/samplv1widget_status.cpp
Examining data/samplv1-0.9.18/src/samplv1_reverb.h
Examining data/samplv1-0.9.18/src/samplv1_wave.cpp
Examining data/samplv1-0.9.18/src/samplv1widget_control.cpp
Examining data/samplv1-0.9.18/src/samplv1_ramp.h
Examining data/samplv1-0.9.18/src/samplv1widget_env.cpp
Examining data/samplv1-0.9.18/src/samplv1_lv2ui.h
Examining data/samplv1-0.9.18/src/samplv1widget_jack.cpp
Examining data/samplv1-0.9.18/src/samplv1_programs.h
Examining data/samplv1-0.9.18/src/samplv1_tuning.h
Examining data/samplv1-0.9.18/src/samplv1_programs.cpp
Examining data/samplv1-0.9.18/src/samplv1_controls.cpp
Examining data/samplv1-0.9.18/src/samplv1_param.h
Examining data/samplv1-0.9.18/src/samplv1_tuning.cpp
FINAL RESULTS:
data/samplv1-0.9.18/src/samplv1widget_spinbox.cpp:231:19: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
return QString().sprintf("%02u:%02u:%02u.%03u", hh, mm, ss, zzz);
data/samplv1-0.9.18/src/samplv1_jack.cpp:748:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
m_bGui = (::getenv("DISPLAY") != 0);
data/samplv1-0.9.18/src/samplv1_jack.cpp:934:27: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
= QString::fromLatin1(::getenv("NSM_URL"));
data/samplv1-0.9.18/src/samplv1.cpp:1481:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gen1_sample.open(pszSampleFile, samplv1_freq(m_gen1.sample0), otabs);
data/samplv1-0.9.18/src/samplv1.cpp:2188:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(outs[k], ins[k], nframes * sizeof(float));
data/samplv1-0.9.18/src/samplv1_controls.cpp:219:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(
data/samplv1-0.9.18/src/samplv1_controls.cpp:226:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(
data/samplv1-0.9.18/src/samplv1_controls.cpp:231:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(
data/samplv1-0.9.18/src/samplv1_jack.cpp:189:2: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(client_name);
data/samplv1-0.9.18/src/samplv1_jack.cpp:296:20: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void samplv1_jack::open ( const char *client_name )
data/samplv1-0.9.18/src/samplv1_jack.cpp:323:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char port_name[32];
data/samplv1-0.9.18/src/samplv1_jack.cpp:555:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char ev_buff[nlimit];
data/samplv1-0.9.18/src/samplv1_jack.cpp:938:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
SIGNAL(open()),
data/samplv1-0.9.18/src/samplv1_jack.cpp:996:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
m_pSampl->open(client_name.toUtf8().constData());
data/samplv1-0.9.18/src/samplv1_jack.h:52:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open(const char *client_name);
data/samplv1-0.9.18/src/samplv1_lv2.cpp:1211:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char s_szNull[1] = {'\0'};
data/samplv1-0.9.18/src/samplv1_nsm.cpp:416:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
emit open();
data/samplv1-0.9.18/src/samplv1_nsm.h:115:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open();
data/samplv1-0.9.18/src/samplv1_param.cpp:245:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file.open(QIODevice::ReadOnly))
data/samplv1-0.9.18/src/samplv1_param.cpp:363:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file.open(QIODevice::WriteOnly | QIODevice::Truncate))
data/samplv1-0.9.18/src/samplv1_resampler.cpp:364:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(m_buff, p1, n * sizeof(float));
data/samplv1-0.9.18/src/samplv1_reverb.h:190:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(m_buffer, old_buffer,
data/samplv1-0.9.18/src/samplv1_sample.cpp:55:22: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
bool samplv1_sample::open ( const char *filename, float freq0, uint16_t otabs )
data/samplv1-0.9.18/src/samplv1_sample.h:128:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
bool open(const char *filename, float freq0 = 1.0f, uint16_t otabs = 0);
data/samplv1-0.9.18/src/samplv1_tuning.cpp:94:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file.open(QIODevice::ReadOnly | QIODevice::Text))
data/samplv1-0.9.18/src/samplv1_tuning.cpp:239:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file.open(QIODevice::ReadOnly | QIODevice::Text))
data/samplv1-0.9.18/src/samplv1_jack.cpp:1096:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (::read(g_fdSigterm[1], &c, sizeof(c)) > 0) {
data/samplv1-0.9.18/src/samplv1_lv2.cpp:618:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t size = ::strlen(value) + 1;
data/samplv1-0.9.18/src/samplv1_lv2.cpp:1231:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
lv2_atom_forge_path(&m_forge, pszSampleFile, ::strlen(pszSampleFile) + 1);
data/samplv1-0.9.18/src/samplv1_lv2.cpp:1268:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
lv2_atom_forge_path(&m_forge, pszScaleFile, ::strlen(pszScaleFile) + 1);
data/samplv1-0.9.18/src/samplv1_lv2.cpp:1275:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
lv2_atom_forge_path(&m_forge, pszKeyMapFile, ::strlen(pszKeyMapFile) + 1);
ANALYSIS SUMMARY:
Hits = 31
Lines analyzed = 29833 in approximately 0.78 seconds (38131 lines/second)
Physical Source Lines of Code (SLOC) = 20112
Hits@level = [0] 11 [1] 5 [2] 23 [3] 2 [4] 1 [5] 0
Hits@level+ = [0+] 42 [1+] 31 [2+] 26 [3+] 3 [4+] 1 [5+] 0
Hits/KSLOC@level+ = [0+] 2.08831 [1+] 1.54137 [2+] 1.29276 [3+] 0.149165 [4+] 0.0497216 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.