Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/sapphire-0.15.8/client.cc
Examining data/sapphire-0.15.8/image.cc
Examining data/sapphire-0.15.8/iconmenu.cc
Examining data/sapphire-0.15.8/main.cc
Examining data/sapphire-0.15.8/misc.cc
Examining data/sapphire-0.15.8/theme.cc
Examining data/sapphire-0.15.8/rootmenu.cc
Examining data/sapphire-0.15.8/scanner.cc
Examining data/sapphire-0.15.8/toolbar.cc
Examining data/sapphire-0.15.8/basemenu.cc
Examining data/sapphire-0.15.8/linkedlist.cc
Examining data/sapphire-0.15.8/menulex.cc
Examining data/sapphire-0.15.8/windowmanager.cc
FINAL RESULTS:
data/sapphire-0.15.8/basemenu.cc:484:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(item->name, n);
data/sapphire-0.15.8/basemenu.cc:504:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buffer, "%s%s", getenv("HOME"), exec+1);
data/sapphire-0.15.8/basemenu.cc:505:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(exec, buffer);
data/sapphire-0.15.8/basemenu.cc:510:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(item->exec, exec);
data/sapphire-0.15.8/basemenu.cc:513:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(item->name, n);
data/sapphire-0.15.8/basemenu.cc:533:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buffer, "%s%s", getenv("HOME"), exec+1);
data/sapphire-0.15.8/basemenu.cc:534:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(exec, buffer);
data/sapphire-0.15.8/basemenu.cc:539:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(item->exec, exec);
data/sapphire-0.15.8/basemenu.cc:542:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(item->name, n);
data/sapphire-0.15.8/basemenu.cc:570:2: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(command, "exec %s &", s);
data/sapphire-0.15.8/basemenu.cc:571:2: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(command);
data/sapphire-0.15.8/iconmenu.cc:48:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(item->name, name);
data/sapphire-0.15.8/menulex.cc:118:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(name, currentToken());
data/sapphire-0.15.8/menulex.cc:188:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(name, currentToken());
data/sapphire-0.15.8/menulex.cc:305:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(name, currentToken());
data/sapphire-0.15.8/menulex.cc:318:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(exe, currentToken());
data/sapphire-0.15.8/menulex.cc:364:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(name, currentToken());
data/sapphire-0.15.8/menulex.cc:377:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(exe, currentToken());
data/sapphire-0.15.8/menulex.cc:423:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(name, currentToken());
data/sapphire-0.15.8/menulex.cc:437:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(exe, currentToken());
data/sapphire-0.15.8/misc.cc:40:2: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, fmt, argp);
data/sapphire-0.15.8/rootmenu.cc:40:2: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(path, "%s%s", configuration_home, menupath);
data/sapphire-0.15.8/theme.cc:44:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(currentTheme, themeFile);
data/sapphire-0.15.8/theme.cc:692:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(command, "exec %s &", value.addr);
data/sapphire-0.15.8/theme.cc:693:3: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(command);
data/sapphire-0.15.8/theme.cc:700:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(font, value.addr);
data/sapphire-0.15.8/theme.cc:710:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(font, f);
data/sapphire-0.15.8/theme.cc:719:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(font, f);
data/sapphire-0.15.8/theme.cc:726:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(menufont, value.addr);
data/sapphire-0.15.8/theme.cc:736:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(menufont, f);
data/sapphire-0.15.8/theme.cc:745:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(menufont, f);
data/sapphire-0.15.8/windowmanager.cc:46:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(HOME, getenv("HOME"));
data/sapphire-0.15.8/windowmanager.cc:287:2: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(windowmanager_conf, "%s/.sapphire/wmconf", HOME);
data/sapphire-0.15.8/windowmanager.cc:325:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(clock_format,value.addr);
data/sapphire-0.15.8/windowmanager.cc:335:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buffer, value.addr);
data/sapphire-0.15.8/windowmanager.cc:339:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buffer, "%s%s", HOME, value.addr+1);
data/sapphire-0.15.8/windowmanager.cc:357:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(defaultTheme, "%s/themes/default.theme", configuration_home);
data/sapphire-0.15.8/windowmanager.cc:713:2: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl("/bin/sh", "sh", "-c", wmCommand, 0);
data/sapphire-0.15.8/windowmanager.cc:835:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(sapphire_config_dir, "%s/.sapphire", HOME);
data/sapphire-0.15.8/basemenu.cc:504:27: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
sprintf(buffer, "%s%s", getenv("HOME"), exec+1);
data/sapphire-0.15.8/basemenu.cc:533:27: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
sprintf(buffer, "%s%s", getenv("HOME"), exec+1);
data/sapphire-0.15.8/windowmanager.cc:45:25: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
HOME = new char[strlen(getenv("HOME"))+1];
data/sapphire-0.15.8/windowmanager.cc:46:15: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
strcpy(HOME, getenv("HOME"));
data/sapphire-0.15.8/windowmanager.cc:99:20: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
display = getenv("DISPLAY");
data/sapphire-0.15.8/basemenu.cc:568:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char command[strlen(s)+8];
data/sapphire-0.15.8/client.cc:853:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(c->client_position, "%dx%d+%d+%d",
data/sapphire-0.15.8/misc.cc:53:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg[80];
data/sapphire-0.15.8/rootmenu.cc:39:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[strlen(configuration_home)+strlen(menupath)+1];
data/sapphire-0.15.8/scanner.cc:28:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((in = fopen(filename, "r"))==NULL)
data/sapphire-0.15.8/theme.cc:691:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char command[value.size+8];
data/sapphire-0.15.8/theme.cc:706:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char f[43];
data/sapphire-0.15.8/theme.cc:707:4: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(f, "-*-lucida-medium-r-normal-*-12-*-*-*-*-*-*-*");
data/sapphire-0.15.8/theme.cc:715:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char f[43];
data/sapphire-0.15.8/theme.cc:716:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(f, "-*-lucida-medium-r-normal-*-12-*-*-*-*-*-*-*");
data/sapphire-0.15.8/theme.cc:732:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char f[43];
data/sapphire-0.15.8/theme.cc:733:4: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(f, "-*-lucida-bold-r-normal-*-15-*-*-*-*-*-*-*");
data/sapphire-0.15.8/theme.cc:741:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char f[43];
data/sapphire-0.15.8/theme.cc:742:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(f, "-*-lucida-bold-r-normal-*-15-*-*-*-*-*-*-*");
data/sapphire-0.15.8/toolbar.cc:414:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char t[25];
data/sapphire-0.15.8/windowmanager.cc:289:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((currentTheme = fopen(windowmanager_conf, "r"))!=NULL)
data/sapphire-0.15.8/windowmanager.cc:342:23: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((currentTheme = fopen(buffer, "r"))!=NULL)
data/sapphire-0.15.8/windowmanager.cc:832:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((wmconf = fopen(windowmanager_conf, "w"))==NULL)
data/sapphire-0.15.8/windowmanager.cc:843:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((wmconf = fopen(windowmanager_conf, "w"))==NULL)
data/sapphire-0.15.8/basemenu.cc:151:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char_count = strlen(menu.menuTitle);
data/sapphire-0.15.8/basemenu.cc:153:59: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
menu.width = XTextWidth(wm->getXFont(), menu.menuTitle, strlen(menu.menuTitle));
data/sapphire-0.15.8/basemenu.cc:174:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char_count = strlen(it.current()->name);
data/sapphire-0.15.8/basemenu.cc:179:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (char_count < strlen(menu.menuTitle)) {
data/sapphire-0.15.8/basemenu.cc:181:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char_count = strlen(menu.menuTitle);
data/sapphire-0.15.8/basemenu.cc:269:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char_count = strlen(menu.menuTitle);
data/sapphire-0.15.8/basemenu.cc:271:59: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
menu.width = XTextWidth(wm->getXFont(), menu.menuTitle, strlen(menu.menuTitle));
data/sapphire-0.15.8/basemenu.cc:292:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char_count = strlen(it.current()->name);
data/sapphire-0.15.8/basemenu.cc:297:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (char_count < strlen(menu.menuTitle)) {
data/sapphire-0.15.8/basemenu.cc:299:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char_count = strlen(menu.menuTitle);
data/sapphire-0.15.8/basemenu.cc:419:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
it.current()->item_y + 2, it.current()->name, strlen(it.current()->name));
data/sapphire-0.15.8/basemenu.cc:439:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
8, 16 , menu.menuTitle, strlen(menu.menuTitle));
data/sapphire-0.15.8/basemenu.cc:459:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i->item_x, i->item_y + 2, i->name, strlen(i->name));
data/sapphire-0.15.8/basemenu.cc:483:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
item->name = new char[strlen(n)+1];
data/sapphire-0.15.8/basemenu.cc:509:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
item->exec = new char[strlen(exec)+1];
data/sapphire-0.15.8/basemenu.cc:512:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
item->name = new char[strlen(n)+1];
data/sapphire-0.15.8/basemenu.cc:538:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
item->exec = new char[strlen(exec)+1];
data/sapphire-0.15.8/basemenu.cc:541:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
item->name = new char[strlen(n)+1];
data/sapphire-0.15.8/basemenu.cc:568:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char command[strlen(s)+8];
data/sapphire-0.15.8/client.cc:859:64: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
c->text_width=XTextWidth(wm->getXFont(), c->client_position, strlen(c->client_position));
data/sapphire-0.15.8/client.cc:866:4: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(c->client_position)),
data/sapphire-0.15.8/client.cc:868:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
c->client_position, strlen(c->client_position));
data/sapphire-0.15.8/client.cc:984:5: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(c->name));
data/sapphire-0.15.8/iconmenu.cc:47:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
item->name = new char[strlen(name)+1];
data/sapphire-0.15.8/rootmenu.cc:39:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char path[strlen(configuration_home)+strlen(menupath)+1];
data/sapphire-0.15.8/rootmenu.cc:39:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char path[strlen(configuration_home)+strlen(menupath)+1];
data/sapphire-0.15.8/scanner.cc:98:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int i=strlen(token);
data/sapphire-0.15.8/scanner.cc:113:3: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy (token, "");
data/sapphire-0.15.8/theme.cc:43:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
currentTheme = new char[strlen(themeFile)+1];
data/sapphire-0.15.8/toolbar.cc:417:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(t);
data/sapphire-0.15.8/toolbar.cc:418:54: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int font_width_test = XTextWidth(wm->getXFont(), t, strlen(t)) + 8;
data/sapphire-0.15.8/windowmanager.cc:45:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
HOME = new char[strlen(getenv("HOME"))+1];
data/sapphire-0.15.8/windowmanager.cc:286:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
windowmanager_conf = new char[strlen(HOME) + 32];
data/sapphire-0.15.8/windowmanager.cc:333:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *buffer = new char[value.size+strlen(HOME)];
data/sapphire-0.15.8/windowmanager.cc:356:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char* defaultTheme = new char[strlen(configuration_home) + 32];
data/sapphire-0.15.8/windowmanager.cc:834:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *sapphire_config_dir = new char[strlen(HOME)+30];
ANALYSIS SUMMARY:
Hits = 99
Lines analyzed = 7645 in approximately 0.18 seconds (43019 lines/second)
Physical Source Lines of Code (SLOC) = 5518
Hits@level = [0] 138 [1] 36 [2] 19 [3] 5 [4] 39 [5] 0
Hits@level+ = [0+] 237 [1+] 99 [2+] 63 [3+] 44 [4+] 39 [5+] 0
Hits/KSLOC@level+ = [0+] 42.9503 [1+] 17.9413 [2+] 11.4172 [3+] 7.9739 [4+] 7.06778 [5+] 0
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.