Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/shine-3.1.1/js/src/wrapper.c Examining data/shine-3.1.1/src/bin/main.c Examining data/shine-3.1.1/src/bin/main.h Examining data/shine-3.1.1/src/bin/wave.c Examining data/shine-3.1.1/src/bin/wave.h Examining data/shine-3.1.1/src/lib/bitstream.c Examining data/shine-3.1.1/src/lib/bitstream.h Examining data/shine-3.1.1/src/lib/huffman.c Examining data/shine-3.1.1/src/lib/huffman.h Examining data/shine-3.1.1/src/lib/l3bitstream.c Examining data/shine-3.1.1/src/lib/l3bitstream.h Examining data/shine-3.1.1/src/lib/l3loop.c Examining data/shine-3.1.1/src/lib/l3loop.h Examining data/shine-3.1.1/src/lib/l3mdct.c Examining data/shine-3.1.1/src/lib/l3mdct.h Examining data/shine-3.1.1/src/lib/l3subband.c Examining data/shine-3.1.1/src/lib/l3subband.h Examining data/shine-3.1.1/src/lib/layer3.c Examining data/shine-3.1.1/src/lib/layer3.h Examining data/shine-3.1.1/src/lib/mult_mips_gcc.h Examining data/shine-3.1.1/src/lib/mult_noarch_gcc.h Examining data/shine-3.1.1/src/lib/mult_sarm_gcc.h Examining data/shine-3.1.1/src/lib/reservoir.c Examining data/shine-3.1.1/src/lib/reservoir.h Examining data/shine-3.1.1/src/lib/tables.c Examining data/shine-3.1.1/src/lib/tables.h Examining data/shine-3.1.1/src/lib/types.h FINAL RESULTS: data/shine-3.1.1/src/bin/main.c:91:29: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). config->mpeg.bitr = atoi(argv[++i]); data/shine-3.1.1/src/bin/main.c:134:10: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char *version_names[4] = { "2.5", "reserved", "II", "I" }; data/shine-3.1.1/src/bin/main.c:135:10: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char *mode_names[4] = { "stereo", "joint-stereo", "dual-channel", "mono" }; data/shine-3.1.1/src/bin/main.c:136:10: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char *demp_names[4] = { "none", "50/15us", "", "CITT" }; data/shine-3.1.1/src/bin/main.c:190:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). outfile = fopen(outfname, "wb"); data/shine-3.1.1/src/bin/wave.c:24:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char id[4]; data/shine-3.1.1/src/bin/wave.c:30:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char wave[4]; data/shine-3.1.1/src/bin/wave.c:53:10: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char wave_get_chunk_header(FILE *file, int has_seek, const char id[4], riff_chunk_header_t *header) data/shine-3.1.1/src/bin/wave.c:53:69: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char wave_get_chunk_header(FILE *file, int has_seek, const char id[4], riff_chunk_header_t *header) data/shine-3.1.1/src/bin/wave.c:110:18: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). wave->file = fopen(fname, "rb"); data/shine-3.1.1/src/lib/l3mdct.c:128:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(config->l3_sb_sample[ch][0], config->l3_sb_sample[ch][config->mpeg.granules_per_frame], sizeof(config->l3_sb_sample[0][0])); data/shine-3.1.1/src/bin/wave.c:49:7: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). getc(file); ANALYSIS SUMMARY: Hits = 12 Lines analyzed = 3230 in approximately 0.13 seconds (23978 lines/second) Physical Source Lines of Code (SLOC) = 2264 Hits@level = [0] 29 [1] 1 [2] 11 [3] 0 [4] 0 [5] 0 Hits@level+ = [0+] 41 [1+] 12 [2+] 11 [3+] 0 [4+] 0 [5+] 0 Hits/KSLOC@level+ = [0+] 18.1095 [1+] 5.30035 [2+] 4.85866 [3+] 0 [4+] 0 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.