Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/siggen-2.3.10/siggen.h
Examining data/siggen-2.3.10/wavfile.c
Examining data/siggen-2.3.10/sweepgen.h
Examining data/siggen-2.3.10/smix.c
Examining data/siggen-2.3.10/wavsubs.h
Examining data/siggen-2.3.10/tt.c
Examining data/siggen-2.3.10/swgen.c
Examining data/siggen-2.3.10/DAC.c
Examining data/siggen-2.3.10/tones.eg/randnote.c
Examining data/siggen-2.3.10/tones.eg/shepard-risset.c
Examining data/siggen-2.3.10/tones.eg/randtone.c
Examining data/siggen-2.3.10/tones.eg/ramp.c
Examining data/siggen-2.3.10/fsynth.c
Examining data/siggen-2.3.10/fsynth.h
Examining data/siggen-2.3.10/fsynscr.c
Examining data/siggen-2.3.10/scfio.c
Examining data/siggen-2.3.10/adB.c
Examining data/siggen-2.3.10/wavsubs.c
Examining data/siggen-2.3.10/sweepscr.c
Examining data/siggen-2.3.10/sigscr.c
Examining data/siggen-2.3.10/dB.c
Examining data/siggen-2.3.10/fmtheaders.h
Examining data/siggen-2.3.10/configsubs.c
Examining data/siggen-2.3.10/scfio.h
Examining data/siggen-2.3.10/scrsubs.c
Examining data/siggen-2.3.10/tones.c
Examining data/siggen-2.3.10/sgen.c
Examining data/siggen-2.3.10/misc.c
Examining data/siggen-2.3.10/config.h
Examining data/siggen-2.3.10/generator.c
Examining data/siggen-2.3.10/mixer.c
Examining data/siggen-2.3.10/mixer.h
Examining data/siggen-2.3.10/soundinfo.c
Examining data/siggen-2.3.10/siggen.c
Examining data/siggen-2.3.10/sweepgen.c
Examining data/siggen-2.3.10/tonesgen.c
FINAL RESULTS:
data/siggen-2.3.10/configsubs.c:138:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(f,SEP);
data/siggen-2.3.10/fsynscr.c:290:4: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(VERS,VERSTR,sys,VERSION);
data/siggen-2.3.10/fsynscr.c:315:8: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(bf," %2d%s Harmonic amplitude ",i,
data/siggen-2.3.10/fsynth.c:85:4: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr,VERSTR,sys,VERSION);
data/siggen-2.3.10/sgen.c:124:4: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr,VERSTR,sys,VERSION);
data/siggen-2.3.10/sgen.c:284:14: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
if (vflg) printf(VERSTR,sys,VERSION);
data/siggen-2.3.10/siggen.c:136:3: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr,VERSTR,sys,VERSION);
data/siggen-2.3.10/sigscr.c:342:4: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(VERS,VERSTR,sys,VERSION);
data/siggen-2.3.10/smix.c:326:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf,"Problem setting level of mixer channel %s.",
data/siggen-2.3.10/smix.c:369:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf,"Problem reading current level of mixer channel %s.",
data/siggen-2.3.10/soundinfo.c:296:6: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf,"Problem reading current level of mixer channel %s.",
data/siggen-2.3.10/sweepgen.c:107:3: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr,VERSTR,sys,VERSION);
data/siggen-2.3.10/sweepscr.c:320:4: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(VERS,VERSTR,sys,VERSION);
data/siggen-2.3.10/swgen.c:113:4: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr,VERSTR,sys,VERSION);
data/siggen-2.3.10/swgen.c:289:14: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
if (vflg) printf(VERSTR,sys,VERSION);
data/siggen-2.3.10/tones.c:102:4: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr,VERSTR,sys,VERSION);
data/siggen-2.3.10/tones.c:269:14: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
if (vflg) printf(VERSTR,sys,VERSION);
data/siggen-2.3.10/tonesgen.c:241:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(bf,aa[i]);
data/siggen-2.3.10/tonesgen.c:341:4: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(GenErrStr,"No such waveform: \"%s\".",p);
data/siggen-2.3.10/tonesgen.c:660:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(bf,s);
data/siggen-2.3.10/tonesgen.c:737:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(GenErrStr,"Couldn't open file '%s'.",fn);
data/siggen-2.3.10/configsubs.c:104:7: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
s=getenv("HOME");
data/siggen-2.3.10/generator.c:493:4: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(time(NULL));
data/siggen-2.3.10/tones.eg/randnote.c:45:4: [3] (random) srandom:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srandom(time(NULL)%(Id+f));
data/siggen-2.3.10/tones.eg/randnote.c:49:12: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
f+=((random()%11)-5);
data/siggen-2.3.10/tones.eg/randnote.c:52:10: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
x=(random()%5)-2;
data/siggen-2.3.10/tones.eg/randtone.c:33:4: [3] (random) srandom:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srandom(time(NULL)%(d+f));
data/siggen-2.3.10/tones.eg/randtone.c:36:12: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
f=f+(random()%(f/4))-f/8;
data/siggen-2.3.10/tones.eg/randtone.c:38:12: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
d=d+(random()%200)-100;
data/siggen-2.3.10/DAC.c:168:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open (fnm,m,0)) >= 0) { /* params must be set in this order */
data/siggen-2.3.10/configsubs.c:81:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char nm1[STR_SIZE+2];
data/siggen-2.3.10/configsubs.c:82:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char nm2[STR_SIZE+2];
data/siggen-2.3.10/configsubs.c:83:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char nm3[STR_SIZE+2];
data/siggen-2.3.10/configsubs.c:86:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *Fnm[NUM_CONF_FILES] = { nm1, nm2, nm3 };
data/siggen-2.3.10/configsubs.c:93:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char f[STR_SIZE+4],*p,*s;
data/siggen-2.3.10/configsubs.c:99:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
F[LOCAL]=fopen(local,"r");
data/siggen-2.3.10/configsubs.c:109:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
F[HOME]=fopen(f,"r");
data/siggen-2.3.10/configsubs.c:114:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
F[GLOBAL]=fopen(global,"r");
data/siggen-2.3.10/configsubs.c:132:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char f[STR_SIZE+4],*p,*s;
data/siggen-2.3.10/configsubs.c:195:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char Xlat_bf[258];
data/siggen-2.3.10/dB.c:22:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
x=(double)(atoi(*argv));
data/siggen-2.3.10/fmtheaders.h:75:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char main_chunk[4]; /* 'RIFF' */
data/siggen-2.3.10/fmtheaders.h:77:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char chunk_type[4]; /* 'WAVE' */
data/siggen-2.3.10/fmtheaders.h:79:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sub_chunk[4]; /* 'fmt ' */
data/siggen-2.3.10/fmtheaders.h:88:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char data_chunk[4]; /* 'data' */
data/siggen-2.3.10/fsynscr.c:75:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char VERS[128];
data/siggen-2.3.10/fsynscr.c:234:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char bf[100];
data/siggen-2.3.10/fsynscr.c:385:20: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
w1=(unsigned char *)(wavbufs[Fwave->adj]);
data/siggen-2.3.10/fsynth.c:71:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char wf[32]="sine"; /* waveform type */
data/siggen-2.3.10/fsynth.c:78:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dac[130];
data/siggen-2.3.10/fsynth.c:120:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *p,bf[130];
data/siggen-2.3.10/fsynth.c:138:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc && isdigit(**argv)) { samplerate=atoi(*argv++); argc--; }
data/siggen-2.3.10/fsynth.c:141:44: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc && isdigit(**argv)) { Nfragbufs=atoi(*argv++); argc--; }
data/siggen-2.3.10/fsynth.c:144:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc && isdigit(**argv)) { Bufspersec=atoi(*argv++); argc--; }
data/siggen-2.3.10/fsynth.c:150:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i=atoi(*argv++); argc--;
data/siggen-2.3.10/fsynth.c:164:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i=atoi(*argv++); argc--;
data/siggen-2.3.10/fsynth.c:187:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
vflg=atoi(get_conf_value(sys,"verbose","0"));
data/siggen-2.3.10/fsynth.c:190:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
samplerate=atoi(get_conf_value(sys,"samplerate",QSAMPLERATE));
data/siggen-2.3.10/fsynth.c:193:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
channels=atoi(get_conf_value(sys,"channels",QDEF_FSYNTH_CHANNELS));
data/siggen-2.3.10/fsynth.c:196:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Nfragbufs=atoi(get_conf_value(sys,"fragments",QDEFAULT_FRAGMENTS));
data/siggen-2.3.10/fsynth.c:199:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Bufspersec=atoi(get_conf_value(sys,"buffspersec",QDEFAULT_BUFFSPERSEC));
data/siggen-2.3.10/fsynth.c:202:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
afmt=atoi(get_conf_value(sys,"samplesize",QAFMT_QUERY));
data/siggen-2.3.10/fsynth.c:205:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
vikeys=atoi(get_conf_value(sys,"vi_keys",QVI_KEYS));
data/siggen-2.3.10/fsynth.c:212:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
freq=atoi(*argv++); argc--;
data/siggen-2.3.10/fsynth.h:23:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char wf[32]; /* waveform type */
data/siggen-2.3.10/generator.c:588:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p,buf,nc); p+=nc;
data/siggen-2.3.10/mixer.c:29:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *mydevname[SOUND_MIXER_NRDEVICES] = SOUND_DEVICE_LABELS;
data/siggen-2.3.10/mixer.c:39:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (((mixFD = open(DEV, O_RDONLY)) >= 0) &&
data/siggen-2.3.10/scfio.c:323:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char f[MAXCOL+1],*q,*p;
data/siggen-2.3.10/scfio.c:424:29: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
return( (struct SCField *)memcpy(p,fp,sizeof(struct SCField)) );
data/siggen-2.3.10/scrsubs.c:213:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(F->val.s,"%2d:%02d:%02d",BT->tm_hour,BT->tm_min,BT->tm_sec);
data/siggen-2.3.10/sgen.c:116:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dac[130];
data/siggen-2.3.10/sgen.c:170:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *p,*wf,*fnm,fname[130],*omode;
data/siggen-2.3.10/sgen.c:188:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc && isdigit(**argv)) { samplerate=atoi(*argv++); argc--; }
data/siggen-2.3.10/sgen.c:202:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i=atoi(*argv++); argc--;
data/siggen-2.3.10/sgen.c:221:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Gain=atoi(*argv++); argc--;
data/siggen-2.3.10/sgen.c:254:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
vflg=atoi(get_conf_value(sys,"verbose","0"));
data/siggen-2.3.10/sgen.c:257:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
samplerate=atoi(get_conf_value(sys,"samplerate",QSAMPLERATE));
data/siggen-2.3.10/sgen.c:260:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
stereo=atoi(get_conf_value(sys,"channels","1"));
data/siggen-2.3.10/sgen.c:264:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
afmt=atoi(get_conf_value(sys,"samplesize",QAFMT_QUERY));
data/siggen-2.3.10/sgen.c:276:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
freq=atoi(*argv++); argc--;
data/siggen-2.3.10/sgen.c:278:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc) { ratio=atoi(*argv++); argc--; }
data/siggen-2.3.10/sgen.c:326:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f=fopen(fnm=outfile,"r"))!=NULL) {
data/siggen-2.3.10/sgen.c:330:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f=fopen(fnm,omode))==NULL) { exit(err_rpt(errno,fnm)); }
data/siggen-2.3.10/sgen.c:393:14: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
} else memcpy(rbuf,lbuf,lbuf_size);
data/siggen-2.3.10/sgen.c:396:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(plbuf,lbuf,plbuf_size);
data/siggen-2.3.10/siggen.c:114:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char wf[32]="sine"; /* waveform type */
data/siggen-2.3.10/siggen.c:121:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char wf2[32]="off"; /* waveform type */
data/siggen-2.3.10/siggen.c:129:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dac[130];
data/siggen-2.3.10/siggen.c:175:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *p,bf[130];
data/siggen-2.3.10/siggen.c:194:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc && isdigit(**argv)) { samplerate=atoi(*argv++); argc--; }
data/siggen-2.3.10/siggen.c:197:44: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc && isdigit(**argv)) { Nfragbufs=atoi(*argv++); argc--; }
data/siggen-2.3.10/siggen.c:200:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc && isdigit(**argv)) { Bufspersec=atoi(*argv++); argc--; }
data/siggen-2.3.10/siggen.c:206:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i=atoi(*argv++); argc--;
data/siggen-2.3.10/siggen.c:214:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Gain=atoi(*argv++)*10; argc--;
data/siggen-2.3.10/siggen.c:245:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
vflg=atoi(get_conf_value(sys,"verbose","0"));
data/siggen-2.3.10/siggen.c:248:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
samplerate=atoi(get_conf_value(sys,"samplerate",QSAMPLERATE));
data/siggen-2.3.10/siggen.c:251:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
stereo=atoi(get_conf_value(sys,"channels","1"));
data/siggen-2.3.10/siggen.c:255:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Nfragbufs=atoi(get_conf_value(sys,"fragments",QDEFAULT_FRAGMENTS));
data/siggen-2.3.10/siggen.c:264:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Bufspersec=atoi(get_conf_value(sys,"buffspersec",QDEFAULT_BUFFSPERSEC));
data/siggen-2.3.10/siggen.c:267:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
afmt=atoi(get_conf_value(sys,"samplesize",QAFMT_QUERY));
data/siggen-2.3.10/siggen.c:270:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
vikeys=atoi(get_conf_value(sys,"vi_keys",QVI_KEYS));
data/siggen-2.3.10/siggen.c:277:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
freq2=freq=atoi(*argv++); argc--;
data/siggen-2.3.10/siggen.c:278:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc) { ratio=atoi(*argv++); argc--; }
data/siggen-2.3.10/siggen.h:29:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char wf[32]; /* waveform type */
data/siggen-2.3.10/siggen.h:35:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char wf2[32]; /* waveform type */
data/siggen-2.3.10/sigscr.c:59:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char VERS[128];
data/siggen-2.3.10/sigscr.c:412:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
w1=(unsigned char *)(wavbufs[Fwav1V.adj]);
data/siggen-2.3.10/sigscr.c:413:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
w2=(unsigned char *)(wavbufs[Fwav2V.adj]);
data/siggen-2.3.10/smix.c:92:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mixname[130];
data/siggen-2.3.10/smix.c:104:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fopen();
data/siggen-2.3.10/smix.c:112:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fname[132],*p;
data/siggen-2.3.10/smix.c:167:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
vflg=atoi(get_conf_value(sys,"verbose","0"));
data/siggen-2.3.10/smix.c:184:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
else if ((fpw=fopen(outfile,"w"))==NULL)
data/siggen-2.3.10/smix.c:192:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
else if ((fpr=fopen(infile,"r"))==NULL)
data/siggen-2.3.10/smix.c:214:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char bf[514],*p;
data/siggen-2.3.10/smix.c:225:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *aa[64],c,*p,*r,*q;
data/siggen-2.3.10/smix.c:306:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[130];
data/siggen-2.3.10/smix.c:365:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[130];
data/siggen-2.3.10/soundinfo.c:114:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fopen(),*mfopen();
data/siggen-2.3.10/soundinfo.c:126:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fname[132],*fnm,*p;
data/siggen-2.3.10/soundinfo.c:139:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (*p==0) n=atoi(p+1); /* e.g. num. option -n23 */
data/siggen-2.3.10/soundinfo.c:153:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(fnm=MIXDEV, O_RDONLY)) < 0) {
data/siggen-2.3.10/soundinfo.c:159:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(fnm=DSPDEV, O_RDWR)) < 0) {
data/siggen-2.3.10/soundinfo.c:191:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[130],*p;
data/siggen-2.3.10/soundinfo.c:256:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[130];
data/siggen-2.3.10/soundinfo.c:257:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *mydevname[SOUND_MIXER_NRDEVICES] = SOUND_DEVICE_LABELS;
data/siggen-2.3.10/sweepgen.c:83:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char wf[32]="sawtooth"; /* waveform type */
data/siggen-2.3.10/sweepgen.c:89:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char wf2[32]="sine"; /* waveform type */
data/siggen-2.3.10/sweepgen.c:100:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dac[130];
data/siggen-2.3.10/sweepgen.c:145:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *p,bf[130];
data/siggen-2.3.10/sweepgen.c:163:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc && isdigit(**argv)) { samplerate=atoi(*argv++); argc--; }
data/siggen-2.3.10/sweepgen.c:166:44: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc && isdigit(**argv)) { Nfragbufs=atoi(*argv++); argc--; }
data/siggen-2.3.10/sweepgen.c:169:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc && isdigit(**argv)) { Bufspersec=atoi(*argv++); argc--; }
data/siggen-2.3.10/sweepgen.c:175:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i=atoi(*argv++); argc--;
data/siggen-2.3.10/sweepgen.c:183:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Gain=atoi(*argv++); argc--;
data/siggen-2.3.10/sweepgen.c:213:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
freq=atoi(*argv++); argc--;
data/siggen-2.3.10/sweepgen.c:214:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc) { ratio=atoi(*argv++); argc--; }
data/siggen-2.3.10/sweepgen.c:223:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
vflg=atoi(get_conf_value(sys,"verbose","0"));
data/siggen-2.3.10/sweepgen.c:226:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
samplerate=atoi(get_conf_value(sys,"samplerate",QSAMPLERATE));
data/siggen-2.3.10/sweepgen.c:229:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
stereo=atoi(get_conf_value(sys,"channels","1"));
data/siggen-2.3.10/sweepgen.c:233:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Nfragbufs=atoi(get_conf_value(sys,"fragments",QDEFAULT_FRAGMENTS));
data/siggen-2.3.10/sweepgen.c:242:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Bufspersec=atoi(get_conf_value(sys,"buffspersec",QDEFAULT_BUFFSPERSEC));
data/siggen-2.3.10/sweepgen.c:245:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
afmt=atoi(get_conf_value(sys,"samplesize",QAFMT_QUERY));
data/siggen-2.3.10/sweepgen.c:248:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
vikeys=atoi(get_conf_value(sys,"vi_keys",QVI_KEYS));
data/siggen-2.3.10/sweepgen.h:27:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char wf[32]; /* waveform type */
data/siggen-2.3.10/sweepgen.h:33:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char wf2[32]; /* waveform type */
data/siggen-2.3.10/sweepscr.c:59:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char VERS[128];
data/siggen-2.3.10/swgen.c:103:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dac[130];
data/siggen-2.3.10/swgen.c:159:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *p,*wf,*fnm,fname[130],*omode;
data/siggen-2.3.10/swgen.c:178:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc && isdigit(**argv)) { samplerate=atoi(*argv++); argc--; }
data/siggen-2.3.10/swgen.c:190:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Gain=atoi(*argv++); argc--;
data/siggen-2.3.10/swgen.c:197:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i=atoi(*argv++); argc--;
data/siggen-2.3.10/swgen.c:241:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
vflg=atoi(get_conf_value(sys,"verbose","0"));
data/siggen-2.3.10/swgen.c:244:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
samplerate=atoi(get_conf_value(sys,"samplerate",QSAMPLERATE));
data/siggen-2.3.10/swgen.c:247:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
stereo=atoi(get_conf_value(sys,"channels","1"));
data/siggen-2.3.10/swgen.c:251:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
afmt=atoi(get_conf_value(sys,"samplesize",QAFMT_QUERY));
data/siggen-2.3.10/swgen.c:263:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
FMfrq=atoi(*argv++); argc--;
data/siggen-2.3.10/swgen.c:270:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Frq=atoi(*argv++); argc--;
data/siggen-2.3.10/swgen.c:331:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f=fopen(fnm=outfile,"r"))!=NULL) {
data/siggen-2.3.10/swgen.c:335:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f=fopen(fnm,omode))==NULL) { exit(err_rpt(errno,fnm)); }
data/siggen-2.3.10/tones.c:92:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dac[130];
data/siggen-2.3.10/tones.c:162:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *p,*fnm,bf[260],*omode;
data/siggen-2.3.10/tones.c:180:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc && isdigit(**argv)) { samplerate=atoi(*argv++); argc--; }
data/siggen-2.3.10/tones.c:194:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i=atoi(*argv++); argc--;
data/siggen-2.3.10/tones.c:200:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
loopflg=atoi(*argv++); argc--;
data/siggen-2.3.10/tones.c:216:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i=atoi(*argv++); argc--;
data/siggen-2.3.10/tones.c:225:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i=atoi(*argv++); argc--;
data/siggen-2.3.10/tones.c:251:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
vflg=atoi(get_conf_value(sys,"verbose","0"));
data/siggen-2.3.10/tones.c:254:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
samplerate=atoi(get_conf_value(sys,"samplerate",QSAMPLERATE));
data/siggen-2.3.10/tones.c:257:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
channels=atoi(get_conf_value(sys,"channels",QDEF_TONES_CHANNELS));
data/siggen-2.3.10/tones.c:260:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Wn=atoi(get_conf_value(sys,"loadable_waveforms",QDEF_WN));
data/siggen-2.3.10/tones.c:263:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
afmt=atoi(get_conf_value(sys,"samplesize",QAFMT_QUERY));
data/siggen-2.3.10/tones.c:275:22: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
} else if ((fi=fopen(infile,"r"))==NULL) {
data/siggen-2.3.10/tones.c:326:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f=fopen(fnm=outfile,"r"))!=NULL) {
data/siggen-2.3.10/tones.c:330:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f=fopen(fnm,omode))==NULL) { exit(err_rpt(errno,fnm)); }
data/siggen-2.3.10/tones.eg/ramp.c:27:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
argc--; st=atoi(*argv++);
data/siggen-2.3.10/tones.eg/ramp.c:29:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
argc--; end=atoi(*argv++);
data/siggen-2.3.10/tones.eg/ramp.c:31:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
argc--; step=atoi(*argv++);
data/siggen-2.3.10/tones.eg/ramp.c:33:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
argc--; l=atoi(*argv++);
data/siggen-2.3.10/tones.eg/randnote.c:11:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char NT[6];
data/siggen-2.3.10/tones.eg/randnote.c:40:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Id=atoi(*argv++); argc--;
data/siggen-2.3.10/tones.eg/randnote.c:42:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
N=atoi(*argv);
data/siggen-2.3.10/tones.eg/randtone.c:26:6: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
f=atoi(*argv); argv++; argc--;
data/siggen-2.3.10/tones.eg/randtone.c:28:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
d=atoi(*argv++); argc--;
data/siggen-2.3.10/tones.eg/randtone.c:30:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
N=atoi(*argv);
data/siggen-2.3.10/tones.eg/shepard-risset.c:65:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
partials=atoi(argv[1]);
data/siggen-2.3.10/tones.eg/shepard-risset.c:67:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
shifts=atoi(argv[3]);
data/siggen-2.3.10/tonesgen.c:128:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char GenErrStr[130]; /* Explanatory message for GenErr */
data/siggen-2.3.10/tonesgen.c:237:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *p,bf[256];
data/siggen-2.3.10/tonesgen.c:270:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f=fopen(fn,"r"))==NULL) return(NULL);
data/siggen-2.3.10/tonesgen.c:656:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *p,c,bf[130];
data/siggen-2.3.10/tonesgen.c:735:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
else if ((f=fopen(fn,"r"))==NULL) {
data/siggen-2.3.10/tonesgen.c:756:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *p,bf[262];
data/siggen-2.3.10/tonesgen.c:774:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char **aa[50];
data/siggen-2.3.10/wavfile.c:147:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f=fopen(fn,"r"))==NULL) return(NULL);
data/siggen-2.3.10/wavsubs.c:106:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char bf[4];
data/siggen-2.3.10/wavsubs.c:129:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char bf[4];
data/siggen-2.3.10/wavsubs.c:149:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char bf[130];
data/siggen-2.3.10/wavsubs.c:172:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char bf[130];
data/siggen-2.3.10/wavsubs.c:217:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char bf[8],*p;
data/siggen-2.3.10/wavsubs.c:235:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char bf[36],*p;
data/siggen-2.3.10/configsubs.c:100:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(Fnm[LOCAL],local,STR_SIZE);
data/siggen-2.3.10/configsubs.c:105:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(f,(s!=NULL)?s:"",STR_SIZE);
data/siggen-2.3.10/configsubs.c:106:5: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(f,"/");
data/siggen-2.3.10/configsubs.c:107:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
st=STR_SIZE+2-strlen(f);
data/siggen-2.3.10/configsubs.c:108:5: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(f,home,st);
data/siggen-2.3.10/configsubs.c:110:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(Fnm[HOME],f,STR_SIZE);
data/siggen-2.3.10/configsubs.c:115:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(Fnm[GLOBAL],global,STR_SIZE);
data/siggen-2.3.10/configsubs.c:137:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(f,sys,STR_SIZE);
data/siggen-2.3.10/configsubs.c:139:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(f);
data/siggen-2.3.10/configsubs.c:142:3: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(s,name,STR_SIZE+2-n);
data/siggen-2.3.10/configsubs.c:204:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(s);
data/siggen-2.3.10/fsynth.c:136:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(p=(*argv++)+1); argc--; /* before paramters */
data/siggen-2.3.10/fsynth.c:204:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dac,get_conf_value(sys,"dacfile",DAC_FILE),sizeof(dac)-1);
data/siggen-2.3.10/fsynth.c:210:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(wf,*argv++,32); wf[31]=0; argc--; /* waveform type */
data/siggen-2.3.10/fsynth.c:246:7: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
getchar();
data/siggen-2.3.10/generator.c:575:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(p=wf);
data/siggen-2.3.10/mixer.c:60:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(dev);
data/siggen-2.3.10/scrsubs.c:155:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(wv);
data/siggen-2.3.10/scrsubs.c:180:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mvputfstr(y+6,44,a3,S,strlen(S));
data/siggen-2.3.10/scrsubs.c:261:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(GetStr(f1),GetStr(f2),GetWidth(f1));
data/siggen-2.3.10/sgen.c:186:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(p=(*argv++)+1); argc--; /* before paramters */
data/siggen-2.3.10/sgen.c:266:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dac,get_conf_value(sys,"dacfile",DAC_FILE),sizeof(dac)-1);
data/siggen-2.3.10/siggen.c:192:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(p=(*argv++)+1); argc--; /* before paramters */
data/siggen-2.3.10/siggen.c:269:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dac,get_conf_value(sys,"dacfile",DAC_FILE),sizeof(dac)-1);
data/siggen-2.3.10/siggen.c:275:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(wf,*argv++,32); wf[31]=0; argc--; /* waveform type */
data/siggen-2.3.10/sigscr.c:308:6: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
getchar();
data/siggen-2.3.10/smix.c:126:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(p=(*argv++)+1); argc--;
data/siggen-2.3.10/smix.c:144:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(mixname,*argv++,sizeof(mixname)-1); mixname[sizeof(mixname)-1]=0; argc--;
data/siggen-2.3.10/smix.c:170:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(mixname,get_conf_value(sys,"mixerfile",MIXER_FILE),sizeof(mixname)-1);
data/siggen-2.3.10/smix.c:249:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(p=*v++); c--;
data/siggen-2.3.10/smix.c:455:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (s!=NULL && *s && *(p=s+strlen(s)-1)=='\n') *p=0;
data/siggen-2.3.10/soundinfo.c:138:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
{ n=strlen(p=(*argv++)+1); argc--; /* before paramters */
data/siggen-2.3.10/sweepgen.c:161:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(p=(*argv++)+1); argc--; /* before paramters */
data/siggen-2.3.10/sweepgen.c:211:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(wf,*argv++,32); wf[31]=0; argc--; /* waveform type */
data/siggen-2.3.10/sweepgen.c:247:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dac,get_conf_value(sys,"dacfile",DAC_FILE),sizeof(dac)-1);
data/siggen-2.3.10/sweepscr.c:287:6: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
getchar();
data/siggen-2.3.10/swgen.c:176:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(p=(*argv++)+1); argc--; /* before paramters */
data/siggen-2.3.10/swgen.c:253:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dac,get_conf_value(sys,"dacfile",DAC_FILE),sizeof(dac)-1);
data/siggen-2.3.10/tones.c:178:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(p=(*argv++)+1); argc--; /* before paramters */
data/siggen-2.3.10/tones.c:265:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dac,get_conf_value(sys,"dacfile",DAC_FILE),sizeof(dac)-1);
data/siggen-2.3.10/tones.eg/randnote.c:31:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(NT,*argv,5); argv++; argc--;
data/siggen-2.3.10/tones.eg/randnote.c:34:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(NT)!=2 || NT[0]<'A' || NT[0]>'G' || !isdigit(NT[1])) {
data/siggen-2.3.10/tonesgen.c:130:22: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
#define SetErrStr(S) strncpy(GenErrStr,S,128)
data/siggen-2.3.10/tonesgen.c:333:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n=strlen(p);
data/siggen-2.3.10/wavsubs.c:238:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(p=bf,"WAVEfmt ",8); p+=8;
ANALYSIS SUMMARY:
Hits = 247
Lines analyzed = 8713 in approximately 0.35 seconds (24626 lines/second)
Physical Source Lines of Code (SLOC) = 5529
Hits@level = [0] 229 [1] 45 [2] 173 [3] 8 [4] 21 [5] 0
Hits@level+ = [0+] 476 [1+] 247 [2+] 202 [3+] 29 [4+] 21 [5+] 0
Hits/KSLOC@level+ = [0+] 86.0915 [1+] 44.6735 [2+] 36.5346 [3+] 5.24507 [4+] 3.79816 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.