Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/slrnface-2.1.1/slrnface.c FINAL RESULTS: data/slrnface-2.1.1/slrnface.c:579:6: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (name_start, my_options[i].specifier + 1); data/slrnface-2.1.1/slrnface.c:580:6: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (class_start, my_options[i].specifier + 1); data/slrnface-2.1.1/slrnface.c:403:19: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (!(winenv = getenv ("WINDOWID")) || !(winid = strtol (winenv, NULL, 0))) data/slrnface-2.1.1/slrnface.c:435:20: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (!(home = getenv ("HOME"))) data/slrnface-2.1.1/slrnface.c:142:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char last_face[8000]; /* Buffer for X-Face data. We keep the last data/slrnface-2.1.1/slrnface.c:479:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fifo_fd = open (fifo_file, O_RDONLY | O_NONBLOCK)) < 0) data/slrnface-2.1.1/slrnface.c:568:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (name_str, terminal.res_name, name_len); data/slrnface-2.1.1/slrnface.c:573:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (class_str, terminal.res_class, class_len); data/slrnface-2.1.1/slrnface.c:589:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (resource, value.addr, value.size); data/slrnface-2.1.1/slrnface.c:657:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *p, *s, clr[MAXCOLORLEN]; data/slrnface-2.1.1/slrnface.c:714:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[8000]; data/slrnface-2.1.1/slrnface.c:828:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (last_face, face_start, face_len); data/slrnface-2.1.1/slrnface.c:956:13: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char data[288]; data/slrnface-2.1.1/slrnface.c:957:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char uncompfacebuf[15000]; data/slrnface-2.1.1/slrnface.c:987:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (uncompfacebuf, last_face, buffered_face_len); data/slrnface-2.1.1/slrnface.c:446:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). maxlen = strlen (home) + sizeof ("/.slrnfaces/") + strlen (u.nodename) data/slrnface-2.1.1/slrnface.c:446:58: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). maxlen = strlen (home) + sizeof ("/.slrnfaces/") + strlen (u.nodename) data/slrnface-2.1.1/slrnface.c:566:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). name_len = strlen (terminal.res_name); data/slrnface-2.1.1/slrnface.c:571:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). class_len = strlen (terminal.res_class); data/slrnface-2.1.1/slrnface.c:723:7: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). n = read (fifo_fd, bufstart, toread); ANALYSIS SUMMARY: Hits = 20 Lines analyzed = 1182 in approximately 0.04 seconds (33110 lines/second) Physical Source Lines of Code (SLOC) = 811 Hits@level = [0] 2 [1] 5 [2] 11 [3] 2 [4] 2 [5] 0 Hits@level+ = [0+] 22 [1+] 20 [2+] 15 [3+] 4 [4+] 2 [5+] 0 Hits/KSLOC@level+ = [0+] 27.127 [1+] 24.6609 [2+] 18.4957 [3+] 4.93218 [4+] 2.46609 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.