Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c
Examining data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c
Examining data/spamassassin-4.0.0~0.0svn1883440/spamc/getopt.c
Examining data/spamassassin-4.0.0~0.0svn1883440/spamc/utils.c
Examining data/spamassassin-4.0.0~0.0svn1883440/spamc/utils.h
Examining data/spamassassin-4.0.0~0.0svn1883440/spamc/acconfig.h
Examining data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.h
Examining data/spamassassin-4.0.0~0.0svn1883440/spamc/qmail-spamc.c
Examining data/spamassassin-4.0.0~0.0svn1883440/spamc/getopt.h
Examining data/spamassassin-4.0.0~0.0svn1883440/masses/garescorer.c
Examining data/spamassassin-4.0.0~0.0svn1883440/masses/evolve_metarule/evolve_metarule.c
Examining data/spamassassin-4.0.0~0.0svn1883440/masses/perceptron.c
FINAL RESULTS:
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:35:9: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define snprintf _snprintf
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:35:18: [4] (format) _snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define snprintf _snprintf
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:36:9: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define vsnprintf _vsnprintf
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1312:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buf, PROTOCOL_VERSION);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1338:15: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buf + len, username);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1428:22: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
m->out_len = sprintf(m->out, "SPAMD/%s %d\n", versbuf, response);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1637:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buf, PROTOCOL_VERSION);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1692:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buf + len, username);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:2232:16: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
len += vsnprintf(buf+len, LOG_BUFSIZ-len, msg, ap);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:2242:9: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buf, LOG_BUFSIZ, msg, ap);
data/spamassassin-4.0.0~0.0svn1883440/spamc/qmail-spamc.c:53:12: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
TRY(execlp("qmail-queue", "qmail-queue", NULL));
data/spamassassin-4.0.0~0.0svn1883440/spamc/qmail-spamc.c:92:13: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
TRY(execvp("spamc", options));
data/spamassassin-4.0.0~0.0svn1883440/spamc/qmail-spamc.c:98:13: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
TRY(execlp("qmail-queue", "qmail-queue", NULL));
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:714:5: [4] (shell) execv:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execv(exec_argv[0], exec_argv);
data/spamassassin-4.0.0~0.0svn1883440/masses/evolve_metarule/evolve_metarule.c:262:16: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((arg = getopt (argc, argv, "h:r:m:t:l:e:p:s:g:x:u:?")) != -1) {
data/spamassassin-4.0.0~0.0svn1883440/masses/garescorer.c:188:19: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((arg = getopt (argc, argv, "b:r:s:e:t:f:C")) != -1) {
data/spamassassin-4.0.0~0.0svn1883440/masses/perceptron.c:133:6: [3] (random) lrand48:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
r = lrand48() % wheel_size;
data/spamassassin-4.0.0~0.0svn1883440/masses/perceptron.c:164:9: [3] (random) drand48:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
bias = drand48() - 0.5;
data/spamassassin-4.0.0~0.0svn1883440/masses/perceptron.c:166:30: [3] (random) drand48:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
weights[i] = range_lo[i] + drand48() * (range_hi[i] - range_lo[i]);
data/spamassassin-4.0.0~0.0svn1883440/masses/perceptron.c:332:12: [3] (random) lrand48:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
int r = lrand48 () % (wheel_size - i);
data/spamassassin-4.0.0~0.0svn1883440/masses/perceptron.c:409:16: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((arg = getopt (argc, argv, "p:e:l:t:w:h?")) != -1) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/qmail-spamc.c:52:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv("RELAYCLIENT")) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/qmail-spamc.c:60:16: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((val = getenv("SPAMDSOCK")) != NULL) { /* Unix Domain Socket path */
data/spamassassin-4.0.0~0.0svn1883440/spamc/qmail-spamc.c:64:16: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((val = getenv("SPAMDHOST")) != NULL) { /* remote spamd host name */
data/spamassassin-4.0.0~0.0svn1883440/spamc/qmail-spamc.c:68:16: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((val = getenv("SPAMDPORT")) != NULL) { /* remote spamd port number */
data/spamassassin-4.0.0~0.0svn1883440/spamc/qmail-spamc.c:72:16: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((val = getenv("SPAMDSSL")) != NULL) { /* use ssl for spamc/spamd */
data/spamassassin-4.0.0~0.0svn1883440/spamc/qmail-spamc.c:75:16: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((val = getenv("SPAMDLIMIT")) != NULL) { /* message size limit */
data/spamassassin-4.0.0~0.0svn1883440/spamc/qmail-spamc.c:79:16: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((val = getenv("SPAMDUSER")) != NULL) { /* spamc user configuration */
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:871:2: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(getpid() ^ (unsigned int)time(NULL));
data/spamassassin-4.0.0~0.0svn1883440/masses/evolve_metarule/evolve_metarule.c:79:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
pfile = fopen(hits_file, "r");
data/spamassassin-4.0.0~0.0svn1883440/masses/evolve_metarule/evolve_metarule.c:171:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZ];
data/spamassassin-4.0.0~0.0svn1883440/masses/evolve_metarule/evolve_metarule.c:176:17: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
assert(rfile = fopen (rules_file, "r"));
data/spamassassin-4.0.0~0.0svn1883440/masses/evolve_metarule/evolve_metarule.c:271:29: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
maximum_relevant_hits = atoi(optarg);
data/spamassassin-4.0.0~0.0svn1883440/masses/evolve_metarule/evolve_metarule.c:274:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
target_num_rules = atoi(optarg);
data/spamassassin-4.0.0~0.0svn1883440/masses/evolve_metarule/evolve_metarule.c:277:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
target_flex_rules = atoi(optarg);
data/spamassassin-4.0.0~0.0svn1883440/masses/evolve_metarule/evolve_metarule.c:286:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
population_size = atoi(optarg);
data/spamassassin-4.0.0~0.0svn1883440/masses/evolve_metarule/evolve_metarule.c:289:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
max_generations = atoi(optarg);
data/spamassassin-4.0.0~0.0svn1883440/masses/garescorer.c:203:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pop_size = atoi(optarg);
data/spamassassin-4.0.0~0.0svn1883440/masses/garescorer.c:207:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
maxiter = atoi(optarg);
data/spamassassin-4.0.0~0.0svn1883440/masses/garescorer.c:211:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
replace_num = atoi(optarg);
data/spamassassin-4.0.0~0.0svn1883440/masses/garescorer.c:999:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
scores_file = fopen("garescorer.scores","w");
data/spamassassin-4.0.0~0.0svn1883440/masses/garescorer.c:1258:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d, s, sizeof(double)*num_scores*2);
data/spamassassin-4.0.0~0.0svn1883440/masses/perceptron.c:416:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
num_epochs = atoi(optarg);
data/spamassassin-4.0.0~0.0svn1883440/masses/perceptron.c:468:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen (OUTPUT_FILE, "w");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:456:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char port[SPAMC_MAXSERV-1]; /* port, for logging */
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:460:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char host[SPAMC_MAXHOST-1]; /* hostname, for logging */
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:805:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:863:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[8196];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:994:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char is_spam[6];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:995:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s_str[21], t_str[21];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:996:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char didset_ret[15];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:997:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char didremove_ret[15];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1025:19: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
m->out_len = sprintf(m->out,
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1030:19: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
m->out_len = sprintf(m->out,
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1179:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[8192];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1184:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char versbuf[20];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1292:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "CHECK ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1294:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "REPORT_IFSPAM ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1296:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "REPORT ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1298:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "SYMBOLS ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1300:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "PING ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1302:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "HEADERS ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1304:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "PROCESS ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1313:9: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf, "\r\n");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1337:15: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf + len, "User: ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1339:15: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf + len, "\r\n");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1585:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[8192];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1590:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char versbuf[20];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1629:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "TELL ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1638:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf, "\r\n");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1642:7: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf + len, "Message-class: ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1644:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf + len, "spam\r\n");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1647:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf + len, "ham\r\n");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1654:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf + len, "Set: ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1656:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf + len, "local");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1663:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf + len, "remote");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1665:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf + len, "\r\n");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1671:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf + len, "Remove: ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1673:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf + len, "local");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1680:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf + len, "remote");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1682:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf + len, "\r\n");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1691:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf + len, "User: ");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1693:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf + len, "\r\n");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1700:12: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
len += sprintf(buf + len, "Content-length: %d\r\n\r\n", (int) m->msg_len);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1703:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf2[1024];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1912:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char port[6];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:2110:17: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&tp->hosts[tp->nhosts], *addrp, hp->h_length);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:2221:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[LOG_BUFSIZ+1];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:2268:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char inputstr[99], cmpbuf1[99], cmpbuf2[99];
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:2272:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(inputstr, "%f", input);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:2279:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(cmpbuf1, "%f", input);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:2280:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(cmpbuf2, "%f", output);
data/spamassassin-4.0.0~0.0svn1883440/spamc/qmail-spamc.c:40:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *options[MAXOPTS];
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:344:46: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ptrn->port = (unsigned short)atoi(spamc_optarg);
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:364:29: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*max_size = atoi(spamc_optarg);
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:381:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
timeout = atoi(spamc_optarg);
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:389:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
connect_timeout = atoi(spamc_optarg);
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:502:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ptrn->connect_retries = atoi(spamc_optarg);
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:507:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ptrn->retry_sleep = atoi(spamc_optarg);
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:517:40: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ptrn->filter_retries = atoi(spamc_optarg);
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:522:44: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ptrn->filter_retry_sleep = atoi(spamc_optarg);
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:583:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char option[CONFIG_MAX_LINE_SIZE];
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:593:19: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((config = fopen(config_file, "r")) == NULL) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:804:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *combo_argv[COMBO_ARGV_SIZE];
data/spamassassin-4.0.0~0.0svn1883440/spamc/getopt.c:245:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
longoptlen = strlen(longopt) - 2;
data/spamassassin-4.0.0~0.0svn1883440/spamc/getopt.c:252:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
longoptlen -= strlen(bp);
data/spamassassin-4.0.0~0.0svn1883440/spamc/getopt.c:261:75: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(((strncmp(longopt+2, longopts[i].name, longoptlen)) == 0) && (strlen(longopts[i].name) == longoptlen)) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:407:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(addrbuf.sun_path, tp->socketpath, sizeof addrbuf.sun_path - 1);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:549:13: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (host, ipaddr, sizeof(host) - 1);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1006:9: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
if (sscanf(buf, "Spam: %5s ; %20s / %20s", is_spam, s_str, t_str) == 3) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1044:14: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
else if (sscanf(buf, "DidSet: %14s", didset_ret) == 1) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1052:14: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
else if (sscanf(buf, "DidRemove: %14s", didremove_ret) == 1) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1171:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (m->out + m->out_len, bodystart, towrite);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1306:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(buf);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1307:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (len + strlen(PROTOCOL_VERSION) + 2 >= bufsiz) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1314:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(buf);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1330:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(username) + 8 >= (bufsiz - len)) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1340:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(buf + len);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1410:9: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
if (sscanf(buf, "SPAMD/%18s %d %*s", versbuf, &response) != 2) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1631:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(buf);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1632:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (len + strlen(PROTOCOL_VERSION) + 2 >= bufsiz) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1639:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(buf);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1649:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(buf + len);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1661:4: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(buf + len, ",");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1666:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(buf + len);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1678:4: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(buf + len, ",");
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1683:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(buf + len);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1687:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(username) + 8 >= (bufsiz - len)) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1694:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(buf + len);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1705:7: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(buf, buf2, bufsiz - len);
data/spamassassin-4.0.0~0.0svn1883440/spamc/libspamc.c:1749:9: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
if (sscanf(buf, "SPAMD/%18s %d %*s", versbuf, &response) != 2) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:604:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int option_l = strlen(option);
data/spamassassin-4.0.0~0.0svn1883440/spamc/spamc.c:626:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(i=strlen(tok); i>0; i--) {
data/spamassassin-4.0.0~0.0svn1883440/spamc/utils.c:114:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
nred = (int)read(fd, buf, nbytes);
ANALYSIS SUMMARY:
Hits = 134
Lines analyzed = 6772 in approximately 0.38 seconds (17772 lines/second)
Physical Source Lines of Code (SLOC) = 5007
Hits@level = [0] 88 [1] 30 [2] 75 [3] 15 [4] 14 [5] 0
Hits@level+ = [0+] 222 [1+] 134 [2+] 104 [3+] 29 [4+] 14 [5+] 0
Hits/KSLOC@level+ = [0+] 44.3379 [1+] 26.7625 [2+] 20.7709 [3+] 5.79189 [4+] 2.79609 [5+] 0
Symlinks skipped = 1 (--allowlink overrides but see doc for security issue)
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.