Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/spice-gtk-0.38/src/bio-gio.c Examining data/spice-gtk-0.38/src/bio-gio.h Examining data/spice-gtk-0.38/src/cd-scsi-dev-params.h Examining data/spice-gtk-0.38/src/cd-scsi.c Examining data/spice-gtk-0.38/src/cd-scsi.h Examining data/spice-gtk-0.38/src/cd-usb-bulk-msd.c Examining data/spice-gtk-0.38/src/cd-usb-bulk-msd.h Examining data/spice-gtk-0.38/src/channel-base.c Examining data/spice-gtk-0.38/src/channel-cursor.c Examining data/spice-gtk-0.38/src/channel-cursor.h Examining data/spice-gtk-0.38/src/channel-display-gst.c Examining data/spice-gtk-0.38/src/channel-display-mjpeg.c Examining data/spice-gtk-0.38/src/channel-display-priv.h Examining data/spice-gtk-0.38/src/channel-display.c Examining data/spice-gtk-0.38/src/channel-display.h Examining data/spice-gtk-0.38/src/channel-inputs.c Examining data/spice-gtk-0.38/src/channel-inputs.h Examining data/spice-gtk-0.38/src/channel-main.c Examining data/spice-gtk-0.38/src/channel-main.h Examining data/spice-gtk-0.38/src/channel-playback-priv.h Examining data/spice-gtk-0.38/src/channel-playback.c Examining data/spice-gtk-0.38/src/channel-playback.h Examining data/spice-gtk-0.38/src/channel-port.c Examining data/spice-gtk-0.38/src/channel-port.h Examining data/spice-gtk-0.38/src/channel-record.c Examining data/spice-gtk-0.38/src/channel-record.h Examining data/spice-gtk-0.38/src/channel-smartcard.c Examining data/spice-gtk-0.38/src/channel-smartcard.h Examining data/spice-gtk-0.38/src/channel-usbredir-priv.h Examining data/spice-gtk-0.38/src/channel-usbredir.c Examining data/spice-gtk-0.38/src/channel-usbredir.h Examining data/spice-gtk-0.38/src/channel-webdav.c Examining data/spice-gtk-0.38/src/channel-webdav.h Examining data/spice-gtk-0.38/src/client_sw_canvas.c Examining data/spice-gtk-0.38/src/client_sw_canvas.h Examining data/spice-gtk-0.38/src/continuation.c Examining data/spice-gtk-0.38/src/continuation.h Examining data/spice-gtk-0.38/src/coroutine.h Examining data/spice-gtk-0.38/src/coroutine_gthread.c Examining data/spice-gtk-0.38/src/coroutine_ucontext.c Examining data/spice-gtk-0.38/src/coroutine_winfibers.c Examining data/spice-gtk-0.38/src/decode-glz-tmpl.c Examining data/spice-gtk-0.38/src/decode-glz.c Examining data/spice-gtk-0.38/src/decode-jpeg.c Examining data/spice-gtk-0.38/src/decode-zlib.c Examining data/spice-gtk-0.38/src/decode.h Examining data/spice-gtk-0.38/src/desktop-integration.c Examining data/spice-gtk-0.38/src/desktop-integration.h Examining data/spice-gtk-0.38/src/gio-coroutine.c Examining data/spice-gtk-0.38/src/gio-coroutine.h Examining data/spice-gtk-0.38/src/giopipe.c Examining data/spice-gtk-0.38/src/giopipe.h Examining data/spice-gtk-0.38/src/qmp-port.c Examining data/spice-gtk-0.38/src/qmp-port.h Examining data/spice-gtk-0.38/src/scsi-constants.h Examining data/spice-gtk-0.38/src/smartcard-manager-priv.h Examining data/spice-gtk-0.38/src/smartcard-manager.c Examining data/spice-gtk-0.38/src/smartcard-manager.h Examining data/spice-gtk-0.38/src/spice-audio-priv.h Examining data/spice-gtk-0.38/src/spice-audio.c Examining data/spice-gtk-0.38/src/spice-audio.h Examining data/spice-gtk-0.38/src/spice-channel-cache.h Examining data/spice-gtk-0.38/src/spice-channel-priv.h Examining data/spice-gtk-0.38/src/spice-channel.c Examining data/spice-gtk-0.38/src/spice-channel.h Examining data/spice-gtk-0.38/src/spice-client-glib-usb-acl-helper.c Examining data/spice-gtk-0.38/src/spice-client-gtk.h Examining data/spice-gtk-0.38/src/spice-client.c Examining data/spice-gtk-0.38/src/spice-client.h Examining data/spice-gtk-0.38/src/spice-common.h Examining data/spice-gtk-0.38/src/spice-file-transfer-task-priv.h Examining data/spice-gtk-0.38/src/spice-file-transfer-task.c Examining data/spice-gtk-0.38/src/spice-file-transfer-task.h Examining data/spice-gtk-0.38/src/spice-glib-main.c Examining data/spice-gtk-0.38/src/spice-grabsequence-priv.h Examining data/spice-gtk-0.38/src/spice-grabsequence.c Examining data/spice-gtk-0.38/src/spice-grabsequence.h Examining data/spice-gtk-0.38/src/spice-gstaudio.c Examining data/spice-gtk-0.38/src/spice-gstaudio.h Examining data/spice-gtk-0.38/src/spice-gtk-session-priv.h Examining data/spice-gtk-0.38/src/spice-gtk-session.c Examining data/spice-gtk-0.38/src/spice-gtk-session.h Examining data/spice-gtk-0.38/src/spice-option.c Examining data/spice-gtk-0.38/src/spice-option.h Examining data/spice-gtk-0.38/src/spice-pulse.c Examining data/spice-gtk-0.38/src/spice-pulse.h Examining data/spice-gtk-0.38/src/spice-session-priv.h Examining data/spice-gtk-0.38/src/spice-session.c Examining data/spice-gtk-0.38/src/spice-session.h Examining data/spice-gtk-0.38/src/spice-types.h Examining data/spice-gtk-0.38/src/spice-uri-priv.h Examining data/spice-gtk-0.38/src/spice-uri.c Examining data/spice-gtk-0.38/src/spice-uri.h Examining data/spice-gtk-0.38/src/spice-util-priv.h Examining data/spice-gtk-0.38/src/spice-util.c Examining data/spice-gtk-0.38/src/spice-util.h Examining data/spice-gtk-0.38/src/spice-widget-cairo.c Examining data/spice-gtk-0.38/src/spice-widget-egl.c Examining data/spice-gtk-0.38/src/spice-widget-priv.h Examining data/spice-gtk-0.38/src/spice-widget.c Examining data/spice-gtk-0.38/src/spice-widget.h Examining data/spice-gtk-0.38/src/usb-acl-helper.c Examining data/spice-gtk-0.38/src/usb-acl-helper.h Examining data/spice-gtk-0.38/src/usb-backend.c Examining data/spice-gtk-0.38/src/usb-backend.h Examining data/spice-gtk-0.38/src/usb-device-cd.c Examining data/spice-gtk-0.38/src/usb-device-cd.h Examining data/spice-gtk-0.38/src/usb-device-manager-priv.h Examining data/spice-gtk-0.38/src/usb-device-manager.c Examining data/spice-gtk-0.38/src/usb-device-manager.h Examining data/spice-gtk-0.38/src/usb-device-widget.c Examining data/spice-gtk-0.38/src/usb-device-widget.h Examining data/spice-gtk-0.38/src/usb-emulation.h Examining data/spice-gtk-0.38/src/usbdk_api.c Examining data/spice-gtk-0.38/src/usbdk_api.h Examining data/spice-gtk-0.38/src/usbutil.c Examining data/spice-gtk-0.38/src/usbutil.h Examining data/spice-gtk-0.38/src/vmcstream.c Examining data/spice-gtk-0.38/src/vmcstream.h Examining data/spice-gtk-0.38/src/vncdisplaykeymap.c Examining data/spice-gtk-0.38/src/vncdisplaykeymap.h Examining data/spice-gtk-0.38/subprojects/keycodemapdb/tests/stdc++.cc Examining data/spice-gtk-0.38/subprojects/keycodemapdb/tests/stdc.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/agent_interface.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/agent_interface.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/backtrace.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/backtrace.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/canvas_utils.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/canvas_utils.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/client_marshallers.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/demarshallers.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/draw.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/lines.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/lines.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/log.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/log.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/lz.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/lz.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/lz_common.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/lz_compress_tmpl.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/lz_config.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/lz_decompress_tmpl.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/macros.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/marshaller.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/marshaller.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/mem.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/mem.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/messages.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/pixman_utils.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/pixman_utils.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/quic.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/quic.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/quic_config.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/quic_family_tmpl.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/quic_tmpl.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/alt_drand48.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/crash_test.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/hanoi_test.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_alloca.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_clearenv.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_drand48.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_egl.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_gdk_event_get_scancode.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_getpeereid.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_glob.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_gstaudio.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_gstvideo.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_int64.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_longlong.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_mingw_aligned_malloc.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_polkit_authority_get_sync.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_polkit_authorization_result_get_dismissed.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_posix_memalign.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_pulse.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_sasl.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_sbrk.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_setlinebuf.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_sigaction.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_strtok_r.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_struct_sigaction.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_struct_stat.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_uchar.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_uint.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_ulong.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_ushort.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/example/hello.cpp Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/example/lib1/lib1.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/example/lib2/lib2.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/example/log-name.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/example/world.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_ring.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_ring.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_test.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/scope/recorder_scope.cpp Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/scope/recorder_slider.cpp Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/scope/recorder_slider.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/scope/recorder_view.cpp Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder/scope/recorder_view.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/recorder.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/rect.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/region.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/region.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/ring.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/rop3.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/rop3.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/snd_codec.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/snd_codec.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/ssl_verify.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/ssl_verify.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/sw_canvas.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/sw_canvas.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/utils.c Examining data/spice-gtk-0.38/subprojects/spice-common/common/utils.h Examining data/spice-gtk-0.38/subprojects/spice-common/common/verify.h Examining data/spice-gtk-0.38/subprojects/spice-common/tests/test-dummy-recorder.c Examining data/spice-gtk-0.38/subprojects/spice-common/tests/test-logging.c Examining data/spice-gtk-0.38/subprojects/spice-common/tests/test-marshallers.c Examining data/spice-gtk-0.38/subprojects/spice-common/tests/test-marshallers.h Examining data/spice-gtk-0.38/subprojects/spice-common/tests/test-quic.c Examining data/spice-gtk-0.38/subprojects/spice-common/tests/test-region.c Examining data/spice-gtk-0.38/subprojects/spice-common/tests/test-ssl-verify.c Examining data/spice-gtk-0.38/subprojects/spice-common/tests/test-utils.c Examining data/spice-gtk-0.38/tests/cd-emu.c Examining data/spice-gtk-0.38/tests/coroutine.c Examining data/spice-gtk-0.38/tests/file-transfer.c Examining data/spice-gtk-0.38/tests/mock-acl-helper.c Examining data/spice-gtk-0.38/tests/pipe.c Examining data/spice-gtk-0.38/tests/session.c Examining data/spice-gtk-0.38/tests/uri.c Examining data/spice-gtk-0.38/tests/usb-acl-helper.c Examining data/spice-gtk-0.38/tests/util.c Examining data/spice-gtk-0.38/tools/spice-cmdline.c Examining data/spice-gtk-0.38/tools/spice-cmdline.h Examining data/spice-gtk-0.38/tools/spicy-connect.c Examining data/spice-gtk-0.38/tools/spicy-connect.h Examining data/spice-gtk-0.38/tools/spicy-screenshot.c Examining data/spice-gtk-0.38/tools/spicy-stats.c Examining data/spice-gtk-0.38/tools/spicy.c FINAL RESULTS: data/spice-gtk-0.38/src/spice-client-glib-usb-acl-helper.c:41:9: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. fprintf(stdout, "Error " __VA_ARGS__); \ data/spice-gtk-0.38/src/spice-client-glib-usb-acl-helper.c:42:9: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. fprintf(stderr, "spice-client-glib-usb-helper: Error " __VA_ARGS__); \ data/spice-gtk-0.38/src/spice-client-glib-usb-acl-helper.c:49:9: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. fprintf(stdout, __VA_ARGS__); \ data/spice-gtk-0.38/subprojects/spice-common/common/agent_interface.c:382:5: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vfprintf(dest, entry->format, args); data/spice-gtk-0.38/subprojects/spice-common/common/agent_interface.h:371:60: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. #define RECORD_X(Name, Format, ...) RECORD_TOO_MANY_ARGS(printf(Format, __VA_ARGS__)) data/spice-gtk-0.38/subprojects/spice-common/common/backtrace.c:84:9: [4] (shell) execle: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execle(GSTACK_PATH, "gstack", parent, NULL, NULL); data/spice-gtk-0.38/subprojects/spice-common/common/backtrace.c:126:10: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (!access(GSTACK_PATH, X_OK)) { data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:1773:5: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(usr_data->message_buf, sizeof(usr_data->message_buf), fmt, ap); data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:1785:5: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(usr_data->message_buf, sizeof(usr_data->message_buf), fmt, ap); data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:1805:5: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(usr_data->message_buf, sizeof(usr_data->message_buf), fmt, ap); data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:1816:5: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(usr_data->message_buf, sizeof(usr_data->message_buf), fmt, ap); data/spice-gtk-0.38/subprojects/spice-common/common/macros.h:28:27: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. __attribute__((format(printf,a,b))) data/spice-gtk-0.38/subprojects/spice-common/common/recorder.h:66:53: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. if (sizeof((spice_recorder_ ## rec).dummy)) printf(format, ##__VA_ARGS__); \ data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:716:28: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. dst += snprintf(dst, dst_end - dst, data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:720:28: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. dst += snprintf(dst, dst_end - dst, data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:724:28: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. dst += snprintf(dst, dst_end - dst, data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:737:28: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. dst += snprintf(dst, dst_end - dst, data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:741:28: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. dst += snprintf(dst, dst_end - dst, data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:745:28: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. dst += snprintf(dst, dst_end - dst, data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:819:11: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. # define snprintf _snprintf data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:819:21: [4] (format) _snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. # define snprintf _snprintf data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:838:5: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. snprintf(dst, dst_end >= dst ? dst_end - dst : 0, __VA_ARGS__) data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2235:13: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(chan_name, "%s/%s", rec->name, name); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.h:549:60: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. #define RECORD_X(Name, Format, ...) RECORD_TOO_MANY_ARGS(printf(Format, __VA_ARGS__)) data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.h:698:65: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. #define RECORD_FAST_X(Name, Format, ...) RECORD_TOO_MANY_ARGS(printf(Format, __VA_ARGS__)) data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_test.c:78:9: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. snprintf(buf, sizeof(buf), __VA_ARGS__); \ data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_test.c:90:9: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. snprintf(buf, sizeof(buf), __VA_ARGS__); \ data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:125:19: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. int len = snprintf(buf, sizeof(buf), \ data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:130:16: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. len += snprintf(buf + len, sizeof(buf) - len, __VA_ARGS__); \ data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:140:19: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. int len = snprintf(buf, sizeof(buf), \ data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:147:16: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. len += snprintf(buf + len, sizeof(buf) - len, __VA_ARGS__); \ data/spice-gtk-0.38/src/spice-option.c:244:23: [3] (buffer) g_get_home_dir: This function is synonymous with 'getenv("HOME")';it returns untrustable input if the environment can beset by an attacker. It can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. homedir = g_get_home_dir(); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/alt_drand48.h:45:15: [3] (random) drand48: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. static double drand48(void) data/spice-gtk-0.38/subprojects/spice-common/common/recorder/make-it-quick/config/check_drand48.c:41:21: [3] (random) drand48: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. double result = drand48(); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1972:24: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. recorder_trace_set(getenv("RECORDER_TRACES")); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1973:24: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. recorder_trace_set(getenv("RECORDER_TWEAKS")); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1975:32: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const char *dump_pattern = getenv("RECORDER_DUMP"); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2136:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const char *result = getenv("RECORDER_SHARE"); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_test.c:102:31: [3] (random) drand48: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. tm.tv_nsec = (minimumMs + drand48() * deltaMs) * 1000000; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_test.c:129:47: [3] (random) drand48: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. (RECORDER_TWEAK(sleep_time) + drand48()*RECORDER_TWEAK(sleep_time_delta)); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_test.c:260:9: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("KEEP_RUNNING")) data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_test.c:270:36: [3] (random) drand48: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. (unsigned) (k * drand48()), data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:173:48: [3] (random) drand48: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. tm.tv_nsec = + minimumMs * (1000 * 1000 + drand48() * 2000000); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:242:21: [3] (random) drand48: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. int index = drand48() * numberOfTests; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/scope/recorder_view.cpp:121:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. bool hasGL = getenv ("RECORDER_NOGL") == NULL; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/scope/recorder_view.cpp:516:22: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. bool hasGL = getenv ("RECORDER_NOGL") == NULL; data/spice-gtk-0.38/subprojects/spice-common/tests/test-quic.c:346:47: [3] (random) g_random_boolean: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. gboolean has_alpha = alpha >= 0 ? alpha : g_random_boolean(); data/spice-gtk-0.38/subprojects/spice-common/tests/test-quic.c:347:18: [3] (random) g_random_int_range: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. gint width = g_random_int_range(100, 2000); data/spice-gtk-0.38/subprojects/spice-common/tests/test-quic.c:348:19: [3] (random) g_random_int_range: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. gint height = g_random_int_range(100, 500); data/spice-gtk-0.38/subprojects/spice-common/tests/test-quic.c:357:21: [3] (random) g_random_int_range: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. pixels[i] = g_random_int_range(0, 256); data/spice-gtk-0.38/src/cd-scsi.c:736:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buf, str, len); data/spice-gtk-0.38/src/cd-scsi.c:864:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(req->buf, dev->fixed_sense, sizeof(dev->fixed_sense)); data/spice-gtk-0.38/src/cd-scsi.c:966:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(outbuf+buflen, dev->serial, serial_len); data/spice-gtk-0.38/src/cd-scsi.c:988:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(outbuf+buflen, dev->serial, serial_len); data/spice-gtk-0.38/src/cd-scsi.c:1075:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&outbuf[32], dev->version, MIN(4, strlen(dev->version))); data/spice-gtk-0.38/src/cd-usb-bulk-msd.c:303:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(scsi_req->cdb, cbw->cmd, scsi_req->cdb_len); data/spice-gtk-0.38/src/channel-cursor.c:428:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(cursor->data, data, size); data/spice-gtk-0.38/src/channel-cursor.c:431:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(cursor->data, data, size); data/spice-gtk-0.38/src/channel-main.c:270:16: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). return atoi(g_getenv("SPICE_MAX_CLIPBOARD")); data/spice-gtk-0.38/src/channel-main.c:998:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(payload, &msg, sizeof(VDAgentMessage)); data/spice-gtk-0.38/src/channel-main.c:1016:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(payload, d, mins); data/spice-gtk-0.38/src/channel-main.c:1209:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(avs->volume, volume, array_size); data/spice-gtk-0.38/src/channel-main.c:1265:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(avs->volume, volume, array_size); data/spice-gtk-0.38/src/channel-main.c:2128:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((uint8_t*)&c->agent_msg + c->agent_msg_pos, *msg_pos, n); data/spice-gtk-0.38/src/channel-main.c:2142:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(c->agent_msg_data + c->agent_msg_pos - sizeof(VDAgentMessage), *msg_pos, n); data/spice-gtk-0.38/src/channel-main.c:2308:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char host[0]; data/spice-gtk-0.38/src/channel-playback.c:408:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(c->volume, vol->volume, sizeof(guint16) * c->nchannels); data/spice-gtk-0.38/src/channel-record.c:367:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(rc->last_frame + rc->last_frame_current, data, n); data/spice-gtk-0.38/src/channel-record.c:383:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(rc->last_frame, data, n); data/spice-gtk-0.38/src/channel-record.c:470:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(c->volume, vol->volume, sizeof(guint16) * c->nchannels); data/spice-gtk-0.38/src/giopipe.c:118:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buffer, self->peer->buffer, count); data/spice-gtk-0.38/src/spice-channel-priv.h:117:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[16]; data/spice-gtk-0.38/src/spice-channel.c:927:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char control[CMSG_SPACE(sizeof(int))]; data/spice-gtk-0.38/src/spice-channel.c:952:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(msgfd, CMSG_DATA(cmsg), sizeof(int)); data/spice-gtk-0.38/src/spice-channel.c:1088:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char encoded[8192]; /* should stay lower than maxbufsize */ data/spice-gtk-0.38/src/spice-channel.c:1112:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data, c->sasl_decoded + c->sasl_decoded_offset, len); data/spice-gtk-0.38/src/spice-channel.c:1349:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p, &c->link_hdr, sizeof(c->link_hdr)); data/spice-gtk-0.38/src/spice-channel.c:1352:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p, &link_msg, sizeof(link_msg)); data/spice-gtk-0.38/src/spice-channel.c:1893:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(caps, caps_src, ncaps * sizeof(uint32_t)); data/spice-gtk-0.38/src/spice-client-glib-usb-acl-helper.c:62:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char path[PATH_MAX]; data/spice-gtk-0.38/src/spice-grabsequence.c:63:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(sequence->keysyms, keysyms, sizeof(guint)*nkeysyms); data/spice-gtk-0.38/src/spice-grabsequence.c:121:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(sequence->keysyms, srcSequence->keysyms, data/spice-gtk-0.38/src/usb-backend.c:639:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data, ch->read_buf, count); data/spice-gtk-0.38/src/usb-device-cd.c:112:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int fd = open(unit->filename, O_RDONLY | O_NONBLOCK); data/spice-gtk-0.38/src/usb-device-cd.c:147:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int fd = open(unit->filename, O_RDONLY | O_NONBLOCK); data/spice-gtk-0.38/src/usb-device-cd.c:173:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int fd = open(unit->filename, O_RDONLY | O_NONBLOCK); data/spice-gtk-0.38/src/usbutil.c:46:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[PRODUCT_NAME_LEN]; data/spice-gtk-0.38/src/usbutil.c:53:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[VENDOR_NAME_LEN]; data/spice-gtk-0.38/src/usbutil.c:67:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename[256]; data/spice-gtk-0.38/src/vmcstream.c:146:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(self->buffer + self->pos, data, min); data/spice-gtk-0.38/subprojects/spice-common/common/agent_interface.c:151:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char msg_in[128]; data/spice-gtk-0.38/subprojects/spice-common/common/agent_interface.h:187:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char dummy[0]; data/spice-gtk-0.38/subprojects/spice-common/common/backtrace.c:76:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char parent[16]; data/spice-gtk-0.38/subprojects/spice-common/common/backtrace.c:88:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char btline[256]; data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:109:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char message_buf[512]; data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:121:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char message_buf[512]; data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:451:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char file_str[200]; data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:455:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(file_str, "c:\\tmp\\spice_dump\\%u.jpg", id); data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:457:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(file_str, "/tmp/spice_dump/%u.jpg", id); data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:460:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *f = fopen(file_str, "wb"); data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:933:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char file_str[200]; data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:937:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(file_str, "c:\\tmp\\spice_dump\\%u.%ubpp", id, bitmap->format); data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:939:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(file_str, "/tmp/spice_dump/%u.%ubpp", id, bitmap->format); data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:941:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *f = fopen(file_str, "wb"); data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:1017:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char file_str[200]; data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:1031:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(file_str, "c:\\tmp\\spice_dump\\%d\\%u.ppm", cache, id); data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:1033:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(file_str, "/tmp/spice_dump/%u.ppm", id); data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:1035:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *f = fopen(file_str, "wb"); data/spice-gtk-0.38/subprojects/spice-common/common/canvas_base.c:1454:17: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest_line, src_line, line_size); data/spice-gtk-0.38/subprojects/spice-common/common/marshaller.c:257:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m->items, m->static_items, sizeof(MarshallerItem) * m->n_items); data/spice-gtk-0.38/subprojects/spice-common/common/marshaller.c:379:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(ptr, data, size); data/spice-gtk-0.38/subprojects/spice-common/common/marshaller.c:485:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p, item->data + skip_bytes, item->len - skip_bytes); data/spice-gtk-0.38/subprojects/spice-common/common/mem.c:54:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(copy, str, len); data/spice-gtk-0.38/subprojects/spice-common/common/mem.c:81:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(copy, mem, n_bytes); data/spice-gtk-0.38/subprojects/spice-common/common/mem.c:225:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p, chunks->chunk[i].data, data/spice-gtk-0.38/subprojects/spice-common/common/mem.c:276:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buffer->buffer + buffer->offset, data, len); data/spice-gtk-0.38/subprojects/spice-common/common/mem.c:283:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest, buffer->buffer, len); data/spice-gtk-0.38/subprojects/spice-common/common/pixman_utils.c:620:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(byte_line, src_line, byte_width); data/spice-gtk-0.38/subprojects/spice-common/common/pixman_utils.c:850:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest, src, width * bpp); data/spice-gtk-0.38/subprojects/spice-common/common/pixman_utils.c:864:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest, src, width * bpp); data/spice-gtk-0.38/subprojects/spice-common/common/pixman_utils.c:1074:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest, src, width * 4); data/spice-gtk-0.38/subprojects/spice-common/common/pixman_utils.c:1084:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest, src, width); data/spice-gtk-0.38/subprojects/spice-common/common/pixman_utils.c:1123:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest, src, width * 2); data/spice-gtk-0.38/subprojects/spice-common/common/pixman_utils.c:1153:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(local_ents, ents, n_ents*4); data/spice-gtk-0.38/subprojects/spice-common/common/pixman_utils.c:1199:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(local_ents, ents, n_ents*4); data/spice-gtk-0.38/subprojects/spice-common/common/pixman_utils.c:1245:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(local_ents, ents, n_ents*4); data/spice-gtk-0.38/subprojects/spice-common/common/pixman_utils.c:1295:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(local_ents, ents, n_ents*4); data/spice-gtk-0.38/subprojects/spice-common/common/recorder.h:44:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char dummy[0]; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/hanoi_test.c:99:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). int count = atoi(argv[i]); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:554:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[256]; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:555:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char format_buffer[32]; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:833:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[256]; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1066:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char commands_buffer[RECORDER_CMD_LEN]; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1167:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int fd = open(file, O_RDWR|O_CREAT|O_TRUNC, (mode_t) 0600); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1331:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(base + name_offs, name, name_len + 1); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1332:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(base + descr_offs, description, descr_len + 1); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1333:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(base + unit_offs, unit, unit_len + 1); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1447:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int fd = open(file, O_RDWR); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2157:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[RECORDER_CMD_LEN]; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2265:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[128]; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2296:17: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buffer, param, len); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2302:17: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(alloc, param, len); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2322:21: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buffer, param, len); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2328:21: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(alloc, param, len); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2420:24: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char error[128]; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2494:27: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *f = fopen(value_ptr, mode); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_ring.c:201:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(ptr, data + idx * item_size, byte_count); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_ring.c:264:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data + idx * item_size, ptr, byte_count); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_test.c:77:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; \ data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_test.c:89:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; \ data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_test.c:170:34: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). unsigned count = argc >= 2 ? atoi(argv[1]) : 16; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder_test.c:171:36: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). unsigned howLong = argc >= 3 ? atoi(argv[2]) : 1; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:124:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; \ data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:139:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; \ data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:301:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:398:32: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). int i, count = argc >= 2 ? atoi(argv[1]) : 16; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:410:36: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). unsigned howLong = argc >= 3 ? atoi(argv[2]) : 1; data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:536:10: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(ptrs[i % 256], ptrs[(i+1) % 256], 512)); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:540:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *f = fopen("test.out", "w"); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:544:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen("test.out", "w"); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/scope/recorder_view.cpp:537:19: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *f = fopen(cname.data(), "w"); data/spice-gtk-0.38/subprojects/spice-common/common/ssl_verify.c:430:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/spice-gtk-0.38/subprojects/spice-common/common/sw_canvas.c:1158:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest, src, (area->right - area->left) * bpp); data/spice-gtk-0.38/tests/cd-emu.c:298:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *f = fopen(TEST_CD_ISO_FILE, "wb"); data/spice-gtk-0.38/tests/cd-emu.c:301:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy((char*) sector, "sector 0"); data/spice-gtk-0.38/tools/spicy-screenshot.c:58:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen(outf,"wb"); data/spice-gtk-0.38/tools/spicy.c:1060:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char title[32]; data/spice-gtk-0.38/tools/spicy.c:1199:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char notify[64]; data/spice-gtk-0.38/tools/spicy.c:1299:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char password[64]; data/spice-gtk-0.38/tools/spicy.c:1534:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[4096]; data/spice-gtk-0.38/src/bio-gio.c:150:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). n = strlen(str); data/spice-gtk-0.38/src/cd-scsi.c:962:22: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). serial_len = strlen(dev->serial); data/spice-gtk-0.38/src/cd-scsi.c:976:26: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int serial_len = strlen(dev->serial); data/spice-gtk-0.38/src/cd-scsi.c:1075:46: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). memcpy(&outbuf[32], dev->version, MIN(4, strlen(dev->version))); data/spice-gtk-0.38/src/channel-main.c:2336:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen((const char*)info->cert_subject_data) == 0) { data/spice-gtk-0.38/src/channel-main.c:2341:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(subject, (const char*)info->cert_subject_data, info->cert_subject_size); data/spice-gtk-0.38/src/channel-smartcard.c:387:55: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). (uint8_t*)reader_name, strlen(reader_name), TRUE); data/spice-gtk-0.38/src/giopipe.c:40:12: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). gssize read; data/spice-gtk-0.38/src/giopipe.c:309:15: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if (peer->read < 0) { data/spice-gtk-0.38/src/giopipe.c:315:20: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). g_assert(peer->read <= self->count); data/spice-gtk-0.38/src/giopipe.c:316:19: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). count = peer->read; data/spice-gtk-0.38/src/giopipe.c:423:73: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). writable = self->buffer == NULL || self->peer_closed || self->peer->read >= 0; data/spice-gtk-0.38/src/spice-channel.c:119:5: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(c->name, "?"); data/spice-gtk-0.38/src/spice-channel.c:1238:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(password) > SPICE_MAX_PASSWORD_LENGTH) { data/spice-gtk-0.38/src/spice-channel.c:1243:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). rc = RSA_public_encrypt(strlen(password) + 1, (uint8_t*)password, data/spice-gtk-0.38/src/spice-channel.c:1475:43: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). interact[ninteract].len = strlen(interact[ninteract].result); data/spice-gtk-0.38/src/spice-channel.c:1489:39: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). interact[ninteract].len = strlen(interact[ninteract].result); data/spice-gtk-0.38/src/spice-channel.c:1703:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(mechname); data/spice-gtk-0.38/src/spice-gtk-session.c:741:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). size = strlen(conv); data/spice-gtk-0.38/src/spice-gtk-session.c:933:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). *len = strlen(conv); data/spice-gtk-0.38/src/spice-gtk-session.c:942:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). *len = strlen(text); data/spice-gtk-0.38/src/spice-gtk-session.c:971:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(text); data/spice-gtk-0.38/src/spice-session.c:435:22: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). path = uri + strlen(URI_SCHEME_SPICE_UNIX); data/spice-gtk-0.38/src/spice-session.c:443:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). authority = uri + strlen(URI_SCHEME_SPICE); data/spice-gtk-0.38/src/spice-session.c:445:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). authority = uri + strlen(URI_SCHEME_SPICE_TLS); data/spice-gtk-0.38/src/spice-uri.c:132:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). uri += strlen(uri_scheme) + 3; /* scheme + "://" */ data/spice-gtk-0.38/src/spice-uri.c:144:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(uri); data/spice-gtk-0.38/src/spice-uri.c:173:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). } else if (strlen(uriv[1]) > 0) { /* invalid string after the hostname */ data/spice-gtk-0.38/src/spice-uri.c:185:28: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (uriv[0] == NULL || strlen(uriv[0]) == 0) { data/spice-gtk-0.38/src/spice-util.c:295:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). nl = strlen(endl); data/spice-gtk-0.38/src/spice-util.c:321:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(str); data/spice-gtk-0.38/src/usb-acl-helper.c:105:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). string[strlen(string) - 1] = 0; data/spice-gtk-0.38/src/usbutil.c:81:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). contents[strlen(contents) - 1] = '\0'; data/spice-gtk-0.38/src/usbutil.c:269:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(*product) > strlen(*manufacturer)) { data/spice-gtk-0.38/src/usbutil.c:269:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(*product) > strlen(*manufacturer)) { data/spice-gtk-0.38/src/usbutil.c:270:42: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). gchar *tmp = g_strdup(*product + strlen(*manufacturer)); data/spice-gtk-0.38/src/vncdisplaykeymap.c:108:41: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). #define STRPREFIX(a,b) (strncmp((a),(b),strlen((b))) == 0) data/spice-gtk-0.38/subprojects/spice-common/common/agent_interface.c:87:13: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if (read(socket, &enable, sizeof(enable)) != sizeof(enable)) { data/spice-gtk-0.38/subprojects/spice-common/common/agent_interface.c:157:18: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). int nbytes = read(socket, msg_in + len, 1); data/spice-gtk-0.38/subprojects/spice-common/common/backtrace.c:96:25: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). bytesread = read(pipefd[0], btline, sizeof(btline) - 1); data/spice-gtk-0.38/subprojects/spice-common/common/macros.h:43:33: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). __pragma(section(".CRT$XCU",read)) \ data/spice-gtk-0.38/subprojects/spice-common/common/macros.h:49:33: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). __pragma(section(".CRT$XPU",read)) \ data/spice-gtk-0.38/subprojects/spice-common/common/mem.c:52:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(str) + 1; data/spice-gtk-0.38/subprojects/spice-common/common/mem.c:67:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(copy, str, n_bytes); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1278:38: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). size_t name_len = strlen(name); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1279:38: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). size_t descr_len = strlen(description); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1280:38: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). size_t unit_len = strlen(unit); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:1569:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). size_t len = strlen(message); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2234:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). chan_name = malloc(strlen(rec->name) + strlen(name) + 2); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2234:52: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). chan_name = malloc(strlen(rec->name) + strlen(name) + 2); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/recorder.c:2310:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(param); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:244:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen(str); data/spice-gtk-0.38/subprojects/spice-common/common/recorder/ring_test.c:350:28: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). unsigned testLen = strlen(test); data/spice-gtk-0.38/subprojects/spice-common/common/region.c:516:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). (int)strlen(prefix), "", data/spice-gtk-0.38/subprojects/spice-common/common/ssl_verify.c:292:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). key = (char*)alloca(strlen(subject)+1); data/spice-gtk-0.38/tests/file-transfer.c:41:66: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). success = g_file_replace_contents (f->files[i], content, strlen(content), NULL, FALSE, data/spice-gtk-0.38/tests/util.c:50:44: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp = spice_dos2unix(dosunix[i].d, strlen(dosunix[i].d) + 1); data/spice-gtk-0.38/tests/util.c:70:44: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp = spice_unix2dos(dosunix[i].u, strlen(dosunix[i].u) + 1); data/spice-gtk-0.38/tools/spicy.c:1335:9: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(password, ""); ANALYSIS SUMMARY: Hits = 229 Lines analyzed = 83895 in approximately 1.84 seconds (45707 lines/second) Physical Source Lines of Code (SLOC) = 58880 Hits@level = [0] 106 [1] 59 [2] 120 [3] 19 [4] 31 [5] 0 Hits@level+ = [0+] 335 [1+] 229 [2+] 170 [3+] 50 [4+] 31 [5+] 0 Hits/KSLOC@level+ = [0+] 5.68954 [1+] 3.88927 [2+] 2.88723 [3+] 0.849185 [4+] 0.526495 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.