Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/ssh-cron-1.03.00/cron/parentprocess.cc
Examining data/ssh-cron-1.03.00/cron/requesthandler.cc
Examining data/ssh-cron-1.03.00/cron/scheduler.cc
Examining data/ssh-cron-1.03.00/cron/data.cc
Examining data/ssh-cron-1.03.00/cron/stop.cc
Examining data/ssh-cron-1.03.00/cron/handlerequests.cc
Examining data/ssh-cron-1.03.00/cron/list.cc
Examining data/ssh-cron-1.03.00/cron/reload.cc
Examining data/ssh-cron-1.03.00/cron/runparentprocess.cc
Examining data/ssh-cron-1.03.00/cron/childprocess.cc
Examining data/ssh-cron-1.03.00/cron/execute.cc
Examining data/ssh-cron-1.03.00/cron/definerunfunction.cc
Examining data/ssh-cron-1.03.00/cron/call.cc
Examining data/ssh-cron-1.03.00/cron/writerequest.cc
Examining data/ssh-cron-1.03.00/cron/readrequest.cc
Examining data/ssh-cron-1.03.00/cron/cron.h
Examining data/ssh-cron-1.03.00/cron/cronloop.cc
Examining data/ssh-cron-1.03.00/cron/cron1.cc
Examining data/ssh-cron-1.03.00/cron/runcronjobs.cc
Examining data/ssh-cron-1.03.00/cron/sendcommand.cc
Examining data/ssh-cron-1.03.00/cron/childredirections.cc
Examining data/ssh-cron-1.03.00/cron/idmsg.cc
Examining data/ssh-cron-1.03.00/cron/hmac.cc
Examining data/ssh-cron-1.03.00/crondata/insert.cc
Examining data/ssh-cron-1.03.00/crondata/addnr.cc
Examining data/ssh-cron-1.03.00/crondata/invalidrange.cc
Examining data/ssh-cron-1.03.00/crondata/data.cc
Examining data/ssh-cron-1.03.00/crondata/addrange.cc
Examining data/ssh-cron-1.03.00/crondata/sethours.cc
Examining data/ssh-cron-1.03.00/crondata/reset.cc
Examining data/ssh-cron-1.03.00/crondata/addcroncommand.cc
Examining data/ssh-cron-1.03.00/crondata/setdayofmonth.cc
Examining data/ssh-cron-1.03.00/crondata/addname.cc
Examining data/ssh-cron-1.03.00/crondata/setmonthofyear.cc
Examining data/ssh-cron-1.03.00/crondata/assign2.cc
Examining data/ssh-cron-1.03.00/crondata/setenvvar.cc
Examining data/ssh-cron-1.03.00/crondata/crondata1.cc
Examining data/ssh-cron-1.03.00/crondata/setminutes.cc
Examining data/ssh-cron-1.03.00/crondata/assign.cc
Examining data/ssh-cron-1.03.00/crondata/setdayofweek.cc
Examining data/ssh-cron-1.03.00/crondata/process.cc
Examining data/ssh-cron-1.03.00/crondata/setcommand.cc
Examining data/ssh-cron-1.03.00/crondata/outofrange.cc
Examining data/ssh-cron-1.03.00/crondata/setall.cc
Examining data/ssh-cron-1.03.00/crondata/crondata.h
Examining data/ssh-cron-1.03.00/cronentry/insert.cc
Examining data/ssh-cron-1.03.00/cronentry/cronentry.h
Examining data/ssh-cron-1.03.00/cronentry/setenvironment.cc
Examining data/ssh-cron-1.03.00/cronentry/operatorinsert.cc
Examining data/ssh-cron-1.03.00/cronentry/showset.cc
Examining data/ssh-cron-1.03.00/daemon/parentprocess.cc
Examining data/ssh-cron-1.03.00/daemon/terminate.cc
Examining data/ssh-cron-1.03.00/daemon/getpassphrase.cc
Examining data/ssh-cron-1.03.00/daemon/enterthread.cc
Examining data/ssh-cron-1.03.00/daemon/list.cc
Examining data/ssh-cron-1.03.00/daemon/run.cc
Examining data/ssh-cron-1.03.00/daemon/reload.cc
Examining data/ssh-cron-1.03.00/daemon/listrequest.cc
Examining data/ssh-cron-1.03.00/daemon/childprocess.cc
Examining data/ssh-cron-1.03.00/daemon/daemon1.cc
Examining data/ssh-cron-1.03.00/daemon/daemon.h
Examining data/ssh-cron-1.03.00/daemon/createipcfile.cc
Examining data/ssh-cron-1.03.00/daemon/basename.cc
Examining data/ssh-cron-1.03.00/daemon/signalhandler.cc
Examining data/ssh-cron-1.03.00/daemon/getipcinfo.cc
Examining data/ssh-cron-1.03.00/daemon/idmsg.cc
Examining data/ssh-cron-1.03.00/daemon/askpassphrase.cc
Examining data/ssh-cron-1.03.00/daemon/cleanup.cc
Examining data/ssh-cron-1.03.00/daemon/ipc.cc
Examining data/ssh-cron-1.03.00/daemon/daemonize.cc
Examining data/ssh-cron-1.03.00/ipcfunction/data.cc
Examining data/ssh-cron-1.03.00/ipcfunction/ipcfunction.h
Examining data/ssh-cron-1.03.00/main.cc
Examining data/ssh-cron-1.03.00/options/syslogfacility.cc
Examining data/ssh-cron-1.03.00/options/loadconfigfile.cc
Examining data/ssh-cron-1.03.00/options/instance.cc
Examining data/ssh-cron-1.03.00/options/data.cc
Examining data/ssh-cron-1.03.00/options/options1.cc
Examining data/ssh-cron-1.03.00/options/usage.cc
Examining data/ssh-cron-1.03.00/options/setsyslog.cc
Examining data/ssh-cron-1.03.00/options/checkaction.cc
Examining data/ssh-cron-1.03.00/options/options.h
Examining data/ssh-cron-1.03.00/options/syslogpriority.cc
Examining data/ssh-cron-1.03.00/options/syslogtag.cc
Examining data/ssh-cron-1.03.00/parser/parser.h
Examining data/ssh-cron-1.03.00/parser/parser1.cc
Examining data/ssh-cron-1.03.00/parser/error.cc
Examining data/ssh-cron-1.03.00/parser/parse.cc
Examining data/ssh-cron-1.03.00/parser/addset.cc
Examining data/ssh-cron-1.03.00/parser/parserbase.h
Examining data/ssh-cron-1.03.00/scanner/lex.cc
Examining data/ssh-cron-1.03.00/scanner/scanner.h
Examining data/ssh-cron-1.03.00/scanner/tokens.h
Examining data/ssh-cron-1.03.00/scanner/main.cc
Examining data/ssh-cron-1.03.00/scanner/scannerbase.h
Examining data/ssh-cron-1.03.00/version.cc
Examining data/ssh-cron-1.03.00/VERSION.h
FINAL RESULTS:
data/ssh-cron-1.03.00/daemon/daemonize.cc:7:9: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(ipcFile.c_str(), F_OK) == 0)
data/ssh-cron-1.03.00/options/loadconfigfile.cc:9:13: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(configFile.c_str(), R_OK) != 0)
data/ssh-cron-1.03.00/daemon/reload.cc:8:27: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
unique_ptr<char> path(realpath(ArgConfig::instance()[0], 0));
data/ssh-cron-1.03.00/cron/childredirections.cc:10:5: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open("/dev/null", O_WRONLY); // reopen cout
data/ssh-cron-1.03.00/cron/childredirections.cc:11:5: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open("/dev/null", O_WRONLY); // reopen cerr
data/ssh-cron-1.03.00/cron/handlerequests.cc:6:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
Exception::open(ipcFile, Options::instance().ipcFile());
data/ssh-cron-1.03.00/cron/reload.cc:20:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
Exception::open(in, path);
data/ssh-cron-1.03.00/crondata/crondata.h:35:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char const *const s_month[12];
data/ssh-cron-1.03.00/crondata/crondata.h:36:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char const *const s_day[7];
data/ssh-cron-1.03.00/daemon/askpassphrase.cc:9:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
Exception::open(in, "/dev/tty");
data/ssh-cron-1.03.00/daemon/createipcfile.cc:10:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buffer.get() + ipcFile.copy(buffer.get(), string::npos), "XXXXXX");
data/ssh-cron-1.03.00/daemon/createipcfile.cc:12:14: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
int fd = mkstemp(buffer.get());
data/ssh-cron-1.03.00/daemon/daemon1.cc:12:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
Exception::open(in, ArgConfig::instance()[0]);
data/ssh-cron-1.03.00/daemon/getipcinfo.cc:6:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
Exception::open(ipcFile, Options::instance().ipcFile());
data/ssh-cron-1.03.00/daemon/getpassphrase.cc:9:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
Exception::open(in, "/dev/tty");
data/ssh-cron-1.03.00/daemon/parentprocess.cc:6:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
Exception::open(ipcFile, Options::instance().ipcFile());
data/ssh-cron-1.03.00/options/loadconfigfile.cc:13:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
d_arg.open(configFile); // read the arg config file, which is also
data/ssh-cron-1.03.00/options/options1.cc:55:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
d_log.open(logName);
data/ssh-cron-1.03.00/cron/readrequest.cc:10:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
in.read(reinterpret_cast<char *>(&value), sizeof(Function));
ANALYSIS SUMMARY:
Hits = 19
Lines analyzed = 5322 in approximately 0.14 seconds (38845 lines/second)
Physical Source Lines of Code (SLOC) = 3914
Hits@level = [0] 0 [1] 1 [2] 15 [3] 1 [4] 2 [5] 0
Hits@level+ = [0+] 19 [1+] 19 [2+] 18 [3+] 3 [4+] 2 [5+] 0
Hits/KSLOC@level+ = [0+] 4.85437 [1+] 4.85437 [2+] 4.59888 [3+] 0.766479 [4+] 0.510986 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.