Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/ssldump-1.2/base/network.c
Examining data/ssldump-1.2/base/network.h
Examining data/ssldump-1.2/base/pcap-snoop.c
Examining data/ssldump-1.2/base/print_utils.c
Examining data/ssldump-1.2/base/print_utils.h
Examining data/ssldump-1.2/base/proto_mod.c
Examining data/ssldump-1.2/base/proto_mod.h
Examining data/ssldump-1.2/base/tcpconn.c
Examining data/ssldump-1.2/base/tcpconn.h
Examining data/ssldump-1.2/base/tcppack.c
Examining data/ssldump-1.2/base/tcppack.h
Examining data/ssldump-1.2/common/include/r_assoc.h
Examining data/ssldump-1.2/common/include/r_bitfield.h
Examining data/ssldump-1.2/common/include/r_common.h
Examining data/ssldump-1.2/common/include/r_data.h
Examining data/ssldump-1.2/common/include/r_defaults.h
Examining data/ssldump-1.2/common/include/r_errors.h
Examining data/ssldump-1.2/common/include/r_includes.h
Examining data/ssldump-1.2/common/include/r_list.h
Examining data/ssldump-1.2/common/include/r_macros.h
Examining data/ssldump-1.2/common/include/r_thread.h
Examining data/ssldump-1.2/common/include/r_time.h
Examining data/ssldump-1.2/common/include/r_types.h
Examining data/ssldump-1.2/common/lib/assoc.h
Examining data/ssldump-1.2/common/lib/debug.c
Examining data/ssldump-1.2/common/lib/debug.h
Examining data/ssldump-1.2/common/lib/r_assoc_test.c
Examining data/ssldump-1.2/common/lib/r_data.h
Examining data/ssldump-1.2/common/lib/r_errors.c
Examining data/ssldump-1.2/common/lib/r_list.c
Examining data/ssldump-1.2/common/lib/r_replace.c
Examining data/ssldump-1.2/common/lib/r_time.c
Examining data/ssldump-1.2/common/lib/threads/pthreads/pthread.c
Examining data/ssldump-1.2/common/lib/r_assoc.c
Examining data/ssldump-1.2/common/lib/r_bitfield.c
Examining data/ssldump-1.2/common/lib/r_data.c
Examining data/ssldump-1.2/null/null_analyze.c
Examining data/ssldump-1.2/null/null_analyze.h
Examining data/ssldump-1.2/ssl/ciphersuites.c
Examining data/ssldump-1.2/ssl/ciphersuites.h
Examining data/ssldump-1.2/ssl/lex.yy.c
Examining data/ssldump-1.2/ssl/main.c
Examining data/ssldump-1.2/ssl/ssl.enums.c
Examining data/ssldump-1.2/ssl/ssl.enums.h
Examining data/ssldump-1.2/ssl/ssl_analyze.c
Examining data/ssldump-1.2/ssl/ssl_analyze.h
Examining data/ssldump-1.2/ssl/ssl_enum.c
Examining data/ssldump-1.2/ssl/ssl_h.h
Examining data/ssldump-1.2/ssl/ssl_rec.c
Examining data/ssldump-1.2/ssl/ssl_rec.h
Examining data/ssldump-1.2/ssl/sslciphers.h
Examining data/ssldump-1.2/ssl/ssldecode.c
Examining data/ssldump-1.2/ssl/ssldecode.h
Examining data/ssldump-1.2/ssl/sslprint.c
Examining data/ssldump-1.2/ssl/sslprint.h
Examining data/ssldump-1.2/ssl/sslxprint.c
Examining data/ssldump-1.2/ssl/sslxprint.h
Examining data/ssldump-1.2/ssl/y.tab.c
Examining data/ssldump-1.2/ssl/y.tab.h
FINAL RESULTS:
data/ssldump-1.2/base/pcap-snoop.c:118:5: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf(PACKAGE_STRING "\n");
data/ssldump-1.2/base/pcap-snoop.c:440:11: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(tmp_filter,fmt,filter,filter);
data/ssldump-1.2/base/pcap-snoop.c:507:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ret+len,argv[i]);
data/ssldump-1.2/base/print_utils.c:56:5: [4] (format) vprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vprintf(format,ap);
data/ssldump-1.2/base/print_utils.c:71:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(prefix,"%s[%d]=\n",name,data->len);
data/ssldump-1.2/common/lib/debug.c:60:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr,format,ap);
data/ssldump-1.2/common/lib/r_errors.c:59:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr,fmt,ap);
data/ssldump-1.2/ssl/lex.yy.c:776:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
{ strcpy(yylval.str,yytext); RETURN(CODE_);}
data/ssldump-1.2/ssl/lex.yy.c:1776:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(yylval.str,yytext);
data/ssldump-1.2/ssl/main.c:61:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr,fmt,ap);
data/ssldump-1.2/ssl/main.c:76:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(name,"%s.c",argv[1]);
data/ssldump-1.2/ssl/main.c:78:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(name,"%s.h",argv[1]);
data/ssldump-1.2/ssl/ssldecode.c:133:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buf,ssl_password);
data/ssldump-1.2/ssl/ssldecode.c:493:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(key,"%s:%d",ssl->server_name,ssl->server_port);
data/ssldump-1.2/ssl/sslprint.c:333:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(n,"%s (length)",name?name:"<unknown>");
data/ssldump-1.2/ssl/sslprint.c:439:5: [4] (format) vprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vprintf(format,ap);
data/ssldump-1.2/ssl/y.tab.c:991:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(msg, count == 0 ? ", expecting `" : " or `");
data/ssldump-1.2/ssl/y.tab.c:992:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(msg, yytname[x]);
data/ssldump-1.2/base/pcap-snoop.c:300:14: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while((c=getopt(argc,argv,"vr:F:f:S:yTt:ai:k:l:p:nsAxXhHVNdqem:P"))!=EOF){
data/ssldump-1.2/common/lib/r_assoc_test.c:63:5: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(getpid());
data/ssldump-1.2/ssl/ssl.enums.c:178:21: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
Data session_id,random;
data/ssldump-1.2/ssl/ssl.enums.c:194:56: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
SSL_DECODE_OPAQUE_ARRAY(ssl,"random",32,P_ND,data,&random);
data/ssldump-1.2/ssl/ssl.enums.c:195:40: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
ssl_set_client_random(ssl->decoder,random.data,random.len);
data/ssldump-1.2/ssl/ssl.enums.c:195:52: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
ssl_set_client_random(ssl->decoder,random.data,random.len);
data/ssldump-1.2/ssl/ssl_enum.c:93:21: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
Data session_id,random;
data/ssldump-1.2/ssl/ssl_enum.c:105:56: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
SSL_DECODE_OPAQUE_ARRAY(ssl,"random",32,P_ND,data,&random);
data/ssldump-1.2/ssl/sslprint.c:105:10: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
char random[32];
data/ssldump-1.2/ssl/sslprint.c:186:12: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
memset(random,0,32);
data/ssldump-1.2/ssl/sslprint.c:189:40: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
ssl_set_client_random(ssl->decoder,random,32);
data/ssldump-1.2/base/network.c:118:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&p.ts,timestamp,sizeof(struct timeval));
data/ssldump-1.2/base/network.c:169:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&p->ts,&in->ts,sizeof(struct timeval));
data/ssldump-1.2/base/network.c:172:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p->base,in->base,p->_len=in->_len);
data/ssldump-1.2/base/pcap-snoop.c:247:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&last_packet_seen_time,&hdr->ts,sizeof(struct timeval));
data/ssldump-1.2/base/pcap-snoop.c:296:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errbuf[PCAP_ERRBUF_SIZE];
data/ssldump-1.2/base/pcap-snoop.c:346:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
conn_ttl=atoi(optarg);
data/ssldump-1.2/base/pcap-snoop.c:349:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
conn_freq=atoi(optarg);
data/ssldump-1.2/base/print_utils.c:66:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char prefix[100];
data/ssldump-1.2/base/tcpconn.c:128:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&conn->conn.i_addr,i_addr,sizeof(struct in_addr));
data/ssldump-1.2/base/tcpconn.c:130:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&conn->conn.r_addr,r_addr,sizeof(struct in_addr));
data/ssldump-1.2/base/tcppack.c:106:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&conn->last_seen_time,&p->ts,sizeof(struct timeval));
data/ssldump-1.2/base/tcppack.c:199:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&conn->start_time,&p->ts,sizeof(struct timeval));
data/ssldump-1.2/base/tcppack.c:200:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&conn->last_seen_time,&p->ts,sizeof(struct timeval));
data/ssldump-1.2/common/lib/r_assoc.c:186:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr->key,old->key,ptr->key_len=old->key_len);
data/ssldump-1.2/common/lib/r_assoc.c:263:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new_bucket->key,key,len);
data/ssldump-1.2/common/lib/r_assoc_test.c:54:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char test_vector[1024],*v;
data/ssldump-1.2/common/lib/r_assoc_test.c:102:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char vec[4],*v;
data/ssldump-1.2/common/lib/r_bitfield.c:81:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tmp,set->data,set->len*4);
data/ssldump-1.2/common/lib/r_data.c:66:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d_->data,d,l);
data/ssldump-1.2/common/lib/r_data.c:110:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dp->data,d,l);
data/ssldump-1.2/common/lib/r_data.c:137:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dst->data,src->data,dst->len=src->len);
data/ssldump-1.2/common/lib/r_replace.c:62:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(n,str,len+1);
data/ssldump-1.2/ssl/lex.yy.c:791:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
{yylval.val=atoi(yytext); RETURN(NUM_);}
data/ssldump-1.2/ssl/main.c:70:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[100];
data/ssldump-1.2/ssl/main.c:77:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dotc=fopen(name,"w");
data/ssldump-1.2/ssl/main.c:79:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
doth=fopen(name,"w");
data/ssldump-1.2/ssl/ssl.enums.c:2685:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(server_name,data->data,l);
data/ssldump-1.2/ssl/ssl_analyze.c:264:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&obj->time_start,base_time,sizeof(struct timeval));
data/ssldump-1.2/ssl/ssl_analyze.c:265:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&obj->time_last,base_time,sizeof(struct timeval));
data/ssldump-1.2/ssl/ssl_analyze.c:428:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(q->ptr,seg->data+offset,tocpy);
data/ssldump-1.2/ssl/ssl_rec.c:136:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dec->implicit_iv->data,iv,cs->block);
data/ssldump-1.2/ssl/ssl_rec.c:150:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dec->mac_key->data,mk,cs->dig_len);
data/ssldump-1.2/ssl/ssl_rec.c:211:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(aead_nonce,d->implicit_iv->data,d->implicit_iv->len);
data/ssldump-1.2/ssl/ssl_rec.c:212:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(aead_nonce+d->implicit_iv->len,in,12-d->implicit_iv->len);
data/ssldump-1.2/ssl/ssl_rec.c:344:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf+4,&netnum,4);
data/ssldump-1.2/ssl/ssldecode.c:176:32: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if(!(d->ssl_key_log_file=fopen(keylogfile, "r"))){
data/ssldump-1.2/ssl/ssldecode.c:428:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d->data,out,outl);
data/ssldump-1.2/ssl/ssldecode.c:459:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(hms->data+hms->len,d,l);
data/ssldump-1.2/ssl/ssldecode.c:489:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(key,id,idlen);
data/ssldump-1.2/ssl/ssldecode.c:693:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr,tmp,tocpy);
data/ssldump-1.2/ssl/ssldecode.c:727:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr,usage,strlen(usage)); ptr+=strlen(usage);
data/ssldump-1.2/ssl/ssldecode.c:728:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr,rnd1->data,rnd1->len); ptr+=rnd1->len;
data/ssldump-1.2/ssl/ssldecode.c:729:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr,rnd2->data,rnd2->len); ptr+=rnd2->len;
data/ssldump-1.2/ssl/ssldecode.c:738:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(S1->data,secret->data,S_l);
data/ssldump-1.2/ssl/ssldecode.c:739:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(S2->data,secret->data + (secret->len - S_l),S_l);
data/ssldump-1.2/ssl/ssldecode.c:784:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr,usage,strlen(usage)); ptr+=strlen(usage);
data/ssldump-1.2/ssl/ssldecode.c:785:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr,rnd1->data,rnd1->len); ptr+=rnd1->len;
data/ssldump-1.2/ssl/ssldecode.c:786:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr,rnd2->data,rnd2->len); ptr+=rnd2->len;
data/ssldump-1.2/ssl/ssldecode.c:825:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(out->data,tmp,out->len);
data/ssldump-1.2/ssl/ssldecode.c:856:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char outbuf[16];
data/ssldump-1.2/ssl/ssldecode.c:892:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(out->data+off,outbuf,tocpy);
data/ssldump-1.2/ssl/ssldecode.c:999:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(_iv_c,iv_block.data,8);
data/ssldump-1.2/ssl/ssldecode.c:1000:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(_iv_s,iv_block.data+8,8);
data/ssldump-1.2/ssl/sslprint.c:105:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char random[32];
data/ssldump-1.2/ssl/sslprint.c:187:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(random+(32-chall_len),chall.data,chall_len);
data/ssldump-1.2/ssl/sslprint.c:327:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char n[1000];
data/ssldump-1.2/ssl/sslprint.c:634:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&ssl->time_last,ts,sizeof(struct timeval));
data/ssldump-1.2/ssl/sslxprint.c:80:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZE];
data/ssldump-1.2/ssl/y.tab.c:47:15: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char str[8192];
data/ssldump-1.2/ssl/y.tab.c:743:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename[100];
data/ssldump-1.2/ssl/y.tab.c:982:8: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(msg, "parse error");
data/ssldump-1.2/ssl/y.tab.h:3:15: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char str[8192];
data/ssldump-1.2/base/pcap-snoop.c:434:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp_filter = (char *)malloc((strlen(filter) * 2) + strlen(fmt) + 1);
data/ssldump-1.2/base/pcap-snoop.c:434:62: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp_filter = (char *)malloc((strlen(filter) * 2) + strlen(fmt) + 1);
data/ssldump-1.2/base/pcap-snoop.c:499:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len+=strlen(argv[i])+1;
data/ssldump-1.2/base/pcap-snoop.c:508:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len+=strlen(argv[i]);
data/ssldump-1.2/common/lib/r_replace.c:56:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len=strlen(str);
data/ssldump-1.2/common/lib/threads/pthreads/pthread.c:81:7: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(10000);
data/ssldump-1.2/ssl/lex.yy.c:570:14: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
(c = getc( yyin )) != EOF && c != '\n'; ++n ) \
data/ssldump-1.2/ssl/ssldecode.c:130:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(num<strlen(ssl_password)+1)
data/ssldump-1.2/ssl/ssldecode.c:134:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return(strlen(ssl_password));
data/ssldump-1.2/ssl/ssldecode.c:483:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l=idlen+strlen(ssl->server_name)+idlen+15; /* HOST + PORT + id */
data/ssldump-1.2/ssl/ssldecode.c:494:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*keyl+=strlen(key);
data/ssldump-1.2/ssl/ssldecode.c:724:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(r=r_data_alloc(&seed,strlen(usage)+rnd1->len+rnd2->len))
data/ssldump-1.2/ssl/ssldecode.c:727:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memcpy(ptr,usage,strlen(usage)); ptr+=strlen(usage);
data/ssldump-1.2/ssl/ssldecode.c:727:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memcpy(ptr,usage,strlen(usage)); ptr+=strlen(usage);
data/ssldump-1.2/ssl/ssldecode.c:781:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(r=r_data_alloc(&seed,strlen(usage)+rnd1->len+rnd2->len))
data/ssldump-1.2/ssl/ssldecode.c:784:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memcpy(ptr,usage,strlen(usage)); ptr+=strlen(usage);
data/ssldump-1.2/ssl/ssldecode.c:784:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memcpy(ptr,usage,strlen(usage)); ptr+=strlen(usage);
data/ssldump-1.2/ssl/sslprint.h:93:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
#define INDENT_NAME(x) ssl->indent_name_len += strlen(x)
data/ssldump-1.2/ssl/y.tab.c:755:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
en->code[strlen(en->code)-2]=0;
data/ssldump-1.2/ssl/y.tab.c:978:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size += strlen(yytname[x]) + 15, count++;
data/ssldump-1.2/ssl/y.tab.c:993:4: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(msg, "'");
ANALYSIS SUMMARY:
Hits = 112
Lines analyzed = 15134 in approximately 0.42 seconds (36465 lines/second)
Physical Source Lines of Code (SLOC) = 10429
Hits@level = [0] 203 [1] 21 [2] 62 [3] 11 [4] 18 [5] 0
Hits@level+ = [0+] 315 [1+] 112 [2+] 91 [3+] 29 [4+] 18 [5+] 0
Hits/KSLOC@level+ = [0+] 30.2042 [1+] 10.7393 [2+] 8.72567 [3+] 2.78071 [4+] 1.72596 [5+] 0
Dot directories skipped = 2 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.