Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/sup-20100519/sys/viceioctl.h Examining data/sup-20100519/atoo.c Examining data/sup-20100519/c.h Examining data/sup-20100519/cvt.c Examining data/sup-20100519/estrdup.c Examining data/sup-20100519/expand.c Examining data/sup-20100519/ffilecopy.c Examining data/sup-20100519/filecopy.c Examining data/sup-20100519/libc.h Examining data/sup-20100519/log.c Examining data/sup-20100519/nxtarg.c Examining data/sup-20100519/path.c Examining data/sup-20100519/quit.c Examining data/sup-20100519/read_line.c Examining data/sup-20100519/run.c Examining data/sup-20100519/scan.c Examining data/sup-20100519/scm.c Examining data/sup-20100519/setproctitle.c Examining data/sup-20100519/stree.c Examining data/sup-20100519/sup.h Examining data/sup-20100519/supcdefs.h Examining data/sup-20100519/supcmain.c Examining data/sup-20100519/supcmeat.c Examining data/sup-20100519/supcmisc.c Examining data/sup-20100519/supcname.c Examining data/sup-20100519/supcparse.c Examining data/sup-20100519/supcvers.c Examining data/sup-20100519/supextern.h Examining data/sup-20100519/supmsg.c Examining data/sup-20100519/supmsg.h Examining data/sup-20100519/supscan.c Examining data/sup-20100519/vprintf.c Examining data/sup-20100519/wrap_pwd.h Examining data/sup-20100519/wrap_pwd.c Examining data/sup-20100519/supfilesrv.c Examining data/sup-20100519/skipto.c Examining data/sup-20100519/netcryptvoid.c Examining data/sup-20100519/scmio.c FINAL RESULTS: data/sup-20100519/supcmeat.c:655:11: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. (void) chmod(name, sbuf.st_mode | S_IRWXU); data/sup-20100519/supcmeat.c:659:13: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. (void) chmod(pname, pbuf.st_mode | S_IRWXU); data/sup-20100519/supcmeat.c:780:11: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. (void) chmod(name, statp->st_mode | S_IRWXU); data/sup-20100519/supcmeat.c:784:13: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. (void) chmod(pname, pbuf.st_mode | S_IRWXU); data/sup-20100519/supcmeat.c:889:10: [5] (race) chown: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchown( ) instead. (void) chown(t->Tname, t->Tuid, t->Tgid); data/sup-20100519/supcmeat.c:890:10: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. (void) chmod(t->Tname, t->Tmode & S_IMODE); data/sup-20100519/supcmeat.c:917:11: [5] (race) readlink: This accepts filename arguments; if an attacker can move those files or change the link content, a race condition results. Also, it does not terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach. (n = readlink(t->Tname, buf, sizeof(buf) - 1)) >= 0 && data/sup-20100519/supcmeat.c:968:11: [5] (race) chown: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchown( ) instead. (void) chown(t->Tname, t->Tuid, t->Tgid); data/sup-20100519/supcmeat.c:969:11: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. (void) chmod(t->Tname, t->Tmode & S_IMODE); data/sup-20100519/supcmeat.c:1030:10: [5] (race) chown: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchown( ) instead. (void) chown(t->Tname, t->Tuid, t->Tgid); data/sup-20100519/supcmeat.c:1031:10: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. (void) chmod(t->Tname, t->Tmode & S_IMODE); data/sup-20100519/supfilesrv.c:1198:12: [5] (race) readlink: This accepts filename arguments; if an attacker can move those files or change the link content, a race condition results. Also, it does not terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach. if ((x = readlink(name, slinkname, STRINGLENGTH - 1)) <= 0) { data/sup-20100519/log.c:73:2: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(buf, sizeof(buf), fmt, ap); data/sup-20100519/log.c:90:2: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(buf, sizeof(buf), fmt, ap); data/sup-20100519/log.c:107:2: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(buf, sizeof(buf), fmt, ap); data/sup-20100519/log.c:140:2: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(buf, sizeof(buf), fmt, ap); data/sup-20100519/log.c:157:2: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(buf, sizeof(buf), fmt, ap); data/sup-20100519/path.c:96:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(file, y); data/sup-20100519/quit.c:58:9: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. (void) vfprintf(stderr, fmt, args); data/sup-20100519/run.c:186:4: [4] (shell) execvp: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execvp(name, argv); data/sup-20100519/run.c:188:4: [4] (shell) execv: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execv(name, argv); data/sup-20100519/run.c:254:3: [4] (shell) execvp: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execvp(argv[0], argv); data/sup-20100519/run.c:287:3: [4] (shell) execvp: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execvp(argv[0], argv); data/sup-20100519/scan.c:287:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILERELEASES, collname); data/sup-20100519/scan.c:356:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILERELEASES, collname); data/sup-20100519/scan.c:454:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILELIST, collname, listfile); data/sup-20100519/scan.c:580:11: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, exec, speclist[i]); data/sup-20100519/scan.c:625:7: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(name, R_OK | X_OK) < 0) data/sup-20100519/scan.c:645:6: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(name, R_OK) < 0) data/sup-20100519/scan.c:653:4: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(rcs_release, "-r %s", rcs_branch); data/sup-20100519/scan.c:655:4: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(rcs_release, "-r%s", rcs_branch); data/sup-20100519/scan.c:660:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(sys_com, "cvs -d %s -r -l -Q co -p %s %s > %s\n", cvs_root, rcs_release, name, rcs_file); data/sup-20100519/scan.c:845:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILESCAN, collname, scanfile); data/sup-20100519/scan.c:946:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(fname, FILESCAN, collname, scanfile); data/sup-20100519/scan.c:947:9: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(tname, "%s.temp", fname); data/sup-20100519/scan.c:965:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(fname, FILESCAN, collname, scanfile); data/sup-20100519/scan.c:966:9: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(tname, "%s.temp", fname); data/sup-20100519/scm.c:484:10: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). (void) strcpy(name, h->h_name); data/sup-20100519/scm.c:667:2: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vfprintf(stderr, fmt, ap); data/sup-20100519/setproctitle.c:70:10: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. (void)vsnprintf(buf + len, sizeof(buf) - len, fmt, ap); data/sup-20100519/setproctitle.c:75:8: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). (void)strcpy(pname, buf); data/sup-20100519/supcmain.c:425:4: [4] (shell) execv: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execv(progname, argv); data/sup-20100519/supcmain.c:642:10: [4] (format) snprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. (void) snprintf(supfname = buf, sizeof(buf), data/sup-20100519/supcmain.c:659:33: [4] (misc) getlogin: It's often easy to fool getlogin. Sometimes it does not work at all, because some program messed up the utmp file. Often, it gives only the first 8 characters of the login name. The user currently logged in on the controlling tty of our program need not be the user who started it. Avoid getlogin() for security-related purposes (CWE-807). Use getpwuid(geteuid()) and extract the desired information instead. if (*username == '\0' && ((u = getlogin()) || data/sup-20100519/supcmain.c:715:11: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEBASEDEFAULT, c->Cname); data/sup-20100519/supcmain.c:734:10: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(p = buf, "file %s", supfname); data/sup-20100519/supcmeat.c:325:10: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(relsufix, ".%s", thisC->Crelease); data/sup-20100519/supcmeat.c:395:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILELOCK, collname); data/sup-20100519/supcmeat.c:485:10: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(relsufix, ".%s", release); data/sup-20100519/supcmeat.c:488:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILELAST, collname, relsufix); data/sup-20100519/supcmeat.c:501:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEREFUSE, collname); data/sup-20100519/supcmeat.c:657:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(pname, "%s/..", name); data/sup-20100519/supcmeat.c:782:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(pname, "%s/..", name); data/sup-20100519/supcmeat.c:1004:10: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(filename, FILEBACKUP, dirpart, filepart); data/sup-20100519/supcmeat.c:1007:11: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEBKDIR, dirpart); data/sup-20100519/supcmeat.c:1101:6: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. w = system(t->Tname); data/sup-20100519/supcmeat.c:1146:10: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(tname, "%s/#%d.sup", dpart, thispid); data/sup-20100519/supcmeat.c:1358:10: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(relsufix, ".%s", release); data/sup-20100519/supcmeat.c:1359:10: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(collrelname, "%s-%s", collname, release); data/sup-20100519/supcmeat.c:1362:10: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). (void) strcpy(collrelname, collname); data/sup-20100519/supcmeat.c:1408:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(fname, FILEWHEN, collname, relsufix); data/sup-20100519/supcmeat.c:1433:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(tname, FILELASTTEMP, collname, relsufix); data/sup-20100519/supcmeat.c:1442:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(fname, FILELAST, collname, relsufix); data/sup-20100519/supcmeat.c:1469:3: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(buf, sizeof(buf), fmt, ap); data/sup-20100519/supcmeat.c:1495:3: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(buf, sizeof(buf), fmt, ap); data/sup-20100519/supcmisc.c:88:10: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(relsufix, ".%s", thisC->Crelease); data/sup-20100519/supcmisc.c:95:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). (void) strcpy(buf, ctime(&twhen)); data/sup-20100519/supcmisc.c:281:10: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(collrelname, "%s-%s", collname, thisC->Crelease); data/sup-20100519/supcmisc.c:283:10: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). (void) strcpy(collrelname, collname); data/sup-20100519/supcmisc.c:296:12: [4] (shell) popen: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. outF = popen(buf, "w"); data/sup-20100519/supcmisc.c:336:2: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vfprintf(noteF, fmt, ap); data/sup-20100519/supcmisc.c:365:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). (void) strcpy(buf, ctime(&time)); data/sup-20100519/supcname.c:80:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEHOSTS, DEFDIR); data/sup-20100519/supcparse.c:237:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEWHEN, collection, relsuffix); data/sup-20100519/supextern.h:183:5: [4] (format) vprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. int vprintf(const char *, va_list); data/sup-20100519/supextern.h:184:5: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. int vfprintf(FILE *, const char *, va_list); data/sup-20100519/supextern.h:185:5: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. int vsprintf(char *, const char *, va_list); data/sup-20100519/supextern.h:186:5: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. int vsnprintf(char *, size_t, const char *, va_list); data/sup-20100519/supfilesrv.c:269:14: [4] (crypto) crypt: The crypt functions use a poor one-way hashing algorithm; since they only accept passwords of 8 characters or fewer and only a two-byte salt, they are excessively vulnerable to dictionary attacks given today's faster computing equipment (CWE-327). Use a different algorithm, such as SHA-256, with a larger, non-repeating salt. extern char *crypt(const char *, const char *); data/sup-20100519/supfilesrv.c:725:4: [4] (shell) execvp: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execvp(xargv[0], xargv); data/sup-20100519/supfilesrv.c:825:10: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEXPATCH, xuser); data/sup-20100519/supfilesrv.c:891:10: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEDIRS, DEFDIR); data/sup-20100519/supfilesrv.c:910:11: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEBASEDEFAULT, collname); data/sup-20100519/supfilesrv.c:916:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEPREFIX, collname); data/sup-20100519/supfilesrv.c:966:10: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEHOST, collname, h); data/sup-20100519/supfilesrv.c:1001:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILELOCK, collname); data/sup-20100519/supfilesrv.c:1035:10: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILECRYPT, collname); data/sup-20100519/supfilesrv.c:1247:8: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access("CVSROOT", F_OK) < 0) data/sup-20100519/supfilesrv.c:1320:7: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(rcs_release, "-r%s", data/sup-20100519/supfilesrv.c:1488:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(lognam, FILELOGFILE, collname); data/sup-20100519/supfilesrv.c:1493:9: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(p, "%s ", fmttime(lasttime)); data/sup-20100519/supfilesrv.c:1495:9: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(p, "%s ", fmttime(starttime)); data/sup-20100519/supfilesrv.c:1497:9: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(p, "%s ", fmttime(finishtime)); data/sup-20100519/supfilesrv.c:1501:9: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(p, "%s %s %d %s\n", remotehost(), releasename, data/sup-20100519/supfilesrv.c:1635:12: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). group = strcpy(nbuf, grp->gr_name); data/sup-20100519/supfilesrv.c:1641:10: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). (void) strcpy(nbuf, namep); data/sup-20100519/supfilesrv.c:1656:11: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(errbuf, "Reason: Unknown user %s", data/sup-20100519/supfilesrv.c:1670:12: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(errbuf, "AFS authentication failed, %s", data/sup-20100519/supfilesrv.c:1704:47: [4] (crypto) crypt: The crypt functions use a poor one-way hashing algorithm; since they only accept passwords of 8 characters or fewer and only a two-byte salt, they are excessively vulnerable to dictionary attacks given today's faster computing equipment (CWE-327). Use a different algorithm, such as SHA-256, with a larger, non-repeating salt. if (pswdp == NULL || strcmp(pwd->pw_passwd, crypt(pswdp, pwd->pw_passwd))) data/sup-20100519/supfilesrv.c:1715:10: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf(errbuf, "Reason: %s", p); data/sup-20100519/supfilesrv.c:1794:2: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(buf, sizeof(buf), fmt, ap); data/sup-20100519/supfilesrv.c:1808:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). (void) strcpy(buf, ctime(&time)); data/sup-20100519/supscan.c:276:10: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(fbuf, FILEDIRS, DEFDIR); data/sup-20100519/supscan.c:284:10: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEHOSTS, DEFDIR); data/sup-20100519/supscan.c:356:11: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEBASEDEFAULT, collname); data/sup-20100519/supscan.c:366:9: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf(buf, FILEPREFIX, collname); data/sup-20100519/supscan.c:401:2: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vfprintf(stderr, fmt, ap); data/sup-20100519/vprintf.c:80:1: [4] (format) vprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vprintf(fmt, args) data/sup-20100519/vprintf.c:89:1: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vfprintf(f, fmt, args) data/sup-20100519/vprintf.c:99:1: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. vsprintf(s, fmt, args) data/sup-20100519/vprintf.c:117:1: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(s, n, fmt, args) data/sup-20100519/expand.c:138:28: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. strncpy(path, (char *) getenv("HOME"), sizeof path - 1); data/sup-20100519/supcmain.c:476:14: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt(*argc, *argv, SUPOPTIONS)) != -1) data/sup-20100519/supfilesrv.c:1293:5: [3] (tmpfile) tmpnam: Temporary file race condition (CWE-377). tmpnam(rcs_file); data/sup-20100519/supfilesrv.c:1344:7: [3] (tmpfile) tmpnam: Temporary file race condition (CWE-377). tmpnam(temp_file); data/sup-20100519/cvt.c:24:12: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fd = open(argv[1], O_RDWR)) == -1) { data/sup-20100519/cvt.c:41:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fp = fopen(argv[1], "w")) == NULL) { data/sup-20100519/expand.c:80:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char pathbuf[MAXPATHLEN]; data/sup-20100519/expand.c:202:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char restbuf[MAXPATHLEN + 1]; data/sup-20100519/filecopy.c:64:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[BUFFERSIZE]; data/sup-20100519/log.c:69:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/log.c:86:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/log.c:103:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/log.c:136:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/log.c:153:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/read_line.c:64:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char sbuf[1024]; data/sup-20100519/read_line.c:122:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buf + len, ptr, s); data/sup-20100519/run.c:179:13: [2] (race) vfork: On some old systems, vfork() permits race conditions, and it's very difficult to use correctly (CWE-362). Use fork() instead. if ((pid = vfork()) == -1) data/sup-20100519/run.c:233:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fd = open(infile, O_RDONLY)) == -1) data/sup-20100519/run.c:240:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fd = open(outfile, O_RDWR | O_CREAT | O_TRUNC, data/sup-20100519/run.c:248:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fd = open(errfile, O_RDWR | O_CREAT | O_TRUNC, data/sup-20100519/scan.c:277:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/scan.c:288:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(buf, "r"); data/sup-20100519/scan.c:350:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/scan.c:357:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(buf, "r"); data/sup-20100519/scan.c:443:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/scan.c:471:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH + MAXPATHLEN * 4 + 1], *p; data/sup-20100519/scan.c:477:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *speclist[SPECNUMBER]; data/sup-20100519/scan.c:479:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(fname, "r"); data/sup-20100519/scan.c:572:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *speclist[SPECNUMBER]; data/sup-20100519/scan.c:573:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/scan.c:649:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char rcs_release[STRINGLENGTH]; data/sup-20100519/scan.c:710:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char newname[STRINGLENGTH], filename[STRINGLENGTH]; data/sup-20100519/scan.c:829:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/scan.c:831:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char fname[MAXPATHLEN]; data/sup-20100519/scan.c:848:11: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((f = fopen(buf, "r")) == NULL) data/sup-20100519/scan.c:860:6: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). if (atoi(p) != SCANVERSION) { data/sup-20100519/scan.c:901:15: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). ts.Tctime = atoi(p); data/sup-20100519/scan.c:906:15: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). ts.Tmtime = atoi(p); data/sup-20100519/scan.c:941:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tname[STRINGLENGTH], fname[STRINGLENGTH]; data/sup-20100519/scan.c:948:19: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (NULL == (f = fopen(tname, "w"))) data/sup-20100519/scan.c:959:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tname[STRINGLENGTH], fname[STRINGLENGTH]; data/sup-20100519/scan.c:967:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). scanF = fopen(tname, "w"); data/sup-20100519/scan.c:995:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char fname[MAXPATHLEN * 4 + 1]; data/sup-20100519/scan.c:1018:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char fname[MAXPATHLEN * 4 + 1]; data/sup-20100519/scm.c:234:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char port[NI_MAXSERV]; data/sup-20100519/scm.c:307:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&remoteaddr, &from, len); data/sup-20100519/scm.c:391:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char port[NI_MAXSERV]; data/sup-20100519/scm.c:445:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&remoteaddr, res->ai_addr, res->ai_addrlen); data/sup-20100519/scm.c:476:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char name[MAXHOSTNAMELEN + 1]; data/sup-20100519/scm.c:492:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char h1[NI_MAXHOST]; data/sup-20100519/scm.c:538:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[10 * 1024]; data/sup-20100519/scm.c:565:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. (void)memcpy(ifa[n].ifa_addr, &ifr->ifr_addr, data/sup-20100519/scm.c:586:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char h1[NI_MAXHOST], h2[NI_MAXHOST]; data/sup-20100519/scm.c:622:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char h1[NI_MAXHOST], h2[NI_MAXHOST]; data/sup-20100519/scm.c:682:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char uc[sizeof(int)]; data/sup-20100519/scmio.c:199:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char b_data[FILEXFER]; /* buffered data */ data/sup-20100519/scmio.c:223:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(gblbufptr->b_ptr, data, count); data/sup-20100519/scmio.c:229:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(bp->b_data, data, count); data/sup-20100519/scmio.c:352:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[FILEXFER]; data/sup-20100519/scmio.c:432:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char buffer[FILEXFER]; data/sup-20100519/scmio.c:441:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(bufptr, data, -count); data/sup-20100519/scmio.c:449:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data, bufptr, count); data/sup-20100519/scmio.c:455:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data, bufptr, (size_t)bufcnt); data/sup-20100519/scmio.c:483:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data, bufptr, (size_t)count); data/sup-20100519/scmio.c:566:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[FILEXFER]; data/sup-20100519/scmio.c:650:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[FILEXFER]; data/sup-20100519/scmio.c:719:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/setproctitle.c:43:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/sup-20100519/skipto.c:62:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char tab[256] = { 0 }; data/sup-20100519/stree.c:265:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[MAXPATHLEN + 1]; data/sup-20100519/supcmain.c:599:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH], *p; data/sup-20100519/supcmain.c:601:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char username[STRINGLENGTH]; data/sup-20100519/supcmain.c:665:7: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(supfname, "r"); data/sup-20100519/supcmeat.c:301:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char relsufix[STRINGLENGTH]; data/sup-20100519/supcmeat.c:391:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supcmeat.c:396:6: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = open(buf, O_RDONLY, 0); data/sup-20100519/supcmeat.c:477:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supcmeat.c:478:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char relsufix[STRINGLENGTH]; data/sup-20100519/supcmeat.c:489:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(buf, "r"); data/sup-20100519/supcmeat.c:502:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(buf, "r"); data/sup-20100519/supcmeat.c:607:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pname[MAXPATHLEN]; data/sup-20100519/supcmeat.c:742:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pname[MAXPATHLEN]; data/sup-20100519/supcmeat.c:905:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supcmeat.c:942:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char dirpart[STRINGLENGTH], filepart[STRINGLENGTH]; data/sup-20100519/supcmeat.c:943:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename[STRINGLENGTH], buf[STRINGLENGTH]; data/sup-20100519/supcmeat.c:994:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fin = fopen(t->Tname, "r"); /* create backup */ data/sup-20100519/supcmeat.c:1005:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fout = fopen(filename, "w"); data/sup-20100519/supcmeat.c:1009:11: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fout = fopen(filename, "w"); data/sup-20100519/supcmeat.c:1123:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char dpart[STRINGLENGTH], fpart[STRINGLENGTH]; data/sup-20100519/supcmeat.c:1124:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tname[STRINGLENGTH]; data/sup-20100519/supcmeat.c:1130:11: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fromf = open(from, O_RDONLY, 0); data/sup-20100519/supcmeat.c:1147:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). tof = open(tname, (O_WRONLY | O_CREAT | O_TRUNC | O_EXCL), 0600); data/sup-20100519/supcmeat.c:1153:10: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf(tname, "sup/#%d.sup", thispid); data/sup-20100519/supcmeat.c:1154:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). tof = open(tname, (O_WRONLY | O_CREAT | O_TRUNC | O_EXCL), 0600); data/sup-20100519/supcmeat.c:1161:10: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf(tname, "#%d.sup", thispid); data/sup-20100519/supcmeat.c:1162:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). tof = open(tname, (O_WRONLY | O_CREAT | O_TRUNC | O_EXCL), 0600); data/sup-20100519/supcmeat.c:1169:10: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf(tname, "/var/tmp/#%d.sup", thispid); data/sup-20100519/supcmeat.c:1170:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). tof = open(tname, (O_WRONLY | O_CREAT | O_TRUNC | O_EXCL), 0600); data/sup-20100519/supcmeat.c:1175:10: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf(tname, "/usr/tmp/#%d.sup", thispid); data/sup-20100519/supcmeat.c:1176:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). tof = open(tname, (O_WRONLY | O_CREAT | O_TRUNC | O_EXCL), 0600); data/sup-20100519/supcmeat.c:1181:10: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf(tname, "/tmp/#%d.sup", thispid); data/sup-20100519/supcmeat.c:1182:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). tof = open(tname, (O_WRONLY | O_CREAT | O_TRUNC | O_EXCL), 0600); data/sup-20100519/supcmeat.c:1188:10: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). tof = open(to, (O_WRONLY | O_CREAT | O_TRUNC | O_EXCL), 0600); data/sup-20100519/supcmeat.c:1288:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *av[4]; data/sup-20100519/supcmeat.c:1295:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((infd = open(tname, O_RDONLY, 0)) == -1 || data/sup-20100519/supcmeat.c:1297:16: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). (outfd = open(tname, O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, 0600)) == -1 || data/sup-20100519/supcmeat.c:1318:10: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fromf = open(tname, O_RDONLY, 0); data/sup-20100519/supcmeat.c:1326:8: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). tof = open(to, (O_WRONLY | O_CREAT | O_TRUNC | O_EXCL), 0600); data/sup-20100519/supcmeat.c:1351:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tname[STRINGLENGTH], fname[STRINGLENGTH]; data/sup-20100519/supcmeat.c:1352:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char relsufix[STRINGLENGTH]; data/sup-20100519/supcmeat.c:1353:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char collrelname[STRINGLENGTH]; data/sup-20100519/supcmeat.c:1434:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). finishfile = fopen(tname, "w"); data/sup-20100519/supcmeat.c:1462:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supcmeat.c:1488:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supcmisc.c:83:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supcmisc.c:84:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char relsufix[STRINGLENGTH]; data/sup-20100519/supcmisc.c:104:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char dpart[STRINGLENGTH], fpart[STRINGLENGTH]; data/sup-20100519/supcmisc.c:137:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char dpart[STRINGLENGTH], fpart[STRINGLENGTH]; data/sup-20100519/supcmisc.c:269:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supcmisc.c:270:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char collrelname[STRINGLENGTH]; data/sup-20100519/supcmisc.c:271:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char hostname[STRINGLENGTH]; data/sup-20100519/supcmisc.c:321:13: [2] (tmpfile) mkstemp: Potential for temporary file vulnerability in some circumstances. Some older Unix-like systems create temp files with permission to write by all by default, so be sure to set the umask to override this. Also, some older Unix systems might fail to use O_EXCL when opening the file, so make sure that O_EXCL is used by the library (CWE-377). int fd = mkstemp(template); data/sup-20100519/supcmisc.c:362:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char buf[STRINGLENGTH]; data/sup-20100519/supcname.c:73:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supcname.c:81:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(buf, "r"); data/sup-20100519/supcparse.c:221:18: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). c->Ctimeout = atoi(arg); data/sup-20100519/supcparse.c:232:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supcparse.c:239:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fp = fopen(buf, "r")) == NULL) data/sup-20100519/supcparse.c:258:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fp = fopen(fname, "w")) == NULL) data/sup-20100519/supextern.h:49:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *read_line(FILE *, size_t *, size_t *, const char[3], int); data/sup-20100519/supfilesrv.c:517:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supfilesrv.c:560:18: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). maxchildren = atoi(argv[0]); data/sup-20100519/supfilesrv.c:605:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(cryptkey, "r"); data/sup-20100519/supfilesrv.c:792:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supfilesrv.c:834:13: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((f = fopen(buf, "r")) != NULL) { data/sup-20100519/supfilesrv.c:892:7: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(buf, "r"); data/sup-20100519/supfilesrv.c:917:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(buf, "r"); data/sup-20100519/supfilesrv.c:967:7: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(buf, "r"); data/sup-20100519/supfilesrv.c:1003:6: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). x = open(buf, O_RDONLY, 0); data/sup-20100519/supfilesrv.c:1030:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supfilesrv.c:1043:13: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((f = fopen(buf, "r")) != NULL) { data/sup-20100519/supfilesrv.c:1177:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char slinkname[STRINGLENGTH]; data/sup-20100519/supfilesrv.c:1275:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char temp_file[STRINGLENGTH]; data/sup-20100519/supfilesrv.c:1276:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *av[50]; /* More than enough */ data/sup-20100519/supfilesrv.c:1291:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char rcs_release[STRINGLENGTH]; data/sup-20100519/supfilesrv.c:1294:10: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = open(rcs_file, (O_WRONLY | O_CREAT | O_TRUNC | O_EXCL), 0600); data/sup-20100519/supfilesrv.c:1355:12: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = open(temp_file, O_RDONLY, 0); data/sup-20100519/supfilesrv.c:1357:12: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = open(rcs_file, O_RDONLY, 0); data/sup-20100519/supfilesrv.c:1365:11: [2] (tmpfile) mkstemp: Potential for temporary file vulnerability in some circumstances. Some older Unix-like systems create temp files with permission to write by all by default, so be sure to set the umask to override this. Also, some older Unix systems might fail to use O_EXCL when opening the file, so make sure that O_EXCL is used by the library (CWE-377). fd = mkstemp(temp_file); data/sup-20100519/supfilesrv.c:1379:11: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = open(temp_file, O_RDONLY, 0); data/sup-20100519/supfilesrv.c:1381:11: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = open(t->Tname, O_RDONLY, 0); data/sup-20100519/supfilesrv.c:1446:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmpbuf[BUFSIZ], *p, lognam[STRINGLENGTH]; data/sup-20100519/supfilesrv.c:1489:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((logfd = open(lognam, O_APPEND | O_WRONLY, 0644)) < 0) data/sup-20100519/supfilesrv.c:1619:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nbuf[STRINGLENGTH]; data/sup-20100519/supfilesrv.c:1620:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char errbuf[STRINGLENGTH]; data/sup-20100519/supfilesrv.c:1629:11: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf(errbuf, "Reason: Unknown user id %d", data/sup-20100519/supfilesrv.c:1756:10: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf(p = errbuf, "Reason: Status %d", status); data/sup-20100519/supfilesrv.c:1788:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH]; data/sup-20100519/supfilesrv.c:1805:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char buf[STRINGLENGTH]; data/sup-20100519/supfilesrv.c:1870:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char cellname[512]; data/sup-20100519/supscan.c:238:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH], fbuf[STRINGLENGTH], *p, *q; data/sup-20100519/supscan.c:285:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((f = fopen(buf, "r")) == NULL) data/sup-20100519/supscan.c:308:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((f = fopen(filename, "r")) == NULL) data/sup-20100519/supscan.c:334:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[STRINGLENGTH], *p, *q; data/sup-20100519/supscan.c:339:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((f = fopen(filename, "r")) != NULL) { data/sup-20100519/supscan.c:367:11: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((f = fopen(buf, "r")) != NULL) { data/sup-20100519/supscan.c:411:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char myhost[MAXHOSTNAMELEN + 1]; data/sup-20100519/cvt.c:29:6: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if (read(fd, &b, sizeof(b)) != sizeof(b)) { data/sup-20100519/expand.c:136:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(path, path + 1, sizeof path - 1); data/sup-20100519/expand.c:138:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(path, (char *) getenv("HOME"), sizeof path - 1); data/sup-20100519/expand.c:140:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). pathp = path + strlen(path); data/sup-20100519/expand.c:372:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ep = malloc(strlen(s1) + strlen(s2) + 1); data/sup-20100519/expand.c:372:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ep = malloc(strlen(s1) + strlen(s2) + 1); data/sup-20100519/expand.c:401:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(home, pp->pw_dir, homelen - 1); data/sup-20100519/filecopy.c:66:32: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while (kount == 0 && (kount = read(here, buffer, BUFFERSIZE)) > 0) data/sup-20100519/path.c:98:3: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(file, "."); data/sup-20100519/path.c:102:3: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(direc, "."); data/sup-20100519/path.c:104:3: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(direc, "/"); data/sup-20100519/scan.c:743:10: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). (void)strncpy(filename, dentry->d_name, data/sup-20100519/scm.c:308:6: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if (read(netfile, &x, sizeof(int)) != sizeof(int)) data/sup-20100519/scmio.c:338:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(p); data/sup-20100519/scmio.c:369:13: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). number = read(f, buf, FILEXFER); data/sup-20100519/scmio.c:473:7: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). x = read(netfile, p, (size_t)n); data/sup-20100519/scmio.c:736:8: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). c = read(netfile, buf, sizeof(buf)); data/sup-20100519/scmio.c:747:8: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). c = read(0, buf, sizeof(buf)); data/sup-20100519/stree.c:281:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). (void) strncpy(buf, p, sizeof(buf) - 1); data/sup-20100519/supcmain.c:540:4: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(username, optarg, ulen); data/sup-20100519/supcmain.c:661:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). (void)strncpy(username, u, sizeof(username)); data/sup-20100519/supcmeat.c:656:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(name) < MAXPATHLEN - 3) { data/sup-20100519/supcmeat.c:781:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(name) < MAXPATHLEN - 3) { data/sup-20100519/supcmeat.c:918:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). (n == strlen(linkname)) && (strncmp(linkname, buf, n) == 0)) data/sup-20100519/supcmisc.c:96:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buf[strlen(buf) - 1] = '\0'; data/sup-20100519/supcmisc.c:174:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(name); data/sup-20100519/supcmisc.c:366:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(buf + 4) - 6; data/sup-20100519/supfilesrv.c:1299:26: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strcmp(&t->Tname[strlen(t->Tname) - 2], ",v") == 0) { data/sup-20100519/supfilesrv.c:1300:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). t->Tname[strlen(t->Tname) - 2] = '\0'; data/sup-20100519/supfilesrv.c:1494:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p += strlen(p); data/sup-20100519/supfilesrv.c:1496:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p += strlen(p); data/sup-20100519/supfilesrv.c:1498:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p += strlen(p); data/sup-20100519/supfilesrv.c:1503:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p += strlen(p); data/sup-20100519/supfilesrv.c:1809:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(buf + 4) - 6; data/sup-20100519/supfilesrv.c:1810:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). (void) strncpy(buf, buf + 4, len); data/sup-20100519/supscan.c:424:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). myhostlen = strlen(myhost); data/sup-20100519/supscan.c:437:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). hostlen = strlen(host); data/sup-20100519/vprintf.c:111:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return (strlen(s)); ANALYSIS SUMMARY: Hits = 316 Lines analyzed = 12307 in approximately 0.36 seconds (33756 lines/second) Physical Source Lines of Code (SLOC) = 8333 Hits@level = [0] 53 [1] 38 [2] 163 [3] 4 [4] 99 [5] 12 Hits@level+ = [0+] 369 [1+] 316 [2+] 278 [3+] 115 [4+] 111 [5+] 12 Hits/KSLOC@level+ = [0+] 44.2818 [1+] 37.9215 [2+] 33.3613 [3+] 13.8006 [4+] 13.3205 [5+] 1.44006 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.