Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/task-spooler-1.0+dfsg1/client.c
Examining data/task-spooler-1.0+dfsg1/env.c
Examining data/task-spooler-1.0+dfsg1/error.c
Examining data/task-spooler-1.0+dfsg1/execute.c
Examining data/task-spooler-1.0+dfsg1/info.c
Examining data/task-spooler-1.0+dfsg1/jobs.c
Examining data/task-spooler-1.0+dfsg1/list.c
Examining data/task-spooler-1.0+dfsg1/mail.c
Examining data/task-spooler-1.0+dfsg1/main.c
Examining data/task-spooler-1.0+dfsg1/main.h
Examining data/task-spooler-1.0+dfsg1/msg.c
Examining data/task-spooler-1.0+dfsg1/msgdump.c
Examining data/task-spooler-1.0+dfsg1/print.c
Examining data/task-spooler-1.0+dfsg1/server.c
Examining data/task-spooler-1.0+dfsg1/signals.c
Examining data/task-spooler-1.0+dfsg1/tail.c
Examining data/task-spooler-1.0+dfsg1/ttail.c
Examining data/task-spooler-1.0+dfsg1/server_start.c
FINAL RESULTS:
data/task-spooler-1.0+dfsg1/client.c:47:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(commandstring, array[0]);
data/task-spooler-1.0+dfsg1/client.c:51:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(commandstring, array[i]);
data/task-spooler-1.0+dfsg1/env.c:43:13: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execlp("/bin/sh", "/bin/sh", "-c", command, (char*)NULL);
data/task-spooler-1.0+dfsg1/error.c:107:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(out, str, ap);
data/task-spooler-1.0+dfsg1/error.c:156:9: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, str, ap);
data/task-spooler-1.0+dfsg1/execute.c:138:13: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execlp("gzip", "gzip", NULL);
data/task-spooler-1.0+dfsg1/execute.c:170:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(outfname_full, tmpdir);
data/task-spooler-1.0+dfsg1/execute.c:171:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(outfname_full, outfname);
data/task-spooler-1.0+dfsg1/execute.c:251:5: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(command_line.command.array[0], command_line.command.array);
data/task-spooler-1.0+dfsg1/info.c:66:11: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
res = vsnprintf(p->ptr + p->nchars, (p->allocchars - p->nchars), line, ap);
data/task-spooler-1.0+dfsg1/mail.c:39:13: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl("/usr/sbin/sendmail", "sendmail", "-oi", dest, NULL);
data/task-spooler-1.0+dfsg1/mail.c:105:13: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execlp(onfinish, onfinish, sjobid, serrorlevel, ofname, command,
data/task-spooler-1.0+dfsg1/mail.c:131:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(to, user);
data/task-spooler-1.0+dfsg1/mail.c:134:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(to, env_to);
data/task-spooler-1.0+dfsg1/main.c:63:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(tmp, str);
data/task-spooler-1.0+dfsg1/main.c:399:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(getopt_env, "POSIXLY_CORRECT=%s", old_getopt_env);
data/task-spooler-1.0+dfsg1/print.c:33:12: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
size = vsnprintf(out, maxsize, fmt, ap);
data/task-spooler-1.0+dfsg1/server.c:183:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(dirpath, path);
data/task-spooler-1.0+dfsg1/server.c:194:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(addr.sun_path, path);
data/task-spooler-1.0+dfsg1/server_start.c:41:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(*path, getenv("TS_SOCKET"));
data/task-spooler-1.0+dfsg1/server_start.c:64:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(*path, "%s/socket-ts.%s", tmpdir, userid);
data/task-spooler-1.0+dfsg1/env.c:62:15: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
command = getenv("TS_ENV");
data/task-spooler-1.0+dfsg1/execute.c:161:30: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *tmpdir = getenv("TMPDIR");
data/task-spooler-1.0+dfsg1/jobs.c:559:13: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
limit = getenv("TS_MAXFINISHED");
data/task-spooler-1.0+dfsg1/mail.c:93:16: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
onfinish = getenv("TS_ONFINISH");
data/task-spooler-1.0+dfsg1/mail.c:123:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
env_to = getenv("TS_MAILTO");
data/task-spooler-1.0+dfsg1/mail.c:127:16: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
user = getenv("USER");
data/task-spooler-1.0+dfsg1/main.c:87:13: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt(argc, argv, ":VhKgClnfmBEr:t:c:o:p:w:k:u:s:U:i:N:L:dS:D:");
data/task-spooler-1.0+dfsg1/main.c:387:22: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
old_getopt_env = getenv("POSIXLY_CORRECT");
data/task-spooler-1.0+dfsg1/server.c:82:20: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
dumpfilename = getenv("TS_SAVELIST");
data/task-spooler-1.0+dfsg1/server.c:104:11: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
str = getenv("TS_SLOTS");
data/task-spooler-1.0+dfsg1/server.c:135:11: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
str = getenv("TS_MAXCONN");
data/task-spooler-1.0+dfsg1/server_start.c:35:13: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
*path = getenv("TS_SOCKET");
data/task-spooler-1.0+dfsg1/server_start.c:41:23: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
strcpy(*path, getenv("TS_SOCKET"));
data/task-spooler-1.0+dfsg1/server_start.c:52:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
tmpdir = getenv("TMPDIR");
data/task-spooler-1.0+dfsg1/env.c:23:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fdnull = open("/dev/null", O_RDONLY);
data/task-spooler-1.0+dfsg1/error.c:75:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(new_path, O_CREAT | O_APPEND | O_WRONLY, 0600);
data/task-spooler-1.0+dfsg1/execute.c:152:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errfname[sizeof outfname + 2]; /* .e */
data/task-spooler-1.0+dfsg1/execute.c:183:21: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
outfd = mkstemp(outfname_full); /* stdout */
data/task-spooler-1.0+dfsg1/execute.c:195:25: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
errfd = open(errfname, O_CREAT | O_WRONLY | O_TRUNC, 0600);
data/task-spooler-1.0+dfsg1/execute.c:218:21: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
outfd = mkstemp(outfname_full); /* stdout */
data/task-spooler-1.0+dfsg1/execute.c:225:25: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
errfd = open(errfname, O_CREAT | O_WRONLY | O_TRUNC, 0600);
data/task-spooler-1.0+dfsg1/jobs.c:562:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
return abs(atoi(limit));
data/task-spooler-1.0+dfsg1/jobs.c:816:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[50];
data/task-spooler-1.0+dfsg1/jobs.c:817:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "Job %i not finished or not running.\n", jobid);
data/task-spooler-1.0+dfsg1/jobs.c:888:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[50];
data/task-spooler-1.0+dfsg1/jobs.c:890:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "The last job has not finished or is not running.\n");
data/task-spooler-1.0+dfsg1/jobs.c:892:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "Job %i not finished or not running.\n", jobid);
data/task-spooler-1.0+dfsg1/jobs.c:899:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[50];
data/task-spooler-1.0+dfsg1/jobs.c:901:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "The last job was skipped due to a dependency.\n");
data/task-spooler-1.0+dfsg1/jobs.c:904:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "Job %i was skipped due to a dependency.\n", jobid);
data/task-spooler-1.0+dfsg1/jobs.c:1002:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[50];
data/task-spooler-1.0+dfsg1/jobs.c:1004:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "The last job cannot be removed.\n");
data/task-spooler-1.0+dfsg1/jobs.c:1006:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "The job %i cannot be removed.\n", *jobid);
data/task-spooler-1.0+dfsg1/jobs.c:1219:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[50];
data/task-spooler-1.0+dfsg1/jobs.c:1221:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "The last job cannot be waited.\n");
data/task-spooler-1.0+dfsg1/jobs.c:1223:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "The job %i cannot be waited.\n", jobid);
data/task-spooler-1.0+dfsg1/jobs.c:1282:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[50];
data/task-spooler-1.0+dfsg1/jobs.c:1284:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "The last job cannot be waited.\n");
data/task-spooler-1.0+dfsg1/jobs.c:1286:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "The job %i cannot be waited.\n", jobid);
data/task-spooler-1.0+dfsg1/jobs.c:1341:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[50];
data/task-spooler-1.0+dfsg1/jobs.c:1343:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "The last job cannot be urged.\n");
data/task-spooler-1.0+dfsg1/jobs.c:1345:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "The job %i cannot be urged.\n", jobid);
data/task-spooler-1.0+dfsg1/jobs.c:1371:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char prev[60];
data/task-spooler-1.0+dfsg1/jobs.c:1372:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(prev, "The jobs %i and %i cannot be swapped.\n", jobid1, jobid2);
data/task-spooler-1.0+dfsg1/jobs.c:1429:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[50];
data/task-spooler-1.0+dfsg1/jobs.c:1431:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "The last job cannot be stated.\n");
data/task-spooler-1.0+dfsg1/jobs.c:1433:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(tmp, "The job %i cannot be stated.\n", jobid);
data/task-spooler-1.0+dfsg1/list.c:93:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dependstr[18] = "";
data/task-spooler-1.0+dfsg1/list.c:146:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dependstr[18] = "";
data/task-spooler-1.0+dfsg1/mail.c:63:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1000];
data/task-spooler-1.0+dfsg1/mail.c:67:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
file_fd = open(ofname, O_RDONLY);
data/task-spooler-1.0+dfsg1/mail.c:89:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sjobid[20];
data/task-spooler-1.0+dfsg1/mail.c:90:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char serrorlevel[20];
data/task-spooler-1.0+dfsg1/mail.c:103:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(sjobid, "%i", jobid);
data/task-spooler-1.0+dfsg1/mail.c:104:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(serrorlevel, "%i", errorlevel);
data/task-spooler-1.0+dfsg1/mail.c:117:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char to[101];
data/task-spooler-1.0+dfsg1/main.c:58:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[50];
data/task-spooler-1.0+dfsg1/main.c:75:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*j1 = atoi(tmp);
data/task-spooler-1.0+dfsg1/main.c:76:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*j2 = atoi(tmp2);
data/task-spooler-1.0+dfsg1/main.c:100:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.jobid = atoi(optarg);
data/task-spooler-1.0+dfsg1/main.c:120:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.jobid = atoi(optarg);
data/task-spooler-1.0+dfsg1/main.c:124:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.jobid = atoi(optarg);
data/task-spooler-1.0+dfsg1/main.c:143:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.jobid = atoi(optarg);
data/task-spooler-1.0+dfsg1/main.c:147:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.jobid = atoi(optarg);
data/task-spooler-1.0+dfsg1/main.c:151:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.jobid = atoi(optarg);
data/task-spooler-1.0+dfsg1/main.c:154:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.num_slots = atoi(optarg);
data/task-spooler-1.0+dfsg1/main.c:160:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.jobid = atoi(optarg);
data/task-spooler-1.0+dfsg1/main.c:164:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.jobid = atoi(optarg);
data/task-spooler-1.0+dfsg1/main.c:168:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.jobid = atoi(optarg);
data/task-spooler-1.0+dfsg1/main.c:172:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.jobid = atoi(optarg);
data/task-spooler-1.0+dfsg1/main.c:176:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.max_slots = atoi(optarg);
data/task-spooler-1.0+dfsg1/main.c:185:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
command_line.depend_on = atoi(optarg);
data/task-spooler-1.0+dfsg1/server.c:85:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(dumpfilename, O_WRONLY | O_APPEND | O_CREAT, 0600);
data/task-spooler-1.0+dfsg1/server.c:108:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
slots = abs(atoi(str));
data/task-spooler-1.0+dfsg1/server.c:139:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
user_maxconn = abs(atoi(str));
data/task-spooler-1.0+dfsg1/server.c:317:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&client_cs[i], &client_cs[i+1], sizeof(client_cs[0]));
data/task-spooler-1.0+dfsg1/server_start.c:31:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char userid[20];
data/task-spooler-1.0+dfsg1/server_start.c:56:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(userid, "%u", (unsigned int) getuid());
data/task-spooler-1.0+dfsg1/tail.c:47:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BSIZE];
data/task-spooler-1.0+dfsg1/tail.c:123:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(fname, O_RDONLY);
data/task-spooler-1.0+dfsg1/tail.c:136:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BSIZE];
data/task-spooler-1.0+dfsg1/client.c:38:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size = size + strlen(array[i]) + 1;
data/task-spooler-1.0+dfsg1/client.c:50:9: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(commandstring, " ");
data/task-spooler-1.0+dfsg1/client.c:70:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m.u.newjob.command_size = strlen(new_command) + 1; /* add null */
data/task-spooler-1.0+dfsg1/client.c:72:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m.u.newjob.env_size = strlen(myenv) + 1; /* add null */
data/task-spooler-1.0+dfsg1/client.c:76:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m.u.newjob.label_size = strlen(command_line.label) + 1; /* add null */
data/task-spooler-1.0+dfsg1/client.c:83:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m.u.newjob.command_size = strlen(new_command) + 1; /* add null */
data/task-spooler-1.0+dfsg1/client.c:278:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m.u.output.ofilename_size = strlen(ofname) + 1;
data/task-spooler-1.0+dfsg1/env.c:79:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
res = read(readfd, ptr + bytes, 1000);
data/task-spooler-1.0+dfsg1/error.c:68:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
new_size = strlen(path)+10;
data/task-spooler-1.0+dfsg1/error.c:71:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(new_path, path, new_size);
data/task-spooler-1.0+dfsg1/error.c:72:5: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is low because the source is a
constant string.
strncat(new_path, ".error", (new_size - strlen(path)) - 1);
data/task-spooler-1.0+dfsg1/error.c:72:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncat(new_path, ".error", (new_size - strlen(path)) - 1);
data/task-spooler-1.0+dfsg1/execute.c:42:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
res = read(fd_read_filename, &namesize, sizeof(namesize));
data/task-spooler-1.0+dfsg1/execute.c:48:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
res = read(fd_read_filename, ofname, namesize);
data/task-spooler-1.0+dfsg1/execute.c:52:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
res = read(fd_read_filename, &starttv, sizeof(starttv));
data/task-spooler-1.0+dfsg1/execute.c:167:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
lname = strlen(tmpdir) + strlen(outfname) + 1 /* \0 */;
data/task-spooler-1.0+dfsg1/execute.c:167:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
lname = strlen(tmpdir) + strlen(outfname) + 1 /* \0 */;
data/task-spooler-1.0+dfsg1/execute.c:193:17: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(errfname, outfname_full, sizeof errfname);
data/task-spooler-1.0+dfsg1/execute.c:194:17: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is low because the source is a
constant string.
strncat(errfname, ".e", 2);
data/task-spooler-1.0+dfsg1/execute.c:223:17: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(errfname, outfname_full, sizeof errfname);
data/task-spooler-1.0+dfsg1/execute.c:224:17: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is low because the source is a
constant string.
strncat(errfname, ".e", 2);
data/task-spooler-1.0+dfsg1/execute.c:235:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
namesize = strlen(outfname_full)+1;
data/task-spooler-1.0+dfsg1/jobs.c:50:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m.u.size = strlen(str) + 1;
data/task-spooler-1.0+dfsg1/jobs.c:828:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(s, p->command, strlen(p->command));
data/task-spooler-1.0+dfsg1/jobs.c:913:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m.u.output.ofilename_size = strlen(p->output_filename) + 1;
data/task-spooler-1.0+dfsg1/jobs.c:1505:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(fd,buffer, strlen(buffer));
data/task-spooler-1.0+dfsg1/jobs.c:1511:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(fd, buffer, strlen(buffer));
data/task-spooler-1.0+dfsg1/jobs.c:1519:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(fd,buffer, strlen(buffer));
data/task-spooler-1.0+dfsg1/jobs.c:1531:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(fd,buffer,strlen(buffer));
data/task-spooler-1.0+dfsg1/list.c:98:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
maxlen = 4 + 1 + 10 + 1 + max(20, strlen(output_filename)) + 1 + 8 + 1
data/task-spooler-1.0+dfsg1/list.c:99:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
+ 14 + 1 + strlen(p->command) + 20; /* 20 is the margin for errors */
data/task-spooler-1.0+dfsg1/list.c:102:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
maxlen += 3 + strlen(p->label);
data/task-spooler-1.0+dfsg1/list.c:151:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
maxlen = 4 + 1 + 10 + 1 + max(20, strlen(output_filename)) + 1 + 8 + 1
data/task-spooler-1.0+dfsg1/list.c:152:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
+ 14 + 1 + strlen(p->command) + 20; /* 20 is the margin for errors */
data/task-spooler-1.0+dfsg1/list.c:155:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
maxlen += 3 + strlen(p->label);
data/task-spooler-1.0+dfsg1/list.c:214:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
maxlen = 10 + strlen(p->command) + 20; /* 20 is the margin for errors */
data/task-spooler-1.0+dfsg1/mail.c:72:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read_bytes = read(file_fd, buffer, 1000);
data/task-spooler-1.0+dfsg1/mail.c:125:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (env_to == NULL || strlen(env_to) > 100)
data/task-spooler-1.0+dfsg1/main.c:61:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(str) >= 50)
data/task-spooler-1.0+dfsg1/server.c:182:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
dirpath = malloc(strlen(path)+1);
data/task-spooler-1.0+dfsg1/server_start.c:39:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size = strlen(*path) + 1;
data/task-spooler-1.0+dfsg1/server_start.c:59:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size = strlen(tmpdir) + strlen("/socket-ts.") + strlen(userid) + 1;
data/task-spooler-1.0+dfsg1/server_start.c:59:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size = strlen(tmpdir) + strlen("/socket-ts.") + strlen(userid) + 1;
data/task-spooler-1.0+dfsg1/server_start.c:59:53: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size = strlen(tmpdir) + strlen("/socket-ts.") + strlen(userid) + 1;
data/task-spooler-1.0+dfsg1/server_start.c:76:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(addr.sun_path, socket_path, sizeof(addr.sun_path) - 1);
data/task-spooler-1.0+dfsg1/server_start.c:107:5: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read(fd, &a, 1);
data/task-spooler-1.0+dfsg1/tail.c:73:21: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
last_read = read(fd, buf, next_read);
data/task-spooler-1.0+dfsg1/tail.c:159:13: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(1 /* sec */* 1000000);
data/task-spooler-1.0+dfsg1/tail.c:174:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
res = read(fd, buf, BSIZE);
ANALYSIS SUMMARY:
Hits = 151
Lines analyzed = 5446 in approximately 0.14 seconds (38902 lines/second)
Physical Source Lines of Code (SLOC) = 4256
Hits@level = [0] 133 [1] 49 [2] 67 [3] 14 [4] 21 [5] 0
Hits@level+ = [0+] 284 [1+] 151 [2+] 102 [3+] 35 [4+] 21 [5+] 0
Hits/KSLOC@level+ = [0+] 66.7293 [1+] 35.4793 [2+] 23.9662 [3+] 8.22368 [4+] 4.93421 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.