Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/tempest-for-eliza-1.0.5/player.cpp Examining data/tempest-for-eliza-1.0.5/mp3player.cpp FINAL RESULTS: data/tempest-for-eliza-1.0.5/mp3player.cpp:69:8: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). resx=atol(argv[2]); data/tempest-for-eliza-1.0.5/mp3player.cpp:70:8: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). resy=atol(argv[3]); data/tempest-for-eliza-1.0.5/mp3player.cpp:71:18: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). horizontalspan=atol(argv[4]); data/tempest-for-eliza-1.0.5/mp3player.cpp:72:16: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). verticalspan=atol(argv[5]); data/tempest-for-eliza-1.0.5/mp3player.cpp:74:16: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). playbackmode=atoi(argv[7]); data/tempest-for-eliza-1.0.5/mp3player.cpp:133:13: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). input = fopen(filename,"rb"); data/tempest-for-eliza-1.0.5/player.cpp:276:8: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). resx=atol(argv[2]); data/tempest-for-eliza-1.0.5/player.cpp:277:8: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). resy=atol(argv[3]); data/tempest-for-eliza-1.0.5/player.cpp:278:18: [2] (integer) atol: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). horizontalspan=atol(argv[4]); data/tempest-for-eliza-1.0.5/player.cpp:313:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char song[100000]; data/tempest-for-eliza-1.0.5/player.cpp:314:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *input=fopen(filename,"r"); data/tempest-for-eliza-1.0.5/player.cpp:218:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). while (pos<int(strlen(song))) { data/tempest-for-eliza-1.0.5/player.cpp:321:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (unsigned i=0;i<strlen(song);i++) ANALYSIS SUMMARY: Hits = 13 Lines analyzed = 518 in approximately 0.03 seconds (17145 lines/second) Physical Source Lines of Code (SLOC) = 420 Hits@level = [0] 17 [1] 2 [2] 11 [3] 0 [4] 0 [5] 0 Hits@level+ = [0+] 30 [1+] 13 [2+] 11 [3+] 0 [4+] 0 [5+] 0 Hits/KSLOC@level+ = [0+] 71.4286 [1+] 30.9524 [2+] 26.1905 [3+] 0 [4+] 0 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.