Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/thunar-4.15.3/plugins/thunar-wallpaper/twp-provider.h
Examining data/thunar-4.15.3/plugins/thunar-wallpaper/thunar-wallpaper-plugin.c
Examining data/thunar-4.15.3/plugins/thunar-wallpaper/twp-provider.c
Examining data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-desktop-page.h
Examining data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-plugin.c
Examining data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-abstract-page.h
Examining data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-abstract-page.c
Examining data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-provider.c
Examining data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-desktop-page.c
Examining data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-private.c
Examining data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-private.h
Examining data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-image-page.h
Examining data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-provider.h
Examining data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-image-page.c
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-context.c
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-chooser.c
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-private.h
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-model.h
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-provider.h
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-private.c
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-model.c
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-context.h
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-editor.h
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-plugin.c
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-provider.c
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca.gresource.c
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-editor.c
Examining data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-chooser.h
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-case-renamer.h
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-replace-renamer.h
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-remove-renamer.c
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-case-renamer.c
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-date-renamer.c
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-insert-renamer.h
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-enum-types.h
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-provider.c
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-number-renamer.h
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-replace-renamer.c
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-number-renamer.c
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-date-renamer.h
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-enum-types.c
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-insert-renamer.c
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-provider.h
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-remove-renamer.h
Examining data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-plugin.c
Examining data/thunar-4.15.3/plugins/thunar-tpa/thunar-tpa.c
Examining data/thunar-4.15.3/plugins/thunar-tpa/thunar-tpa-bindings.c
Examining data/thunar-4.15.3/plugins/thunar-tpa/thunar-tpa-bindings.h
Examining data/thunar-4.15.3/plugins/thunar-sendto-email/main.c
Examining data/thunar-4.15.3/thunar/thunar-properties-dialog.c
Examining data/thunar-4.15.3/thunar/thunar-gtk-extensions.h
Examining data/thunar-4.15.3/thunar/thunar-history.c
Examining data/thunar-4.15.3/thunar/thunar-notify.h
Examining data/thunar-4.15.3/thunar/thunar-transfer-job.c
Examining data/thunar-4.15.3/thunar/thunar-thumbnailer.c
Examining data/thunar-4.15.3/thunar/thunar-dialogs.c
Examining data/thunar-4.15.3/thunar/thunar-location-bar.h
Examining data/thunar-4.15.3/thunar/thunar-chooser-dialog.c
Examining data/thunar-4.15.3/thunar/thunar-resources.h
Examining data/thunar-4.15.3/thunar/thunar-device.c
Examining data/thunar-4.15.3/thunar/thunar-transfer-job.h
Examining data/thunar-4.15.3/thunar/thunar-progress-view.c
Examining data/thunar-4.15.3/thunar/thunar-gobject-extensions.h
Examining data/thunar-4.15.3/thunar/thunar-ice.h
Examining data/thunar-4.15.3/thunar/thunar-location-entry.c
Examining data/thunar-4.15.3/thunar/thunar-browser.c
Examining data/thunar-4.15.3/thunar/thunar-chooser-button.h
Examining data/thunar-4.15.3/thunar/thunar-shortcuts-icon-renderer.c
Examining data/thunar-4.15.3/thunar/thunar-private.h
Examining data/thunar-4.15.3/thunar/thunar-device-monitor.h
Examining data/thunar-4.15.3/thunar/thunar-job.h
Examining data/thunar-4.15.3/thunar/thunar-view.c
Examining data/thunar-4.15.3/thunar/thunar-preferences-dialog.c
Examining data/thunar-4.15.3/thunar/thunar-location-buttons.h
Examining data/thunar-4.15.3/thunar/thunar-dbus-freedesktop-interfaces.h
Examining data/thunar-4.15.3/thunar/thunar-gdk-extensions.c
Examining data/thunar-4.15.3/thunar/thunar-user.h
Examining data/thunar-4.15.3/thunar/thunar-folder.h
Examining data/thunar-4.15.3/thunar/thunar-window.h
Examining data/thunar-4.15.3/thunar/thunar-details-view.h
Examining data/thunar-4.15.3/thunar/thunar-path-entry.h
Examining data/thunar-4.15.3/thunar/thunar-column-editor.c
Examining data/thunar-4.15.3/thunar/thunar-clipboard-manager.h
Examining data/thunar-4.15.3/thunar/thunar-dnd.h
Examining data/thunar-4.15.3/thunar/thunar-progress-dialog.h
Examining data/thunar-4.15.3/thunar/thunar-statusbar.c
Examining data/thunar-4.15.3/thunar/thunar-notify.c
Examining data/thunar-4.15.3/thunar/thunar-gio-extensions.h
Examining data/thunar-4.15.3/thunar/thunar-application.h
Examining data/thunar-4.15.3/thunar/thunar-component.c
Examining data/thunar-4.15.3/thunar/thunar-folder.c
Examining data/thunar-4.15.3/thunar/thunar-file.h
Examining data/thunar-4.15.3/thunar/thunar-file-monitor.h
Examining data/thunar-4.15.3/thunar/thunar-chooser-dialog.h
Examining data/thunar-4.15.3/thunar/thunar-renamer-dialog.h
Examining data/thunar-4.15.3/thunar/thunar-dbus-service.c
Examining data/thunar-4.15.3/thunar/thunar-io-jobs-util.c
Examining data/thunar-4.15.3/thunar/thunar-renamer-pair.h
Examining data/thunar-4.15.3/thunar/thunar-user.c
Examining data/thunar-4.15.3/thunar/thunar-gdk-extensions.h
Examining data/thunar-4.15.3/thunar/thunar-renamer-model.h
Examining data/thunar-4.15.3/thunar/thunar-pango-extensions.h
Examining data/thunar-4.15.3/thunar/thunar-dbus-freedesktop-interfaces.c
Examining data/thunar-4.15.3/thunar/thunar-tree-view.c
Examining data/thunar-4.15.3/thunar/thunar-device-monitor.c
Examining data/thunar-4.15.3/thunar/thunar-io-scan-directory.c
Examining data/thunar-4.15.3/thunar/thunar-side-pane.c
Examining data/thunar-4.15.3/thunar/thunar-component.h
Examining data/thunar-4.15.3/thunar/thunar-column-model.h
Examining data/thunar-4.15.3/thunar/thunar-compact-view.h
Examining data/thunar-4.15.3/thunar/thunar-resources.c
Examining data/thunar-4.15.3/thunar/thunar-dialogs.h
Examining data/thunar-4.15.3/thunar/thunar-size-label.h
Examining data/thunar-4.15.3/thunar/thunar-file-monitor.c
Examining data/thunar-4.15.3/thunar/thunar-abstract-dialog.c
Examining data/thunar-4.15.3/thunar/thunar-application.c
Examining data/thunar-4.15.3/thunar/thunar-details-view.c
Examining data/thunar-4.15.3/thunar/thunar-simple-job.c
Examining data/thunar-4.15.3/thunar/thunar-deep-count-job.h
Examining data/thunar-4.15.3/thunar/thunar-shortcuts-model.h
Examining data/thunar-4.15.3/thunar/thunar-navigator.c
Examining data/thunar-4.15.3/thunar/main.c
Examining data/thunar-4.15.3/thunar/thunar-clipboard-manager.c
Examining data/thunar-4.15.3/thunar/thunar-image.c
Examining data/thunar-4.15.3/thunar/thunar-marshal.c
Examining data/thunar-4.15.3/thunar/thunar-list-model.c
Examining data/thunar-4.15.3/thunar/thunar-location-buttons.c
Examining data/thunar-4.15.3/thunar/thunar-thumbnailer-proxy.c
Examining data/thunar-4.15.3/thunar/thunar-session-client.c
Examining data/thunar-4.15.3/thunar/thunar-enum-types.c
Examining data/thunar-4.15.3/thunar/thunar-launcher.h
Examining data/thunar-4.15.3/thunar/thunar-dnd.c
Examining data/thunar-4.15.3/thunar/thunar-renamer-model.c
Examining data/thunar-4.15.3/thunar/thunar-dbus-service-infos.h
Examining data/thunar-4.15.3/thunar/thunar-column-model.c
Examining data/thunar-4.15.3/thunar/thunar-session-client.h
Examining data/thunar-4.15.3/thunar/thunar-list-model.h
Examining data/thunar-4.15.3/thunar/thunar-thumbnail-cache.h
Examining data/thunar-4.15.3/thunar/thunar-standard-view.c
Examining data/thunar-4.15.3/thunar/thunar-menu.h
Examining data/thunar-4.15.3/thunar/thunar-thumbnailer-proxy.h
Examining data/thunar-4.15.3/thunar/thunar-preferences.c
Examining data/thunar-4.15.3/thunar/thunar-icon-renderer.c
Examining data/thunar-4.15.3/thunar/thunar-icon-factory.h
Examining data/thunar-4.15.3/thunar/thunar-chooser-button.c
Examining data/thunar-4.15.3/thunar/thunar-abstract-dialog.h
Examining data/thunar-4.15.3/thunar/thunar-path-entry.c
Examining data/thunar-4.15.3/thunar/thunar-compact-view.c
Examining data/thunar-4.15.3/thunar/thunar-side-pane.h
Examining data/thunar-4.15.3/thunar/thunar-shortcuts-pane.c
Examining data/thunar-4.15.3/thunar/thunar-thumbnailer.h
Examining data/thunar-4.15.3/thunar/thunar-shortcuts-view.h
Examining data/thunar-4.15.3/thunar/thunar-device.h
Examining data/thunar-4.15.3/thunar/thunar-util.h
Examining data/thunar-4.15.3/thunar/thunar-image.h
Examining data/thunar-4.15.3/thunar/thunar-statusbar.h
Examining data/thunar-4.15.3/thunar/thunar-marshal.h
Examining data/thunar-4.15.3/thunar/thunar-size-label.c
Examining data/thunar-4.15.3/thunar/thunar-icon-view.c
Examining data/thunar-4.15.3/thunar/thunar-icon-renderer.h
Examining data/thunar-4.15.3/thunar/thunar-renamer-pair.c
Examining data/thunar-4.15.3/thunar/thunar-gtk-extensions.c
Examining data/thunar-4.15.3/thunar/thunar-dbus-service-infos.c
Examining data/thunar-4.15.3/thunar/thunar-file.c
Examining data/thunar-4.15.3/thunar/thunar-tree-pane.h
Examining data/thunar-4.15.3/thunar/thunar-tree-model.h
Examining data/thunar-4.15.3/thunar/thunar-permissions-chooser.c
Examining data/thunar-4.15.3/thunar/thunar-abstract-icon-view.h
Examining data/thunar-4.15.3/thunar/thunar-progress-view.h
Examining data/thunar-4.15.3/thunar/thunar-enum-types.h
Examining data/thunar-4.15.3/thunar/thunar-dbus-service.h
Examining data/thunar-4.15.3/thunar/thunar-ice.c
Examining data/thunar-4.15.3/thunar/thunar-column-editor.h
Examining data/thunar-4.15.3/thunar/thunar-location-bar.c
Examining data/thunar-4.15.3/thunar/thunar-thumbnail-cache-proxy.h
Examining data/thunar-4.15.3/thunar/thunar-renamer-progress.c
Examining data/thunar-4.15.3/thunar/thunar-io-jobs.h
Examining data/thunar-4.15.3/thunar/thunar-io-jobs-util.h
Examining data/thunar-4.15.3/thunar/thunar-thumbnail-cache-proxy.c
Examining data/thunar-4.15.3/thunar/thunar-tree-model.c
Examining data/thunar-4.15.3/thunar/thunar-view.h
Examining data/thunar-4.15.3/thunar/thunar-gio-extensions.c
Examining data/thunar-4.15.3/thunar/thunar-emblem-chooser.h
Examining data/thunar-4.15.3/thunar/thunar-shortcuts-pane.h
Examining data/thunar-4.15.3/thunar/thunar-emblem-chooser.c
Examining data/thunar-4.15.3/thunar/thunar-tree-view.h
Examining data/thunar-4.15.3/thunar/thunar-sendto-model.c
Examining data/thunar-4.15.3/thunar/thunar-window.c
Examining data/thunar-4.15.3/thunar/thunar-navigator.h
Examining data/thunar-4.15.3/thunar/thunar-launcher.c
Examining data/thunar-4.15.3/thunar/thunar-location-button.c
Examining data/thunar-4.15.3/thunar/thunar-deep-count-job.c
Examining data/thunar-4.15.3/thunar/thunar-job.c
Examining data/thunar-4.15.3/thunar/thunar-icon-view.h
Examining data/thunar-4.15.3/thunar/thunar-renamer-progress.h
Examining data/thunar-4.15.3/thunar/thunar-simple-job.h
Examining data/thunar-4.15.3/thunar/thunar-gobject-extensions.c
Examining data/thunar-4.15.3/thunar/thunar-location-entry.h
Examining data/thunar-4.15.3/thunar/thunar-renamer-dialog.c
Examining data/thunar-4.15.3/thunar/thunar-preferences-dialog.h
Examining data/thunar-4.15.3/thunar/thunar-history.h
Examining data/thunar-4.15.3/thunar/thunar-shortcuts-view.c
Examining data/thunar-4.15.3/thunar/thunar-properties-dialog.h
Examining data/thunar-4.15.3/thunar/thunar-tree-pane.c
Examining data/thunar-4.15.3/thunar/thunar-standard-view.h
Examining data/thunar-4.15.3/thunar/thunar-chooser-model.c
Examining data/thunar-4.15.3/thunar/thunar-browser.h
Examining data/thunar-4.15.3/thunar/thunar-icon-factory.c
Examining data/thunar-4.15.3/thunar/thunar-progress-dialog.c
Examining data/thunar-4.15.3/thunar/thunar-shortcuts-model.c
Examining data/thunar-4.15.3/thunar/thunar-shortcuts-icon-renderer.h
Examining data/thunar-4.15.3/thunar/thunar-sendto-model.h
Examining data/thunar-4.15.3/thunar/thunar-permissions-chooser.h
Examining data/thunar-4.15.3/thunar/thunar-abstract-icon-view.c
Examining data/thunar-4.15.3/thunar/thunar-preferences.h
Examining data/thunar-4.15.3/thunar/thunar-chooser-model.h
Examining data/thunar-4.15.3/thunar/thunar-util.c
Examining data/thunar-4.15.3/thunar/thunar-location-button.h
Examining data/thunar-4.15.3/thunar/thunar-io-jobs.c
Examining data/thunar-4.15.3/thunar/thunar-menu.c
Examining data/thunar-4.15.3/thunar/thunar-thumbnail-cache.c
Examining data/thunar-4.15.3/thunar/thunar-io-scan-directory.h
Examining data/thunar-4.15.3/thunar/thunar-pango-extensions.c
Examining data/thunar-4.15.3/examples/tex-open-terminal/tex-open-terminal.h
Examining data/thunar-4.15.3/examples/tex-open-terminal/tex-open-terminal.c
Examining data/thunar-4.15.3/examples/tex-open-terminal/tex-open-terminal-plugin.c
Examining data/thunar-4.15.3/thunarx/thunarx-provider-module.h
Examining data/thunar-4.15.3/thunarx/thunarx-config.c
Examining data/thunar-4.15.3/thunarx/thunarx-preferences-provider.c
Examining data/thunar-4.15.3/thunarx/thunarx-menu-item.c
Examining data/thunar-4.15.3/thunarx/thunarx.h
Examining data/thunar-4.15.3/thunarx/thunarx-private.h
Examining data/thunar-4.15.3/thunarx/thunarx-file-info.c
Examining data/thunar-4.15.3/thunarx/thunarx-property-page-provider.c
Examining data/thunar-4.15.3/thunarx/thunarx-config.h
Examining data/thunar-4.15.3/thunarx/thunarx-provider-plugin.c
Examining data/thunar-4.15.3/thunarx/thunarx-menu-provider.c
Examining data/thunar-4.15.3/thunarx/thunarx-renamer.h
Examining data/thunar-4.15.3/thunarx/thunarx-property-page-provider.h
Examining data/thunar-4.15.3/thunarx/thunarx-renamer.c
Examining data/thunar-4.15.3/thunarx/thunarx-menu.c
Examining data/thunar-4.15.3/thunarx/thunarx-menu-provider.h
Examining data/thunar-4.15.3/thunarx/thunarx-preferences-provider.h
Examining data/thunar-4.15.3/thunarx/thunarx-menu-item.h
Examining data/thunar-4.15.3/thunarx/thunarx-renamer-provider.c
Examining data/thunar-4.15.3/thunarx/thunarx-provider-plugin.h
Examining data/thunar-4.15.3/thunarx/thunarx-renamer-provider.h
Examining data/thunar-4.15.3/thunarx/thunarx-provider-factory.h
Examining data/thunar-4.15.3/thunarx/thunarx-menu.h
Examining data/thunar-4.15.3/thunarx/thunarx-file-info.h
Examining data/thunar-4.15.3/thunarx/thunarx-property-page.c
Examining data/thunar-4.15.3/thunarx/thunarx-property-page.h
Examining data/thunar-4.15.3/thunarx/thunarx-private.c
Examining data/thunar-4.15.3/thunarx/thunarx-provider-factory.c
Examining data/thunar-4.15.3/thunarx/thunarx-provider-module.c
FINAL RESULTS:
data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-desktop-page.c:47:35: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
#define g_access(filename, mode) (access ((filename), (mode)))
data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-model.c:256:22: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
uca_model->stamp = g_random_int ();
data/thunar-4.15.3/thunar/thunar-application.c:1328:72: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
role = g_strdup_printf ("Thunar-%u-%u", (guint) time (NULL), (guint) g_random_int ());
data/thunar-4.15.3/thunar/thunar-column-model.c:192:25: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
column_model->stamp = g_random_int ();
data/thunar-4.15.3/thunar/thunar-list-model.c:434:18: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
store->stamp = g_random_int ();
data/thunar-4.15.3/thunar/thunar-list-model.c:1926:18: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
store->stamp = g_random_int ();
data/thunar-4.15.3/thunar/thunar-renamer-model.c:276:26: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
renamer_model->stamp = g_random_int ();
data/thunar-4.15.3/thunar/thunar-shortcuts-model.c:281:18: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
model->stamp = g_random_int ();
data/thunar-4.15.3/thunar/thunar-tree-model.c:294:18: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
model->stamp = g_random_int ();
data/thunar-4.15.3/thunar/thunar-util.c:203:42: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
bookmarks_path = g_build_filename (g_get_home_dir (), ".gtk-bookmarks", NULL);
data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-desktop-page.c:583:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen (filename, "w");
data/thunar-4.15.3/thunar/thunar-chooser-dialog.c:97:84: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gboolean open);
data/thunar-4.15.3/thunar/thunar-chooser-dialog.c:110:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gboolean open;
data/thunar-4.15.3/thunar/thunar-chooser-dialog.c:478:36: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (G_LIKELY (succeed && dialog->open))
data/thunar-4.15.3/thunar/thunar-chooser-dialog.c:1133:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
return dialog->open;
data/thunar-4.15.3/thunar/thunar-chooser-dialog.c:1147:54: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gboolean open)
data/thunar-4.15.3/thunar/thunar-chooser-dialog.c:1152:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dialog->open = open;
data/thunar-4.15.3/thunar/thunar-chooser-dialog.c:1155:61: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gtk_button_set_label (GTK_BUTTON (dialog->accept_button), open ? _("_Open") : _("_OK"));
data/thunar-4.15.3/thunar/thunar-chooser-dialog.c:1182:41: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gboolean open)
data/thunar-4.15.3/thunar/thunar-chooser-dialog.c:1213:34: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
"open", open,
data/thunar-4.15.3/thunar/thunar-chooser-dialog.h:41:67: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gboolean open);
data/thunar-4.15.3/thunar/thunar-dbus-service.c:85:90: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gboolean open,
data/thunar-4.15.3/thunar/thunar-dbus-service.c:439:69: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gboolean open,
data/thunar-4.15.3/thunar/thunar-dbus-service.c:454:45: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
thunar_show_chooser_dialog (screen, file, open);
data/thunar-4.15.3/thunar/thunar-session-client.c:395:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen (session_client->path, "w");
data/thunar-4.15.3/thunar/thunar-util.c:198:8: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen (bookmarks_path, "r");
data/thunar-4.15.3/thunar/thunar-util.c:204:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(bookmarks_path, "r");
data/thunar-4.15.3/examples/tex-open-terminal/tex-open-terminal-plugin.c:44:16: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
const gchar *mismatch;
data/thunar-4.15.3/examples/tex-open-terminal/tex-open-terminal-plugin.c:48:19: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
if (G_UNLIKELY (mismatch != NULL))
data/thunar-4.15.3/examples/tex-open-terminal/tex-open-terminal-plugin.c:50:42: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
g_warning ("Version mismatch: %s", mismatch);
data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-plugin.c:46:16: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
const gchar *mismatch;
data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-plugin.c:50:19: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
if (G_UNLIKELY (mismatch != NULL))
data/thunar-4.15.3/plugins/thunar-apr/thunar-apr-plugin.c:52:42: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
g_warning ("Version mismatch: %s", mismatch);
data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-number-renamer.c:391:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
invalid = (strlen (number_renamer->start) != 1
data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-number-renamer.c:486:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
invalid = (strlen (number_renamer->start) != 1
data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-plugin.c:49:16: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
const gchar *mismatch;
data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-plugin.c:53:19: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
if (G_UNLIKELY (mismatch != NULL))
data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-plugin.c:55:42: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
g_warning ("Version mismatch: %s", mismatch);
data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-replace-renamer.c:466:69: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
rc = pcre_exec (replace_renamer->pcre_pattern, NULL, subject, strlen (subject), 0, PCRE_NOTEMPTY, ovec, olen);
data/thunar-4.15.3/plugins/thunar-sbr/thunar-sbr-replace-renamer.c:522:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
second = strlen (subject) - 1;
data/thunar-4.15.3/plugins/thunar-sendto-email/main.c:376:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen (tmpl);
data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-plugin.c:46:16: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
const gchar *mismatch;
data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-plugin.c:50:19: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
if (G_UNLIKELY (mismatch != NULL))
data/thunar-4.15.3/plugins/thunar-uca/thunar-uca-plugin.c:52:42: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
g_warning ("Version mismatch: %s", mismatch);
data/thunar-4.15.3/plugins/thunar-uca/thunar-uca.gresource.c:677:31: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
__pragma(section(".CRT$XCU",read)) \
data/thunar-4.15.3/plugins/thunar-uca/thunar-uca.gresource.c:685:31: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
__pragma(section(".CRT$XCU",read)) \
data/thunar-4.15.3/plugins/thunar-uca/thunar-uca.gresource.c:697:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
section(".CRT$XCU",read)
data/thunar-4.15.3/plugins/thunar-uca/thunar-uca.gresource.c:704:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
section(".CRT$XCU",read)
data/thunar-4.15.3/plugins/thunar-wallpaper/thunar-wallpaper-plugin.c:45:16: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
const gchar *mismatch;
data/thunar-4.15.3/plugins/thunar-wallpaper/thunar-wallpaper-plugin.c:49:19: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
if (G_UNLIKELY (mismatch != NULL))
data/thunar-4.15.3/plugins/thunar-wallpaper/thunar-wallpaper-plugin.c:51:42: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
g_warning ("Version mismatch: %s", mismatch);
data/thunar-4.15.3/thunar/thunar-dialogs.c:961:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (separator[strlen (separator - 1)] != '.')
data/thunar-4.15.3/thunar/thunar-file.c:3509:62: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_checksum_update (checksum, (const guchar *) uri, strlen (uri));
data/thunar-4.15.3/thunar/thunar-gdk-extensions.c:189:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (other_name, display_name, strlen (display_name)) == 0)
data/thunar-4.15.3/thunar/thunar-gdk-extensions.c:195:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (other_name, display_name, strlen (other_name)) == 0)
data/thunar-4.15.3/thunar/thunar-gio-extensions.c:333:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p = parse_name + strlen (scheme);
data/thunar-4.15.3/thunar/thunar-path-entry.c:1134:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (*text != '\0' && text[strlen (text) - 1] != '/')
data/thunar-4.15.3/thunar/thunar-resources.c:149:31: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
__pragma(section(".CRT$XCU",read)) \
data/thunar-4.15.3/thunar/thunar-resources.c:157:31: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
__pragma(section(".CRT$XCU",read)) \
data/thunar-4.15.3/thunar/thunar-resources.c:169:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
section(".CRT$XCU",read)
data/thunar-4.15.3/thunar/thunar-resources.c:176:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
section(".CRT$XCU",read)
data/thunar-4.15.3/thunar/thunar-session-client.c:224:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
value_discard[2].length = strlen (session_client->path);
data/thunar-4.15.3/thunar/thunar-session-client.c:242:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
value_restart[2].length = strlen (session_client->id);
data/thunar-4.15.3/thunar/thunar-session-client.c:252:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
value_userid[0].length = strlen (value_userid[0].value);
data/thunar-4.15.3/thunar/thunar-standard-view.c:2456:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen (uri));
data/thunar-4.15.3/thunar/thunar-window.c:2190:54: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_checksum_update (checksum, (const guchar *) uri, strlen (uri));
data/thunar-4.15.3/thunarx/thunarx-private.c:74:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
name = g_new (gchar, strlen (pspec->name) + 1);
ANALYSIS SUMMARY:
Hits = 67
Lines analyzed = 116658 in approximately 2.45 seconds (47620 lines/second)
Physical Source Lines of Code (SLOC) = 73436
Hits@level = [0] 19 [1] 40 [2] 17 [3] 9 [4] 1 [5] 0
Hits@level+ = [0+] 86 [1+] 67 [2+] 27 [3+] 10 [4+] 1 [5+] 0
Hits/KSLOC@level+ = [0+] 1.17109 [1+] 0.912359 [2+] 0.367667 [3+] 0.136173 [4+] 0.0136173 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.