Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/ttylog-0.31/ttylog.c FINAL RESULTS: data/ttylog-0.31/ttylog.c:60:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line[1024], modem_device[512]; data/ttylog-0.31/ttylog.c:157:19: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). int sec = atoi(argv[i + 1]); data/ttylog-0.31/ttylog.c:163:37: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). new_value.it_value.tv_sec = atoi(argv[i + 1]); data/ttylog-0.31/ttylog.c:178:13: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). logfile = fopen (modem_device, "rb"); data/ttylog-0.31/ttylog.c:134:13: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy (modem_device, argv[i + 1], sizeof(modem_device)-1); data/ttylog-0.31/ttylog.c:173:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (!strlen(modem_device)) { data/ttylog-0.31/ttylog.c:227:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). timestr[strlen(timestr) - 1] = 0; ANALYSIS SUMMARY: Hits = 7 Lines analyzed = 242 in approximately 0.03 seconds (9164 lines/second) Physical Source Lines of Code (SLOC) = 191 Hits@level = [0] 26 [1] 3 [2] 4 [3] 0 [4] 0 [5] 0 Hits@level+ = [0+] 33 [1+] 7 [2+] 4 [3+] 0 [4+] 0 [5+] 0 Hits/KSLOC@level+ = [0+] 172.775 [1+] 36.6492 [2+] 20.9424 [3+] 0 [4+] 0 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.