Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/twm-1.0.10/src/deftwmrc.c
Examining data/twm-1.0.10/src/iconmgr.c
Examining data/twm-1.0.10/src/resize.c
Examining data/twm-1.0.10/src/util.h
Examining data/twm-1.0.10/src/gram.h
Examining data/twm-1.0.10/src/version.c
Examining data/twm-1.0.10/src/add_window.c
Examining data/twm-1.0.10/src/events.h
Examining data/twm-1.0.10/src/list.h
Examining data/twm-1.0.10/src/icons.h
Examining data/twm-1.0.10/src/gc.c
Examining data/twm-1.0.10/src/twm.c
Examining data/twm-1.0.10/src/menus.c
Examining data/twm-1.0.10/src/session.c
Examining data/twm-1.0.10/src/parse.h
Examining data/twm-1.0.10/src/gram.c
Examining data/twm-1.0.10/src/version.h
Examining data/twm-1.0.10/src/add_window.h
Examining data/twm-1.0.10/src/events.c
Examining data/twm-1.0.10/src/cursor.c
Examining data/twm-1.0.10/src/util.c
Examining data/twm-1.0.10/src/resize.h
Examining data/twm-1.0.10/src/screen.h
Examining data/twm-1.0.10/src/iconmgr.h
Examining data/twm-1.0.10/src/session.h
Examining data/twm-1.0.10/src/parse.c
Examining data/twm-1.0.10/src/gc.h
Examining data/twm-1.0.10/src/twm.h
Examining data/twm-1.0.10/src/menus.h
Examining data/twm-1.0.10/src/list.c
Examining data/twm-1.0.10/src/icons.c
Examining data/twm-1.0.10/src/lex.c
FINAL RESULTS:
data/twm-1.0.10/src/gram.c:1004:21: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
# define YYFPRINTF fprintf
data/twm-1.0.10/src/menus.c:1356:2: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(*Argv, Argv);
data/twm-1.0.10/src/menus.c:2001:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(tmp, action);
data/twm-1.0.10/src/menus.c:2009:10: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
if (sscanf (ptr, "%s", tmp) == 1) {
data/twm-1.0.10/src/menus.c:2246:2: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execlp("/bin/sh", "sh", "-c", action, (void *)NULL);
data/twm-1.0.10/src/menus.c:2358:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (oldDisplay, doisplay);
data/twm-1.0.10/src/menus.c:2369:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, ds);
data/twm-1.0.10/src/menus.c:2378:12: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
(void) system (s);
data/twm-1.0.10/src/session.c:702:20: [4] (tmpfile) mktemp:
Temporary file race condition (CWE-377).
tmp = (char *) mktemp (tempFile);
data/twm-1.0.10/src/util.c:272:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
(void) sprintf (newname, "%s/%s", Home, &name[1]);
data/twm-1.0.10/src/util.c:364:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
(void) sprintf (bigname, "%s/%s", Scr->IconDirectory, name);
data/twm-1.0.10/src/menus.c:2356:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
doisplay=getenv("DISPLAY");
data/twm-1.0.10/src/parse.c:180:10: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
home = getenv ("HOME");
data/twm-1.0.10/src/session.c:696:22: [3] (tmpfile) tempnam:
Temporary file race condition (CWE-377).
return ((char *) tempnam (path, prefix));
data/twm-1.0.10/src/session.c:778:12: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
path = getenv ("SM_SAVE_DIR");
data/twm-1.0.10/src/session.c:781:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
path = getenv ("HOME");
data/twm-1.0.10/src/twm.c:306:12: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
Home = getenv("HOME");
data/twm-1.0.10/src/gram.c:1250:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char const *yyarg[YYERROR_VERBOSE_ARGS_MAXIMUM];
data/twm-1.0.10/src/gram.c:1437:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char yymsgbuf[128];
data/twm-1.0.10/src/gram.c:2451:44: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
AddToList(list, (yyvsp[-2].ptr), (char *)
data/twm-1.0.10/src/gram.c:2461:44: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
AddToList(list, (yyvsp[-3].ptr), (char *)
data/twm-1.0.10/src/iconmgr.c:61:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[100];
data/twm-1.0.10/src/iconmgr.c:62:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str1[100];
data/twm-1.0.10/src/menus.c:1022:56: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
AddToMenu(menu, WindowNames[i]->name, (char *)WindowNames[i],
data/twm-1.0.10/src/menus.c:1295:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[200];
data/twm-1.0.10/src/menus.c:1297:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[MAX_FILE_SIZE];
data/twm-1.0.10/src/menus.c:2013:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open (ptr, O_RDONLY);
data/twm-1.0.10/src/menus.c:2042:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
WarpToScreen (atoi (action), 0);
data/twm-1.0.10/src/menus.c:2175:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(ptr, O_RDONLY);
data/twm-1.0.10/src/menus.c:2242:46: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
(void)XSyncSetPriority(dpy, tmp_win->w, atoi(action));
data/twm-1.0.10/src/menus.c:2348:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[256];
data/twm-1.0.10/src/menus.c:2351:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char oldDisplay[256];
data/twm-1.0.10/src/menus.c:2368:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (buf, "DISPLAY=");
data/twm-1.0.10/src/menus.c:2373:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
(void) sprintf (dot1, ".%d", Scr->screen);
data/twm-1.0.10/src/parse.c:81:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char buff[BUF_LEN+1];
data/twm-1.0.10/src/parse.c:82:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char overflowbuff[20]; /* really only need one */
data/twm-1.0.10/src/parse.c:166:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmpfilename[257];
data/twm-1.0.10/src/parse.c:202:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (cp) twmrc = fopen (cp, "r");
data/twm-1.0.10/src/resize.c:481:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[100];
data/twm-1.0.10/src/session.c:146:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char file_short[2];
data/twm-1.0.10/src/session.c:159:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char file_short[2];
data/twm-1.0.10/src/session.c:204:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char file_short[2];
data/twm-1.0.10/src/session.c:216:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char file_short[2];
data/twm-1.0.10/src/session.c:520:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
configFile = fopen (filename, "rb");
data/twm-1.0.10/src/session.c:698:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tempFile[PATH_MAX];
data/twm-1.0.10/src/session.c:709:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tempFile[PATH_MAX];
data/twm-1.0.10/src/session.c:715:9: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
*pFd = mkstemp (ptr);
data/twm-1.0.10/src/session.c:735:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char discardCommand[80];
data/twm-1.0.10/src/session.c:744:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char userId[20];
data/twm-1.0.10/src/session.c:789:24: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(configFile = fopen (filename, "wb")))
data/twm-1.0.10/src/session.c:962:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorMsg[256];
data/twm-1.0.10/src/twm.c:113:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char Info[INFO_LINES][INFO_SIZE]; /* info strings to print */
data/twm-1.0.10/src/add_window.c:278:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
namelen = strlen (tmp_win->name);
data/twm-1.0.10/src/events.c:620:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(key->win_name);
data/twm-1.0.10/src/events.c:783:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen (Tmp_win->name));
data/twm-1.0.10/src/events.c:967:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
Tmp_win->icon_name, strlen(Tmp_win->icon_name));
data/twm-1.0.10/src/events.c:1066:3: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(Info[i]));
data/twm-1.0.10/src/events.c:1079:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
Tmp_win->name, strlen(Tmp_win->name));
data/twm-1.0.10/src/events.c:1089:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
Tmp_win->icon_name, strlen(Tmp_win->icon_name));
data/twm-1.0.10/src/events.c:1119:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
Tmp_win->icon_name, strlen(Tmp_win->icon_name));
data/twm-1.0.10/src/gram.c:1150:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
# define yystrlen strlen
data/twm-1.0.10/src/icons.c:478:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp_win->icon_name, strlen(tmp_win->icon_name));
data/twm-1.0.10/src/lex.c:665:14: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
(c = getc( yyin )) != EOF && c != '\n'; ++n ) \
data/twm-1.0.10/src/lex.c:1700:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return yy_scan_bytes( yystr, (int) strlen(yystr) );
data/twm-1.0.10/src/menus.c:393:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
text_y, mi->item, mi->strlen);
data/twm-1.0.10/src/menus.c:413:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mi->x, text_y, mi->item, mi->strlen);
data/twm-1.0.10/src/menus.c:454:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
text_y, mi->item, mi->strlen);
data/twm-1.0.10/src/menus.c:716:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp->strlen = strlen(item);
data/twm-1.0.10/src/menus.c:724:57: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
width = MyFont_TextWidth(&Scr->MenuFont, item, tmp->strlen);
data/twm-1.0.10/src/menus.c:802:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cur->strlen);
data/twm-1.0.10/src/menus.c:1178:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
namelen = strlen (tmp_win->name);
data/twm-1.0.10/src/menus.c:2002:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(tmp, "\n");
data/twm-1.0.10/src/menus.c:2003:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
XStoreBytes(dpy, tmp, strlen(tmp));
data/twm-1.0.10/src/menus.c:2015:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
count = read (fd, buff, MAX_FILE_SIZE - 1);
data/twm-1.0.10/src/menus.c:2098:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(action);
data/twm-1.0.10/src/menus.c:2128:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(action);
data/twm-1.0.10/src/menus.c:2178:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
count = read(fd, buff, MAX_FILE_SIZE - 1);
data/twm-1.0.10/src/menus.c:2372:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!dot1) dot1 = colon + strlen (colon); /* if not there, append */
data/twm-1.0.10/src/menus.c:2622:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(Info[i]));
data/twm-1.0.10/src/menus.h:85:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
short strlen; /* strlen(item) */
data/twm-1.0.10/src/parse.c:182:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
homelen = strlen (home);
data/twm-1.0.10/src/parse.c:249:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen((char *) buff);
data/twm-1.0.10/src/session.c:174:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
unsigned char count = strlen (string);
data/twm-1.0.10/src/session.c:752:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop1val.length = strlen (Argv[0]);
data/twm-1.0.10/src/session.c:760:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop2val.length = strlen (userId);
data/twm-1.0.10/src/session.c:854:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop1.vals[numVals++].length = strlen (Argv[i]);
data/twm-1.0.10/src/session.c:862:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop1.vals[numVals++].length = strlen (twm_clientId);
data/twm-1.0.10/src/session.c:868:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop1.vals[numVals++].length = strlen (filename);
data/twm-1.0.10/src/session.c:878:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop2val.length = strlen (discardCommand);
data/twm-1.0.10/src/twm.c:323:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
HomeLen = strlen(Home);
data/twm-1.0.10/src/util.c:265:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
newname = malloc (HomeLen + strlen(name) + 2);
data/twm-1.0.10/src/util.c:269:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ProgramName, HomeLen + (unsigned long)strlen(name) + 2,
data/twm-1.0.10/src/util.c:357:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
bigname = malloc (strlen(name) + strlen(Scr->IconDirectory) + 2);
data/twm-1.0.10/src/util.c:357:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
bigname = malloc (strlen(name) + strlen(Scr->IconDirectory) + 2);
ANALYSIS SUMMARY:
Hits = 94
Lines analyzed = 21446 in approximately 0.57 seconds (37386 lines/second)
Physical Source Lines of Code (SLOC) = 14996
Hits@level = [0] 116 [1] 42 [2] 35 [3] 6 [4] 11 [5] 0
Hits@level+ = [0+] 210 [1+] 94 [2+] 52 [3+] 17 [4+] 11 [5+] 0
Hits/KSLOC@level+ = [0+] 14.0037 [1+] 6.26834 [2+] 3.46759 [3+] 1.13364 [4+] 0.733529 [5+] 0
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.